[PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-07 Thread Doug Evans via
Wrapping an IP address in square brackets does not necessarily mean the address is an IPv6 address. The wrapping is just an aid to parsing since IPv6 addresses have colons, but does not provide semantic information. E.g., [127.0.0.1] is a valid way to write 127.0.0.1. Signed-off-by: Doug Evans --

[PATCH v5 2/5] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-19 Thread Doug Evans via
The parsing is moved into new function inet_parse_host_and_port. This is done in preparation for using the function in net/slirp.c. Signed-off-by: Doug Evans --- Changes from v4: - move recognition of "[]:port" to separate patch - allow passing NULL for ip_v6 - fix some formatting issues Change

[PATCH v5 4/5] net/slirp.c: Refactor address parsing

2021-02-19 Thread Doug Evans via
... in preparation for adding ipv6 host forwarding support. New test: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v4: - was 3/4 in v4 - fix some formatting issues Changes from v3: - this patch renamed from 2/3 to 3/4 - call inet_parse_host_and_port from u

[PATCH v5 0/5] Add support for ipv6 host forwarding

2021-02-19 Thread Doug Evans via
This patchset takes the original patch from Maxim, https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html and updates it. Option hostfwd is extended to support ipv6 addresses. Commands hostfwd_add, hostfwd_remove are extended as well. The libslirp part of the patch has been committed u

[PATCH v5 3/5] inet_parse_host_and_addr: Recognize []:port (empty ipv6 address)

2021-02-19 Thread Doug Evans via
Some callers need to distinguish empty ipv4 addresses from ipv6. Signed-off-by: Doug Evans --- Changes from v4: - new in this patchset revision util/qemu-sockets.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 3ca6a6

[PATCH v5 5/5] net: Extend host forwarding to support IPv6

2021-02-19 Thread Doug Evans via
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Signed-off-by: Doug Evans --- Changes from v4: - was 4/4 in v4 - fix some formatting issues Differences from v3: - this patch renamed from 3/3 to 4/4 - ipv6 support added to exist

[PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-19 Thread Doug Evans via
Signed-off-by: Doug Evans --- Changes from v4: NOTE TO REVIEWERS: I need some hand-holding to know what The Right way to submit this particular patch is. - no change Changes from v3: - pick up latest libslirp patch to reject ipv6 addr-any for guest address - libslirp currently only provides a

[PATCH v5 0/3] Add npcm7xx emc model

2021-02-18 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

[PATCH v5 2/3] hw/arm: Add npcm7xx emc model

2021-02-18 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences

[PATCH v5 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-18 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v4: - handle --disable-slirp Differences from v3: - handle big endian hosts, tested on sparc64 Differences from v2: - remove use of C99 mixed decls/statements tests/qtest/

[PATCH v5 1/3] hw/net: Add npcm7xx emc model

2021-02-18 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- Differences from v4: - no change Diffe

[PATCH v4 4/4] net: Extend host forwarding to support IPv6

2021-02-18 Thread Doug Evans via
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Signed-off-by: Doug Evans --- Differences from v3: - this patch renamed from 3/3 to 4/4 - ipv6 support added to existing hostfwd option, commands - instead of creating new ipv6 o

[PATCH v4 0/4] Add support for ipv6 host forwarding

2021-02-18 Thread Doug Evans via
This patchset takes the original patch from Maxim, https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html and updates it. Option hostfwd is extended to support ipv6 addresses. Commands hostfwd_add, hostfwd_remove are extended as well. The libslirp part of the patch has been committed u

[PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-18 Thread Doug Evans via
Signed-off-by: Doug Evans --- Changes from v3: - pick up latest libslirp patch to reject ipv6 addr-any for guest address - libslirp currently only provides a stateless DHCPv6 server, which means it can't know in advance what the guest's IP address is, and thus cannot do the "addr-any ->

[PATCH v4 3/4] net/slirp.c: Refactor address parsing

2021-02-18 Thread Doug Evans via
... in preparation for adding ipv6 host forwarding support. New test: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v3: - this patch renamed from 2/3 to 3/4 - call inet_parse_host_and_port from util/qemu-sockets.c - added tests/acceptance/hostfwd.py Changes

[PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-18 Thread Doug Evans via
The parsing is moved into new function inet_parse_host_and_port. This is done in preparation for using the function in net/slirp.c. Signed-off-by: Doug Evans --- Changes from v3: - this patch is new in v4 - provides new utility: inet_parse_host_and_port, updates inet_parse to use it incl

[PATCH v4 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-12 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v3: - handle big endian hosts, tested on sparc64 Differences from v2: - remove use of C99 mixed decls/statements tests/qtest/meson.build| 1 + tests/qtest/npcm7xx

[PATCH v4 2/3] hw/arm: Add npcm7xx emc model

2021-02-12 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences

[PATCH v4 0/3] Add npcm7xx emc model

2021-02-12 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

[PATCH v4 1/3] hw/net: Add npcm7xx emc model

2021-02-12 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences

[PATCH] qom/object.c: Fix typo

2021-02-11 Thread Doug Evans via
A simple typo (noticed by inspection). commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee Author: Doug Evans Date: Thu Feb 11 16:29:13 2021 -0800 qom/object.c: Fix typo Signed-off-by: Doug Evans diff --git a/qom/object.c b/qom/object.c index 491823db4a..6a01d56546 100644 --- a/qom/

[PATCH v3 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-08 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v2: - remove use of C99 mixed decls/statements tests/qtest/meson.build| 1 + tests/qtest/npcm7xx_emc-test.c | 812 + 2 files change

[PATCH v3 2/3] hw/arm: Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences

[PATCH v3 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- Differences from v2: - move call to qem

[PATCH v3 0/3] Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

[PATCH 1/1] trace: Send "-d trace:help" output to stdout

2020-11-25 Thread Doug Evans via
... for consistency with "-d help". Signed-off-by: Doug Evans --- trace/control.c | 12 ++-- trace/control.h | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/trace/control.c b/trace/control.c index b82fb87316..cd04dd4e0c 100644 --- a/trace/control.c +++ b/trace/co