On Sun, Sep 22, 2024 at 09:24:33PM +0800, Chao Liu wrote:
> Signed-off-by: Chao Liu
Reviewed-by: Edgar E. Iglesias
> ---
> hw/dma/xlnx-zynq-devcfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zyn
Ping!
On Wed, Aug 14, 2024 at 01:15:55PM -0500, Eric Blake wrote:
> On Mon, Aug 12, 2024 at 04:43:23PM GMT, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Avoid a maybe-uninitialized warning in raw_refresh_zoned_limits()
> > by initial
"xen: remove the legacy 'xen_disk' backend")
> >
> > xen_config_dev_console is unused since 2018's
> > 6d7c06c213 ("Remove broken Xen PV domain builder")
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert
>
> Acked-by: Anthony PERARD
>
> Thanks,
Reviewed-by: Edgar E. Iglesias
Cheers,
Edgar
From: "Edgar E. Iglesias"
Acked-by: Stefano Stabellini
Signed-off-by: Edgar E. Iglesias
---
hw/xen/xen-pvh-common.c | 36
1 file changed, 36 insertions(+)
diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c
index 76a9b2b945..218ac85
From: "Edgar E. Iglesias"
Add a way to enable/disable buffered IOREQs for PVH machines
and disable them for ARM. ARM does not support buffered
IOREQ's nor the legacy way to map IOREQ info pages.
See the following for more details:
https://xenbits.xen.org/gitweb/?p=xen.git
From: "Edgar E. Iglesias"
Enable PCI support for the ARM Xen PVH machine.
Reviewed-by: Stefano Stabellini
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xen-pvh.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
index 28af3910ea..
From: "Edgar E. Iglesias"
Enable PCI on the ARM PVH machine. First we add a way to control the use
of buffered IOREQ's since those are not supported on Xen/ARM.
Finally we enable the PCI support.
I've published some instructions on how to try this including the work in
prog
From: "Edgar E. Iglesias"
Expose handle_bufioreq in xen_register_ioreq().
This is to allow machines to enable or disable buffered ioreqs.
No functional change since all callers still set it to
HVM_IOREQSRV_BUFIOREQ_ATOMIC.
Signed-off-by: Edgar E. Iglesias
---
hw/i386/xen
On Mon, Sep 16, 2024 at 04:45:34PM -0700, Stefano Stabellini wrote:
> On Mon, 16 Sep 2024, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Expose handle_bufioreq in xen_register_ioreq().
> > This is to allow machines to enable or disable bu
On Mon, Sep 16, 2024 at 04:47:43PM -0700, Stefano Stabellini wrote:
> On Mon, 16 Sep 2024, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Add a way to enable/disable buffered IOREQs for PVH machines
> > and disable them for ARM. ARM does not
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
hw/xen/xen-pvh-common.c | 36
1 file changed, 36 insertions(+)
diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c
index 76a9b2b945..218ac851cf 100644
--- a/hw/xen/xen-pv
From: "Edgar E. Iglesias"
Enable PCI support for the ARM Xen PVH machine.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xen-pvh.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
index 28af3910ea..33f0dd5982 100644
--- a/hw/arm
From: "Edgar E. Iglesias"
Enable PCI on the ARM PVH machine. First we add a way to control the use
of buffered IOREQ's since those are not supported on Xen/ARM.
Finally we enable the PCI support.
I've published some instructions on how to try this including the work in
prog
From: "Edgar E. Iglesias"
Expose handle_bufioreq in xen_register_ioreq().
This is to allow machines to enable or disable buffered ioreqs.
No functional change since all callers still set it to
HVM_IOREQSRV_BUFIOREQ_ATOMIC.
Signed-off-by: Edgar E. Iglesias
---
hw/i386/xen
From: "Edgar E. Iglesias"
Add a way to enable/disable buffered IOREQs for PVH machines
and disable them for ARM. ARM does not support buffered
IOREQ's nor the legacy way to map IOREQ info pages.
See the following for more details:
https://xenbits.xen.org/gitweb/?p=xen.git
r the removal? I'd rather have your
> explicit Acked-by before merging this.
>
>
Hi Phil,
Yes, sorry, I haven't had time to review each patch but:
Acked-by: Edgar E. Iglesias
Cheers,
Edgar
> Thanks,
>
> Phil.
>
> > Philippe Mathieu-Daudé (15):
>
From: "Edgar E. Iglesias"
Tweak machine description to better express that this is
a Xen PVH machine for ARM.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/arm/xen_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xen_arm.
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/arm/meson.build | 5 -
hw/arm/xen-stubs.c | 32
hw/arm/xen_arm.c | 20
3 files changed, 36 insertions(+), 21 deletions(-)
c
From: "Edgar E. Iglesias"
Add support for optionally creating a PCIe/GPEX controller.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/xen/xen-pvh-common.c | 76 +
include/hw/xen/xen-pvh-common.h | 29
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/arm/xen_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c
index fda65d0d8d..16b3f00992 100644
--- a/hw/arm/xen_arm.c
++
From: "Edgar E. Iglesias"
We've been creating the virtio-mmio devices in forwards order
but since the qbus lists prepend (rather than append) entries,
the virtio busses end up with decreasing base address order.
Xen enables virtio-mmio nodes in forwards order so there's been
From: "Edgar E. Iglesias"
Break out a common Xen PVH machine in preparation for
adding a x86 Xen PVH machine.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/arm/trace-events | 5 -
hw/arm/xen_arm.c| 198 +++--
From: "Edgar E. Iglesias"
Add SMP support for Xen PVH ARM guests.
Create ms->smp.max_cpus ioreq servers to handle hotplug.
Note that ms->smp.max_cpus will be passed to us by the
user (Xen tools) set to the guests maxvcpus.
The value in mc->max_cpus is an absolute maximum
From: "Edgar E. Iglesias"
Rename xen_arm.c -> xen-pvh.c to better express that this
is a PVH machine and to align with x86 HVM and future PVH
machine filenames:
hw/i386/xen/xen-hvm.c
hw/i386/xen/xen-pvh.c (in preparation)
No functional changes.
Signed-off-by: Edgar E. Iglesias
From: "Edgar E. Iglesias"
Update file header to use SPDX and remove stray empty
comment line.
No functional changes.
Signed-off-by: Edgar E. Iglesias
Acked-by: Stefano Stabellini
---
hw/arm/xen_arm.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff
From: "Edgar E. Iglesias"
Add a Xen PVH x86 machine based on the abstract PVH Machine.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/i386/xen/meson.build | 1 +
hw/i386/xen/xen-pvh.c | 121
2 files changed, 122
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
MAINTAINERS | 1 +
docs/system/i386/xenpvh.rst | 49 +
docs/system/target-i386.rst | 1 +
3 files changed, 51 insertions(+)
create m
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
Acked-by: Stefano Stabellini
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3584d6a6c6..c2fb0c2f42 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -559,6 +559,7 @@ F: incl
From: "Edgar E. Iglesias"
The following changes since commit e638d685ec2a0700fb9529cbd1b2823ac4120c53:
Open 9.2 development tree (2024-09-03 09:18:43 -0700)
are available in the Git repository at:
https://gitlab.com/edgar.iglesias/qemu.git
tags/edgar/xen-queue-2024-09-04.fo
t have a ton of images for the
> board so we erred on the safe side of not changing the
> behaviour to avoid potentially breaking existing guest code.)
I tried this patch on a couple of my images and it works fine for me!
Reviewed-by: Edgar E. Iglesias
Tested-by: Edgar E. Iglesias
2 material.
>
>
All of it looks good to me:
Reviewed-by: Edgar E. Iglesias
> thanks
> -- PMM
>
> Peter Maydell (6):
> hw/misc/xlnx-versal-cfu: destroy fifo in finalize
> hw/misc/xlnx-versal-trng: Free s->prng in finalize, not unrealize
> hw/nvram/xlnx-bbram: C
From: "Edgar E. Iglesias"
Add a Xen PVH x86 machine based on the abstract PVH Machine.
Signed-off-by: Edgar E. Iglesias
---
hw/i386/xen/meson.build | 1 +
hw/i386/xen/xen-pvh.c | 121
2 files changed, 122 insertions(+)
create mode 1006
From: "Edgar E. Iglesias"
Tweak machine description to better express that this is
a Xen PVH machine for ARM.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
hw/arm/xen_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xen_arm.
From: "Edgar E. Iglesias"
Update file header to use SPDX and remove stray empty
comment line.
No functional changes.
Signed-off-by: Edgar E. Iglesias
Acked-by: Stefano Stabellini
---
hw/arm/xen_arm.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff
From: "Edgar E. Iglesias"
Rename xen_arm.c -> xen-pvh.c to better express that this
is a PVH machine and to align with x86 HVM and future PVH
machine filenames:
hw/i386/xen/xen-hvm.c
hw/i386/xen/xen-pvh.c (in preparation)
No functional changes.
Signed-off-by: Edgar E. Iglesias
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
hw/arm/meson.build | 5 -
hw/arm/xen-stubs.c | 32
hw/arm/xen_arm.c | 20
3 files changed, 36 insertions(+), 21 deletions(-)
create mode 100644 hw/arm/xen-stu
From: "Edgar E. Iglesias"
Add support for optionally creating a PCIe/GPEX controller.
Signed-off-by: Edgar E. Iglesias
---
hw/xen/xen-pvh-common.c | 76 +
include/hw/xen/xen-pvh-common.h | 29 +
2 files changed, 105 insertions(+)
From: "Edgar E. Iglesias"
Break out a common Xen PVH machine in preparation for
adding a x86 Xen PVH machine.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/trace-events | 5 -
hw/arm/xen_arm.c| 198 +++
hw/xen/meson.build
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
Acked-by: Stefano Stabellini
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3584d6a6c6..c2fb0c2f42 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -559,6 +559,7 @@ F: incl
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
---
MAINTAINERS | 1 +
docs/system/i386/xenpvh.rst | 49 +
docs/system/target-i386.rst | 1 +
3 files changed, 51 insertions(+)
create m
From: "Edgar E. Iglesias"
We've been creating the virtio-mmio devices in forwards order
but since the qbus lists prepend (rather than append) entries,
the virtio busses end up with decreasing base address order.
Xen enables virtio-mmio nodes in forwards order so there's been
From: "Edgar E. Iglesias"
Add SMP support for Xen PVH ARM guests.
Create ms->smp.max_cpus ioreq servers to handle hotplug.
Note that ms->smp.max_cpus will be passed to us by the
user (Xen tools) set to the guests maxvcpus.
The value in mc->max_cpus is an absolute maximum
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xen_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c
index fda65d0d8d..16b3f00992 100644
--- a/hw/arm/xen_arm.c
+++ b/hw/arm/xen_arm.c
@@ -165,7 +165,7
From: "Edgar E. Iglesias"
This series breaks out parts of the ARM PVH support into an abstract
machine that other targets can reuse.. There's a bit of refactoring
and some bug-fixes along the way.
Finally we add a new x86 xen-pvh machine.
The corresponding changes in Xen for P
On Sat, Aug 17, 2024 at 2:45 AM Jason Andryuk wrote:
> On 2024-08-16 12:53, Stefano Stabellini wrote:
> > On Fri, 16 Aug 2024, Edgar E. Iglesias wrote:
> >> On Thu, Aug 15, 2024 at 2:30 AM Stefano Stabellini <
> sstabell...@kernel.org> wrote:
> >> On
On Thu, Aug 15, 2024 at 2:30 AM Stefano Stabellini
wrote:
> On Wed, 14 Aug 2024, Edgar E. Iglesias wrote:
> > On Tue, Aug 13, 2024 at 03:52:32PM -0700, Stefano Stabellini wrote:
> > > On Tue, 13 Aug 2024, Edgar E. Iglesias wrote:
> > > > On Mon, Aug 12, 202
On Mon, Aug 12, 2024 at 06:48:52PM -0700, Stefano Stabellini wrote:
> On Mon, 12 Aug 2024, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > This adds a Xen PVH x86 machine based on the PVH Common
> > module used by the ARM PVH machine.
>
On Mon, Aug 12, 2024 at 06:48:37PM -0700, Stefano Stabellini wrote:
> On Mon, 12 Aug 2024, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Add support for optionally creating a PCIe/GPEX controller.
> >
> > Signed-off-by: Edgar E. Igl
On Mon, Aug 12, 2024 at 06:47:51PM -0700, Stefano Stabellini wrote:
> On Mon, 12 Aug 2024, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Break out a common Xen PVH module in preparation for
> > adding a x86 Xen PVH Machine.
>
On Tue, Aug 13, 2024 at 03:52:32PM -0700, Stefano Stabellini wrote:
> On Tue, 13 Aug 2024, Edgar E. Iglesias wrote:
> > On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote:
> > > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote:
> > > > From: "Edgar
On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote:
> On Mon, 12 Aug 2024, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq
> > servers to handle hotplug.
>
From: "Edgar E. Iglesias"
Hi,
I ran into the following build-warning when building QEMU
with GCC 14.1.0:
[925/1857] Compiling C object libblock.a.p/block_file-posix.c.o
FAILED: libblock.a.p/block_file-posix.c.o
aarch64-poky-linux-gcc -mcpu=cortex-a57+crc -mbranch-protection=standar
From: "Edgar E. Iglesias"
Avoid a maybe-uninitialized warning in raw_refresh_zoned_limits()
by initializing zoned.
With GCC 14.1.0:
In function ‘raw_refresh_zoned_limits’,
inlined from ‘raw_refresh_limits’ at ../qemu/block/file-posix.c:1522:5:
../qemu/block/file-posix.c:1405
From: "Edgar E. Iglesias"
Tweak machine description to better express that this is
a Xen PVH machine for ARM.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xen_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c
index
From: "Edgar E. Iglesias"
Break out a common Xen PVH module in preparation for
adding a x86 Xen PVH Machine.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/trace-events | 5 -
hw/arm/xen_arm.c| 154 ++
hw/xen/meson.build
From: "Edgar E. Iglesias"
This adds a Xen PVH x86 machine based on the PVH Common
module used by the ARM PVH machine.
Signed-off-by: Edgar E. Iglesias
---
hw/i386/xen/meson.build | 1 +
hw/i386/xen/xen-pvh.c | 196
2 files changed, 197
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
MAINTAINERS | 1 +
docs/system/i386/xenpvh.rst | 49 +
docs/system/target-i386.rst | 1 +
3 files changed, 51 insertions(+)
create mode 100644 docs/system/i386/xenpvh
From: "Edgar E. Iglesias"
Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq
servers to handle hotplug.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xen_arm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_a
From: "Edgar E. Iglesias"
Update file header to use SPDX and remove stray empty
comment line.
No functional changes.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xen_arm.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/hw/arm/xen_arm.
From: "Edgar E. Iglesias"
We've been creating the virtio-mmio devices in forwards order
but since the qbus lists prepend (rather than append) entries,
the virtio busses end up with decreasing base address order.
Xen enables virtio-mmio nodes in forwards order so there's been
From: "Edgar E. Iglesias"
Add support for optionally creating a PCIe/GPEX controller.
Signed-off-by: Edgar E. Iglesias
---
hw/xen/xen-pvh-common.c | 66 +
include/hw/xen/xen-pvh-common.h | 10 -
2 files changed, 75 insertions(+), 1 deletio
From: "Edgar E. Iglesias"
Rename xen_arm.c -> xen-pvh.c to better express that this
is a PVH machine and to align with x86 HVM and future PVH
machine filenames:
hw/i386/xen/xen-hvm.c
hw/i386/xen/xen-pvh.c (in preparation)
No functional changes.
Signed-off-by: Edgar E. Iglesias
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 10af212632..a24c2e14d9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -559,6 +559,7 @@ F: include/hw/xen/
F: include/sysem
From: "Edgar E. Iglesias"
This series breaks-out parts of the ARM PVH support into a reusable
QOM module. There's a bit of refactoring and some bug-fixes along
the way.
Finally we add a new x86 xen-pvh machine using the new xen-pvh-common
module.
The corresponding changes Xen
ke the board code simpler.
>
> Regards,
> BALATON Zoltan
I tested this with my virtex-ml507 images:
Reviewed-by: Edgar E. Iglesias
Tested-by: Edgar E. Iglesias
Cheers,
Edgar
>
> BALATON Zoltan (2):
> hw/ppc: Consolidate e500 initial mapping creation functions
> h
From: "Edgar E. Iglesias"
Bail out in qemu_ram_block_from_host() when
xen_ram_addr_from_mapcache() does not find an existing
mapping.
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alex Bennée
Reviewed-by: Stefano Stabellini
---
system/physmem.c | 4
1 file changed, 4
From: "Edgar E. Iglesias"
This fixes the clobbering of the entry->next pointer when
unmapping the first entry in a bucket of a mapcache.
Fixes: 123acd816d ("xen: mapcache: Unmap first entries in buckets")
Reported-by: Anthony PERARD
Signed-off-by: Edgar E. Iglesias
Revi
From: "Edgar E. Iglesias"
The following changes since commit 23901b2b721c0576007ab7580da8aa855d6042a9:
Merge tag 'pull-target-arm-20240711' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-07-11
12:00:00 -0700)
are available in the Git rep
very happy to welcome him to the team. His knowledge and expertise
with QEMU internals will be of great help.
Signed-off-by: Stefano Stabellini
Reviewed-by: Paul Durrant
Acked-by: Anthony PERARD
Reviewed-by: Alex Bennée
Signed-off-by: Edgar E. Iglesias
---
MAINTAINERS | 1 +
1 file changed
On Thu, Jul 11, 2024 at 12:09 PM Alex Bennée wrote:
> Stefano Stabellini writes:
>
> > Add Edgar as Xen subsystem maintainer in QEMU. Edgar has been a QEMU
> > maintainer for years, and has already made key changes to one of the
> > most difficult areas of the Xen subsystem (the mapcache).
> >
>
ered helping us maintain the Xen subsystem in QEMU and we
> are very happy to welcome him to the team. His knowledge and expertise
> with QEMU internals will be of great help.
>
> Signed-off-by: Stefano Stabellini
>
>
Thanks Stefano!
Reviewed-by: Edgar E. Iglesias
> di
On Thu, Jul 4, 2024 at 9:48 PM Edgar E. Iglesias
wrote:
> On Thu, Jul 04, 2024 at 05:44:52PM +0100, Alex Bennée wrote:
> > Anthony PERARD writes:
> >
> > > On Tue, Jul 02, 2024 at 12:44:21AM +0200, Edgar E. Iglesias wrote:
> > >> From: "Edgar E
On Thu, Jul 04, 2024 at 05:44:52PM +0100, Alex Bennée wrote:
> Anthony PERARD writes:
>
> > On Tue, Jul 02, 2024 at 12:44:21AM +0200, Edgar E. Iglesias wrote:
> >> From: "Edgar E. Iglesias"
> >>
> >> This fixes the clobbering of the entry->n
On Thu, Jul 4, 2024 at 1:26 PM Alex Bennée wrote:
> "Edgar E. Iglesias" writes:
>
> > From: "Edgar E. Iglesias"
> >
> > Bail out in qemu_ram_block_from_host() when
> > xen_ram_addr_from_mapcache() does not find an existing
>
From: "Edgar E. Iglesias"
Bail out in qemu_ram_block_from_host() when
xen_ram_addr_from_mapcache() does not find an existing
mapping.
Signed-off-by: Edgar E. Iglesias
---
system/physmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/system/physmem.c b/system/physm
From: "Edgar E. Iglesias"
This fixes the unmapping of the first mapping in a bucket of a mapcache.
We also add error handling to qemu_ram_block_from_host() to bail out when
xen_ram_addr_from_mapcache() doesn't find an existing mapping.
Cheers,
Edgar
Edgar E. Iglesias (2):
ph
From: "Edgar E. Iglesias"
This fixes the clobbering of the entry->next pointer when
unmapping the first entry in a bucket of a mapcache.
Fixes: 123acd816d ("xen: mapcache: Unmap first entries in buckets")
Reported-by: Anthony PERARD
Signed-off-by: Edgar E. Iglesias
---
On Mon, Jul 1, 2024 at 6:21 PM Anthony PERARD
wrote:
> On Mon, Jul 01, 2024 at 04:34:53PM +0200, Edgar E. Iglesias wrote:
> > On Mon, Jul 1, 2024 at 4:30 PM Edgar E. Iglesias <
> edgar.igles...@gmail.com>
> > wrote:
> > > On Mon, Jul 1, 2024 at 3:58 PM
On Mon, Jul 1, 2024 at 4:30 PM Edgar E. Iglesias
wrote:
>
>
> On Mon, Jul 1, 2024 at 3:58 PM Edgar E. Iglesias
> wrote:
>
>> On Mon, Jul 1, 2024 at 2:55 PM Anthony PERARD
>> wrote:
>>
>>> Hi all,
>>>
>>> Following this commit, a te
On Mon, Jul 1, 2024 at 3:58 PM Edgar E. Iglesias
wrote:
> On Mon, Jul 1, 2024 at 2:55 PM Anthony PERARD
> wrote:
>
>> Hi all,
>>
>> Following this commit, a test which install Debian in a guest with OVMF
>> as firmware started to fail. QEMU exit with an err
RCU_READ_LOCK_GUARD();
ram_addr = xen_ram_addr_from_mapcache(ptr);
+if (ram_addr == RAM_ADDR_INVALID) {
+return NULL;
+}
block = qemu_get_ram_block(ram_addr);
if (block) {
*offset = ram_addr - block->offset;
> Cheers,
>
>
On Thu, Jun 20, 2024 at 12:25:51PM +0200, Philippe Mathieu-Daudé wrote:
> On 20/6/24 12:10, Peter Maydell wrote:
> > On Tue, 18 Jun 2024 at 15:51, Philippe Mathieu-Daudé
> > wrote:
> > >
> > > On 18/6/24 16:40, Zheyu Ma wrote:
> > > > This commit updates the a9_gtimer_get_current_cpu() function
Anyway, I'm OK with your approach:
Acked-by: Edgar E. Iglesias
> Signed-off-by: Sai Pavan Boddu
> ---
> hw/arm/xilinx_zynq.c | 31 +++
> 1 file changed, 31 insertions(+)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
>
On Wed, Jun 19, 2024 at 11:16 AM Sai Pavan Boddu
wrote:
> BootMode property sets user values into BOOT_MODE register, on hardware
> these are derived from board switches.
>
>
Reviewed-by: Edgar E. Iglesias
> Signed-off-by: Sai Pavan Boddu
> ---
> hw/
de values in lower-case or the
boot-mode example in upper-case.
I know case doesn't matter but it would be nice to have the example
consistent with the list of supported values.
With those changes feel free to add:
Reviewed-by: Edgar E. Iglesias
Cheers,
Edgar
> Signed-off-by
eaking the loop in this
case is one of the possible ways to handle it.
Signed-off-by: Fea.Wang
Reviewed-by: Frank Chang
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Edgar E. Iglesias
---
hw/dma/xilinx_axidma.c | 30 ++
1 file changed, 26 insertions(+), 4 deletion
From: "Fea.Wang"
Due to a description loading failure, adding a trace log makes observing
the DMA behavior easy.
Signed-off-by: Fea.Wang
Reviewed-by: Edgar E. Iglesias
Reviewed-by: Frank Chang
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Edgar E. Iglesias
---
hw/dma/tr
From: "Edgar E. Iglesias"
The following changes since commit 900536d3e97aed7fdd9cb4dadd3bf7023360e819:
Merge tag 'dirtylimit-dirtyrate-pull-request-20240617' of
https://github.com/newfriday/qemu into staging (2024-06-17 11:40:24 -0700)
are available in the Git rep
From: "Fea.Wang"
Fix the transmission return size because not all bytes could be
transmitted successfully. So, return a successful length instead of a
constant value.
Signed-off-by: Fea.Wang
Reviewed-by: Edgar E. Iglesias
Reviewed-by: Frank Chang
Signed-off-by: Edgar E. Iglesias
-
On Thu, Jun 13, 2024 at 5:36 PM Sai Pavan Boddu
wrote:
> Read boot-mode value as machine property and propagate that to
> SLCR.BOOT_MODE register.
>
>
Hi Sai,
Directly exposing the register field to the user to set on the command-line
probably makes usability a little too rough (user has to chec
On Thu, Jun 6, 2024 at 2:06 PM Peter Maydell
wrote:
> On Thu, 6 Jun 2024 at 12:04, Edgar E. Iglesias
> wrote:
> >
> > On Thu, Jun 6, 2024 at 12:00 PM Andrew.Yuan
> wrote:
> >>
> >> In the Cadence IP for Gigabit Ethernet MAC Part Number: IP7014
&g
that the function may return a failure value. Breaking the loop in this
> case is one of the possible ways to handle it.
>
> Signed-off-by: Fea.Wang
> Reviewed-by: Frank Chang
>
Thanks!
Reviewed-by: Edgar E. Iglesias
---
> hw/dma/xilinx_axidma.c | 30
be corrected to：
> rx_cmp = rxbuf_ptr[offset + 1] << 8 | rxbuf_ptr[offset];
>
> Signed-off-by: Andrew.Yuan
>
LGTM:
Reviewed-by: Edgar E. Iglesias
At some point it would be nice to add the missing logic for the
DISABLE_MASK bit that
extends the compare range from 16 t
From: "Edgar E. Iglesias"
Julien reported that he has seen strange behaviour when running
Xen on QEMU using GICv2. When Xen migrates a guest's vCPU to
another pCPU while the vCPU is handling an interrupt the guest
is unable to properly deactivate interrupts.
It sounds like someth
From: "Edgar E. Iglesias"
Julien reported that he has seen strange behaviour when running
Xen on QEMU using GICv2. When Xen migrates a guest's vCPU from
one pCPU to another while the vCPU is handling an interrupt, the
guest is unable to properly deactivate interrupts.
Looking
ory that we had some trouble with similar patches before.
Anyway, the change looks good to me:
Reviewed-by: Edgar E. Iglesias
> Signed-off-by: Fea.Wang
> ---
> hw/net/xilinx_axienet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/xilinx_ax
On Mon, Jun 3, 2024 at 7:48 AM Fea.Wang wrote:
> Due to a description loading failure, adding a trace log makes observing
> the DMA behavior easy.
>
>
Reviewed-by: Edgar E. Iglesias
> Signed-off-by: Fea.Wang
> ---
> hw/dma/trace-events| 3 +++
> hw/dma/xili
On Mon, Jun 3, 2024 at 7:48 AM Fea.Wang wrote:
> When calling the loading a description function, it should be noticed
> that the function may return a failure value. Breaking the loop is one
> of the possible ways to handle it.
>
> Signed-off-by: Fea.Wang
>
Looks good, a nitpick comment, I wo
On Mon, Jun 3, 2024 at 7:47 AM Fea.Wang wrote:
> Loading a description from memory may cause a bus-error. In this
> case, the DMA should stop working, set the error flag, and return
> the error value.
>
> Signed-off-by: Fea.Wang
>
Hi Fea,
I've got a couple of small comments:
---
> hw/dma/x
ocal struct
> variable "DPDMADescriptor tmp_desc" and so passing &tmp_desc to
> dma_memory_write() is correct.)
>
> Spotted by Coverity: CID 1546649
>
>
+ CC Fred.
Reviewed-by: Edgar E. Iglesias
> Fixes: fdf029762f50101 ("xlnx_dpdma: fix descr
1 - 100 of 1769 matches
Mail list logo
