[PATCH for-6.2 2/6] sbsa_gwdt: Delete broken SBSA_*CLASS macros

2021-08-05 Thread Eduardo Habkost
Those macros never worked and never will, because the SBSA_GWDTClass type never existed. Signed-off-by: Eduardo Habkost --- Cc: qemu-devel@nongnu.org Cc: Peter Maydell Cc: Shashi Mallela --- include/hw/watchdog/sbsa_gwdt.h | 4 1 file changed, 4 deletions(-) diff --git a/include/hw

[PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro

2021-08-05 Thread Eduardo Habkost
The macro never worked and never will, because the AcpiGedX86State type never existed. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: qemu-devel@nongnu.org --- include/hw/acpi/generic_event_device.h | 2 -- 1 file changed, 2 deletions(-) di

[PATCH for-6.2 0/6] qom: Fix broken OBJECT_CHECK usage

2021-08-05 Thread Eduardo Habkost
This series removes some broken OBJECT_CHECK macros and fix cases where OBJECT_CHECK is being used directly in the code. Eduardo Habkost (6): acpi: Delete broken ACPI_GED_X86 macro sbsa_gwdt: Delete broken SBSA_*CLASS macros s390-sclp-events-bus: Set instance_size s390-sclp-events-bus

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-05 Thread Eduardo Habkost
On Thu, Aug 05, 2021 at 12:36:11PM -0400, Eduardo Habkost wrote: > On Wed, Aug 04, 2021 at 08:26:10PM -0400, John Snow wrote: > > On Wed, Aug 4, 2021 at 5:00 PM Eduardo Habkost wrote: > > > > > On Wed, Aug 04, 2021 at 09:42:24PM +0100, Peter Maydell wrote: > > &

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-05 Thread Eduardo Habkost
On Wed, Aug 04, 2021 at 08:26:10PM -0400, John Snow wrote: > On Wed, Aug 4, 2021 at 5:00 PM Eduardo Habkost wrote: > > > On Wed, Aug 04, 2021 at 09:42:24PM +0100, Peter Maydell wrote: > > > Is there a sensible default-role we can use as the default for the whole > >

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-04 Thread Eduardo Habkost
On Wed, Aug 04, 2021 at 09:42:24PM +0100, Peter Maydell wrote: > On Wed, 4 Aug 2021 at 21:31, Eduardo Habkost wrote: > > > > On Mon, Aug 02, 2021 at 01:14:57PM +0100, Peter Maydell wrote: > > > On Thu, 29 Jul 2021 at 19:00, Eduardo Habkost wrote: > > > > di

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-08-04 Thread Eduardo Habkost
On Mon, Aug 02, 2021 at 01:19:14PM +0100, Peter Maydell wrote: > On Thu, 29 Jul 2021 at 19:01, Eduardo Habkost wrote: > > > > When there's no specific class struct used for a QOM type, we > > normally don't define a typedef for it. Remove the typedef from &g

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-04 Thread Eduardo Habkost
On Mon, Aug 02, 2021 at 01:14:57PM +0100, Peter Maydell wrote: > On Thu, 29 Jul 2021 at 19:00, Eduardo Habkost wrote: > > > > Replace leftover of GTK-Doc #name syntax with `name`, and use > > default-role:: any, so we can add references to other functions, > > types, an

Re: [PATCH 0/5] seccomp: fix hole in blocking forks

2021-08-04 Thread Eduardo Terrell Ferrari Otubo
unit/test-seccomp.c | 269 >  4 files changed, 490 insertions(+), 66 deletions(-) >  create mode 100644 tests/unit/test-seccomp.c > > -- > 2.31.1 > > Acked-by: Eduardo Otubo -- Eduardo Otubo signature.asc Description: This is a digitally signed message part

[PATCH for-6.2 10/10] MAINTAINERS: Add qom.rst to QOM section

2021-07-29 Thread Eduardo Habkost
Add qom.rst to the QOM section of MAINTAINERS. Signed-off-by: Eduardo Habkost --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 42ac45c3e50..dc3f04242eb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2651,6 +2651,7 @@ M: Paolo Bonzini R

[PATCH for-6.2 09/10] docs: qom: Remove OBJECT_CHECK macro examples

2021-07-29 Thread Eduardo Habkost
We shouldn't encourage people to keep defining typecast macros manually, when we have the OBJECT_DECLARE* macros. Remove the section showing how to define them, and replace with a section explaining how typecasting works. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst

[PATCH for-6.2 08/10] docs: qom: Show actual typecast functions in examples

2021-07-29 Thread Eduardo Habkost
For clarity and to avoid encouraging people to copy the examples, show the actual typecast functions being defined by OBJECT_DECLARE* macros in the examples. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 24 1 file changed, 16 insertions(+), 8 deletions

[PATCH for-6.2 07/10] docs: qom: Fix OBJECT_DECLARE_SIMPLE_TYPE documentation

2021-07-29 Thread Eduardo Habkost
E and OBJECT_DECLARE_TYPE. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst index dee60a64c0a..aa1f672efbe 100644 --- a/docs/devel/qom.rst +++ b/docs/devel/qom.rst @@ -

[PATCH for-6.2 05/10] docs: qom: Add subsection headings to declaration/definition macros section

2021-07-29 Thread Eduardo Habkost
Add two new subsection headings to make the separation between "declaration macros" and "definition macros" more visible. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/qom.rst b/docs/devel/qom.r

[PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-07-29 Thread Eduardo Habkost
When there's no specific class struct used for a QOM type, we normally don't define a typedef for it. Remove the typedef from the minimal example, as it is unnecessary. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/

[PATCH for-6.2 03/10] docs: qom: Fix autoptr expansion example

2021-07-29 Thread Eduardo Habkost
The wrong type name was being used. The autoptr cleanup function will be declared for the instance type, not the class type. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst index

[PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-07-29 Thread Eduardo Habkost
truct members are not possible yet. This was replaced with `TypeInfo`.class_init. - #CPUClass.reset and #DeviceClass.realize: cpu.h and qdev docs are not rendered using Sphinx yet, so use ``code`` syntax for those. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 25 +--

[PATCH for-6.2 02/10] docs: qom: Use Sphinx cross references more often

2021-07-29 Thread Eduardo Habkost
To make the document easier to navigate, use `reference` syntax more often when mentioning other types, functions, and macros. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/docs/devel

[PATCH for-6.2 04/10] docs: qom: Fix "API Reference" heading level

2021-07-29 Thread Eduardo Habkost
The API reference section was being rendered as a subsection of the "Standard type declaration and definition macros" subsection. Fix that. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/qom.rst b/

[PATCH for-6.2 00/10] QOM documentation updates

2021-07-29 Thread Eduardo Habkost
This series includes a few fixes to the QOM documentation, and add some changes to avoid encouraging people from defining typecast macros manually. Eduardo Habkost (10): docs: qom: Replace old GTK-Doc #symbol syntax with `symbol` docs: qom: Use Sphinx cross references more often docs: qom

Re: [PATCH] Fix CPUID_Fn8000001E_EBX for AMD

2021-07-26 Thread Eduardo Habkost
ebx = ((topo_info->threads_per_core - 1) << 8) | (core_id & 0xFF); > > /* > * CPUID_Fn801E_ECX [Node Identifiers] (NodeId) > -- > 2.24.3 (Apple Git-128) > -- Eduardo

[PULL 09/11] target/i386: Fix cpuid level for AMD

2021-07-13 Thread Eduardo Habkost
"Dr. David Alan Gilbert" Cc: Eduardo Habkost Cc: Richard Henderson Cc: Igor Mammedov Cc: zhenwei pi Fixes: a94e1428991 (target/i386: Add CPUID.1F generation support for multi-dies PCMachine) Signed-off-by: zhenwei pi Signed-off-by: Michael Roth Message-Id: <20210708170641.49410-1-

[PULL 11/11] numa: Parse initiator= attribute before cpus= attribute

2021-07-13 Thread Eduardo Habkost
a-type=access-bandwidth,bandwidth=208896K \ -numa hmat-cache,node-id=0,size=10K,level=1,associativity=direct,policy=write-back,line=8 \ -numa hmat-cache,node-id=1,size=10K,level=1,associativity=direct,policy=write-back,line=8 \ Signed-off-by: Michal Privoznik Reviewed-by: Igor Mammedov

[PULL 02/11] i386: hardcode supported eVMCS version to '1'

2021-07-13 Thread Eduardo Habkost
ll have to have their own enablement options (e.g. 'hv-evmcs=2'). Signed-off-by: Vitaly Kuznetsov Reviewed-by: Eduardo Habkost Message-Id: <20210608120817.1325125-4-vkuzn...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/hyperv.txt | 2 +- target/i386/kvm/kvm.c | 39 +++

[PULL 10/11] numa: Report expected initiator

2021-07-13 Thread Eduardo Habkost
tual value (which is different because an error is being reported). Report both values in the error message. Signed-off-by: Michal Privoznik Reviewed-by: Igor Mammedov Reviewed-by: Pankaj Gupta Message-Id: Signed-off-by: Eduardo Habkost --- hw/core/machine.c | 3 ++- 1 file changed, 2 insert

[PULL 07/11] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS privileges

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov When Hyper-V SynIC is enabled, we may need to allow Windows guests to make hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed because KVM is very permissive, allowing these hypercalls regarding of guest visible CPUid bits. Reviewed-by: Eduardo

[PULL 08/11] target/i386: suppress CPUID leaves not defined by the CPU vendor

2021-07-13 Thread Eduardo Habkost
-only" CPU property, which is true by default, but switched off for older machine types to maintain compatibility. Cc: "Dr. David Alan Gilbert" Cc: Eduardo Habkost Cc: Richard Henderson Cc: Igor Mammedov Cc: zhenwei pi Suggested-by: Eduardo Habkost Signed-off-by: Mich

[PULL 01/11] i386: clarify 'hv-passthrough' behavior

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov Clarify the fact that 'hv-passthrough' only enables features which are already known to QEMU and that it overrides all other 'hv-*' settings. Reviewed-by: Eduardo Habkost Signed-off-by: Vitaly Kuznetsov Message-Id: <20210608120817.1325125-3-vkuz

[PULL 06/11] i386: HV_HYPERCALL_AVAILABLE privilege bit is always needed

2021-07-13 Thread Eduardo Habkost
unconditionally, no issue is observed. We may, however, want to tighten the checks eventually. Conforming to the spec is probably also a good idea. Enable HV_HYPERCALL_AVAILABLE bit unconditionally. Reviewed-by: Eduardo Habkost Signed-off-by: Vitaly Kuznetsov Message-Id: <20210608120817.1325125-8-vk

[PULL 00/11] x86 queue, 2021-07-13

2021-07-13 Thread Eduardo Habkost
Sorry for submitting this so late. I had to deal with build issues caused by other patches (now removed from the queue). The following changes since commit eca73713358f7abb18f15c026ff4267b51746992: Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210712' into staging (2021-07-12 21:2

Re: [PATCH 0/4] docs: improve -smp documentation

2021-07-13 Thread Eduardo Habkost
On Fri, Jul 09, 2021 at 04:48:57PM -0400, Eduardo Habkost wrote: > On Mon, Jun 28, 2021 at 12:30:43PM +0100, Daniel P. Berrangé wrote: > > This is a spin off from this thread: > > > > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06135.html > > > >

[PULL 05/11] i386: kill off hv_cpuid_check_and_set()

2021-07-13 Thread Eduardo Habkost
dencies check out of it. Also, in 'passthrough' mode we don't really need to check dependencies because KVM is supposed to provide a consistent set anyway. Reviewed-by: Eduardo Habkost Signed-off-by: Vitaly Kuznetsov Message-Id: <20210608120817.1325125-7-vkuzn...@redhat.com&

[PULL 04/11] i386: expand Hyper-V features during CPU feature expansion time

2021-07-13 Thread Eduardo Habkost
kvm_arch_get_supported_cpuid(). We can't use kvm_arch_get_supported_cpuid() as Hyper-V specific CPUID leaves intersect with KVM's. Note, early expansion will only happen when KVM supports system wide KVM_GET_SUPPORTED_HV_CPUID ioctl (KVM_CAP_SYS_HYPERV_CPUID). Reviewed-by: Eduardo Habkost Signed-off-

[PULL 03/11] i386: make hyperv_expand_features() return bool

2021-07-13 Thread Eduardo Habkost
From: Vitaly Kuznetsov Return 'false' when hyperv_expand_features() sets an error. No functional change intended. Reviewed-by: Eduardo Habkost Signed-off-by: Vitaly Kuznetsov Message-Id: <20210608120817.1325125-5-vkuzn...@redhat.com> Signed-off-by: Eduardo Habkost --- targe

Re: [PATCH 0/2] numa: Parse initiator= attribute before cpus= attribute

2021-07-09 Thread Eduardo Habkost
On Wed, Jul 07, 2021 at 03:40:28PM +0200, Michal Privoznik wrote: > See 2/2 for explanation. The first patch is just cosmetics. > > Michal Privoznik (2): > numa: Report expected initiator > numa: Parse initiator= attribute before cpus= attribute Queued, thanks! -- Eduardo

Re: [PATCH 0/4] docs: improve -smp documentation

2021-07-09 Thread Eduardo Habkost
suggested that we change the behaviour > to prefer use of cores over sockets, when topology is omitted. This > documentation update explicitly notes that default topology is liable > to change, to allow for this enhancement. Queued, thanks! -- Eduardo

Re: [PATCH] target/i386: Use cpu_breakpoint_test in breakpoint_handler

2021-07-09 Thread Eduardo Habkost
we happen to have a BP_GDB breakpoint at the same address. > > > > We have a function for this: cpu_breakpoint_test. > > > > Signed-off-by: Richard Henderson cpu_breakpoint_test() logic matches the existing code being replaced, so: Reviewed-by: Eduardo Habkost I would

Re: [PATCH v8 9/9] qtest/hyperv: Introduce a simple hyper-v test

2021-07-08 Thread Eduardo Habkost
ab.com/ehabkost/qemu/-/jobs/1404084459 I'm removing it from the queue. -- Eduardo

Re: [PATCH] target/i386: Fix cpuid level for AMD

2021-07-08 Thread Eduardo Habkost
On Thu, Jul 08, 2021 at 12:06:41PM -0500, Michael Roth wrote: > From: zhenwei pi > > A AMD server typically has cpuid level 0x10(test on Rome/Milan), it > should not be changed to 0x1f in multi-dies case. > > Cc: "Dr. David Alan Gilbert" > Cc: Eduardo Habkost

Re: [PATCH] target/i386: suppress CPUID leaves not defined by the CPU vendor

2021-07-08 Thread Eduardo Habkost
CPU types to suppress these via a new "x-vendor-cpuid-only" > CPU property, which is true by default, but switched off for older > machine types to maintain compatibility. > > Cc: "Dr. David Alan Gilbert" > Cc: Eduardo Habkost > Cc: Richard Henderson >

Re: [PATCH v7 1/9] i386: avoid hardcoding '12' as 'hyperv_vendor_id' length

2021-07-08 Thread Eduardo Habkost
memset(cpu->hyperv_vendor_id, 0, 12); > +memset(cpu->hyperv_vendor_id, 0, sizeof(cpu->hyperv_vendor_id)); > memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len); > > /* 'Hv#1' interface identification*/ > -- > 2.31.1 > -- Eduardo

[PULL v2 14/15] virtio-mem: Require only coordinated discards

2021-07-08 Thread Eduardo Habkost
irkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-13-da...@redhat.com> Signed-off-by: Eduardo

[PULL v2 11/15] vfio: Support for RamDiscardManager in the vIOMMU case

2021-07-08 Thread Eduardo Habkost
Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-10-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/migration/vmstate.h | 1 + hw/vfio/common.c| 39 +++

[PULL v2 09/15] vfio: Query and store the maximum number of possible DMA mappings

2021-07-08 Thread Eduardo Habkost
y: David Hildenbrand Message-Id: <20210413095531.25603-8-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/common.c | 4 2 files changed, 5 insertions(+) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-

[PULL v2 08/15] vfio: Support for RamDiscardManager in the !vIOMMU case

2021-07-08 Thread Eduardo Habkost
210413095531.25603-7-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/vfio/vfio-common.h | 11 +++ hw/vfio/common.c | 164 ++ 2 files changed, 175 insertions(+) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-

[PULL v2 07/15] virtio-mem: Implement RamDiscardManager interface

2021-07-08 Thread Eduardo Habkost
com> Signed-off-by: Eduardo Habkost --- include/hw/virtio/virtio-mem.h | 3 + hw/virtio/virtio-mem.c | 288 - 2 files changed, 288 insertions(+), 3 deletions(-) diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h index 4ee

[PULL v2 06/15] virtio-mem: Don't report errors when ram_block_discard_range() fails

2021-07-08 Thread Eduardo Habkost
a Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-5-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/virtio/virtio-mem.c | 20 1 file changed, 4 insertions(+),

[PULL v2 05/15] virtio-mem: Factor out traversing unplugged ranges

2021-07-08 Thread Eduardo Habkost
dov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-4-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/virtio/virtio-mem.c | 86 -

[PULL v2 00/15] Machine queue, 2021-07-07

2021-07-08 Thread Eduardo Habkost
ueue, 2021-07-07 Deprecation: * Deprecate pmem=on with non-DAX capable backend file (Igor Mammedov) Feature: * virtio-mem: vfio support (David Hildenbrand) Cleanup: * vmbus: Don't make QOM property registration conditional (

[PULL v2 12/15] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)

2021-07-08 Thread Eduardo Habkost
ael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-11-da...@redhat.com> Signed-off-by: Eduardo

[PULL v2 10/15] vfio: Sanity check maximum number of DMA mappings with RamDiscardManager

2021-07-08 Thread Eduardo Habkost
irkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-9-da...@redhat.com> Signed-off-by: Eduardo

[PULL v2 15/15] vfio: Disable only uncoordinated discards for VFIO_TYPE1 iommus

2021-07-08 Thread Eduardo Habkost
210413095531.25603-14-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/vfio/common.c | 65 +++- 1 file changed, 53 insertions(+), 12 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 8a9bbf27918..3f0d1113608 100644 ---

[PULL v2 02/15] Deprecate pmem=on with non-DAX capable backend file

2021-07-08 Thread Eduardo Habkost
So if user asks for persistence (pmem=on), they should store backing file on NVDIMM. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210111203332.740815-1-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/system/deprecated.rst | 18 ++

[PULL v2 13/15] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types

2021-07-08 Thread Eduardo Habkost
" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-12-da...@redhat.com> Signed-off-by: Eduardo Habkost -

[PULL v2 04/15] memory: Helpers to copy/free a MemoryRegionSection

2021-07-08 Thread Eduardo Habkost
i Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-3-da...@redhat.com> Signed-of

[PULL v2 03/15] memory: Introduce RamDiscardManager for RAM memory regions

2021-07-08 Thread Eduardo Habkost
Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-2-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/exec/memory.h |

[PULL v2 01/15] vmbus: Don't make QOM property registration conditional

2021-07-08 Thread Eduardo Habkost
Having properties registered conditionally makes QOM type introspection difficult. Instead of skipping registration of the "instanceid" property, always register the property but validate its value against the instance id required by the class. Signed-off-by: Eduardo Habkost Acked-by

Re: [PULL 00/15] Machine queue, 2021-07-07

2021-07-08 Thread Eduardo Habkost
On Thu, Jul 8, 2021 at 5:53 AM Peter Maydell wrote: > > On Wed, 7 Jul 2021 at 20:32, Eduardo Habkost wrote: > > > > The following changes since commit 9aef0954195cc592e86846dbbe7f3c2c5603690a: > > > > Merge remote-tracking branch 'remotes/bonzini-gitlab/t

[PULL 15/15] vfio: Disable only uncoordinated discards for VFIO_TYPE1 iommus

2021-07-07 Thread Eduardo Habkost
210413095531.25603-14-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/vfio/common.c | 65 +++- 1 file changed, 53 insertions(+), 12 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 8a9bbf27918..3f0d1113608 100644 ---

[PULL 14/15] virtio-mem: Require only coordinated discards

2021-07-07 Thread Eduardo Habkost
irkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-13-da...@redhat.com> Signed-off-by: Eduardo

[PULL 10/15] vfio: Sanity check maximum number of DMA mappings with RamDiscardManager

2021-07-07 Thread Eduardo Habkost
irkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-9-da...@redhat.com> Signed-off-by: Eduardo

[PULL 08/15] vfio: Support for RamDiscardManager in the !vIOMMU case

2021-07-07 Thread Eduardo Habkost
210413095531.25603-7-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/vfio/vfio-common.h | 11 +++ hw/vfio/common.c | 164 ++ 2 files changed, 175 insertions(+) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-

[PULL 09/15] vfio: Query and store the maximum number of possible DMA mappings

2021-07-07 Thread Eduardo Habkost
y: David Hildenbrand Message-Id: <20210413095531.25603-8-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/common.c | 4 2 files changed, 5 insertions(+) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-

[PULL 12/15] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)

2021-07-07 Thread Eduardo Habkost
ael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-11-da...@redhat.com> Signed-off-by: Eduardo

[PULL 05/15] virtio-mem: Factor out traversing unplugged ranges

2021-07-07 Thread Eduardo Habkost
dov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-4-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/virtio/virtio-mem.c | 86 -

[PULL 07/15] virtio-mem: Implement RamDiscardManager interface

2021-07-07 Thread Eduardo Habkost
com> Signed-off-by: Eduardo Habkost --- include/hw/virtio/virtio-mem.h | 3 + hw/virtio/virtio-mem.c | 288 - 2 files changed, 288 insertions(+), 3 deletions(-) diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h index 4ee

[PULL 01/15] vmbus: Don't make QOM property registration conditional

2021-07-07 Thread Eduardo Habkost
Having properties registered conditionally makes QOM type introspection difficult. Instead of skipping registration of the "instanceid" property, always register the property but validate its value against the instance id required by the class. Signed-off-by: Eduardo Habkost Acked-by

[PULL 11/15] vfio: Support for RamDiscardManager in the vIOMMU case

2021-07-07 Thread Eduardo Habkost
Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-10-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/migration/vmstate.h | 1 + hw/vfio/common.c| 39 +++

[PULL 13/15] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types

2021-07-07 Thread Eduardo Habkost
" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-12-da...@redhat.com> Signed-off-by: Eduardo Habkost -

[PULL 00/15] Machine queue, 2021-07-07

2021-07-07 Thread Eduardo Habkost
ecate pmem=on with non-DAX capable backend file (Igor Mammedov) Feature: * virtio-mem: vfio support (David Hildenbrand) Cleanup: * vmbus: Don't make QOM property registration conditional (Eduardo Habkost) David Hildenbrand

[PULL 06/15] virtio-mem: Don't report errors when ram_block_discard_range() fails

2021-07-07 Thread Eduardo Habkost
a Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-5-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/virtio/virtio-mem.c | 20 1 file changed, 4 insertions(+),

[PULL 03/15] memory: Introduce RamDiscardManager for RAM memory regions

2021-07-07 Thread Eduardo Habkost
Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-2-da...@redhat.com> Signed-off-by: Eduardo Habkost --- include/exec/memory.h |

[PULL 02/15] Deprecate pmem=on with non-DAX capable backend file

2021-07-07 Thread Eduardo Habkost
So if user asks for persistence (pmem=on), they should store backing file on NVDIMM. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210111203332.740815-1-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/system/deprecated.rst | 18 ++

[PULL 04/15] memory: Helpers to copy/free a MemoryRegionSection

2021-07-07 Thread Eduardo Habkost
i Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski Signed-off-by: David Hildenbrand Message-Id: <20210413095531.25603-3-da...@redhat.com> Signed-of

Re: [PATCH v8 0/9] i386: KVM: expand Hyper-V features early

2021-07-07 Thread Eduardo Habkost
On Tue, Jun 08, 2021 at 02:08:08PM +0200, Vitaly Kuznetsov wrote: > Changes since v7: > - Make eVMCS version check future proof [Eduardo] > - Collect R-b tags [Eduardo] > - Drop 'if (!strcmp(arch, "i386") || !strcmp(arch, "x86_64"))' check from > q

Re: [PATCH v7 0/9] i386: KVM: expand Hyper-V features early

2021-07-07 Thread Eduardo Habkost
On Thu, Jun 03, 2021 at 01:48:26PM +0200, Vitaly Kuznetsov wrote: > Changes since v6 [Eduardo]: > - First 14 patches of v6 made it upstream! > - New patches addressing feedback on the already merged patches added: > i386: make hyperv_expand_features() return bool > i386: har

Re: [PATCH v7 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-07-06 Thread Eduardo Habkost
parate patch later. > > Signed-off-by: Ziqiao Kong Richard, are you OK with merging this? I'm not familiar enough with TCG code to be confident in reviewing it. -- Eduardo

Re: [External] Re: [PATCH] target/i386: Fix cpuid level for AMD

2021-07-02 Thread Eduardo Habkost
> > > > > for multi-dies PCMachine) > > > > > > > Signed-off-by: zhenwei pi > > > > > > > > > > > > (Copying in Babu) > > > > > > > > > > > > Hmm I think you're right. I've cc'd in Bab

Re: [PATCH] target/i386: Fix cpuid level for AMD

2021-07-02 Thread Eduardo Habkost
to 0x1f in multi-dies case. > > > > > > Fixes: a94e1428991 (target/i386: Add CPUID.1F generation support > > > for multi-dies PCMachine) > > > Signed-off-by: zhenwei pi > > > > (Copying in Babu) > > > > Hmm I think you're right. I

Re: [PATCH] seccomp: don't block getters for resource control syscalls

2021-07-01 Thread Eduardo Otubo
SYS(sched_setaffinity), QEMU_SECCOMP_SET_RESOURCECTL }, > -{ SCMP_SYS(sched_getaffinity), QEMU_SECCOMP_SET_RESOURCECTL }, > -{ SCMP_SYS(sched_get_priority_max), QEMU_SECCOMP_SET_RESOURCECTL }, > -{ SCMP_SYS(sched_get_priority_min), QEMU_SECCOMP_SET_RESOURCECTL }, > }; > >

Re: [PATCH v4 01/34] modules: add modinfo macros

2021-06-24 Thread Eduardo Habkost
; +#define module_obj(name) modinfo(obj, name) Can we make OBJECT_DEFINE_TYPE*() use this macro automatically? -- Eduardo

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

2021-06-21 Thread Eduardo Habkost
On Mon, Jun 21, 2021 at 10:07:44AM +0200, Claudio Fontana wrote: > On 6/18/21 10:40 PM, Eduardo Habkost wrote: > > On Fri, Jun 18, 2021 at 07:52:47AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >>> On Thu, Jun 17, 2021 at 05:53:11PM

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

2021-06-18 Thread Eduardo Habkost
On Fri, Jun 18, 2021 at 07:52:47AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: > >> On 6/17/21 5:39 PM, Valeriy Vdovin wrote: > >> > On Thu, Jun 17, 2021 at 04:14:17

[PULL 4/7] docs: Add SEV-ES documentation to amd-memory-encryption.txt

2021-06-18 Thread Eduardo Habkost
Reviewed-by: Connor Kuehl Message-Id: Signed-off-by: Eduardo Habkost --- docs/amd-memory-encryption.txt | 54 +- 1 file changed, 47 insertions(+), 7 deletions(-) diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt index ed85159ea7d

[PULL 2/7] i386: Add ratelimit for bus locks acquired in guest

2021-06-18 Thread Eduardo Habkost
ecture-instruction-set-extensions-programming-reference.html Signed-off-by: Chenyi Qiang Message-Id: <20210521043820.29678-1-chenyi.qi...@intel.com> Signed-off-by: Eduardo Habkost --- include/hw/i386/x86.h | 8 hw/i386/x86.c | 24 +

[PULL 6/7] docs: add a table showing x86-64 ABI compatibility levels

2021-06-18 Thread Eduardo Habkost
and more. Signed-off-by: Daniel P. Berrangé Message-Id: <20210607135843.196595-2-berra...@redhat.com> Signed-off-by: Eduardo Habkost --- MAINTAINERS| 2 +- docs/system/cpu-models-x86-abi.csv | 67 ++ docs/system/cpu-models-x86.rst.in

[PULL 7/7] scripts: helper to generate x86_64 CPU ABI compat info

2021-06-18 Thread Eduardo Habkost
From: Daniel P. Berrangé This script is what is used to generate the docs data table in: docs/system/cpu-models-x86-abi.csv It can be useful to run if adding new CPU models / versions and the csv needs updating. Signed-off-by: Daniel P. Berrangé Acked-by: Eduardo Habkost Message-Id

[PULL 3/7] doc: Fix some mistakes in the SEV documentation

2021-06-18 Thread Eduardo Habkost
From: Tom Lendacky Fix some spelling and grammar mistakes in the amd-memory-encryption.txt file. No new information added. Signed-off-by: Tom Lendacky Reviewed-by: Laszlo Ersek Reviewed-by: Connor Kuehl Message-Id: Signed-off-by: Eduardo Habkost --- docs/amd-memory-encryption.txt | 59

[PULL 5/7] docs/interop/firmware.json: Add SEV-ES support

2021-06-18 Thread Eduardo Habkost
eviewed-by: Laszlo Ersek Reviewed-by: Connor Kuehl Message-Id: Signed-off-by: Eduardo Habkost --- docs/interop/firmware.json | 47 +- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json index 9

[PULL 0/7] x86 queue, 2021-06-18

2021-06-18 Thread Eduardo Habkost
tomated changes: * Update Linux headers to 5.13-rc4 (Eduardo Habkost) Chenyi Qiang (1): i386: Add ratelimit for bus locks acquired in guest Daniel P. Berrangé (2): docs: add a table showing x86-64 ABI compatibility levels sc

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

2021-06-17 Thread Eduardo Habkost
On Thu, Jun 17, 2021 at 3:17 PM Dov Murik wrote: > > > > On 17/06/2021 20:22, Eduardo Habkost wrote: > > On Thu, Jun 17, 2021 at 03:48:52PM +0300, Dov Murik wrote: > >> > >> > >> On 15/06/2021 22:53, Philippe Mathieu-Daudé wrote: > >>> Hi

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

2021-06-17 Thread Eduardo Habkost
On Thu, Jun 17, 2021 at 03:48:52PM +0300, Dov Murik wrote: > > > On 15/06/2021 22:53, Philippe Mathieu-Daudé wrote: > > Hi Dov, James, > > > > +Connor who asked to be reviewer. > > > > On 6/15/21 5:20 PM, Eduardo Habkost wrote: > >> On Tue, M

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

2021-06-17 Thread Eduardo Habkost
entirely, the command isn't > >> there, and trying to use it fails like > >> > >> {"error": {"class": "CommandNotFound", "desc": "The command > >> query-kvm-cpuid has not been found"}} > >> > >> If KVM is compiled in, but disabled, e.g. with -machine accel=tcg, then > >> the command fails like > >> > >> {"error": {"class": "GenericError", "desc": "VCPU was not initialized > >> yet"}} > >> > >> This is misleading. The VCPU is actually running, it's just the wrong > >> kind of VCPU. > >> > >>>> If it just isn't implemented for anything but KVM, then putting "kvm" > >>>> into the command name is a bad idea. Also, the commit message should > >>>> briefly note the restriction to KVM. > >> > >> Perhaps this one is closer to reality. > >> > > I agree. > > What command name do you suggest? > > query-exposed-cpuid? Pasting the reply I sent at [1]: I don't really mind how the command is called, but I would prefer to add a more complex abstraction only if maintainers of other accelerators are interested and volunteer to provide similar functionality. I don't want to introduce complexity for use cases that may not even exist. I'm expecting this to be just a debugging mechanism, not a stable API to be maintained and supported for decades. (Maybe a "x-" prefix should be added to indicate that?) [1] https://lore.kernel.org/qemu-devel/20210602204604.crsxvqixkkll4...@habkost.net -- Eduardo

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

2021-06-15 Thread Eduardo Habkost
F > has " > +"no hash table guid\n"); > +exit(1); > +} > +area = (struct sev_hash_table_descriptor *)data; > + > +sev_ht = qemu_map_ram_ptr(NULL, area->base); > + memcpy(sev_ht->guid, sev_hash_table_header_guid, > sizeof(sev_ht->guid)); > +sev_ht->len = sizeof(*sev_ht); > +} > + > /* kernel protocol version */ > if (ldl_p(header + 0x202) == 0x53726448) { > protocol = lduw_p(header + 0x206); [...] -- Eduardo

Re: [PATCH v8 3/9] i386: hardcode supported eVMCS version to '1'

2021-06-15 Thread Eduardo Habkost
t;it wouldn't be possible to migrate", as this patch fixes the problem and makes it possible? > > Hardcode eVMCS ver.1 as the result of 'hv-evmcs' enablement for now. Newer > eVMCS versions will have to have their own enablement options (e.g. > 'hv-evmcs=2'). > > Signed-off-by: Vitaly Kuznetsov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v8 9/9] qtest/hyperv: Introduce a simple hyper-v test

2021-06-15 Thread Eduardo Habkost
gt; guest. > > Signed-off-by: Vitaly Kuznetsov Acked-by: Eduardo Habkost -- Eduardo

Re: [PATCH v3 0/4] target/i386/cpu: introduce new CPU models for x86-64 ABI levels

2021-06-07 Thread Eduardo Habkost
document any of the CPU aliases, since they vary per >machine type, only the concrete types. > - Formally add the script for re-generating the docs > > Daniel P. Berrangé (4): > docs: add a table showing x86-64 ABI compatibility levels > target/i386: define CPU models to model x86-64 ABI levels > scripts: helper to generate x86_64 CPU ABI compat info > NOT FOR MERGE target/i386: use x86-64-abi1 CPU model as default on > x86_64 > > MAINTAINERS| 2 +- > docs/system/cpu-models-x86-abi.csv | 75 +++ > docs/system/cpu-models-x86.rst.inc | 22 > hw/i386/pc_piix.c | 3 + > hw/i386/pc_q35.c | 3 + > scripts/cpu-x86-uarch-abi.py | 194 + > target/i386/cpu.c | 156 +++ > target/i386/cpu.h | 2 +- > 8 files changed, 455 insertions(+), 2 deletions(-) > create mode 100644 docs/system/cpu-models-x86-abi.csv > create mode 100644 scripts/cpu-x86-uarch-abi.py > > -- > 2.31.1 > > -- Eduardo

Re: [PATCH v3 3/4] scripts: helper to generate x86_64 CPU ABI compat info

2021-06-07 Thread Eduardo Habkost
On Mon, Jun 07, 2021 at 02:11:44PM -0300, Eduardo Habkost wrote: > On Mon, Jun 07, 2021 at 02:58:42PM +0100, Daniel P. Berrangé wrote: > [...] > > +# Assumes externally launched process such as > > +# > > +# qemu-system-x86_64 -qmp unix:/tmp/qmp,server,nowait -disp

Re: [PATCH v3 1/4] docs: add a table showing x86-64 ABI compatibility levels

2021-06-07 Thread Eduardo Habkost
ttps://gitlab.com/x86-psABIs/x86-64-ABI/ > > and supported by GCC, Clang, glibc and more. > > Signed-off-by: Daniel P. Berrangé Queued, thanks! -- Eduardo

Re: [PATCH v3 3/4] scripts: helper to generate x86_64 CPU ABI compat info

2021-06-07 Thread Eduardo Habkost
t;) I would make the script launch QEMU itself, using the QEMUMachine class. But life is too short for polishing a quick utility script, so: Acked-by: Eduardo Habkost I plan to queue this once I review the rest of the series. -- Eduardo

<    1   2   3   4   5   6   7   8   9   10   >