RE: [RFC v2 11/13] vdpa: add vdpa net migration state notifier

2023-02-12 Thread Eli Cohen
h Anand > ; Gautam Dawar ; Stefano > Garzarella ; Cornelia Huck ; > Cindy Lu ; Eli Cohen ; Paolo Bonzini > ; Michael S. Tsirkin ; Jason Wang > ; Stefan Hajnoczi ; Parav > Pandit > Subject: Re: [RFC v2 11/13] vdpa: add vdpa net migration state notifier > > > > On 1/

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-28 Thread Eli Cohen
> From: Michael S. Tsirkin > Sent: Wednesday, July 27, 2022 6:44 PM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; Jason > Wang ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negotiated > > On Wed, Jul 27, 20

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
> From: Jason Wang > Sent: Thursday, July 28, 2022 5:09 AM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > Michael S. Tsirkin ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negotiated > > On Wed, Jul 27, 2022

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
> -Original Message- > From: Michael S. Tsirkin > Sent: Wednesday, July 27, 2022 12:35 PM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; Jason > Wang ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negoti

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
> -Original Message- > From: Michael S. Tsirkin > Sent: Wednesday, July 27, 2022 10:25 AM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; Jason > Wang ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negoti

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
I found out that the reason why I could not enforce the mtu stems from the fact that I did not configure max mtu for the net device (e.g. through libvirt ). Libvirt does not allow this configuration for vdpa devices and probably for a reason. The vdpa backend driver has the freedom to do it

Re: [PATCH 15/18] vhost-net: control virtqueue support

2021-06-24 Thread Eli Cohen
On Mon, Jun 21, 2021 at 12:16:47PM +0800, Jason Wang wrote: > We assume there's no cvq in the past, this is not true when we need > control virtqueue support for vhost-user backends. So this patch > implements the control virtqueue support for vhost-net. As datapath, > the control virtqueue is

Re: [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()

2021-06-24 Thread Eli Cohen
On Thu, Jun 24, 2021 at 03:10:46PM +0800, Jason Wang wrote: > > 在 2021/6/24 下午3:06, Eli Cohen 写道: > > On Wed, Jun 23, 2021 at 05:00:16PM +0200, Stefano Garzarella wrote: > > > On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote: > > > > Fixes: 1e0a84ea49

Re: [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()

2021-06-24 Thread Eli Cohen
On Wed, Jun 23, 2021 at 05:00:16PM +0200, Stefano Garzarella wrote: > On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote: > > Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") > > Signed-off-by: Jason Wang > > --- > > net/vhost-vdpa.c | 1 + > > 1 file changed, 1

Re: [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()

2021-06-24 Thread Eli Cohen
On Wed, Jun 23, 2021 at 05:00:16PM +0200, Stefano Garzarella wrote: > On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote: > > Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") > > Signed-off-by: Jason Wang > > --- > > net/vhost-vdpa.c | 1 + > > 1 file changed, 1

Re: [PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()

2021-06-24 Thread Eli Cohen
off-by: Jason Wang Reviewed-by: Eli Cohen > --- > net/vhost-vdpa.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 18b45ad777..728e63ff54 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -112,10 +112,6 @@

Re: [PATCH 03/18] vhost_net: do not assume nvqs is always 2

2021-06-24 Thread Eli Cohen
Maybe worth mentioning in the changelog that nvqs is still set to 2 for all users and this patch does not change functionality. Reviewed-by: Eli Cohen > Signed-off-by: Jason Wang > --- > hw/net/vhost_net.c | 2 +- > include/net/vhost_net.h | 1 + > net/tap.c

Re: [PATCH 01/18] vhost_net: remove the meaningless assignment in vhost_net_start_one()

2021-06-21 Thread Eli Cohen
On Mon, Jun 21, 2021 at 12:16:33PM +0800, Jason Wang wrote: > The nvqs and vqs has been initialized during vhost_net_init() and is I suggest "nvqs and vqs have been initialized during vhost_net_init() and are not..." Other than that Reviewed-by: Eli Cohen > not expected

Re: [PATCH 02/18] vhost: use unsigned int for nvqs

2021-06-21 Thread Eli Cohen
On Mon, Jun 21, 2021 at 12:16:34PM +0800, Jason Wang wrote: > Switch to use unsigned int for nvqs since it's not expected to be > negative. > > Signed-off-by: Jason Wang Reviewed-by: Eli Cohen > --- > include/hw/virtio/vhost.h | 2 +- > 1 file changed, 1 insertion(+), 1