Re: [Qemu-devel] [PATCH 40/64] PPC: Fix sync instructions problem in SMP

2011-10-06 Thread Elie Richa
be to perform a write on the second step rather than just a reservation. But aside from that the problem remains the same and the patch does solve it. On Oct 6, 2011, at 10:05 AM, Alexander Graf wrote: From: Elie Richa ri...@adacore.com In the current emulation of the load-and-reserve (lwarx

[Qemu-devel] [PATCH] Flexible array should be last in struct mbuf

2011-09-08 Thread Elie Richa
The flexible array member should remain the last member in the structure as this assumption is based upon in the code. Signed-off-by: Elie Richa ri...@adacore.com --- slirp/mbuf.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/slirp/mbuf.h b/slirp/mbuf.h index

Re: [Qemu-devel] [PATCH] PPC: Fix for the gdb single step problem on an rfi instruction

2011-08-12 Thread Elie Richa
Hello, I've had this problem recently and your patch does fix the issue, thanks! Regards, Elie On 08/10/2011 01:41 PM, Sebastian Bauer wrote: When using gdb to single step a ppc interrupt routine, the execution flow passes the rfi instruction without actually returning from the interrupt. The

Re: [Qemu-devel] [PATCH] PPC: Fix sync instructions problem in SMP

2011-08-04 Thread Elie Richa
board if needed. Even though my patch is rather harsh, it has the advantage of solving the problem for any number of CPUs without touching the translation code. And it does not affect normal execution as I explained in the previous mail. Regards, Elie On 07/22/2011 05:58 PM, Elie Richa wrote

Re: [Qemu-devel] [PATCH 05/28] PPC: Set MPIC IDE for IPI to 0

2011-07-25 Thread Elie Richa
On 07/23/2011 12:49 PM, Alexander Graf wrote: @@ -1304,6 +1304,10 @@ static void mpic_reset (void *opaque) mpp-src[i].ipvp = 0x8080; mpp-src[i].ide = 0x0001; } +/* Set IDE for IPIs to 0 so we don't get spurious interrupts */ +for (i = mpp-irq_ipi0; i

Re: [Qemu-devel] [PATCH 06/23] PPC: Fix IPI support in MPIC

2011-07-22 Thread Elie Richa
Hello. I have been working on SMP support for the MPC8641D processor, so I have also worked on completing the SMP implementation of MPIC. I've been meaning to post a patch, but you beat me to it :) I compared your implementation to mine, and it boils down to the same, except that I had

Re: [Qemu-devel] [PATCH 08/23] PPC: Bump MPIC up to 32 supported CPUs

2011-07-22 Thread Elie Richa
On 07/21/2011 03:27 AM, Alexander Graf wrote: @@ -1288,7 +1288,7 @@ static void mpic_reset (void *opaque) mpp-glbc = 0x8000; /* Initialise controller registers */ -mpp-frep = 0x004f0002; +mpp-frep = 0x004f0002 | ((MAX_CPU - 1) 8); Should we really report the maximum

[Qemu-devel] [PATCH] PPC: Fix sync instructions problem in SMP

2011-07-22 Thread Elie Richa
before a CPU switch occurs. However in the rare case where a CPU switch does occur between the lwarx and its corresponding stwcx. this patch solves a potential erroneous behavior of the synchronization instructions. Signed-off-by: Elie Richa ri...@adacore.com --- cpu-exec.c |1 + 1 files