Re: [PATCH qemu v3] x86: don't let decompressed kernel image clobber setup_data

2023-01-22 Thread Eric Biggers
Hi Michael, On Tue, Jan 10, 2023 at 12:50:42PM -0500, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 04:34:49PM +0100, Jason A. Donenfeld wrote: > > Hi Michael, > > > > Could you queue up this patch and mark it as a fix for 7.2.1? It is a > > straight-up bug fix for a 7.2 regression that's

Re: [PATCH qemu v3] x86: don't let decompressed kernel image clobber setup_data

2023-01-04 Thread Eric Biggers
> be changed around, incurring more complexity. In contrast, using cmdline > is simple and doesn't interfere with anything. > > The microvm machine has a gross hack where it fiddles with fw_cfg data > after the fact. So this hack is updated to account for this appending, > by reserv

Re: [PATCH v5 4/4] x86: re-enable rng seeding via SetupData

2022-12-23 Thread Eric Biggers
Hi Jason, On Wed, Sep 21, 2022 at 11:31:34AM +0200, Jason A. Donenfeld wrote: > This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), but > for 7.2 rather than 7.1, now that modifying setup_data is safe to do. > > Cc: Laurent Vivier > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini

Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned

2022-11-03 Thread Eric Biggers
On Thu, Nov 03, 2022 at 04:26:14PM +, Eric Biggers wrote: > > In other words, STATX_DIOALIGN is unusable from the start because we > > don't know whether the information it returns is actually correct? :-/ > > That's a silly point of view. STATX_DIOALIGN has only been in a

Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned

2022-11-03 Thread Eric Biggers
On Thu, Nov 03, 2022 at 10:52:43AM +0100, Kevin Wolf wrote: > Am 02.11.2022 um 03:49 hat Eric Biggers geschrieben: > > On Tue, Nov 01, 2022 at 07:27:16PM -0700, Eric Biggers wrote: > > > On Tue, Nov 01, 2022 at 03:00:30PM -0400, Stefan Hajnoczi wrote: > > > > Linux d

Re: [PATCH 2/2] file-posix: add statx(STATX_DIOALIGN) support

2022-11-01 Thread Eric Biggers
On Tue, Nov 01, 2022 at 03:00:31PM -0400, Stefan Hajnoczi wrote: > /* Let's try to use the logical blocksize for the alignment. */ > -if (probe_logical_blocksize(fd, >bl.request_alignment) < 0) { > -bs->bl.request_alignment = 0; > +if (!bs->bl.request_alignment) { > +

Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned

2022-11-01 Thread Eric Biggers
On Tue, Nov 01, 2022 at 07:27:16PM -0700, Eric Biggers wrote: > On Tue, Nov 01, 2022 at 03:00:30PM -0400, Stefan Hajnoczi wrote: > > Linux dm-crypt returns errno EIO from unaligned O_DIRECT pread(2) calls. > > Citation needed. For direct I/O to block devices, the kernel's block

Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned

2022-11-01 Thread Eric Biggers
On Tue, Nov 01, 2022 at 03:00:30PM -0400, Stefan Hajnoczi wrote: > Linux dm-crypt returns errno EIO from unaligned O_DIRECT pread(2) calls. Citation needed. For direct I/O to block devices, the kernel's block layer checks the alignment before the I/O is actually submitted to the underlying block

Re: Re: [PATCH v3 0/6] Support akcipher for virtio-crypto

2022-03-23 Thread Eric Biggers
On Wed, Mar 23, 2022 at 03:32:37PM +0800, zhenwei pi wrote: > > On 3/23/22 13:17, Eric Biggers wrote: > > On Wed, Mar 23, 2022 at 10:49:06AM +0800, zhenwei pi wrote: > > > v2 -> v3: > > > - Introduce akcipher types to qapi > > > - Add test/benchmark

Re: [PATCH v3 0/6] Support akcipher for virtio-crypto

2022-03-22 Thread Eric Biggers
On Wed, Mar 23, 2022 at 10:49:06AM +0800, zhenwei pi wrote: > v2 -> v3: > - Introduce akcipher types to qapi > - Add test/benchmark suite for akcipher class > - Seperate 'virtio_crypto: Support virtio crypto asym operation' into: > - crypto: Introduce akcipher crypto class > - virtio-crypto:

Re: [PATCH RFC v1 1/2] random: add mechanism for VM forks to reinitialize crng

2022-02-23 Thread Eric Biggers
On Wed, Feb 23, 2022 at 02:12:30PM +0100, Jason A. Donenfeld wrote: > When a VM forks, we must immediately mix in additional information to > the stream of random output so that two forks or a rollback don't > produce the same stream of random numbers, which could have catastrophic > cryptographic

Re: [PATCH RFC v1 1/2] random: add mechanism for VM forks to reinitialize crng

2022-02-23 Thread Eric Biggers
On Thu, Feb 24, 2022 at 01:54:54AM +0100, Jason A. Donenfeld wrote: > On 2/24/22, Eric Biggers wrote: > > I think we should be removing cases where the base_crng key is changed > > directly > > besides extraction from the input_pool, not adding new ones.