Re: [PATCH 0/3] vhost-user-gpu: support dmabuf modifiers

2023-08-22 Thread Erico Nunes
Hello, On 14/07/2023 22:03, Marc-André Lureau wrote: > Hi > > On Fri, Jul 14, 2023 at 7:42 PM Erico Nunes <mailto:ernu...@redhat.com>> wrote: > > virglrenderer recently added virgl_renderer_resource_get_info_ext as a > new api, which gets resource in

Re: [PATCH v3 0/9] gfxstream + rutabaga_gfx

2023-08-07 Thread Erico Nunes
Hello, On 04/08/2023 01:54, Gurchetan Singh wrote: > Prior versions: > > https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg05801.html > > https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg02341.html > > https://patchew.org/QEMU/20230421011223.718-1-gurchetansi...@chromium.org/ >

[PATCH 2/3] contrib/vhost-user-gpu: add support for sending dmabuf modifiers

2023-07-14 Thread Erico Nunes
modifiers information may result in completely broken rendering. Signed-off-by: Erico Nunes --- contrib/vhost-user-gpu/vhost-user-gpu.c | 5 ++- contrib/vhost-user-gpu/virgl.c | 51 +++-- contrib/vhost-user-gpu/vugpu.h | 9 + 3 files changed, 61 insertions

[PATCH 1/3] docs: vhost-user-gpu: add protocol changes for dmabuf modifiers

2023-07-14 Thread Erico Nunes
-off-by: Erico Nunes --- docs/interop/vhost-user-gpu.rst | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/docs/interop/vhost-user-gpu.rst b/docs/interop/vhost-user-gpu.rst index b78806892d..3035822d05 100644 --- a/docs/interop/vhost-user-gpu.rst +++ b

[PATCH 3/3] vhost-user-gpu: support dmabuf modifiers

2023-07-14 Thread Erico Nunes
When the backend sends VHOST_USER_GPU_DMABUF_SCANOUT2, handle it by getting the modifiers information which is now available. Signed-off-by: Erico Nunes --- hw/display/vhost-user-gpu.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/display/vhost-user

[PATCH 0/3] vhost-user-gpu: support dmabuf modifiers

2023-07-14 Thread Erico Nunes
there is a better way (or naming) to handle it. Erico Nunes (3): docs: vhost-user-gpu: add protocol changes for dmabuf modifiers contrib/vhost-user-gpu: add support for sending dmabuf modifiers vhost-user-gpu: support dmabuf modifiers contrib/vhost-user-gpu/vhost-user-gpu.c | 5 ++- contrib

[PATCH v4 0/4] vhost-user-gpu get_edid feature

2023-06-26 Thread Erico Nunes
eature but does not support the protocol feature, the backend will abort with an error. v3 -> v4: - Remove unused fd code on patch 4/4 v2 -> v3: - Fixed review comments from v2. Missing struct documentation and setting feature bits to be compatible with the frontend. Erico Nunes (4):

[PATCH v4 4/4] vhost-user-gpu: implement get_edid frontend feature

2023-06-26 Thread Erico Nunes
Implement the frontend side of the get_edid feature in the qemu vhost-user-gpu frontend device. Signed-off-by: Erico Nunes Reviewed-by: Marc-André Lureau --- hw/display/vhost-user-gpu.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/display/vhost-user

[PATCH v4 3/4] contrib/vhost-user-gpu: implement get_edid feature

2023-06-26 Thread Erico Nunes
feature but does not support the protocol feature, the backend will abort with an error. Signed-off-by: Erico Nunes Reviewed-by: Marc-André Lureau --- contrib/vhost-user-gpu/vhost-user-gpu.c | 73 +++-- contrib/vhost-user-gpu/virgl.c | 3 + contrib/vhost-user-gpu

[PATCH v4 1/4] virtio-gpu: refactor generate_edid function to virtio_gpu_base

2023-06-26 Thread Erico Nunes
This functionality can be shared with upcoming use in vhost-user-gpu, so move it to the shared file to avoid duplicating it. Signed-off-by: Erico Nunes Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu-base.c | 17 + hw/display/virtio-gpu.c| 20

[PATCH v4 2/4] docs: vhost-user-gpu: add protocol changes for EDID

2023-06-26 Thread Erico Nunes
VHOST_USER_GPU_GET_EDID is defined as a message from the backend to the frontend to retrieve the EDID data for a given scanout. The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is defined as a way to check whether this new message is supported or not. Signed-off-by: Erico Nunes Reviewed-by

[PATCH v3 1/4] virtio-gpu: refactor generate_edid function to virtio_gpu_base

2023-06-07 Thread Erico Nunes
This functionality can be shared with upcoming use in vhost-user-gpu, so move it to the shared file to avoid duplicating it. Signed-off-by: Erico Nunes --- hw/display/virtio-gpu-base.c | 17 + hw/display/virtio-gpu.c| 20 +--- include/hw/virtio/virtio

[PATCH v3 3/4] contrib/vhost-user-gpu: implement get_edid feature

2023-06-07 Thread Erico Nunes
feature but does not support the protocol feature, the backend will abort with an error. Signed-off-by: Erico Nunes --- contrib/vhost-user-gpu/vhost-user-gpu.c | 73 +++-- contrib/vhost-user-gpu/virgl.c | 3 + contrib/vhost-user-gpu/vugpu.h | 11 3 files

[PATCH v3 4/4] vhost-user-gpu: implement get_edid frontend feature

2023-06-07 Thread Erico Nunes
Implement the frontend side of the get_edid feature in the qemu vhost-user-gpu frontend device. Signed-off-by: Erico Nunes --- hw/display/vhost-user-gpu.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost

[PATCH v3 2/4] docs: vhost-user-gpu: add protocol changes for EDID

2023-06-07 Thread Erico Nunes
VHOST_USER_GPU_GET_EDID is defined as a message from the backend to the frontend to retrieve the EDID data for a given scanout. The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is defined as a way to check whether this new message is supported or not. Signed-off-by: Erico Nunes --- docs

[PATCH v3 0/4] vhost-user-gpu get_edid feature

2023-06-07 Thread Erico Nunes
eature but does not support the protocol feature, the backend will abort with an error. v2 -> v3: - Fixed review comments from v2. Missing struct documentation and setting feature bits to be compatible with the frontend. Erico Nunes (4): virtio-gpu: refactor generate_edid function to virt

Re: [PATCH 0/2] vhost-user-gpu get_edid feature

2023-05-31 Thread Erico Nunes
On 24/05/2023 13:23, Marc-André Lureau wrote: > Hi Erico > > On Wed, May 17, 2023 at 8:09 PM Erico Nunes <mailto:ernu...@redhat.com>> wrote: > > On 15/05/2023 13:38, Marc-André Lureau wrote: > > However, I worry about using the new backend (calling GET_EDI

[PATCH v2 1/4] virtio-gpu: refactor generate_edid function to virtio_gpu_base

2023-05-31 Thread Erico Nunes
This functionality can be shared with upcoming use in vhost-user-gpu, so move it to the shared file to avoid duplicating it. Signed-off-by: Erico Nunes --- hw/display/virtio-gpu-base.c | 17 + hw/display/virtio-gpu.c| 20 +--- include/hw/virtio/virtio

[PATCH v2 2/4] docs: vhost-user-gpu: add protocol changes for EDID

2023-05-31 Thread Erico Nunes
VHOST_USER_GPU_GET_EDID is defined as a message from the backend to the frontend to retrieve the EDID data for a given scanout. The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is defined as a way to check whether this new message is supported or not. Signed-off-by: Erico Nunes --- docs

[PATCH v2 3/4] contrib/vhost-user-gpu: implement get_edid feature

2023-05-31 Thread Erico Nunes
feature but does not support the protocol feature, the backend will abort with an error. Signed-off-by: Erico Nunes --- contrib/vhost-user-gpu/vhost-user-gpu.c | 67 +++-- contrib/vhost-user-gpu/virgl.c | 3 ++ contrib/vhost-user-gpu/vugpu.h | 11 3 files

[PATCH v2 0/4] vhost-user-gpu get_edid feature

2023-05-31 Thread Erico Nunes
eature but does not support the protocol feature, the backend will abort with an error. Erico Nunes (4): virtio-gpu: refactor generate_edid function to virtio_gpu_base docs: vhost-user-gpu: add protocol changes for EDID contrib/vhost-user-gpu: implement get_edid feature vhost-user-gpu: imp

[PATCH v2 4/4] vhost-user-gpu: implement get_edid frontend feature

2023-05-31 Thread Erico Nunes
Implement the frontend side of the get_edid feature in the qemu vhost-user-gpu frontend device. Signed-off-by: Erico Nunes --- hw/display/vhost-user-gpu.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost

Re: [PATCH 0/2] vhost-user-gpu get_edid feature

2023-05-17 Thread Erico Nunes
On 15/05/2023 13:38, Marc-André Lureau wrote: > However, I worry about using the new backend (calling GET_EDID) with an > older front-end/QEMU. It may just hang, since > vhost_user_gpu_handle_display() won't reply to unknown messages. That's > what PROTOCOL_FEATURES were meant for, iirc. Can you ch

Re: [PATCH] ui/gtk: fix passing y0_top parameter to scanout

2023-05-11 Thread Erico Nunes
Hello, On 20/02/2023 18:58, Marc-André Lureau wrote: > > > On Mon, Feb 20, 2023 at 9:56 PM Erico Nunes <mailto:ernu...@redhat.com>> wrote: > > The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however > in the gtk ui both implementations

[PATCH 1/2] virtio-gpu: refactor generate_edid function to virtio_gpu_base

2023-05-11 Thread Erico Nunes
This can be shared with upcoming use in vhost-user-gpu, so move it to the shared file to avoid duplicating it. Signed-off-by: Erico Nunes --- hw/display/virtio-gpu-base.c | 17 + hw/display/virtio-gpu.c| 20 +--- include/hw/virtio/virtio-gpu.h | 2

[PATCH 0/2] vhost-user-gpu get_edid feature

2023-05-11 Thread Erico Nunes
so far requiring bidirectional messages with different payloads so I just based it on similar available ones. Thanks Erico Nunes (2): virtio-gpu: refactor generate_edid function to virtio_gpu_base vhost-user-gpu: implement get_edid feature contrib/vhost-user-gpu/vhost-user-gpu.c | 53

[PATCH 2/2] vhost-user-gpu: implement get_edid feature

2023-05-11 Thread Erico Nunes
access to all the display information. In the case of get_edid, it also needs to pass which scanout we should retrieve the edid for. Signed-off-by: Erico Nunes --- contrib/vhost-user-gpu/vhost-user-gpu.c | 53 - contrib/vhost-user-gpu/virgl.c | 3 ++ contrib/vhost

Re: [PATCH 1/2] ui/gtk: use widget size for cursor motion event

2023-03-30 Thread Erico Nunes
On 23/03/2023 15:41, Marc-André Lureau wrote: > Should we queue the 2 patches from this series? (note that they were > not correctly handled by patchew, probably because you dropped the > cover letter). > > For me -display gtk is unusable on hidpi & wayland anyway, because the > cursor position

Re: [PATCH 1/2] ui/gtk: use widget size for cursor motion event

2023-03-22 Thread Erico Nunes
idget, which already returns the size >> of the actual space to render the framebuffer. >> >> Signed-off-by: Erico Nunes >> --- >> ui/gtk.c | 8 +++- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/ui/gtk.c b/ui/gtk.c >&

Re: [PULL 0/7] ui/ fixes for 8.0

2023-03-21 Thread Erico Nunes
serial reset, during init (2023-03-21 11:46:22 +0400) > > > ui/ fixes for 8.0 > > -------- > > Erico Nunes (1): > ui/sdl2: remove workaround forcing x11 > > Marc-André

[PATCH 2/2] ui/gtk-egl: fix scaling for cursor position in scanout mode

2023-03-20 Thread Erico Nunes
ackend. Use the surface dimensions which are already updated accordingly. Signed-off-by: Erico Nunes --- ui/gtk-egl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index e84431790c..a4422be837 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -88,8

[PATCH 1/2] ui/gtk: use widget size for cursor motion event

2023-03-20 Thread Erico Nunes
elements like a menu bar at the top of the window. This leads to a wrong position calculation by a few pixels. Fix it by using the size of the widget, which already returns the size of the actual space to render the framebuffer. Signed-off-by: Erico Nunes --- ui/gtk.c | 8 +++- 1 file changed, 3

[PATCH] ui/sdl2: remove workaround forcing x11

2023-03-01 Thread Erico Nunes
long time (e.g. in Fedora, first available 8 years ago), and is now considered stable and becoming the default for new SDL2 releases. Instead of requiring the x11 backend to exist by default, let new qemu releases run with the default chosen by the installed SDL2 version. Signed-off-by: Erico Nunes

[PATCH] tests/acceptance/virtio-gpu.py: update fedora URL

2023-02-27 Thread Erico Nunes
The URL listed previously is no longer valid and that caused the test to skip. Signed-off-by: Erico Nunes --- tests/avocado/virtio-gpu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/avocado/virtio-gpu.py b/tests/avocado/virtio-gpu.py index 2a249a3a2c

[PATCH] ui/gtk: fix passing y0_top parameter to scanout

2023-02-20 Thread Erico Nunes
The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however in the gtk ui both implementations dropped it when doing the next scanout_texture call. Fixes flipped linux console using vhost-user-gpu with the gtk ui display. Signed-off-by: Erico Nunes --- ui/gtk-egl.c | 2 +-