Hi,
since about half a year ago, we're getting user reports about guest
reboot issues with KVM/QEMU[0].
The most common scenario is a Windows Server VM (2012R2/2016/2019,
UEFI/OVMF and SeaBIOS) getting stuck during the screen with the Windows
logo and the spinning circles after a reboot was trigge
n question, so it is kept as is. And since
max_pdiscard is still <= SIZE_MAX, relying on max_pdiscard is still
fine.
Fixes: 0c8022876f ("block: use int64_t instead of int in driver discard
handlers")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Fabian Ebner
---
v2 -> v3:
* Kee
Am 12.05.22 um 18:05 schrieb Stefano Garzarella:
> On Thu, May 12, 2022 at 05:44:13PM +0200, Stefano Garzarella wrote:
>> On Thu, May 12, 2022 at 12:30:48PM +0200, Fabian Ebner wrote:
>>> On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is
>>
>> The
t64_t instead of int in driver discard
handlers")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Fabian Ebner
---
block/gluster.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index 398976bc66..f711bf0bd6 100644
--- a/block/gluster.c
Am 06.05.22 um 17:39 schrieb Eric Blake:
> On Thu, May 05, 2022 at 10:31:24AM +0200, Fabian Ebner wrote:
>> Previously, max_pdiscard would be zero in the following assertion:
>> qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion
>> `max_pdiscard >= bs->b
emu-sta...@nongnu.org
Signed-off-by: Fabian Ebner
---
block/gluster.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index 398976bc66..592e71b22a 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -891,7 +891,7
| 6 --
> hw/acpi/piix4.c | 11 ++-
> include/hw/acpi/pcihp.h | 2 --
> 4 files changed, 10 insertions(+), 13 deletions(-)
>
Fixes the issue for me, thanks!
Tested-by: Fabian Ebner
Am 25.02.22 um 12:34 schrieb Markus Armbruster:
> Fabian Ebner writes:
>
>> From: Stefan Reiter
>>
>> It is possible to specify more than one VNC server on the command line,
>> either with an explicit ID or the auto-generated ones à la "default",
>>
2 to 7.0
put 'keep' first in enum to ease use as a default]
Signed-off-by: Fabian Ebner
---
monitor/hmp-cmds.c | 29 +++--
monitor/qmp-cmds.c | 37 -
qapi/ui.json | 36 ++--
3 files
Original cover letter by Stefan R.:
Since the removal of the generic 'qmp_change' command, one can no
longer replace the 'default' VNC display listen address at runtime
(AFAIK). For our users who need to set up a secondary VNC access port,
this means configuring a second VNC display (in addition t
itted if the flag is not given.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Eric Blake
Signed-off-by: Stefan Reiter
[FE: fixed typo pointed out by Eric Blake
use s instead of V to indicate string parameter]
Signed-off-by: Fabian Ebner
---
v8 -> v9:
* Use s rather than V to ind
ands with protocol-discriminated unions.
Signed-off-by: Stefan Reiter
[FE: update "Since: " from 6.2 to 7.0
make @connected a common member of @SetPasswordOptions]
Signed-off-by: Fabian Ebner
---
v8 -> v9:
* Make @connected a common member of @SetPasswordOptions.
* Use s rath
Am 09.02.22 um 15:12 schrieb Markus Armbruster:
> Fabian Ebner writes:
8<
>> diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h
>> index 3da3f86c6a..a4cb307c8a 100644
>> --- a/monitor/monitor-internal.h
>> +++ b/monitor/monito
Am 09.02.22 um 15:07 schrieb Markus Armbruster:
> Fabian Ebner writes:
>
>> From: Stefan Reiter
>>
>> It is possible to specify more than one VNC server on the command line,
>> either with an explicit ID or the auto-generated ones à la "default",
>>
Am 11.02.22 um 17:42 schrieb Hanna Reitz:
> On 11.02.22 17:31, Eric Blake wrote:
>> On Thu, Feb 10, 2022 at 02:31:19PM +0100, Fabian Ebner wrote:
>>> Adds support for reading from stdin and writing to stdout (when raw
>>> format is used), as well as overriding the size
]
Signed-off-by: Fabian Ebner
---
docs/tools/qemu-img.rst | 6 +-
qemu-img-cmds.hx| 4 ++--
qemu-img.c | 23 ++-
3 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
index 43328fe108..9b022d93
add documenation]
Signed-off-by: Fabian Ebner
---
docs/tools/qemu-img.rst | 10 --
qemu-img-cmds.hx| 4 ++--
qemu-img.c | 24 +++-
3 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
ride the output file's size.
Signed-off-by: Wolfgang Bumiller
Signed-off-by: Thomas Lamprecht
[FE: add documentation
avoid error when osize is larger than input image's size
fail if both count and osize are specified
fail if skip is specified when reading from stdin]
Signed
Signed-off-by: Fabian Ebner
---
docs/tools/qemu-img.rst | 7 ---
qemu-img-cmds.hx| 4 ++--
qemu-img.c | 33 +++--
3 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
index
Derumier (1):
qemu-img: dd: add -n option (skip target volume creation)
Fabian Ebner (1):
qemu-img: dd: add -l option for loading a snapshot
Wolfgang Bumiller (2):
qemu-img: dd: add osize and read from/to stdin/stdout
qemu-img: dd: add isize parameter
docs/tools/qemu-img.rst | 28
the commands with protocol-discriminated unions.
Suggested-by: Markus Armbruster
Signed-off-by: Stefan Reiter
[FE: update "Since: " from 6.2 to 7.0
set {has_}connected for VNC in hmp_set_password]
Signed-off-by: Fabian Ebner
---
v7 -> v8:
* add missing # in the description for @
; first in enum to ease use as a default]
Signed-off-by: Fabian Ebner
---
v7 -> v8:
* drop if conditionals for DisplayProtocol enum, so compilation with
--disable-{spice,vnc} works
monitor/hmp-cmds.c | 29 +++--
monitor/qmp-cmds.c | 37 ---
itted if the flag is not given.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Eric Blake
Signed-off-by: Stefan Reiter
[FE: fixed typo pointed out by Eric Blake]
Signed-off-by: Fabian Ebner
---
monitor/hmp.c | 19 ++-
monitor/monitor-internal.h | 3 ++-
2 file
Original cover letter by Stefan R.:
Since the removal of the generic 'qmp_change' command, one can no
longer replace the 'default' VNC display listen address at runtime
(AFAIK). For our users who need to set up a secondary VNC access port,
this means configuring a second VNC display (in addition t
Am 02.02.22 um 15:21 schrieb Hanna Reitz:
> On 02.02.22 14:53, Eric Blake wrote:
>> On Wed, Feb 02, 2022 at 12:49:36PM +0100, Fabian Ebner wrote:
>>> Am 27.09.21 um 23:55 schrieb Eric Blake:
>>>> From: Vladimir Sementsov-Ogievskiy
>>>>
>>>>
Am 27.09.21 um 23:55 schrieb Eric Blake:
> From: Vladimir Sementsov-Ogievskiy
>
> OK, that's a big rewrite of the logic.
>
> Pre-patch we have an always running coroutine - connection_co. It does
> reply receiving and reconnecting. And it leads to a lot of difficult
> and unobvious code around d
Am 25.01.22 um 16:06 schrieb Daniel P. Berrangé:
> On Mon, Jan 24, 2022 at 02:50:39PM +0100, Markus Armbruster wrote:
>> Stefan Reiter writes:
>>
>>> Since the removal of the generic 'qmp_change' command, one can no longer
>>> replace
>>> the 'default' VNC display listen address at runtime (AFAIK
Am 28.10.21 um 21:37 schrieb Markus Armbruster:
Markus Armbruster writes:
8<
diff --git a/qapi/ui.json b/qapi/ui.json
index 5292617b44..39ca0b5ead 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -69,8 +69,10 @@
'base': { 'protocol': 'DisplayProtocol',
'password':
Am 21.10.21 um 12:01 schrieb Stefan Reiter:
'protocol' and 'connected' are better suited as enums than as strings,
make use of that. No functional change intended.
Suggested-by: Markus Armbruster
Reviewed-by: Markus Armbruster
Signed-off-by: Stefan Reiter
---
monitor/hmp-cmds.c | 29 +++
Am 28.10.21 um 21:37 schrieb Markus Armbruster:
Markus Armbruster writes:
Stefan Reiter writes:
Since the removal of the generic 'qmp_change' command, one can no longer replace
the 'default' VNC display listen address at runtime (AFAIK). For our users who
need to set up a secondary VNC acce
With the current wording, users might think that the -F option is not
required as long as the script is placed in the default path[0]. Be
clear that the option is always required.
[0]: https://forum.proxmox.com/threads/82680/post-437608
Signed-off-by: Fabian Ebner
---
I also tried to improve
Reviewed-by: Stefano Garzarella
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Focus on what's relevant for the patch itself in the commit
message.
* Add Stefan's comment.
* Add Stefano's R-b tag (I hope that's fine, since there was no
change
[b732000c8dd0] scsi_end_request at a4233a5c
#20 [b732000c8e08] scsi_io_completion at a423432c
#21 [b732000c8e58] scsi_finish_command at a422c527
#22 [b732000c8e88] scsi_softirq_done at a42341e4
Signed-off-by: Fabian Ebner
---
I'm new to
33 matches
Mail list logo
