Re: [Qemu-devel] Fix build break during configuration on musl-libc based system

2017-02-16 Thread Felix Janda
Defining _GNU_SOURCE causes musl to define everything including everything protected by _XOPEN_SOURCE. However it does not cause musl to define _XOPEN_SOURCE. On the other hand, the ncurses header specifically checks for _XOPEN_SOURCE or _XOPEN_SOURCE_EXTENDED. So it is not completely clear

Re: [Qemu-devel] [PATCH] linux-user: include for F_EXLCK and F_SHLCK

2016-10-01 Thread Felix Janda
Peter Maydell wrote: > On 30 September 2016 at 16:39, Felix Janda <felix.ja...@posteo.de> wrote: > > The F_EXLCK and F_SHLCK fcntl lock constants are obsolete synonyms for > > F_WRLCK and F_RDLCK. > > This seems unlikely, since on for instance Alpha F_EXLCK is > 1

Re: [Qemu-devel] [PATCH RFC] linux-user: peform __SIGRTMIN hack only when __SIGRTMIN is defined

2016-09-30 Thread Felix Janda
Peter Maydell wrote: > On 30 September 2016 at 16:41, Felix Janda <felix.ja...@posteo.de> wrote: > > This fixes a compilation error with the musl c library. > > --- > > I don't really understand the purpose of the hack, which was > > introduced in > > > &g

Re: [Qemu-devel] [PATCH] linux-user: include for F_EXLCK and F_SHLCK

2016-09-30 Thread Felix Janda
Peter Maydell wrote: > On 30 September 2016 at 16:39, Felix Janda <felix.ja...@posteo.de> wrote: > > The F_EXLCK and F_SHLCK fcntl lock constants are obsolete synonyms for > > F_WRLCK and F_RDLCK. > > This seems unlikely, since on for instance Alpha F_EXLCK is > 1

[Qemu-devel] [PATCH] linux-user: include instead of

2016-09-30 Thread Felix Janda
This removes the last usage of in the code base. Signed-off-by: Felix Janda <felix.ja...@posteo.de> --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3d1f694..4bfb671 100644 --- a/linux-user/sys

[Qemu-devel] [PATCH RFC] linux-user: peform __SIGRTMIN hack only when __SIGRTMIN is defined

2016-09-30 Thread Felix Janda
This fixes a compilation error with the musl c library. --- I don't really understand the purpose of the hack, which was introduced in http://git.qemu.org/?p=qemu.git;a=commit;h=624f7979058b84cbf81c76d45f302ce757b213ca but musl does not have a separate thread library (it is included in libc.so),

[Qemu-devel] [PATCH] linux-user: include for F_EXLCK and F_SHLCK

2016-09-30 Thread Felix Janda
The F_EXLCK and F_SHLCK fcntl lock constants are obsolete synonyms for F_WRLCK and F_RDLCK. Include to fix compilation with the musl c library, which does not expose these constants. Signed-off-by: Felix Janda <felix.ja...@posteo.de> --- linux-user/syscall.c | 1 + 1 file changed, 1 ins

[Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall

2016-09-30 Thread Felix Janda
integer type promotions. Since glibc-2.4 is now a decade old, we can remove this workaround. Signed-off-by: Felix Janda <felix.ja...@posteo.de> --- linux-user/mmap.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c

Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

2016-09-28 Thread Felix Janda
Peter Maydell wrote: > On 17 September 2016 at 18:20, Felix Janda <felix.ja...@posteo.de> wrote: > > Signed-off-by: Felix Janda <felix.ja...@posteo.de> > > --- > > linux-user/mmap.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > &g

Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

2016-09-22 Thread Felix Janda
Riku Voipio wrote: > Hi, > > On Sat, Sep 17, 2016 at 09:20:14PM -0400, Felix Janda wrote: > > Signed-off-by: Felix Janda <felix.ja...@posteo.de> > > Have you run the mremap tests of ltp with this on your host/guest > combo? I have just run the tests. My host

[Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

2016-09-17 Thread Felix Janda
Signed-off-by: Felix Janda <felix.ja...@posteo.de> --- linux-user/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index c4371d9..4882816 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -682,7 +682,7 @@ ab

Re: [Qemu-devel] linux-user: translate resource also for prlimit64

2014-12-11 Thread Felix Janda
ping (forgot to CC to maintainer before) http://patchwork.ozlabs.org/patch/417154/

[Qemu-devel] [PATCH] linux-user: translate resource also for prlimit64

2014-12-02 Thread Felix Janda
The resource argument is translated from host to target for [gs]etprlimit but not for prlimit64. Fix this. Signed-off-by: Felix Janda felix.ja...@posteo.de --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c