Re: [PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-15 Thread Gautam Dawar
On 3/3/23 20:28, Eugenio Perez Martin wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Mar 3, 2023 at 12:58 PM Gautam Dawar wrote: Guest announce capability is emulated by qemu

[PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-03 Thread Gautam Dawar
so send the correct status value to the virtio-net driver. Signed-off-by: Gautam Dawar --- hw/net/virtio-net.c| 9 +++-- include/hw/virtio/virtio-net.h | 3 ++- net/vhost-vdpa.c | 3 +-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c b

Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration

2023-02-10 Thread Gautam Dawar
Hi Eugenio, I've tested this patch series on Xilinx/AMD SN1022 device without control vq and VM Live Migration between two hosts worked fine. Tested-by: Gautam Dawar Here is some minor feedback: Pls fix the typo (Dynamycally -> Dynamically) in the Subject. On 2/8/23 15:12, Eugenio Pé

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-01-27 Thread Gautam Dawar
irtio_clear_feature(, VIRTIO_NET_F_GUEST_ANNOUNCE); +} + return features; } -- Why stay in college? Why go to night school? Reviewed-by: Gautam Dawar Tested-by: Gautam Dawar

RE: About restoring the state in vhost-vdpa device

2022-05-13 Thread Gautam Dawar
-Original Message- From: Parav Pandit Sent: Friday, May 13, 2022 8:39 PM To: Eugenio Perez Martin ; virtualization ; qemu-level ; Jason Wang ; Cindy Lu ; Gautam Dawar ; virtio-network...@redhat.com; Eli Cohen ; Laurent Vivier ; Stefano Garzarella Subject: RE: About restoring

RE: [PATCH 1/2] linux headers: update against Linux 5.17-rc4

2022-02-17 Thread Gautam Dawar
-Original Message- From: Jason Wang Sent: Thursday, February 17, 2022 12:47 PM To: Gautam Dawar Cc: mst ; qemu-devel ; eperezma ; Martin Petrus Hubertus Habets ; Harpreet Singh Anand ; Gautam Dawar ; Tanuj Murlidhar Kamde ; Pablo Cascon Subject: Re: [PATCH 1/2] linux headers: update

RE: [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices

2022-02-17 Thread Gautam Dawar
-Original Message- From: Jason Wang Sent: Thursday, February 17, 2022 12:46 PM To: Gautam Dawar Cc: mst ; qemu-devel ; eperezma ; Martin Petrus Hubertus Habets ; Harpreet Singh Anand ; Gautam Dawar ; Tanuj Murlidhar Kamde ; Pablo Cascon Subject: Re: [PATCH 2/2] Allow

[PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices

2022-02-15 Thread Gautam Dawar
backend doesn't involve any userspace virtqueue operations. Signed-off-by: Gautam Dawar --- hw/net/virtio-net.c | 10 ++ net/vhost-vdpa.c| 1 + 2 files changed, 11 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index cf8ab0f8af..a1089d06f6 100644 --- a/hw/net

[PATCH 1/2] linux headers: update against Linux 5.17-rc4

2022-02-15 Thread Gautam Dawar
This update is done to bring in the definition of VIRTIO_F_IN_ORDER from Linux kernel's include/uapi/linux/virtio_config.h. A patch was recently published to add VIRTIO_F_IN_ORDER's definition in the Linux kernel on top of version 5.17-rc4 Signed-off-by: Gautam Dawar --- include/standard

[PATCH 0/2] Allow VIRTIO_F_IN_ORDER negotiation with vhost-vdpa

2022-02-15 Thread Gautam Dawar
-linux-headers.sh. Next, it adds VIRTIO_F_IN_ORDER to host_features in case the underlying vdpa device exposes this feature bit in device featues there by making it available for negotiation with the virtio_net driver. Gautam Dawar (2): linux headers: update against Linux 5.17-rc4 Allow

RE: [RFC PATCH] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices

2022-02-07 Thread Gautam Dawar
Hi Jason, Thanks for your feedback. Pls see my comments inline. Regards, Gautam -Original Message- From: Jason Wang Sent: Monday, February 7, 2022 8:53 AM To: Gautam Dawar Cc: mst ; qemu-devel ; eperezma ; Gautam Dawar ; Martin Petrus Hubertus Habets ; Harpreet Singh Anand ; Tanuj

RE: [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features()

2021-06-05 Thread Gautam Dawar
No user for this helper, let's remove it. [GD>>] These patches seem unrelated to me. Do you think they should be part of one patch series? Signed-off-by: Jason Wang --- include/net/vhost-vdpa.h | 1 - net/vhost-vdpa.c | 9 - 2 files changed, 10 deletions(-) diff --git

RE: [PATCH 1/2] vhost-vdpa: don't initialize backend_features

2021-06-04 Thread Gautam Dawar
Hi Jason, -Original Message- From: Jason Wang Sent: Wednesday, June 2, 2021 2:18 PM To: Gautam Dawar ; m...@redhat.com; qemu-devel@nongnu.org Cc: l...@redhat.com; qemu-sta...@nongnu.org Subject: Re: [PATCH 1/2] vhost-vdpa: don't initialize backend_features Hi Gautam: 在 2021/6/2 下午3:38

RE: [PATCH 1/2] vhost-vdpa: don't initialize backend_features

2021-06-02 Thread Gautam Dawar
Hi Jason, Pls see my comments inline marked by GD>> Regards, Gautam -Original Message- From: Jason Wang Sent: Wednesday, June 2, 2021 9:01 AM To: m...@redhat.com; qemu-devel@nongnu.org Cc: Gautam Dawar ; l...@redhat.com; Jason Wang ; qemu-sta...@nongnu.org Subject: [PATCH 1/2]

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-18 Thread Gautam Dawar
Thanks Thomas Huth. I couldn't find an option to assign the issue on gitlab to anyone. Can you please help with that? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1924603 Title: Incorrect

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-13 Thread Gautam Dawar
https://qemu-devel.nongnu.narkive.com/jUimpLt0/patch-vhost-net-initialize-acked-features-to-a-safe-value-during-ack This review of a patch that introduced "acked_features = backend_features" behaviour suggests that acked_features should be 0 by default, but it ended up pushing it as it is now

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-04-15 Thread Gautam Dawar
QEMU version: 5.1.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1924603 Title: Incorrect feature negotiation for vhost-vdpa netdevice Status in QEMU: New Bug description: QEMU cmdline:

[Bug 1924603] [NEW] Incorrect feature negotiation for vhost-vdpa netdevice

2021-04-15 Thread Gautam Dawar
Public bug reported: QEMU cmdline: = ./x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -m 2G -hda /gautam/centos75_1.qcow2 -name gautam,process=gautam -enable-kvm -netdev vhost-vdpa,id=mynet0,vhostdev=/dev/vhost-vdpa-0 -device