Re: [Qemu-devel] [PATCH 0/3] memory: some little optimzation

2016-05-09 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Subject: Re: [PATCH 0/3] memory: some little optimzation > > > > On 20/04/2016 05:34, Gonglei wrote: > > Please see the details in each patch. > > > > Gonglei (3): > > memory: drop find_ram_block() > > exec: adjuest rcu_read_lock requiemen

Re: [Qemu-devel] [PATCH 3/3] memory: pass RAMBlock as a agrument

2016-04-29 Thread Gonglei (Arei)
> From: Fam Zheng [mailto:f...@redhat.com] > Sent: Friday, April 29, 2016 4:07 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangpeng (Peter) > Subject: Re: [PATCH 3/3] memory: pass RAMBlock as a agrument > > On Wed, 04/20 11:34, Gonglei wrote: &g

Re: [Qemu-devel] [PATCH 2/3] exec: adjuest rcu_read_lock requiement

2016-04-29 Thread Gonglei (Arei)
> From: Fam Zheng [mailto:f...@redhat.com] > Sent: Friday, April 29, 2016 3:57 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangpeng (Peter) > Subject: Re: [PATCH 2/3] exec: adjuest rcu_read_lock requiement > > In the subject line, s/adjuest/adj

Re: [Qemu-devel] [PATCH 1/3] memory: drop find_ram_block()

2016-04-29 Thread Gonglei (Arei)
Hi, > > > > @@ -1447,8 +1432,9 @@ void qemu_ram_set_idstr(ram_addr_t addr, const > char *name, DeviceState *dev) > > } > > pstrcat(new_block->idstr, sizeof(new_block->idstr), name); > > > > -QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { > > -if (block != new_block && !st

Re: [Qemu-devel] [RFC v3] virtio-crypto specification

2016-04-21 Thread Gonglei (Arei)
Hi Stefan, > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, April 21, 2016 11:24 PM > Subject: Re: [RFC v3] virtio-crypto specification > > On Tue, Apr 19, 2016 at 08:37:13AM +, Gonglei (Arei) wrote: > > 1.6.1.1 Driver Requirements: Session operatio

Re: [Qemu-devel] [RFC v3] virtio-crypto specification

2016-04-19 Thread Gonglei (Arei)
Hi Michael, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [RFC v3] virtio-crypto specification > > On Tue, Apr 19, 2016 at 08:37:13AM +0000, Gonglei (Arei) wrote: > > Hi all, > > > > This is the specification (version 3) about a new virtio crypt

[Qemu-devel] [RFC v3] virtio-crypto specification

2016-04-19 Thread Gonglei (Arei)
Hi all, This is the specification (version 3) about a new virtio crypto device. Changes from v2: - Reserve virtio device ID 20 for crypto device. [Cornelia] - Drop all feature bits, those capabilities are offered by the device all the time. [Stefan & Cornelia] - Add a new section 1.4.2 for

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Gonglei (Arei)
> > > Hi, > > > > > > > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > > > > > 1 Crypto Device > > > > > > > > The virtio crypto device is a virtual crypto device (ie. > > > > > > > > hardware > crypto > > > > > > > accelerator card). The encryption an

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Gonglei (Arei)
> > > Hi, > > > > > > > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > > > > > 1 Crypto Device > > > > > > > > The virtio crypto device is a virtual crypto device (ie. > > > > > > > > hardware > crypto > > > > > > > accelerator card). The encryption an

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Gonglei (Arei)
Hi, > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > 1 Crypto Device > > > > > > The virtio crypto device is a virtual crypto device (ie. hardware > > > > > > crypto > > > > > accelerator card). The encryption and decryption requests of are > > > > > pla

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-13 Thread Gonglei (Arei)
Hi, > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Thursday, April 14, 2016 12:30 AM > To: Gonglei (Arei) > Subject: Re: [RFC v2] virtio-crypto specification > > On Tue, 12 Apr 2016 09:03:33 +0000 > "Gonglei (Arei)" wrote: > > >

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-12 Thread Gonglei (Arei)
Hi Cornelia, Thank you so much for your review :) > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Tuesday, April 12, 2016 4:00 PM > Subject: Re: [RFC v2] virtio-crypto specification > > On Tue, 5 Apr 2016 09:14:09 +0000 > "

Re: [Qemu-devel] [virtio-dev] [RFC v2] virtio-crypto specification

2016-04-11 Thread Gonglei (Arei)
irtio-dev] [RFC v2] virtio-crypto specification > > On Tue, Apr 05, 2016 at 09:14:09AM +, Gonglei (Arei) wrote: > > Virtio-crypto device Spec > > > > 1 Crypto Device > > The virtio crypto device is a virtual crypto device (ie. hardware crypto >

Re: [Qemu-devel] [PATCH 0/6] fix some coverity complains

2016-04-05 Thread Gonglei (Arei)
Hi Paolo, Would you pls pick patch 1,3,4,5 to qemu-2.6 ? It seems the trivial-branch maintainer didn't notice them. :( Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, March 03, 2016 5:44 PM > To: qemu-devel@nongnu.org > Cc: pbonz

[Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-05 Thread Gonglei (Arei)
Dear all, I'm so sorry for the late version 2 and appreciate the good comments came from Cornelia and Michael. Changes from v1: - Drop the feature bit definaion for each algorithm, and using config space instead [Cornelia] - Add multiqueue support and add corresponding feature bit - Update

Re: [Qemu-devel] [PATCH 2/6] sheepdog: fix possible resouce leak and out-of-bounds access

2016-03-03 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, March 03, 2016 8:12 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org > Subject: Re: [PATCH 2/6] sheepdog: fix possible resou

Re: [Qemu-devel] [PATCH 6/6] smbus: fix memory leak

2016-03-03 Thread Gonglei (Arei)
> Subject: Re: [PATCH 6/6] smbus: fix memory leak > > > > On 03/03/2016 10:43, Gonglei wrote: > > Signed-off-by: Gonglei > > --- > > hw/i2c/smbus_eeprom.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c > > index 5b7bd89..83c6b27 1

Re: [Qemu-devel] [PATCH 2/6] sheepdog: fix possible resouce leak and out-of-bounds access

2016-03-03 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, March 03, 2016 7:18 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org > Subject: Re: [PATCH 2/6] sheepdog: fix possible resou

Re: [Qemu-devel] [PATCH v2 3/7] memory: Implement memory_region_get_ram_addr with mr->ram_block

2016-02-29 Thread Gonglei (Arei)
> Subject: [PATCH v2 3/7] memory: Implement memory_region_get_ram_addr > with mr->ram_block > > Signed-off-by: Fam Zheng > --- > include/exec/memory.h | 8 +--- > memory.c | 5 + > 2 files changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: Gonglei > diff --git a/in

Re: [Qemu-devel] [PATCH 5/6] exec: Pass RAMBlock pointer to qemu_ram_free

2016-02-29 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH 5/6] exec: Pass RAMBlock pointer to > qemu_ram_free > > The only caller now knows exactly which RAMBlock to free, so it's not > necessary to do the lookup. > > Signed-off-by: Fam Zheng > --- > exec.c | 21 +++-- > include/exec/ram

Re: [Qemu-devel] [PATCH 4/6] memory: Drop MemoryRegion.ram_addr

2016-02-29 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH 4/6] memory: Drop MemoryRegion.ram_addr > > All references to mr->ram_addr are replaced by > memory_region_get_ram_addr(mr) (except for a few assertions that are > replaced with mr->ram_block). > > Signed-off-by: Fam Zheng > --- > cputlb.c | 4 +-- >

Re: [Qemu-devel] [PATCH 3/6] memory: Implement memory_region_get_ram_addr with mr->ram_block

2016-02-29 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH 3/6] memory: Implement > memory_region_get_ram_addr with mr->ram_block > > Signed-off-by: Fam Zheng > --- > include/exec/memory.h | 8 +--- > memory.c | 5 + > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/include/exec/mem

Re: [Qemu-devel] [PATCH 2/6] memory: Move assignment to ram_block to memory_region_init_*

2016-02-29 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH 2/6] memory: Move assignment to ram_block to > memory_region_init_* > > We don't force "const" qualifiers with pointers in QEMU, but it's still > good to keep a clean function interface. Assigning to mr->ram_block is > in this sense ugly - one initializer mutating i

Re: [Qemu-devel] [PATCH 1/6] exec: Return RAMBlock pointer from allocating functions

2016-02-29 Thread Gonglei (Arei)
> > Subject: [Qemu-devel] [PATCH 1/6] exec: Return RAMBlock pointer from > allocating functions > > Previously we return RAMBlock.offset; now return the pointer to the > whole structure. > > ram_block_add returns void now, error is completely passed with errp. > > Signed-off-by: Fam Zheng > ---

Re: [Qemu-devel] [PULL 00/19] Misc changes for 2016-02-24

2016-02-25 Thread Gonglei (Arei)
Hi, > > Subject: Re: [Qemu-devel] [PULL 00/19] Misc changes for 2016-02-24 > > On 24 February 2016 at 13:27, Paolo Bonzini wrote: > > The following changes since commit > dd5e38b19d7cb07d317e1285941d8245c01da540: > > > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-201

Re: [Qemu-devel] [PATCH v3] usb: add pid check at the first of uhci_handle_td()

2016-02-22 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, February 22, 2016 4:55 PM > > Hi, > > > [Also fixed BZ 1070027] > > Which bugzilla instance is this? > https://bugzilla.redhat.com/show_bug.cgi?id=1070027 > Better cut+paste the full bug URL into

Re: [Qemu-devel] [PATCH 1/3] exec: store RAMBlock pointer into memory region

2016-02-21 Thread Gonglei (Arei)
Hi Fam, > From: Fam Zheng [mailto:f...@redhat.com] > Sent: Monday, February 22, 2016 10:46 AM > > On Sat, 02/20 10:35, Gonglei wrote: > > Each RAM memory region has a unique corresponding RAMBlock. > > In the current realization, the memory region only stored > > the ram_addr which means the offs

Re: [Qemu-devel] [PATCH 0/3] memory: an optimization

2016-02-20 Thread Gonglei (Arei)
Hi Paolo, > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Saturday, February 20, 2016 5:48 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangpeng (Peter) > Subject: Re: [PATCH 0/3] me

Re: [Qemu-devel] [PATCH v2] usb: drop active assert when pid is invalid

2016-02-16 Thread Gonglei (Arei)
> > Hi, > > > diff --git a/hw/usb/core.c b/hw/usb/core.c > > index bea5e1e..6fbcf00 100644 > > --- a/hw/usb/core.c > > +++ b/hw/usb/core.c > > @@ -716,7 +716,6 @@ struct USBEndpoint *usb_ep_get(USBDevice *dev, > int pid, int ep) > > if (ep == 0) { > > return &dev->ep_ctl; > >

Re: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches

2016-02-04 Thread Gonglei (Arei)
Dear Paolo, > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, February 04, 2016 6:19 PM > > On 03/02/2016 13:08, Gonglei (Arei) wrote: > > 22.56% qemu-kvm [.] address_space_translate > > 13.29% qemu-kvm [.] qem

Re: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor

2016-02-04 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, February 04, 2016 6:18 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: cornelia.h...@de.ibm.com; m...@redhat.com > Subject: Re: [PATCH 07/10] virtio: com

Re: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor

2016-02-03 Thread Gonglei (Arei)
Hi Paolo, > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > > On 03/02/2016 13:34, Gonglei (Arei) wrote: > > Hi, > > > >> Subject: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a > >> descriptor > >&g

Re: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches

2016-02-03 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Paolo Bonzini > Sent: Sunday, January 31, 2016 6:29 PM > To: qemu-devel@nongnu.org > Cc: cornelia.h...@de.ibm.com; m...@redhat.

Re: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor

2016-02-03 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor > > Compared to vring, virtio has a performance penalty of 10%. Fix it > by combining all the reads for a descriptor in a single address_space_read > call. This also simplifies the code nicely. > > Reviewed-by:

Re: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches

2016-02-03 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches > > This includes two optimization of virtio: > > - "slimming down" VirtQueueElements by not including room for > 1024 buffers. This makes malloc much faster. > > - optimizations to limit the number of address_sp

Re: [Qemu-devel] [PATCH] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-01-26 Thread Gonglei (Arei)
> > Subject: [PATCH] nvme: generate OpenFirmware device path in the "bootorder" > fw_cfg file > > Background on QEMU boot indices > --- > > Normally, the "bootindex" property is configured for bootable devices > with: > > DEVICE_instance_init() > device_add_boot

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-22 Thread Gonglei (Arei)
> -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Tuesday, December 22, 2015 11:51 PM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org; Radim Krcmar >

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-21 Thread Gonglei (Arei)
> -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Tuesday, December 22, 2015 2:47 AM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org; Radim Krcmar >

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-21 Thread Gonglei (Arei)
Dear Kevin, > -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Sunday, December 20, 2015 10:33 PM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org; Rad

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-20 Thread Gonglei (Arei)
> -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Saturday, December 19, 2015 11:12 PM > On Sat, Dec 19, 2015 at 12:03:15PM +0000, Gonglei (Arei) wrote: > > Maybe the root cause is not NMI but INTR, so yield() can open hardware &g

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-19 Thread Gonglei (Arei)
Hi Kevin, > -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > On Fri, Dec 18, 2015 at 03:04:58AM +0000, Gonglei (Arei) wrote: > > Hi Kevin & Paolo, > > > > Luckily, I reproduced this problem last night. And I go

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-18 Thread Gonglei (Arei)
> > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Saturday, December 19, 2015 7:13 AM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org > Subject: Re: [Qemu-devel] [PATCH] Se

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-18 Thread Gonglei (Arei)
hand nmi inject, write rtc \n"); } void diff --git a/roms/seabios/src/stacks.c b/roms/seabios/src/stacks.c index 1dbdfe9..c1b5203 100644 --- a/roms/seabios/src/stacks.c +++ b/roms/seabios/src/stacks.c @@ -174,6 +174,7 @@ call16_smm(u32 eax, u32 edx, void *func) static void call32_sloppy_p

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-17 Thread Gonglei (Arei)
> > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Thursday, December 17, 2015 4:37 PM > > > On 17/12/2015 08:17, Gonglei (Arei) wrote: > >> On 16/12/2015 11:28, Gonglei (Arei) wrote: > >>> I'll move the

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-16 Thread Gonglei (Arei)
Hello Paolo, > > > On 16/12/2015 11:28, Gonglei (Arei) wrote: > > I'll move the global nmi_disabled into RTCState, then I have to add a global > RTCState > > Variable so that other C files can use the rtc_state->external_nmi_disabled. > > Hmm, I think it

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-16 Thread Gonglei (Arei)
> > On 15/12/2015 19:53, Radim Krcmar wrote: > > 2015-12-15 05:43-0500, Paolo Bonzini: > >>> Hi Paolo, > >>> > >>> /* for KVM_GET/SET_VCPU_EVENTS */ > >>> struct kvm_vcpu_events { > >>> ... > >>> struct { > >>> __u8 injected; > >>> __u8 pending; > >>> __u8 masked; >

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-16 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Radim Krcmar [mailto:rkrc...@redhat.com] > Subject: Re: [PATCH] rtc: introduce nmi disable bit handler for cmos > > 2015-12-15 05:43-0500, Paolo Bonzini: > >> Hi Paolo, > >> > >> /* for KVM_GET/SET_VCPU_EVENTS */ > >> struct kvm_vcpu_events { > >> ... > >

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-15 Thread Gonglei (Arei)
. So, I think we don't need to add a new bit. Right? Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, December 15, 2015 8:58 AM > To: 'Paolo Bonzini'; qemu-devel@nongnu.org > Cc: r...@twiddle.net; ehabk...@redhat.com; ke...@ko

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Gonglei (Arei)
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, December 15, 2015 2:17 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; r...@twiddle.net; > ke...@koconnor.net; Huangpeng (Peter) > Subject: Re: [PATC

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, December 14, 2015 9:37 PM > On 14/12/2015 14:27, Gonglei (Arei) wrote: > > > >> > >> On 14/12/2015 13:49, Gonglei (Arei) wrote: > >>>>>>> This patch introduce nmi disa

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Gonglei (Arei)
> > On 14/12/2015 13:49, Gonglei (Arei) wrote: > >>> > > This patch introduce nmi disable bit handler to fix the problem > >>> > > and make the emulated CMOS like the real hardware. > >> > > >> > I think that this on

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Gonglei (Arei)
Hi Paolo, Thanks for your comments firstly. > Subject: Re: [PATCH] rtc: introduce nmi disable bit handler for cmos > > > > On 12/12/2015 14:15, Gonglei wrote: > > The Non-Maskable Interrupt (NMI) Enable bit is 0x80 bit of Port 0x70 > > (and its aliases). This bit must be 0b to enable the hardw

Re: [Qemu-devel] [PATCH] exec: Stop using memory after free

2015-12-02 Thread Gonglei (Arei)
> Subject: RE: [PATCH] exec: Stop using memory after free > > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > > > On 30/11/2015 23:11, Don Slutz wrote: > > > memory_region_unref(mr) can free memory. > > > > > > For example I got: > > > > > > Program received signal SIGSEGV, Segmentation fau

Re: [Qemu-devel] [PATCH] exec: Stop using memory after free

2015-12-01 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > On 30/11/2015 23:11, Don Slutz wrote: > > memory_region_unref(mr) can free memory. > > > > For example I got: > > > > Program received signal SIGSEGV, Segmentation fault. > > [Switching to Thread 0x7f43280d4700 (LWP 4462)] > > 0x7f43323283

Re: [Qemu-devel] [RFC v1] virtio-crypto specification

2015-11-24 Thread Gonglei (Arei)
ypto device definition. > Welcome to join us :) Regards, -Gonglei > Regards > Varun > > -Original Message- > From: qemu-devel-bounces+varun.sethi=freescale....@nongnu.org > [mailto:qemu-devel-bounces+varun.sethi=freescale@nongnu.org] On > Behalf Of Gonglei (Ar

Re: [Qemu-devel] [virtio-dev] [RFC v1] virtio-crypto specification

2015-11-23 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, November 23, 2015 11:14 PM > Subject: Re: [virtio-dev] [RFC v1] virtio-crypto specification > > On Fri, 20 Nov 2015 03:27:51 +0000 > "Gonglei (Arei)" wrote

Re: [Qemu-devel] [RFC v1] virtio-crypto specification

2015-11-20 Thread Gonglei (Arei)
? > Generally, I think this needs a bit more formal conformance statements. > Some examples below. > > On Fri, Nov 20, 2015 at 03:27:51AM +, Gonglei (Arei) wrote: > > Hi guys, > > > > After initial discussion at this year's KVM forum, I post the RFC

[Qemu-devel] [RFC v1] virtio-crypto specification

2015-11-19 Thread Gonglei (Arei)
Hi guys, After initial discussion at this year's KVM forum, I post the RFC version of virtio-crypto device specification now. If you have any comments, please let me know, thanks. Regards, -Gonglei 1 Crypto Device The virtio crypto device is a virtual crypto device (ie. hardware crypt

[Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed

2015-09-14 Thread Gonglei (Arei)
Hi, Recently, our test team found several Qemu crash problems with the next assertion messages: [2015-09-11 13:42:44] domain is rebooting qemu-kvm: /home/abuild/rpmbuild/BUILD/qemu-kvm-2.3.0/exec.c:1188: register_subpage: Assertion `existing->mr->subpage || existing->mr == &io_mem_unassigned'

[Qemu-devel] [RFC] Can we convert UTC time to local time in Qemu

2015-05-19 Thread Gonglei (Arei)
Hi, At present, Qemu use g_time_val_to_iso8601() to get the UTC added to error_report() (commit 5e2ac5191), TBH this way is very simply, we just need invoke standard glib functions to complete the job. But in the cloud computing and data center scenarios, there are many Other open source compo

[Qemu-devel] wrong size for virtio-scsi headers

2015-03-11 Thread Gonglei (Arei)
Hi, Today I start a vm failed, and get the following log: qemu-system-x86_64: wrong size for virtio-scsi headers 1) The Qemu command line: ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name suse -device virtio-scsi-pci,id=scsi0 -drive file=/home/suse11_sp3_32_2, \ if=none,id=drive-scsi0-0-0

[Qemu-devel] [Bug ?]Qemu segfault because of non-initial kvm_state variable

2015-03-03 Thread Gonglei (Arei)
Hi, I encountered a Qemu segfault problem in my environment. # ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive file=/home/win2008_ent_r2_64_01,\ if=none,id=drive-ide0-0-0 -device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -vnc :10 Segmentation fault Some

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.2.1, freeze on 2015-03-05

2015-02-24 Thread Gonglei (Arei)
> Subject: [Qemu-stable] Patch Round-up for stable 2.2.1, freeze on 2015-03-05 > > Hi everyone, > > The following new patches are queued for QEMU stable v2.2.1: > > https://github.com/mdroth/qemu/commits/stable-2.2-staging > > The release is planned for 2015-03-10: > > http://wiki.qemu.org

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.3, freeze on 2015-01-14

2015-01-26 Thread Gonglei (Arei)
> Subject: Re: [Qemu-stable] Patch Round-up for stable 2.1.3, freeze on > 2015-01-14 > > Quoting Paolo Bonzini (2015-01-13 14:40:07) > > On 13/01/2015 20:53, Michael Roth wrote: > > > 364c3e6, "vl.c: fix regression when reading machine type from config > > > file"? > > > > > > I've gone ahead and

[Qemu-devel] [RFC] Support to boot for vhost-scsi device?

2015-01-18 Thread Gonglei (Arei)
Hi, At present, vhost-scsi device do not boot in Qemu, but some clients/users have requirements for that in some scenarios. Of course if we want complete the aim we should make some changes both Qemu and kernel (vhost-scsi driver module, it need to add an IOCTL interface to get target_id/lun_id et

[Qemu-devel] [Question] about ipxe version update

2014-12-03 Thread Gonglei (Arei)
Hi, Recently, my colleagues encountered a confused issue about ipxe in qemu release version, both qemu-2.1 and qemu-2.2-rc4. Details: When vm configured a lot of network devices, ipxe install failed. The result as follow: Configuring (net0 00:e0:fc::00:fc:54)Error 0x04

Re: [Qemu-devel] [BUG] Redhat-6.4_64bit-guest kernel panic with cpu-passthrough and guest numa

2014-11-27 Thread Gonglei (Arei)
Cc'ing Paolo and BenoƮt. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, November 27, 2014 8:58 PM > To: qemu-devel@nongnu.org > Subject: [BUG] Redhat-6.4_64bit-guest kernel panic with cpu-passthrough and > guest numa > &

[Qemu-devel] [BUG] Redhat-6.4_64bit-guest kernel panic with cpu-passthrough and guest numa

2014-11-27 Thread Gonglei (Arei)
Hi, Running a redhat-6.4-64bit (kernel 2.6.32-358.el6.x86_64) or elder guest on qemu-2.1, with kvm enabled and -cpu host, non default cpu-topology and guest numa I'm seeing a reliable kernel panic from the guest shortly after boot. It is happening in find_busiest_group(). We also found it happ

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-10-07 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of > pcie devices > > On Fri, 2014-10-03 at 13:22 +0200, Knut Omang wrote: > > On Wed, 2014-10-01 at 17:08 +0300, Marcel Apfelbaum wrote: > > > On Wed, 2014-10-01 at 07:26 +0200, Knut Omang wrote: > > > > On Tue, 2014-09

Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [PATCH v2 12/12] virtio: add a wrapper for virtio-backend > initialization > > Il 30/09/2014 11:04, Cornelia Huck ha scritto: > >> > For better code sharing, add a wrapper help funciton > > typo: s/funciton/function/ > > > >> > for various virtio devices. > > s/for various virtio de

Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [PATCH v2 12/12] virtio: add a wrapper for virtio-backend > initialization > > Il 30/09/2014 11:04, Cornelia Huck ha scritto: > > On Tue, 30 Sep 2014 14:10:38 +0800 > > wrote: > > > >> From: Gonglei > >> > >> For better code sharing, add a wrapper help funciton > > > > typo: s/fun

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error > message > > Il 30/09/2014 10:12, Markus Armbruster ha scritto: > > error_report() is just fine here. qerror_report() is never necessary in > > HMP-only code. It makes a difference only in QMP context, and even > > there

Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [PATCH v2 00/12] virtio: fix virtio child recount in transports > > On Tue, 30 Sep 2014 14:10:26 +0800 > wrote: > > > From: Gonglei > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with strin

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-30 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v4] pci-hotplug-old: avoid losing error message > > Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto: > > we will lose the error message. Using error_report > > to report it. > > > > Cc: Markus Armbruster > > Signed-off-by: Gonglei > > Reviewed-by: Markus Armbru

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-30 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v3 0/3] add check for PCIe root ports and downstream > ports > > On Mon, Sep 01, 2014 at 09:29:16PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Root ports and downstream ports of switches are the hot > > pluggable ports in a PCI Express hierarchy. >

Re: [Qemu-devel] [PATCH v3 2/3] pcie: add check for ari capability of pcie devices

2014-09-29 Thread Gonglei (Arei)
> > > > In QEMU, ARI Forwarding is enabled defualt at emulation of PCIe > > ports. ARI Forwarding enable setting at firmware/OS Control handoff. > > If the bit is Set when a non-ARI Device is present, the non-ARI > > Device can respond to Configuration Space accesses under what it > > interprets as

Re: [Qemu-devel] [PATCH v3 6/7] qmp: print descriptions of object properties

2014-09-29 Thread Gonglei (Arei)
> > On 09/26/2014 11:14 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Add a new "description" field to DevicePropertyInfo. > > The descriptions can serve as documentation in the code, > > and they can be used to provide better help. For example: > > > > $./qemu-system-x86_64 -devic

Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct

2014-09-29 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v3 4/7] qom: add description field in ObjectProperty > struct > > Il 27/09/2014 07:13, arei.gong...@huawei.com ha scritto: > > +void object_property_set_description(Object *obj, const char *name, > > + const char *description, Error >

Re: [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-29 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v3 0/7] add description field in > ObjectProperty and PropertyInfo struct > > Hi, > > Am 27.09.2014 um 07:13 schrieb arei.gong...@huawei.com: > > Gonglei (7): > > qom: add error handler for object_property_print() > > qom: add error handler for object alias

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> > > > > > > > Hm... > > > > > > > > void virtio_instance_init_common(Object *proxydev, > > > > DeviceState *vdev, > > > > size_t vdevsize, > > > > const char *vdevname) > > > > { > > > > object_

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, September 29, 2014 8:32 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > Il 29/09/2014 12:53, Cornelia Huck ha scritto: > > void virtio_instance_init_common(Object *proxydev, > >

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, September 29, 2014 7:33 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > On Fri, 26 Sep 2014 16:45:38 +0800 > wrote: > > > Gonglei (9): > > virtio-net: use aliases instead of duplicat

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, September 29, 2014 6:53 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > On Sat, 27 Sep 2014 10:37:23 +0000 > "Gonglei (Arei)" wrote: > > > > &

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-29 Thread Gonglei (Arei)
Hi, Michael Would you give me some response? I have pinged this patch series the third time. :( Thanks a lot! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 01, 2014 9:29 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.co

Re: [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is not specified.

2014-09-29 Thread Gonglei (Arei)
> -Original Message- > From: Richard W.M. Jones [mailto:rjo...@redhat.com] > Sent: Monday, September 29, 2014 4:06 PM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei) > Subject: [PATCH v2] ssh: Don't crash if either host or path is not specified. > > $ ./qem

Re: [Qemu-devel] [PATCH] ssh: Don't crash if either host or path is not specified.

2014-09-29 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] ssh: Don't crash if either host or path is not > specified. > > $ ./qemu-img create -f qcow2 overlay \ > -b 'json: { "file.driver":"ssh", > "file.host":"localhost", > "file.host_key_check":"no" }' > qemu-img: qobject/qdict.c:193:

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-28 Thread Gonglei (Arei)
Hi, Michael Would you like to pick up this patch, which had been reviewed by Markus and Eric? Thanks. :) Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 18, 2014 9:06 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com;

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-27 Thread Gonglei (Arei)
> > > virtio-net: use aliases instead of duplicate qdev properties > > > virtio: fix virtio-net child refcount in transports > > > virtio/vhost scsi: use aliases instead of duplicate qdev properties > > > virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in > > > transports >

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-26 Thread Gonglei (Arei)
Hi, > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with string or pointer properties since we > > must be careful about leaking or double-freeing them. > > > > Use the QOM alias property to forward property

Re: [Qemu-devel] [PATCH 0/3] os-posix: improve the error message printing

2014-09-26 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Subject: Re: [PATCH 0/3] os-posix: improve the error message printing > > Il 26/09/2014 10:14, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > The patches mainly improve the error message printing. > > And adjust coding style of o

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-26 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 26, 2014 2:53 PM > To: Gonglei (Arei) > Cc: Jan Vesely; QEMU > Subject: Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > Hi, > > > > -stati

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > v2: rebase > > Signed-off-by: Jan Vesely > --- > hw/usb/dev-hid.c | 38 ++ > 1 file changed, 18 insertions(+), 20 deletions(-) > > diff --git a/hw/usb/dev-hid.c

Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert > fprintf/perror > to error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > util/oslib-posix.c | 8 > > util/oslib-win32.c | 2 +- > > 2 fi

Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > util/osdep.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --gi

Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror > to > error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > os-posix.c | 34 ++ > > os-win32.c | 3 ++-

Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

2014-09-24 Thread Gonglei (Arei)
Hi, > > > > Il 24/09/2014 02:42, Gonglei (Arei) ha scritto: > > > OK. > > > > > > This way I have to add a description string parametet to > > > object_property_add_alias function. Will do in the next version. :) > > > > No, just take it

Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

2014-09-24 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 24, 2014 2:54 PM > Subject: Re: [PATCH 5/7] qdev: set the object property's description to the > qdev > property's. > > Il 24/09/2014 02:42,

Re: [Qemu-devel] [PATCH 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-23 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 24, 2014 1:04 AM > Subject: Re: [PATCH 0/7] add description field in ObjectProperty and > PropertyInfo struct > > Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto: > > From: Gong

Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

2014-09-23 Thread Gonglei (Arei)
> Subject: Re: [PATCH 5/7] qdev: set the object property's description to the > qdev > property's. > > Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > When we call qdev_alias_all_properties() adding alias properties to > > the source object all qdev properties

Re: [Qemu-devel] [PATCH 4/7] qom: add description field in ObjectProperty struct

2014-09-23 Thread Gonglei (Arei)
> Subject: [PATCH 4/7] qom: add description field in ObjectProperty struct > > From: Gonglei > > The descriptions can serve as documentation in the code, > and they can be used to provide better help. > > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Cc: Markus Armbruster > Signed-off-by: Gon

<    1   2   3   4   5   6   7   8   9   10   >