Re: [PATCH 6.1.y] virtio_net: Do not send RSS key if it is not supported

On Wed, Apr 24, 2024 at 03:57:04AM -0700, Konstantin Ovsepian wrote: > From: Breno Leitao > > commit 059a49aa2e25c58f90b50151f109dd3c4cdb3a47 upstream > > There is a bug when setting the RSS options in virtio_net that can break > the whole machine, getting the kernel into an infinite loop. > >

Re: [PATCH 6.6.y] virtio_net: Do not send RSS key if it is not supported

On Mon, Apr 22, 2024 at 08:18:03AM -0700, Vlad Poenaru wrote: > From: Breno Leitao > > commit 059a49aa2e25c58f90b50151f109dd3c4cdb3a47 upstream. > Now queued up, thanks. greg k-h

Re: [PATCH v3] kset: fix memory leak when kset_register() returns error

On Tue, Oct 25, 2022 at 03:15:49PM +0800, Yang Yingliang wrote: > Inject fault while loading module, kset_register() may fail. > If it fails, the kset.kobj.name allocated by kobject_set_name() > which must be called before a call to kset_register() may be > leaked, since refcount of kobj was set in

Re: [PATCH v2] kset: fix memory leak when kset_register() returns error

On Mon, Oct 24, 2022 at 10:39:44PM +0800, Yang Yingliang wrote: > > On 2022/10/24 21:52, Greg KH wrote: > > On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote: > > > Inject fault while loading module, kset_register() may fail. > > > If it fails, the name

Re: [PATCH v2] kset: fix memory leak when kset_register() returns error

On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote: > Inject fault while loading module, kset_register() may fail. > If it fails, the name allocated by kobject_set_name() which > is called before kset_register() is leaked, because refcount > of kobject is hold in kset_init(). > > As a

Re: [PATCH 00/11] fix memory leak while kset_register() fails

On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:37, Greg KH wrote: > > On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > > The previous discussion link: >

Re: [PATCH 00/11] fix memory leak while kset_register() fails

On Fri, Oct 21, 2022 at 03:55:18AM -0400, Luben Tuikov wrote: > On 2022-10-21 01:37, Greg KH wrote: > > On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > >> On 2022-10-20 22:20, Yang Yingliang wrote: > >>> The previous discus

Re: [PATCH 01/11] kset: fix documentation for kset_register()

On Fri, Oct 21, 2022 at 04:05:18PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:34, Luben Tuikov wrote: > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > kset_register() is currently used in some places without calling > > > kset_put() in error path, because the callers think it should be

Re: [PATCH 00/11] fix memory leak while kset_register() fails

On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > On 2022-10-20 22:20, Yang Yingliang wrote: > > The previous discussion link: > > https://lore.kernel.org/lkml/0db486eb-6927-927e-3629-958f8f211...@huawei.com/T/ > > The very first discussion on this was here: > > https://www.spinics.

Re: propagating vmgenid outward and upward

On Tue, Mar 01, 2022 at 07:24:11PM +0100, Jason A. Donenfeld wrote: > Hi Greg, > > On Tue, Mar 1, 2022 at 7:01 PM Greg KH wrote: > > A notifier block like this makes sense, but why tie onto the PM_ stuff? > > This isn't power management issues, it's a system-wide c

Re: propagating vmgenid outward and upward

On Tue, Mar 01, 2022 at 04:42:47PM +0100, Jason A. Donenfeld wrote: > The easy way, and the way that I think I prefer, would be to just have a > sync notifier_block for this, just like we have with > register_pm_notifier(). From my perspective, it'd be simplest to just > piggy back on the already e

Re: [PATCH v4] virt: vmgenid: introduce driver for reinitializing RNG on VM fork

On Fri, Feb 25, 2022 at 02:57:38PM +0100, Alexander Graf wrote: > > + > > + phys_addr = (obj->package.elements[0].integer.value << 0) | > > + (obj->package.elements[1].integer.value << 32); > > + state->next_id = devm_memremap(&device->dev, phys_addr, > > VMGENID_SIZE

Re: [PATCH v4] virt: vmgenid: introduce driver for reinitializing RNG on VM fork

On Fri, Feb 25, 2022 at 01:48:48PM +0100, Jason A. Donenfeld wrote: > VM Generation ID is a feature from Microsoft, described at > , and supported by > Hyper-V and QEMU. Its usage is described in Microsoft's RNG whitepaper, >

Re: [PATCH v4] virt: vmgenid: introduce driver for reinitializing RNG on VM fork

On Fri, Feb 25, 2022 at 01:48:48PM +0100, Jason A. Donenfeld wrote: > +static struct acpi_driver acpi_driver = { > + .name = "vmgenid", > + .ids = vmgenid_ids, > + .owner = THIS_MODULE, > + .ops = { > + .add = vmgenid_acpi_add, > + .notify = vmgenid_acpi_noti

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

On Tue, Mar 23, 2021 at 04:10:27PM +, Catangiu, Adrian Costin wrote: > Hi Greg, > > After your previous reply on this thread we started considering to provide > this interface and framework/functionality through a userspace service > instead of a kernel interface. > The latest iteration on t

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

On Tue, Mar 23, 2021 at 04:10:27PM +, Catangiu, Adrian Costin wrote: > Hi Greg, > > After your previous reply on this thread we started considering to provide > this interface and framework/functionality through a userspace service > instead of a kernel interface. > The latest iteration on t

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

On Mon, Mar 08, 2021 at 05:03:58PM +0100, Alexander Graf wrote: > > > On 08.03.21 15:36, Greg KH wrote: > > > > On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > > > +static struct miscdevice sysgenid_misc = { > > > + .minor

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

On Mon, Mar 08, 2021 at 05:03:58PM +0100, Alexander Graf wrote: > > > On 08.03.21 15:36, Greg KH wrote: > > > > On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > > > +static struct miscdevice sysgenid_misc = { > > > + .minor

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > +static struct miscdevice sysgenid_misc = { > + .minor = MISC_DYNAMIC_MINOR, > + .name = "sysgenid", > + .fops = &fops, > +}; Much cleaner, but: > +static int __init sysgenid_init(void) > +{ > + int ret; > + > +

Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver

On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote: > The driver also generates a `SYSGENID=%u` uevent containing the new > system generation counter/id value every time it changes. Unlike the > filesystem interface, the uevent has no synchronization guarantees > therefore it should no

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +static long sysgenid_ioctl(struct file *file, > +unsigned int cmd, unsigned > long arg) Very odd indentation style, checkpatch.pl didn't catch this?

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +EXPORT_SYMBOL(sysgenid_bump_generation); EXPORT_SYMBOL_GPL()? I have to ask...

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +config SYSGENID > + tristate "System Generation ID driver" > + default N "N" is always the default, no need to list it again :(

Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver

On Tue, Jan 12, 2021 at 02:15:59PM +0200, Adrian Catangiu wrote: > +``read()``: > + Read is meant to provide the *new* system generation counter when a > + generation change takes place. The read operation blocks until the > + associated counter is no longer up to date, at which point the new >

Re: [Qemu-devel] [PATCH v2] block: fix QEMU crash with scsi-hd and drive_del

On Thu, May 24, 2018 at 11:09:47AM +0200, Greg Kurz wrote: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) > bdrv_co_flush(blk->root->bs)

Re: [Qemu-devel] [PATCH] block: fix QEMU crash with scsi-hd and drive_del

On Wed, May 16, 2018 at 01:21:54PM +0200, Greg Kurz wrote: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) > bdrv_co_flush(blk->root->bs)

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,69 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include No license text at all? Come on, I already made on

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,261 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * publish

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

On Fri, Feb 24, 2017 at 11:00:32AM +0100, Paolo Bonzini wrote: > > > On 24/02/2017 10:59, Greg KH wrote: > > On Fri, Feb 24, 2017 at 05:35:17PM +0800, Herongguang (Stephen) wrote: > >> > >> > >> On 2017/2/24 10:23, Herongguang (Stephen) wrote: > >

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

On Fri, Feb 24, 2017 at 05:35:17PM +0800, Herongguang (Stephen) wrote: > > > On 2017/2/24 10:23, Herongguang (Stephen) wrote: > > > > > > On 2017/2/22 22:43, Paolo Bonzini wrote: > > > > > > > > > On 22/02/2017 14:31, Chris Friesen wrote: > > > > > > > > > > > > > > > > Can you reproduce it

Re: [Qemu-devel] [RFC PATCH] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

On Mon, Mar 07, 2016 at 06:55:43PM -0500, Gabriel Somlo wrote: > Allowing for the future possibility of implementing AML-based > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > acquire the global ACPI lock when accessing the device on behalf > of the guest-side sysfs driver, to preve

Re: [Qemu-devel] [PATCH v8 0/4] SysFS driver for QEMU fw_cfg device

On Wed, Feb 03, 2016 at 10:47:29PM +, Matt Fleming wrote: > On Thu, 28 Jan, at 09:23:10AM, Gabriel L. Somlo wrote: > > From: "Gabriel Somlo" > > > > Allow access to QEMU firmware blobs, passed into the guest VM via > > the fw_cfg device, through SysFS entries. Blob meta-data (e.g. name, > > s

Re: [Qemu-devel] [PATCH v8 2/4] kobject: export kset_find_obj() for module use

On Thu, Jan 28, 2016 at 09:23:12AM -0500, Gabriel L. Somlo wrote: > From: Gabriel Somlo > > Signed-off-by: Gabriel Somlo > --- > lib/kobject.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/kobject.c b/lib/kobject.c > index 7cbccd2..90d1be6 100644 > --- a/lib/kobject.c > +++ b/li

Re: [Qemu-devel] [PATCH 1/3] firmware: introduce sysfs driver for QEMU's fw_cfg device

On Mon, Aug 10, 2015 at 03:02:22PM -0400, Gabriel L. Somlo wrote: > Mainly, qemu's fw_cfg is a read-only "device", so one wouldn't ever > care to try writing anything to it. /sys/firmware/... feels like a fit > because fw_cfg contains binary blobs originally meant to be used by > the bios (it's how

Re: [Qemu-devel] [PATCH 2/3] kobject: export kset_find_obj() to be used from modules

On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: > On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: > > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: > > > From: "Gabriel Somlo" > > > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/3] kobject: export kset_find_obj() to be used from modules

On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: > From: "Gabriel Somlo" > > Signed-off-by: Gabriel Somlo > --- > lib/kobject.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/kobject.c b/lib/kobject.c > index 3e3a5c3..f9754a0 100644 > --- a/lib/kobject.c > +++ b/

Re: [Qemu-devel] [PATCH 3/3] firmware: fw_cfg: create directory hierarchy for fw_cfg file names

On Mon, Aug 10, 2015 at 12:31:20PM -0400, Gabriel L. Somlo wrote: > From: "Gabriel Somlo" > > Each fw_cfg entry of type "file" has an associated 56-char, > nul-terminated ASCII string which represents its name. While > the fw_cfg device doesn't itself impose any specific naming > convention, QEMU

Re: [Qemu-devel] [PATCH 1/3] firmware: introduce sysfs driver for QEMU's fw_cfg device

On Mon, Aug 10, 2015 at 12:31:18PM -0400, Gabriel L. Somlo wrote: > From: "Gabriel Somlo" > > Make fw_cfg entries of type "file" available via sysfs. Entries > are listed under /sys/firmware/fw_cfg/by_select, in folders named > after each entry's selector key. Filename, selector value, and > size

Re: [Qemu-devel] [PATCH 01/13] driver core: Add iommu_group tracking to struct device

On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote: > IOMMU groups allow IOMMU drivers to represent DMA visibility > and isolation of devices. Multiple devices may be grouped > together for the purposes of DMA. Placing a pointer on > struct device enable easy access for things like s

Re: [Qemu-devel] [PATCH 01/13] driver core: Add iommu_group tracking to struct device

On Fri, May 11, 2012 at 05:58:01PM -0600, Alex Williamson wrote: > On Fri, 2012-05-11 at 16:38 -0700, Greg KH wrote: > > On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote: > > > IOMMU groups allow IOMMU drivers to represent DMA visibility > > > and isol

Re: [Qemu-devel] [PATCH 02/13] iommu: IOMMU Groups

On Fri, May 11, 2012 at 04:55:41PM -0600, Alex Williamson wrote: > IOMMU device groups are currently a rather vague associative notion > with assembly required by the user or user level driver provider to > do anything useful. This patch intends to grow the IOMMU group concept > into something a b

[Qemu-devel] Re: [stable] [PATCH] tun: orphan an skb on tx

On Wed, Apr 21, 2010 at 02:35:57PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 13, 2010 at 05:59:44PM +0300, Michael S. Tsirkin wrote: > > The following situation was observed in the field: > > tap1 sends packets, tap2 does not consume them, as a result > > tap1 can not be closed. This happens b

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

On Wed, Nov 11, 2009 at 09:06:58AM +0800, Scott Tsai wrote: > On Wed, Nov 11, 2009 at 8:57 AM, Greg KH wrote: > > > > What code? ??Where is it at? > > http://patchwork.ozlabs.org/patch/38118/ > > This code emulates a Vernier Go!Temp device in qemu. > I wrote this t

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

On Wed, Nov 11, 2009 at 01:15:45AM +0100, Alexander Graf wrote: > > On 11.11.2009, at 01:09, Anthony Liguori wrote: > > > Scott Tsai wrote: > >> On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino >> > wrote: > >> > I'd certainly like to make this code useful for something other > than