Re: [PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

Hi Drew, On Tue, Sep 17, 2024 at 5:45 AM Andrew Jones wrote: > > On Mon, Sep 09, 2024 at 01:27:05PM GMT, Alistair Francis wrote: > > On Tue, Aug 6, 2024 at 7:05 AM Gregor Haas wrote: > > > > > > This patch series adds support for specifying OpenSBI domains on

[PATCH v5 0/2] Add support for generating OpenSBI domains in the device tree

e g_autofree for dynamically allocated variables - Added an "assign" flag to OpenSBIDomainState, which indicates whether to assign the domain's boot hart to it at domain parsing time. Gregor Haas (2): hw/riscv: Add support for generating OpenSBI domains in the device tree docs/

[PATCH v5 2/2] docs/system/riscv: Add documentation for command-line OpenSBI domains

Signed-off-by: Gregor Haas --- MAINTAINERS | 1 + docs/system/riscv/opensbi_domains.rst | 156 ++ docs/system/target-riscv.rst | 10 ++ 3 files changed, 167 insertions(+) create mode 100644 docs/system/riscv/opensbi_domains.rst diff

[PATCH v5 1/2] hw/riscv: Add support for generating OpenSBI domains in the device tree

gions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas Reviewed-by: Daniel Henrique Barboza --- MAINTAINERS | 7 + hw/riscv/Kconfig

[PATCH v5 2/2] docs/system/riscv: Add documentation for command-line OpenSBI domains

Signed-off-by: Gregor Haas --- MAINTAINERS | 1 + docs/system/riscv/opensbi_domains.rst | 156 ++ docs/system/target-riscv.rst | 10 ++ 3 files changed, 167 insertions(+) create mode 100644 docs/system/riscv/opensbi_domains.rst diff

[PATCH v5 2/2] Add documentation for command-line OpenSBI domains

Signed-off-by: Gregor Haas --- MAINTAINERS | 1 + docs/system/riscv/opensbi_domains.rst | 156 ++ docs/system/target-riscv.rst | 10 ++ 3 files changed, 167 insertions(+) create mode 100644 docs/system/riscv/opensbi_domains.rst diff

[PATCH v5 1/2] Add support for generating OpenSBI domains in the device tree

gions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas Reviewed-by: Daniel Henrique Barboza --- MAINTAINERS | 7 + hw/riscv/Kconfig

[PATCH v5 1/2] hw/riscv: Add support for generating OpenSBI domains in the device tree

gions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas Reviewed-by: Daniel Henrique Barboza --- MAINTAINERS | 7 + hw/riscv/Kconfig

[PATCH v5 0/2] Add support for generating OpenSBI domains in the device tree

e g_autofree for dynamically allocated variables - Added an "assign" flag to OpenSBIDomainState, which indicates whether to assign the domain's boot hart to it at domain parsing time. Gregor Haas (2): hw/riscv: Add support for generating OpenSBI domains in the device tree docs/

Re: [PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

Hi Alistair! On Sun, Sep 8, 2024 at 8:27 PM Alistair Francis wrote: > On Tue, Aug 6, 2024 at 7:05 AM Gregor Haas > wrote: > > > > This patch series adds support for specifying OpenSBI domains on the QEMU > > command line. A simple example of what this looks li

[PATCH v4 2/2] Add documentation for command-line OpenSBI domains

/MAINTAINERS index 3b9f5b7432..5eb65cc499 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -361,6 +361,7 @@ RISC-V OpenSBI domain support M: Gregor Haas L: qemu-ri...@nongnu.org S: Maintained +F: docs/system/riscv/opensbi_domains.rst F: hw/riscv/opensbi_domain.c F: include/hw/riscv/opensbi_domain.h

[PATCH v4 1/2] Add support for generating OpenSBI domains in the device tree

gions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas Reviewed-by: Daniel Henrique Barboza --- MAINTAINERS | 7 + hw/riscv/Kconfig

[PATCH v4 0/2] Add support for generating OpenSBI domains in the device tree

r to assign the domain's boot hart to it at domain parsing time. Gregor Haas (2): Add support for generating OpenSBI domains in the device tree Add documentation for command-line OpenSBI domains MAINTAINERS | 8 + docs/system/riscv/opensbi_domains.rst |

Re: [PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

rboza < dbarb...@ventanamicro.com> wrote: > > > On 8/5/24 6:04 PM, Gregor Haas wrote: > > This patch series adds support for specifying OpenSBI domains on the QEMU > > command line. A simple example of what this looks like is below, > including > > mapping t

[PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

vice if one does not yet exist. v2: - Addressed review comments from v1. Specifically, renamed domain.{c,h} -> opensbi_domain.{c,h} to increase clarity of what these files do. Also, more consistently use g_autofree for dynamically allocated variables - Added an "assign" flag to Open

[PATCH v3 1/1] Add support for generating OpenSBI domains in the device tree

gions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas --- MAINTAINERS | 7 + hw/riscv/Kconfig | 4 + hw/riscv/meson.

Re: [PATCH v2 1/1] Add support for generating OpenSBI domains in the device tree

y/007173.html >From da45d5b9538427d0f33f7d9a2c7470095ceef4ae Mon Sep 17 00:00:00 2001 From: Gregor Haas Date: Mon, 5 Aug 2024 12:59:51 -0700 Subject: [PATCH] Add default parameters to OpenSBI domain properties Signed-off-by: Gregor Haas --- hw/riscv/opensbi_domain.c | 145 -

[PATCH v2 1/1] Add support for generating OpenSBI domains in the device tree

iners, identifies all domains and memregions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas --- MAINTAINERS | 7 + hw/riscv/Kconfig

[PATCH v2 0/1] Add support for generating OpenSBI domains in the device tree

es whether to assign the domain's boot hart to it at domain parsing time. Gregor Haas (1): Add support for generating OpenSBI domains in the device tree MAINTAINERS | 7 + hw/riscv/Kconfig | 4 + hw/riscv/meson.build | 1 + hw/risc

Re: [PATCH] Add support for generating OpenSBI domains in the device tree

Hi Daniel, Oops! Sorry about the build failure - slightly embarrassing on my part! > +RISC-V OpenSBI domain support > > +M: Gregor Haas > > +L: qemu-ri...@nongnu.org > > +S: Maintained > > +F: hw/riscv/domain.c > > +F: include/hw/riscv/domain.h >

[PATCH] Add support for generating OpenSBI domains in the device tree

iners, identifies all domains and memregions, and parses them into the relevant device tree structures. [1] https://github.com/riscv-software-src/opensbi/blob/master/docs/domain_support.md Signed-off-by: Gregor Haas --- MAINTAINERS | 7 + hw/riscv/Kconfig | 4 + hw/

[PATCH v4] hw/core/loader: allow loading larger ROMs

using multiple calls to read() while also returning the loaded ROM size. Signed-off-by: Gregor Haas --- hw/core/loader.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 2f8105d7de..4a5714 100644 --- a

[PATCH v3] hw/core/loader: allow loading larger ROMs

multiple calls to read(). Also, the ROM size is now determined using the get_image_size() function rather than using manual lseek(). Signed-off-by: Gregor Haas --- hw/core/loader.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/hw/core/loader.c b/hw/core

[PATCH v2] hw/core/loader: allow loading larger ROMs

multiple calls to read(). Signed-off-by: Gregor Haas --- hw/core/loader.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 2f8105d7de..8216781a75 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -1115,14 +1115,13 @@ ssize_t

Re: [PATCH] hw/core/loader: allow loading larger ROMs

rom->name, strerror(errno)); > > > +goto err; > > > +} > > > +sz += rc; > > > +} while (sz != rom->datasize); > > I think we can use load_image_size() instead. > > > > > > > > > > *From:* Gregor

Re: [PATCH] hw/core/loader: allow loading larger ROMs

Hi Xingtao, > Can you reproduce this issue? Absolutely! I encountered this when trying to load an OpenSBI payload firmware using the bios option for the QEMU RISC-V virt board. These payload firmwares bundle the entire next boot stage, which in my case is a build of the Linux kernel (which is a st

[PATCH] hw/core/loader: allow loading larger ROMs

. Signed-off-by: Gregor Haas --- hw/core/loader.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 2f8105d7de..afa26dccb1 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -1075,7 +1075,7 @@ ssize_t rom_add_file