Re: [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0

2020-01-21 Thread Guoheyi
在 2020/1/22 13:39, Michael S. Tsirkin 写道: On Thu, Dec 19, 2019 at 02:47:58PM +0800, Heyi Guo wrote: The sub device "PR0" under PCI0 in ACPI/DSDT does not make any sense, so simply remote it. Signed-off-by: Heyi Guo So given this has no methods except _ADR, I think it's safe to remove: Acke

Re: [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0

2020-01-20 Thread Guoheyi
Hi Julia, Could you provide some comments or advice? Thanks, Heyi 在 2020/1/13 20:37, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:58 +0800 Heyi Guo wrote: The sub device "PR0" under PCI0 in ACPI/DSDT does not make any sense, so simply remote it. Could you make commit message more concrete

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Guoheyi
在 2020/1/16 20:24, Peter Maydell 写道: On Wed, 15 Jan 2020 at 10:55, Michael S. Tsirkin wrote: Here's a hopefully better patch. Peter does this address the issue? Signed-off-by: Michael S. Tsirkin diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index f1ac2d7e96.

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Guoheyi
在 2020/1/16 21:25, Igor Mammedov 写道: On Thu, 16 Jan 2020 19:56:19 +0800 Guoheyi wrote: 在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR

Re: [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0

2020-01-16 Thread Guoheyi
在 2020/1/13 20:37, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:58 +0800 Heyi Guo wrote: The sub device "PR0" under PCI0 in ACPI/DSDT does not make any sense, so simply remote it. Could you make commit message more concrete so it would say why it doesn't make any sense. The reason I'd like

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Guoheyi
在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does no

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-15 Thread Guoheyi
在 2020/1/15 14:30, Michael S. Tsirkin 写道: Problem is IASL disassembler still doesn't work on all hosts we want to support. And its output isn't really stable enough to act as a golden master. Until we have a better tool, I propose the contributor just follows all steps 1-6. The reason they ha

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Guoheyi
Hi Peter, Michael, Have we come to conclusion on how to submit patches for ARM ACPI tables? Some rough thoughts: is it possible to use the disassembled ASL file as the 'golden master' data? One problem I can imagine is that this may introduce dependency on the version of iASL tool. If so, how

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Guoheyi
在 2020/1/13 23:26, Andrew Jones 写道: On Mon, Jan 13, 2020 at 09:57:55PM +0800, Guoheyi wrote: 在 2020/1/13 20:08, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Guoheyi
在 2020/1/13 20:08, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does not make sense to have a _ADR object for devices which already have _HID and wil

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Guoheyi
Hi Michael, Any more comments? Or shall I refine the commit message? Thanks, Heyi 在 2020/1/6 10:10, Guoheyi 写道: 在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Guoheyi
在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does no

Re: [RFC v2 00/14] Add SDEI support for arm64

2019-12-23 Thread Guoheyi
Hi Peter, Really appreciate your comments. For other platforms/boards emulated in qemu, like omap, imx*, etc, are they just TCG platforms? Can we just enable security and EL3 emulation for these platforms instead of implementing copies of firmware interfaces in qemu? Also I think it is possib

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-11 Thread Guoheyi
在 2019/12/11 17:00, Andrew Jones 写道: On Wed, Dec 11, 2019 at 04:02:52PM +0800, Guoheyi wrote: 在 2019/12/6 23:22, Peter Maydell 写道: On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: v2: - move from RFC status to v1 - put kvm_arm_vm_state_change() in kvm.c to share among kvm32.c and

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-11 Thread Guoheyi
在 2019/12/6 23:22, Peter Maydell 写道: On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: v2: - move from RFC status to v1 - put kvm_arm_vm_state_change() in kvm.c to share among kvm32.c and kvm64.c - add r-b's from Richard This series is inspired by a series[1] posted by Bijan Mottahede

Re: [Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

2019-12-08 Thread Guoheyi
在 2019/12/6 21:50, Peter Maydell 写道: On Sat, 30 Nov 2019 at 03:47, Guoheyi wrote: Hi Peter, Igor, I couldn't find these 2 patches in the latest tree. Could you help to merge them? In future I recommend pinging unapplied patches with a shorter delay than nine months :-) Tha'

Re: [Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

2019-11-29 Thread Guoheyi
Hi Peter, Igor, I couldn't find these 2 patches in the latest tree. Could you help to merge them? Thanks, HG On 2019/3/13 0:09, Igor Mammedov wrote: On Sat, 9 Mar 2019 10:30:47 +0800 Heyi Guo wrote: After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have

[RFC] smbios: does it make sense to present some host smbios information to guest?

2019-11-28 Thread Guoheyi
Hi folks, Right now some smbios fields are hard coded (like CPU nominal frequency), and some can be opted in, but there is no feasible way to present real backend hardware information to the front. In some scenario, the users of virtual machines may not be happy to see an unknown CPU model an

Re: [RFC v2 00/14] Add SDEI support for arm64

2019-11-18 Thread Guoheyi
Thanks a lot. Please take your time. HG On 2019/11/18 21:35, Peter Maydell wrote: On Mon, 18 Nov 2019 at 06:55, Guoheyi wrote: Hi Peter, Could you spare some time to review the framework and provide comments and advice? This patchset is on my to-review list but there are also a lot of

Re: [RFC v2 00/14] Add SDEI support for arm64

2019-11-17 Thread Guoheyi
Hi Peter, Could you spare some time to review the framework and provide comments and advice? Thanks, HG On 2019/11/5 17:10, Heyi Guo wrote: SDEI is for ARM "Software Delegated Exception Interface". AS ARM64 doesn't have native non-maskable interrupt (NMI), we rely on higher privileged (lar

Re: [RFC v2 14/14] virt/acpi: add SDEI table if SDEI is enabled

2019-11-17 Thread Guoheyi
On 2019/11/12 22:52, Igor Mammedov wrote: On Tue, 5 Nov 2019 17:10:56 +0800 Heyi Guo wrote: Add SDEI table if SDEI is enabled, so that guest OS can get aware and utilize the interfaces. Signed-off-by: Heyi Guo Cc: Peter Maydell Cc: Dave Martin Cc: Marc Zyngier Cc: Mark Rutland Cc: Jam

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-07 Thread Guoheyi
On 2019/11/7 20:12, Cornelia Huck wrote: On Thu, 7 Nov 2019 19:57:22 +0800 Guoheyi wrote: On 2019/11/7 16:57, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 09:44:36AM +0800, Guoheyi wrote: On 2019/11/7 1:55, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-07 Thread Guoheyi
On 2019/11/7 16:57, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 09:44:36AM +0800, Guoheyi wrote: On 2019/11/7 1:55, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote: To keep backward compatibility, we add new KVM capability "KVM_CAP_FORWARD_HYPERCALL"

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-06 Thread Guoheyi
On 2019/11/7 1:55, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote: To keep backward compatibility, we add new KVM capability "KVM_CAP_FORWARD_HYPERCALL" to probe whether KVM supports forwarding hypercall to userspace. The capability should be enabled explicitly, for

Re: [RFC v2 02/14] standard-headers: import arm_sdei.h

2019-11-06 Thread Guoheyi
On 2019/11/7 1:52, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:44 +0800 Heyi Guo wrote: Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. This is to prepare for qemu SDEI emulation. Signed-off-by: Heyi Guo Cc: Peter Maydell Cc: Dave Martin Cc: Marc Zyngier

Re: [RFC v2 00/14] Add SDEI support for arm64

2019-11-05 Thread Guoheyi
On 2019/11/5 17:10, Heyi Guo wrote: SDEI is for ARM "Software Delegated Exception Interface". AS ARM64 doesn't have native non-maskable interrupt (NMI), we rely on higher privileged (larger exception level) software to change the execution flow of lower privileged (smaller exception level) sof

Re: Occasional VM soft lockup when a remote cdrom is attached

2019-10-13 Thread Guoheyi
Really appreciate your advice. Some comments below: On 2019/10/12 3:06, John Snow wrote: On 10/11/19 9:22 AM, Guoheyi wrote: Hi folks, We observed Linux on VM occasionally (at very low rate) got soft lockup when a remote cdrom is attached. The guest hangs up at below call trace: That&#

Occasional VM soft lockup when a remote cdrom is attached

2019-10-11 Thread Guoheyi
Hi folks, We observed Linux on VM occasionally (at very low rate) got soft lockup when a remote cdrom is attached. The guest hangs up at below call trace: [Tue Oct8 23:02:53 2019]ata_scsi_queuecmd+0xe0/0x2a0 [libata] [Tue Oct8 23:02:53 2019]scsi_dispatch_cmd+0xec/0x288 [Tue Oct8 23:02:53 201

Re: [RFC PATCH 12/12] virt/acpi: add SDEI table if SDEI is enabled

2019-10-10 Thread Guoheyi
Thanks for your comments. On 2019/10/10 17:15, Igor Mammedov wrote: On Tue, 24 Sep 2019 23:21:51 +0800 Heyi Guo wrote: Add SDEI table if SDEI is enabled, so that guest OS can get aware and utilize the interfaces. Signed-off-by: Heyi Guo Cc: Peter Maydell Cc: Dave Martin Cc: Marc Zyngier

Re: [RFC PATCH 00/12] Add SDEI support for arm64

2019-10-09 Thread Guoheyi
On 2019/9/30 21:15, Peter Maydell wrote: On Tue, 24 Sep 2019 at 16:23, Heyi Guo wrote: As promised, this is the first RFC patch set for arm64 SDEI support. Hi; for the benefit of possible reviewers who aren't familiar with every corner of the arm ecosystem, could you provide a summary of:

Re: [RFC PATCH 07/12] arm/sdei: override qemu_irq handler when binding interrupt

2019-10-09 Thread Guoheyi
Hi Peter, Thanks for your comments. I will explain SDEI in another mail and please provide your suggestions for such situation. Heyi On 2019/9/30 21:19, Peter Maydell wrote: On Tue, 24 Sep 2019 at 16:23, Heyi Guo wrote: Override qemu_irq handler to support trigger SDEI event transparently

Re: [RFC PATCH 01/12] linux-headers: import arm_sdei.h

2019-09-25 Thread Guoheyi
On 2019/9/24 23:39, Michael S. Tsirkin wrote: On Tue, Sep 24, 2019 at 11:21:40PM +0800, Heyi Guo wrote: Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.3 release. This is to prepare for qemu SDEI emulation. Signed-off-by: Heyi Guo Cc: Peter Maydell Cc: Dave Martin C

[Qemu-devel] hw/vfio/pci: duplicated invocation of vfio_msix_vector_release() in vfio_msix_disable()

2019-09-10 Thread Guoheyi
Hi folks, Recently we found there are 2 invocations of vfio_msix_vector_release() in vfio_msix_disable(). The 1st one is in msix_unset_vector_notifiers(), for we set device's msix_vector_release_notifier to vfio_msix_vector_release() in vfio_msix_enable(), while the 2nd is the explicit one in

Re: [Qemu-devel] [RFC] Add virtual SDEI support in qemu

2019-07-18 Thread Guoheyi
Thanks for all your comments. I'm going to write a simple demo to go through the whole workflow first, and then adjust the policies following the conclusions of our discussion. Heyi On 2019/7/16 16:47, Dave Martin wrote: On Mon, Jul 15, 2019 at 03:44:46PM +0100, Mark Rutland wrote: On Mon,

[Qemu-devel] [RFC] Add virtual SDEI support in qemu

2019-07-13 Thread Guoheyi
Hi folks, Do it make sense to implement virtual SDEI in qemu? So that we can have the standard way for guest to handle NMI watchdog, RAS events and something else which involves SDEI in a physical ARM64 machine. My basic idea is like below: 1. Change a few lines of code in kvm to allow unhan

[Qemu-devel] Can't see mouse cursor on VNC viewer

2018-11-20 Thread Guoheyi
Hi folks, I'm using qemu 2.8 on ARM64 with KVM enabled, and TightVNC on MS Windows as a VNC viewer. We can see the graphic screen on VNC viewer, but we can't see the mouse cursor after we enable "Mouse Cursor -> Let remote server deal with cursor". When I move or click on VNC viewer screen, we