[Qemu-devel] [PATCH 11/12] vhost-vsock: convert to VIRTIO_DEF_DEVICE_VMSD

Refactor so the previously introduced VIRTIO_DEF_DEVICE_VMSD replaces VMSTATE_VIRTIO_DEVICE. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/virtio/vhost-vsock.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/hw/virtio

[Qemu-devel] [PATCH 01/12] virtio: add VIRTIO_DEF_DEVICE_VMSD macro

and replace VMSTATE_VIRTIO_DEVICE with it gradually. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/virtio/virtio.c | 15 +++ include/hw/virtio/virtio.h | 25 + 2 files changed, 40 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/vi

[Qemu-devel] [PATCH 05/12] virtio-serial: convert to VIRTIO_DEF_DEVICE_VMSD

Refactor so the previously introduced VIRTIO_DEF_DEVICE_VMSD replaces VMSTATE_VIRTIO_DEVICE. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/char/virtio-serial-bus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/h

[Qemu-devel] [PATCH 00/11] virtio migration: simplify vmstate helper

get rid of some code duplication. Did only a couple of smoke tests. Comprehensive testing is still to be done. Halil Pasic (11): virtio: add VIRTIO_DEF_DEVICE_VMSD macro virtio-blk: convert to VIRTIO_DEF_DEVICE_VMSD virtio-net: convert to VIRTIO_DEF_DEVICE_VMSD virtio-9p: convert to VIRTIO_DEF_

[Qemu-devel] [PATCH 06/12] virtio-gpu: do not use VMSTATE_VIRTIO_DEVICE

Refactor so that VMSTATE_VIRTIO_DEVICE macro which we want to remove in the future is not used any more. The device virtio-gpu is special because it actually does not adhere to the virtio migration schema, because device state is last. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> -

[Qemu-devel] [PATCH 09/12] virtio-balloon: convert to VIRTIO_DEF_DEVICE_VMSD

Refactor so the previously introduced VIRTIO_DEF_DEVICE_VMSD replaces VMSTATE_VIRTIO_DEVICE. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/virtio/virtio-balloon.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/

[Qemu-devel] [PATCH 10/12] virtio-rng: convert to VIRTIO_DEF_DEVICE_VMSD

Refactor so the previously introduced VIRTIO_DEF_DEVICE_VMSD replaces VMSTATE_VIRTIO_DEVICE. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/virtio/virtio-rng.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/

[Qemu-devel] [PATCH 12/12] virtio: remove unused VMSTATE_VIRTIO_DEVICE

Previously we mande sure VMSTATE_VIRTIO_DEVICE is not used any more. Let us remove it along with the associated wrapper function. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/virtio/virtio.c | 6 -- include/hw/virtio/virtio.h | 20 2

[Qemu-devel] [PATCH 02/12] virtio-blk: convert to VIRTIO_DEF_DEVICE_VMSD

Refactor so the previously introduced VIRTIO_DEF_DEVICE_VMSD replaces VMSTATE_VIRTIO_DEVICE. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/block/virtio-blk.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw

[Qemu-devel] [PATCH 07/12] virtio-input: convert to VIRTIO_DEF_DEVICE_VMSD

Refactor so the previously introduced VIRTIO_DEF_DEVICE_VMSD replaces VMSTATE_VIRTIO_DEVICE. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/input/virtio-input.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/input/virtio-input.c b/hw

[Qemu-devel] [PATCH v4 1/1] block: improve error handling in raw_open

Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was set generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Re

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

On 07/28/2016 11:03 PM, Eric Blake wrote: > On 07/28/2016 09:29 AM, Halil Pasic wrote: > >>> You mean va_start, not start_va. And actually, C11 is clear that errno >>> is unspecified after library functions (but not macros) that don't >>> explicitly

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

On 07/28/2016 04:56 PM, Eric Blake wrote: > On 07/28/2016 04:46 AM, Halil Pasic wrote: > >> The implementation of preserve errno seems inconsistent to me. The >> function error_setv is static, and I guess it is supposed to provide >> this indirect errno preservat

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

On 07/28/2016 12:19 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 07/27/2016 03:24 AM, Sascha Silbe wrote: >>> C11 allows errno to be clobbered by pretty much any library function >>> call, so in general callers need to take care to save errno before >>> calling

Re: [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 07/27/2016 04:37 PM, Max Reitz wrote: >> Now if you examine #1 drive_new(all_opts,block_default_type) you see, >> > there is no errp argument and if you examine the code you see that the >> > error from blockdev_init which gets propagated properly to this point >> > gets "handled" by

Re: [Qemu-devel] [PATCH 1/1] block: improve error handling in raw_open

On 07/27/2016 05:28 PM, Halil Pasic wrote: > Make raw_open for POSIX more consistent in handling errors by setting > the error object also when qemu_open fails. The error object was set > generally set in case of errors, but I guess this case was overlooked. > Do the same for win32.

[Qemu-devel] [PATCH 1/1] block: improve error handling in raw_open

Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was set generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Re

Re: [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 07/26/2016 07:47 PM, Max Reitz wrote: >> Frankly, I'm a bit uncomfortable with asking (do not want to be pushy), >> > but do you have an opinion on the 'error_report_err' issue (pointed >> > out in the cover letter part)? > You are using drive_add with QMP? As far as I know, one can only do

Re: [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 07/26/2016 05:42 PM, Max Reitz wrote: >> +++ b/block/raw-posix.c >> > @@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict >> > *options, >> > s->fd = -1; >> > fd = qemu_open(filename, s->open_flags, 0644); >> > if (fd < 0) { >> > +

[Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was set generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Re

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: improve error handling in raw_open

On 07/18/2016 05:57 PM, Max Reitz wrote: > On 18.07.2016 17:48, Halil Pasic wrote: >> >> >> On 07/18/2016 04:41 PM, Max Reitz wrote: >>> On 18.07.2016 14:30, Halil Pasic wrote: >>>> Make raw_open for POSIX more consistent in handling errors by setting

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: improve error handling in raw_open

On 07/18/2016 04:41 PM, Max Reitz wrote: > On 18.07.2016 14:30, Halil Pasic wrote: >> Make raw_open for POSIX more consistent in handling errors by setting >> the error object also when qemu_open fails. The error object was >> generally set in case of errors, but I guess thi

[Qemu-devel] [PATCH 1/1] block: improve error handling in raw_open

Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Re

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

", "virtio-net", QEMU_ARCH_S390X }, > +{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X }, > { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X }, > -{ "lsi53c895a", "lsi" }, > -{ "ich9-ahci", "ahci" }, > -{ "kvm-pci-assign", "pci-assign" }, > -{ "e1000", "e1000-82540em" }, > +{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X > }, > { } > }; > Reviewed-by: Halil Pasic <pa...@linux.vnet.ibm.com>

<    6   7   8   9   10   11