Re: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr

On 10/17/2017 05:13 PM, Cornelia Huck wrote: > On Tue, 17 Oct 2017 16:04:46 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Abstract >> === >> >> The basic idea is: tell how to handle an unusual condition where it's >> identified, in

Re: [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control

On 10/17/2017 04:58 PM, Cornelia Huck wrote: > On Tue, 17 Oct 2017 16:04:48 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> CSS code needs to tell the IO instruction handlers located in how should >> the emulated instruction be ended. Currently this is d

[Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

Simplify the error handling of the HSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 18 +- include/hw/s390x/css.

[Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

of required ORB flags. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 84 + hw/s390x/s390-ccw.c | 11 +++--- hw/vfio/ccw.c | 28 +++ include/hw/s390x/css.h

[Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler

Simplify the error handling of the XSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 17 + include/hw/s390x/css.

[Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control

for moving a way form (mis)using generic error codes for flow control let us introduce a type which tells the instruction handler function how to end the instruction, in a more straight-forward and less ambiguous way. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- include/hw/s390x

[Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

Simplify the error handling of the MSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 18 +- include/hw/s390x/css.

[Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

Simplify the error handling of the cSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 12 +++- include/hw/s390x/css.h | 2 +-

[Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr

e test. Dong Jia gave v2 a spin with a focus on vfio-ccw. @Dong Jia I would appreciate some proper testing, especially regarding the changes in vfio-ccw (patch #3). Halil Pasic (7): s390x/css: be more consistent if broken beyond repair s390x/css: IO instr handler ending control s390x: improve

[Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair

-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- Already applied to Connies s390-next. Included for the sake of completenes (with) the old typo in the commit message. --- hw/s390x/css.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/17/2017 02:13 PM, Cornelia Huck wrote: > On Tue, 17 Oct 2017 13:28:57 +0200 > Thomas Huth <th...@redhat.com> wrote: > >> On 17.10.2017 13:10, Halil Pasic wrote: >>> >>> >>> On 10/12/2017 01:44 PM, Halil Pasic wrote: >>

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/12/2017 01:44 PM, Halil Pasic wrote: > > > On 10/12/2017 08:58 AM, Thomas Huth wrote: >> On 10.10.2017 13:41, Halil Pasic wrote: [..] >> So yes, please don't do a "typedef unsigned int IOInstEnding" either. I >> think the best match for QEMU would

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

On 10/12/2017 02:11 PM, Cornelia Huck wrote: > On Thu, 12 Oct 2017 14:06:42 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 10/10/2017 04:36 PM, Halil Pasic wrote: >>> >>> >>> On 10/10/2017 03:07 PM, Cornelia Huck wrote: >>

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

On 10/10/2017 04:36 PM, Halil Pasic wrote: > > > On 10/10/2017 03:07 PM, Cornelia Huck wrote: >> On Wed, 4 Oct 2017 17:41:39 +0200 >> Halil Pasic <pa...@linux.vnet.ibm.com> wrote: >> >>> Simplify the error handling of the SSCH and RSCH handler avoi

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/12/2017 08:58 AM, Thomas Huth wrote: > On 10.10.2017 13:41, Halil Pasic wrote: >> [..] >>>> >>>> Yeah, the ABI is smart enough (where it matters) and this one is obviously >>>> less that 8 bytes. I read this as you assumed that the return won't

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

On 10/11/2017 05:47 AM, Dong Jia Shi wrote: > * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-10-04 17:41:39 +0200]: > >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being used to tell how the instruction >

Re: [Qemu-devel] [PATCH v2 1/8] s390x/css: be more consistent if broken beyond repair

On 10/10/2017 03:25 PM, Cornelia Huck wrote: > On Wed, 4 Oct 2017 17:41:37 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Calling do_subchannel_work with no function control flags set in SCSW is >> a programming error. Currently

Re: [Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic

On 10/10/2017 03:10 PM, Cornelia Huck wrote: > On Wed, 4 Oct 2017 17:41:44 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Some of ioinst the handlers look very much the same: they basically >> delegate the work to the appropriate css function (doing so

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

On 10/10/2017 03:07 PM, Cornelia Huck wrote: > On Wed, 4 Oct 2017 17:41:39 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being used to tell how the

Re: [Qemu-devel] [v20 1/2] virtio-crypto: Add virtio crypto device specification

On 10/10/2017 01:12 PM, Longpeng (Mike) wrote: > > > On 2017/10/9 23:43, Halil Pasic wrote: > >> >> >> On 09/29/2017 07:24 AM, Longpeng(Mike) wrote: >>> From: Gonglei <arei.gong...@huawei.com> >>> >>> The virtio crypto device

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/10/2017 01:39 PM, Cornelia Huck wrote: > On Tue, 10 Oct 2017 12:28:35 +0200 > Thomas Huth <th...@redhat.com> wrote: > >> On 09.10.2017 17:00, Halil Pasic wrote: >>> >>> >>> On 10/09/2017 01:07 PM, Thomas Huth wrote: > >>

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

[..] >> >> Yeah, the ABI is smart enough (where it matters) and this one is obviously >> less that 8 bytes. I read this as you assumed that the return won't be >> passed via register (general purpose register 2 for a z host + ELF assumed), >> and that would have been ugly indeed. >> >> Btw I have

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

On 10/10/2017 10:13 AM, Dong Jia Shi wrote: > * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-10-04 17:41:39 +0200]: > > [...] > >> diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> index 4f47dbc8b0..b2978c3bae 100644 >> --- a/hw/s390x/css.c >> ++

Re: [Qemu-devel] [v20 1/2] virtio-crypto: Add virtio crypto device specification

On 09/29/2017 07:24 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. >

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/09/2017 01:09 PM, Cornelia Huck wrote: > On Mon, 9 Oct 2017 12:54:03 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 10/09/2017 10:20 AM, Thomas Huth wrote: >>> On 04.10.2017 17:41, Halil Pasic wrote: > >>>> +/* IO instruct

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/09/2017 01:07 PM, Thomas Huth wrote: > On 09.10.2017 12:54, Halil Pasic wrote: >> >> >> On 10/09/2017 10:20 AM, Thomas Huth wrote: >>> On 04.10.2017 17:41, Halil Pasic wrote: >>>> CSS code needs to tell the IO instruction handlers lo

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

On 10/09/2017 11:22 AM, Gonglei (Arei) wrote: > The next patch refactors make sense to me, > but why do we need to decouple the virtio-crypto.h? > > I wanted to be able to freely change the host side and test with an unchanged guest side, that's why I've done that. It's just for testing. I

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

On 10/09/2017 10:20 AM, Thomas Huth wrote: > On 04.10.2017 17:41, Halil Pasic wrote: >> CSS code needs to tell the IO instruction handlers located in how should > > located in how? > First, thanks for your review! Wanted to say: in target/s390x/ioinst.c just fo

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

On 09/18/2017 03:17 AM, Longpeng (Mike) wrote: > > > On 2017/9/16 1:33, Halil Pasic wrote: > >> >> >> On 09/14/2017 02:58 AM, Longpeng (Mike) wrote: >>> >>> >>> On 2017/9/14 2:14, Halil Pasic wrote: >>> >>>> >&

Re: [Qemu-devel] [PATCH] hw/s390x: Mark the "sclpquiesce" device with user_creatable = false

let's > better mark it with user_creatable = false to avoid unexpected behavior, > e.g. because the quiesce notifier gets registered multiple times. > > Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Halil Pasic <pa...@linux.vnet.ibm.com> > --- > hw/s390x/sclpquie

[Qemu-devel] [PATCH v2 6/8] s390x: refactor error handling for HSCH handler

Simplify the error handling of the HSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 18 +- include/hw/s390x/css.

[Qemu-devel] [PATCH v2 7/8] s390x: refactor error handling for MSCH handler

Simplify the error handling of the MSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 18 +- include/hw/s390x/css.

[Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic

Some of ioinst the handlers look very much the same: they basically delegate the work to the appropriate css function (doing some always the same stuff before and after the call to the appropriate css function). Let us create a template and get rid of some code. Signed-off-by: Halil Pasic <

[Qemu-devel] [PATCH v2 5/8] s390x: refactor error handling for CSCH handler

Simplify the error handling of the cSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 12 +++- include/hw/s390x/css.h | 2 +-

[Qemu-devel] [PATCH v2 1/8] s390x/css: be more consistent if broken beyond repair

-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index c59be1aad1..4f47dbc8b0 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -1067,9 +1067,6

[Qemu-devel] [PATCH v2 0/8] improve error handling for IO instr

ake sense. Halil Pasic (8): s390x/css: be more consistent if broken beyond repair s390x/css: IO instr handler ending control s390x: improve error handling for SSCH and RSCH s390x: refactor error handling for XSCH handler s390x: refactor error handling for CSCH handler s390x: refactor er

[Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

for moving a way form (mis)using generic error codes for flow control let us introduce a struct which tells the instruction handler function how to end the instruction, in a more straight-forward and less ambiguous way. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- include/hw/s390x

[Qemu-devel] [PATCH v2 4/8] s390x: refactor error handling for XSCH handler

Simplify the error handling of the XSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 17 + include/hw/s390x/css.

[Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- AFAIR we decided in the previous round to rather do transformation and fixing in one patch than touch stuff twice. Hence this patch ain't pure transformation any more. --- hw/s390x/css.c

Re: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false

r_creatable = false > accordingly. > > Signed-off-by: Thomas Huth <th...@redhat.com> > While I'm not really familiar with the sclp code, I do understand the measure (user_creatable = false), but I'm not sure I understand the explanation. So it's: Acked-by: Halil Pasic <pa...@

Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix css migration compat handling

On 10/04/2017 01:10 PM, Cornelia Huck wrote: > On Wed, 4 Oct 2017 13:01:09 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Commit e996583eb3 ("s390x/css: activate ChannelSubSys migration", >> 2017-07-11) was supposed to enable css migration for

[Qemu-devel] [PATCH 1/1] s390x/css: fix css migration compat handling

Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reported-by: Thomas Huth <th...@redhat.com> --- hw/s390x/s390-virtio-ccw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index fafbc6d4fe..3b5dfdb48d

Re: [Qemu-devel] [PATCH v3 5/6] s390x/css: activate ChannelSubSys migration

On 10/04/2017 10:16 AM, Cornelia Huck wrote: > On Tue, 3 Oct 2017 13:58:29 +0200 > Thomas Huth <th...@redhat.com> wrote: > >> On 11.07.2017 16:54, Halil Pasic wrote: >>> Turn on migration for the channel subsystem for the next machine. For >>> legacy mach

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

On 09/28/2017 05:19 PM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 19:23:12 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Jason found some problems with 3270 which he traced down to insufficient >> output buffer size. I've looked into the underlying issu

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

On 09/21/2017 01:00 PM, Halil Pasic wrote: >>>> Are you planning to do some further work on 3270, btw? >>>> >>> I did not. I jumped in because of IDA, and because I did >>> not agree with increasing the buffer size to another arbitrary >>&

Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support

On 09/26/2017 12:18 PM, Cornelia Huck wrote: > On Thu, 21 Sep 2017 20:08:36 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Abstract >> >> >> The objective of this series is introducing CCW IDA (indirect data >> access) support to

Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream

On 09/26/2017 12:10 PM, Cornelia Huck wrote: > On Fri, 22 Sep 2017 17:39:35 +0200 > Pierre Morel <pmo...@linux.vnet.ibm.com> wrote: > >> On 21/09/2017 20:08, Halil Pasic wrote: >>> Replace direct access which implicitly assumes no IDA >>> or MIDA with

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

On 09/19/2017 04:20 PM, Pierre Morel wrote: > On 15/09/2017 19:01, Cornelia Huck wrote: >> On Fri, 15 Sep 2017 09:27:58 +0200 >> Cornelia Huck <coh...@redhat.com> wrote: >> >>> On Thu, 14 Sep 2017 18:50:29 +0200 >>> Halil Pasic <pa...@linux.vnet

Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH

On 09/25/2017 09:31 AM, Dong Jia Shi wrote: > * Cornelia Huck <coh...@redhat.com> [2017-09-08 11:59:50 +0200]: > >> On Fri, 8 Sep 2017 11:21:57 +0200 >> Halil Pasic <pa...@linux.vnet.ibm.com> wrote: >> >>> On 09/08/2017 05:41 AM, Dong Jia Shi

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

On 09/22/2017 04:07 PM, Christian Borntraeger wrote: > > > On 09/22/2017 04:02 PM, Pierre Morel wrote: >> On 22/09/2017 14:40, Christian Borntraeger wrote: >>> >>> >>> On 09/22/2017 02:13 PM, Pierre Morel wrote: On 22/09/2017 10:38, Christian Borntraeger wrote: > Instead of

[Qemu-devel] [PATCH v4 2/5] s390x/css: use ccw data stream

Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> Reviewed-by:

[Qemu-devel] [PATCH v4 1/5] s390x/css: introduce css data stream

-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> --- hw/s390x/css.c | 55 + include/h

[Qemu-devel] [PATCH v4 5/5] s390x/css: support ccw IDA

Let's add indirect data addressing support for our virtual channel subsystem. This implementation does not bother with any kind of prefetching. We simply step through the IDAL on demand. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c

[Qemu-devel] [PATCH v4 4/5] 390x/css: introduce maximum data address checking

is not to be performed and a channel program check needs to be generated. As of today, we fail to do this check. Let us stick even closer to the architecture specification. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 10 ++ include/hw/s390x/css.h | 1 + 2

[Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support

rewording of commit message #3 Halil Pasic (5): s390x/css: introduce css data stream s390x/css: use ccw data stream virtio-ccw: use ccw data stream 390x/css: introduce maximum data address checking s390x/css: support ccw IDA hw/s390x/css.c

[Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream

Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> Reviewed-by:

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

On 09/21/2017 11:44 AM, Pierre Morel wrote: > On 19/09/2017 20:27, Halil Pasic wrote: >> Replace direct access which implicitly assumes no IDA >> or MIDA with the new ccw data stream interface which should >> cope with these transparently in the future. >> >&g

Re: [Qemu-devel] [PATCH 1/2] s390x/3270: IDA support for 3270 via CcwDataStream

On 09/21/2017 02:05 PM, Cornelia Huck wrote: > On Thu, 21 Sep 2017 13:22:44 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 09/21/2017 11:15 AM, Cornelia Huck wrote: >>>> +static inline CcwDataStream *get_cds(Terminal3270 *t) >>>> +{ &

Re: [Qemu-devel] [PATCH 1/2] s390x/3270: IDA support for 3270 via CcwDataStream

On 09/21/2017 11:15 AM, Cornelia Huck wrote: >> +static inline CcwDataStream *get_cds(Terminal3270 *t) >> +{ >> +return &(CCW_DEVICE(>cdev)->sch->cds); >> +} >> + >> +static int read_payload_3270(EmulatedCcw3270Device *dev) >> { >> Terminal3270 *t = TERMINAL_3270(dev); >> int len;

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

On 09/21/2017 12:48 PM, Cornelia Huck wrote: > On Thu, 21 Sep 2017 12:22:30 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 09/21/2017 11:24 AM, Cornelia Huck wrote: >>> On Wed, 20 Sep 2017 19:23:12 +0200 >>> Halil Pasic <pa...@linux.vn

Re: [Qemu-devel] [PATCH 2/2] s390x/3270: handle writes of arbitrary length

On 09/21/2017 11:23 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 19:23:14 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> The problem is, that the current implementation places unrealistic and >> arbitrary constraints on the length of writes to the devi

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

On 09/21/2017 11:24 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 19:23:12 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Jason found some problems with 3270 which he traced down to insufficient >> output buffer size. I've looked into the underlying issu

[Qemu-devel] [PATCH 1/2] s390x/3270: IDA support for 3270 via CcwDataStream

preserved). Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> --- hw/char/terminal3270.c | 18 +++--- hw/s390x/3270-ccw.c | 4 ++-- include/h

[Qemu-devel] [PATCH 0/2] 3270 improvements

/archive/html/qemu-devel/2017-09/msg03434.html. Halil Pasic (2): s390x/3270: IDA support for 3270 via CcwDataStream s390x/3270: handle writes of arbitrary length hw/char/terminal3270.c | 46 +++-- hw/s390x/3270-ccw.c | 4 ++-- include/hw/s390x

[Qemu-devel] [PATCH 2/2] s390x/3270: handle writes of arbitrary length

how to deal with arbitrary long writes. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> Reported-by: Jason J . Herne <jjhe...@linux.vnet.ibm.com> Tested-b

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On 09/20/2017 01:18 PM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 13:13:01 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 09/20/2017 10:33 AM, Cornelia Huck wrote: >>> On Wed, 20 Sep 2017 15:42:38 +0800 >>> Dong Jia Shi <bjsdj...@linu

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

On 09/20/2017 10:25 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 15:47:51 +0800 > Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote: > >> * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-09-19 20:27:44 +0200]: > >>> @@ -828,7 +836,9 @@ void ccw_dstr

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

On 09/20/2017 09:58 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 20:27:43 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Replace direct access which implicitly assumes no IDA >> or MIDA with the new ccw data stream interface which should >&

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On 09/20/2017 10:11 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 20:27:45 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Let's add indirect data addressing support for our virtual channel >> subsystem. This implementation does not bother with any kind o

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On 09/20/2017 10:33 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 15:42:38 +0800 > Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote: > >> * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-09-19 20:27:45 +0200]: >> >>> Let's add indirect data

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

On 09/20/2017 10:06 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 20:27:44 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> The architecture mandates the addresses to be accessed on the first >> indirection level (that is, the data addresses without IDA, a

[Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> --- hw/s390x/

[Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

Let's add indirect data addressing support for our virtual channel subsystem. This implementation does not bother with any kind of prefetching. We simply step through the IDAL on demand. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <coh...@redhat.com

[Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

is not to be performed and a channel program check needs to be generated. As of today, we fail to do this check. Let us stick even closer to the architecture specification. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- hw/s390x/css.c | 10 ++ include/hw/s390x/css.h | 1 + 2

[Qemu-devel] [PATCH v3 2/5] s390x/css: use ccw data stream

Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> Reviewed-by:

[Qemu-devel] [PATCH v3 1/5] s390x/css: introduce css data stream

-by: Halil Pasic <pa...@linux.vnet.ibm.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> --- hw/s390x/css.c | 55 + include/h

[Qemu-devel] [PATCH v3 0/5] add CCW indirect data access support

d some TODOs addressed by another series of mine * refactored ccw_dstream_rw_ida (structured programming) * done some rewording of commit message #3 Halil Pasic (5): s390x/css: introduce css data stream s390x/css: use ccw data stream virtio-ccw: use ccw data stream 390x/css: introduce maximu

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

On 09/19/2017 02:23 PM, Cornelia Huck wrote: > +{ > +union {uint64_t fmt2; uint32_t fmt1; } idaw; ^ Nit. >> Maybe checkpatch wanted it this way. My memories are blurry. > I'd just leave it like that, tbh. Yes, if

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

On 09/19/2017 03:46 PM, Pierre Morel wrote: > On 19/09/2017 12:57, Cornelia Huck wrote: >> On Tue, 19 Sep 2017 12:36:33 +0200 >> Halil Pasic <pa...@linux.vnet.ibm.com> wrote: >> >>> On 09/19/2017 11:48 AM, Cornelia Huck wrote: >>>> On Tue, 19

Re: [Qemu-devel] [PATCH v2 3/4] virtio-ccw: use ccw data stream

On 09/19/2017 11:06 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 11:37:30 +0800 > Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote: > >> * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-09-13 13:50:28 +0200]: >> >>> Replace direct access which implicit

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

On 09/19/2017 02:23 PM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 14:04:03 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 09/19/2017 12:57 PM, Cornelia Huck wrote: >>>>>>> +static inline int ida_read_next_idaw(CcwDataStream *cds) &g

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

On 09/19/2017 01:41 PM, Pierre Morel wrote: > On 19/09/2017 11:53, Cornelia Huck wrote: >> On Tue, 19 Sep 2017 11:11:27 +0200 >> Pierre Morel <pmo...@linux.vnet.ibm.com> wrote: >> >>> On 13/09/2017 13:50, Halil Pasic wrote: >>>> This is a prepar

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

On 09/19/2017 12:57 PM, Cornelia Huck wrote: > +static inline int ida_read_next_idaw(CcwDataStream *cds) > +{ > +union {uint64_t fmt2; uint32_t fmt1; } idaw; ^ Nit. >> Maybe checkpatch wanted it this way. My memories

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

On 09/19/2017 11:48 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 13:50:05 +0800 > Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote: > >> * Halil Pasic <pa...@linux.vnet.ibm.com> [2017-09-13 13:50:29 +0200]: >> >>> Let's add indirect data

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

On 09/18/2017 04:51 PM, Zeng, Xin wrote: > On Monday, September 18, 2017 9:24 PM, Gonglei (Arei) wrote: > > < > On 09/18/2017 02:13 PM, Gonglei (Arei) wrote: > < > >> Destroy does not need to specify queue_id. That means session_id's > aren't > < > >> queue scoped from namespace perspective.

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

On 09/18/2017 02:13 PM, Gonglei (Arei) wrote: >> Destroy does not need to specify queue_id. That means session_id's aren't >> queue scoped from namespace perspective. The question remains what is >> queue_id good for, and whether a session type op request should be >> rejected if the the session

Re: [Qemu-devel] [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

On 09/14/2017 02:58 AM, Longpeng (Mike) wrote: > > > On 2017/9/14 2:14, Halil Pasic wrote: > >> >> >> On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: >>> *NOTE* >>> The code realization is based on the latest virtio crypto spec: >>

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

On 09/11/2017 03:12 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. >

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

,Huawei \newline > +Peng Long, Huawei \newline > \end{oasistitlesection} > > The following non-members have provided valuable feedback on this > @@ -43,4 +45,5 @@ Laura Novich, Red Hat \newline > Patrick Durusau, Technical Advisory Board, OASIS \newline

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

On 09/15/2017 03:37 PM, David Hildenbrand wrote: > On 15.09.2017 15:22, Cornelia Huck wrote: >> On Fri, 15 Sep 2017 15:09:02 +0200 >> David Hildenbrand wrote: >> >>> On 15.09.2017 15:07, Cornelia Huck wrote: On Fri, 15 Sep 2017 13:57:40 +0200 David Hildenbrand

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

On 09/14/2017 04:26 PM, Cornelia Huck wrote: > On Wed, 13 Sep 2017 15:27:51 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Add a fake device meant for testing the correctness of our css emulation. >> >> What we currently have is writing

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

On 09/14/2017 12:36 PM, Thomas Huth wrote: > libseccomp supports s390x since version 2.3.0, and I was able to start > a VM with "-sandbox on" without any obvious problems by using this patch, > so it should be safe to allow --enable-seccomp on s390x nowadays, too. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

On 09/14/2017 11:15 AM, Cornelia Huck wrote: > On Wed, 13 Sep 2017 13:50:25 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> Abstract >> >> >> The objective of this series is introducing CCW IDA (indirect data >> access) support to

[Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

the responsibility into the transport isn't even possible, because the transport would have to know about the config space layout of each device. Let us remove the stale comments. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Suggested-by: Cornelia Huck <coh...@redhat.com> --- hw/s390x/

Re: [Qemu-devel] [RFC 0/8] virtio-crypto: add multiplexing mode support

On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: > *NOTE* > The code realization is based on the latest virtio crypto spec: > [PATCH v19 0/2] virtio-crypto: virtio crypto device specification >https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05217.html > > In session mode, the

Re: [Qemu-devel] [PATCH v1 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

On 09/12/2017 04:26 PM, Farhan Ali wrote: > Wire up the virtio-gpu device for the CCW bus. The virtio-gpu > is a virtio-1 device, so disable revision 0. > > Signed-off-by: Farhan Ali <al...@linux.vnet.ibm.com> > Acked-by: Christian Borntraeger <borntrae...@de.ibm.com>

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

On 09/13/2017 12:08 PM, Cornelia Huck wrote: > On Thu, 7 Sep 2017 13:01:34 +0200 > Halil Pasic <pa...@linux.vnet.ibm.com> wrote: > >> On 09/07/2017 10:02 AM, Dong Jia Shi wrote: >>> * Cornelia Huck <coh...@redhat.com> [2017-09-06 13:25:38 +0200]: >>&

[Qemu-devel] [PATCH 0/2] tests for CCW IDA

of the patches used to be included in my IDA series, but I've split them out on maintainer request. Halil Pasic (1): s390x/ccs: add ccw-tester emulated device hw/s390x/Makefile.objs | 1 + hw/s390x/ccw-tester.c | 179 + 2 files changed, 180 insertions

[Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

count. Of course lot's of invalid inputs (besides basic data processing) can be tested with that as well. Usage: 1) fire up a qemu with something like -device ccw-tester,devno=fe.0.0001 on the command line 2) exercise the device from the guest Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.

[Qemu-devel] [PATCH 2/2 NOT QEMU] a tester device for ccw I/O

he driver expects the device posts a device exception indicating that element. Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> --- Do not try to apply this to a QEMU tree. Use an empty repo. --- .gitignore | 8 ++ Makefile | 10 ++ ccw

<    1   2   3   4   5   6   7   8   9   10   >