Re: [PATCH] hw/block/fdc: do not set SEEK status bit in multi track commands

2024-01-01 Thread Hervé Poussineau
Ping. Le 12/08/2023 à 10:59, Hervé Poussineau a écrit : I don't understand when SEEK must be set or not, but it seems to fix Minix... Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1522 Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH] hw/block/fdc: do not set SEEK status bit in multi track commands

2023-08-12 Thread Hervé Poussineau
I don't understand when SEEK must be set or not, but it seems to fix Minix... Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1522 Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index d7cc4d3ec19

Re: [PATCH] hw/dma/rc4030: Move RC4030 declarations to its own 'rc4030.h' header

2023-01-05 Thread Hervé Poussineau
ot; --- hw/dma/rc4030.c | 2 +- hw/mips/jazz.c | 1 + include/hw/dma/rc4030.h | 21 + include/hw/mips/mips.h | 9 - 4 files changed, 23 insertions(+), 10 deletions(-) create mode 100644 include/hw/dma/rc4030.h Acked-by: Hervé Poussineau

[PATCH v2 2/2] vvfat: allow spaces in file names

2022-10-10 Thread Hervé Poussineau
In R/W mode, files with spaces were never created on host side. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176 Fixes: c79e243ed67683d6d06692bd7040f7394da178b0 Signed-off-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf --- block/vvfat.c | 2 +- 1

[PATCH v2 0/2] Fix some problems with vvfat in R/W mode

2022-10-10 Thread Hervé Poussineau
allows creating file names with spaces. Hervé Changes since v1: - updated patch 1 with remarks (modify in-memory copy, add comment about FAT32) Hervé Poussineau (2): vvfat: allow some writes to bootsector vvfat: allow spaces in file names block/vvfat.c | 28 ++-- 1

[PATCH v2 1/2] vvfat: allow some writes to bootsector

2022-10-10 Thread Hervé Poussineau
'reserved1' field in bootsector is used to mark volume dirty, or need to verify. Allow writes to bootsector which only changes the 'reserved1' field. This fixes I/O errors on Windows guests. Resolves: https://bugs.launchpad.net/qemu/+bug/1889421 Signed-off-by: Hervé Poussineau --- block

Re: [PATCH 1/2] vvfat: allow some writes to bootsector

2022-09-29 Thread Hervé Poussineau
Le 29/09/2022 à 16:10, Kevin Wolf a écrit : Am 03.09.2022 um 18:23 hat Hervé Poussineau geschrieben: 'reserved1' field in bootsector is used to mark volume dirty, or need to verify. Allow writes to bootsector which only changes the 'reserved1' field. This fixes I/O errors on Windows guests

[PATCH 2/2] vvfat: allow spaces in file names

2022-09-03 Thread Hervé Poussineau
In R/W mode, files with spaces were never created on host side. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176 Fixes: c79e243ed67683d6d06692bd7040f7394da178b0 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/2] Fix some problems with vvfat in R/W mode

2022-09-03 Thread Hervé Poussineau
allows creating file names with spaces. Hervé Hervé Poussineau (2): vvfat: allow some writes to bootsector vvfat: allow spaces in file names block/vvfat.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.36.2

[PATCH 1/2] vvfat: allow some writes to bootsector

2022-09-03 Thread Hervé Poussineau
'reserved1' field in bootsector is used to mark volume dirty, or need to verify. Allow writes to bootsector which only changes the 'reserved1' field. This fixes I/O errors on Windows guests. Resolves: https://bugs.launchpad.net/qemu/+bug/1889421 Signed-off-by: Hervé Poussineau --- block

Re: [PATCH 29/50] pckbd: more vmstate_register() from i8042_mm_init() to i8042_mmio_realize()

2022-05-23 Thread Hervé Poussineau
Hello, If you want, you can break migration compatibility. I don't see it as a problem. Hervé Le 22/05/2022 à 20:18, Mark Cave-Ayland a écrit : Note in this case it is not possible to register a (new) VMStateDescription in the DeviceClass without breaking migration compatibility for the MIPS

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-22 Thread Hervé Poussineau
Le 18/05/2021 à 09:14, Philippe Mathieu-Daudé a écrit : Cc'ing Hervé, Aleksandar, Markus & Mark. On 5/17/21 11:11 PM, John Snow wrote: On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote: On 5/17/21 9:19 PM, John Snow wrote: On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: The floppy disc

Re: [PATCH] floppy: remove unused function fdctrl_format_sector

2021-03-13 Thread Hervé Poussineau
Le 12/03/2021 à 07:45, John Snow a écrit : On 1/8/21 6:01 PM, Alexander Bulekov wrote: fdctrl_format_sector was added in baca51faff ("updated floppy driver: formatting code, disk geometry auto detect (Jocelyn Mayer)") The single callsite is guarded by a check: fdctrl->data_state &

Re: [PATCH 0/5] m48t59: remove legacy init functions

2020-10-16 Thread Hervé Poussineau
| 35 --- hw/sparc/sun4m.c| 8 +++- hw/sparc64/sun4u.c | 7 +-- include/hw/rtc/m48t59.h | 6 -- 6 files changed, 21 insertions(+), 70 deletions(-) Reviewed-by: Hervé Poussineau

Re: [PATCH 39/63] esp: Rename ESP_STATE to ESP

2020-09-03 Thread Hervé Poussineau
Le 03/09/2020 à 00:42, Eduardo Habkost a écrit : Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost --- Cc: Mark Cave-Ayland Cc: Laurent Vivier Cc: "Hervé Poussineau" Cc: Aleksandar Rikalo Cc: Aleksandar Markovic Cc: Aurelien

Re: [PATCH 47/63] rs6000_mc: Rename RS6000MC_DEVICE to RS6000MC

2020-09-03 Thread Hervé Poussineau
Le 03/09/2020 à 00:42, Eduardo Habkost a écrit : Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost --- Cc: "Hervé Poussineau" Cc: David Gibson Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/ppc/rs6000_mc.c | 4 ++-

Re: [PATCH 20/63] pc87312: Rename TYPE_PC87312_SUPERIO to TYPE_PC87312

2020-09-03 Thread Hervé Poussineau
Le 03/09/2020 à 00:42, Eduardo Habkost a écrit : This will make the type name constant consistent with the name of the type checking macro. Signed-off-by: Eduardo Habkost --- Cc: "Hervé Poussineau" Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- include/hw/isa/pc87312.h | 4

Re: [PATCH v3 0/2] hw/timer/m48t59: Convert to trace events

2020-01-18 Thread Hervé Poussineau
- hw/rtc/m48t59.c | 11 +-- MAINTAINERS | 2 ++ hw/rtc/trace-events | 6 ++ 4 files changed, 13 insertions(+), 11 deletions(-) Reviewed-by: Hervé Poussineau

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2020-01-07 Thread Hervé Poussineau
ode 100644 pc-bios/ppc_rom.bin delete mode 16 roms/openhackware [...] Ping ... Hervé, what do you think about the patch? Hello Thomas, I completely agree with this welcomed patch! Acked-by: Hervé Poussineau Regards, Hervé

Re: NetBSD/arc on MIPS Magnum, was Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation

2019-12-23 Thread Hervé Poussineau
Le 24/12/2019 à 05:33, Finn Thain a écrit : On Tue, 24 Dec 2019, Finn Thain wrote: I know precious little about NetBSD installation and MIPS Magnum. What I wrote above was guesswork. Hence this could be a NetBSD bug or user error. It was bugs and user error. The user error was not using

[PATCH] dma/rc4030: correctly reset DMA translation table at reset

2019-12-22 Thread Hervé Poussineau
This fixes a freeze at reboot, introduced in c627e7526a902dd5bb1907dbbd5cf961679dfa68 Signed-off-by: Hervé Poussineau --- hw/dma/rc4030.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c index c4cf8236f4..76302fe431 100644 --- a/hw/dma/rc4030.c +++ b/hw/dma

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

2019-11-22 Thread Hervé Poussineau
@@ F: hw/mips/mips_mipssim.c    F: hw/net/mipsnet.c    R4000 -M: Aurelien Jarno -R: Aleksandar Rikalo +M: Hervé Poussineau Commit 0c10962a033 from Hervé was part of a bigger refactor series, so I don't think he is interested. +R: Aurelien Jarno +R: Philippe Mathieu-Daudé    S: Maintained

Re: [PATCH 2/3] dp8393x: fix dp8393x_receive()

2019-11-05 Thread Hervé Poussineau
Le 05/11/2019 à 22:53, Laurent Vivier a écrit : Le 05/11/2019 à 22:06, Hervé Poussineau a écrit : Le 02/11/2019 à 18:15, Laurent Vivier a écrit : address_space_rw() access size must be multiplied by the width. This fixes DHCP for Q800 guest. Signed-off-by: Laurent Vivier ---   hw/net

Re: [PATCH 2/3] dp8393x: fix dp8393x_receive()

2019-11-05 Thread Hervé Poussineau
Le 02/11/2019 à 18:15, Laurent Vivier a écrit : address_space_rw() access size must be multiplied by the width. This fixes DHCP for Q800 guest. Signed-off-by: Laurent Vivier --- hw/net/dp8393x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/dp8393x.c

Re: [PATCH 3/3] dp8393x: fix receiving buffer exhaustion

2019-11-05 Thread Hervé Poussineau
Le 02/11/2019 à 18:15, Laurent Vivier a écrit : The card is not able to exit from exhaustion state, because while the drive consumes the buffers, the RRP is incremented (when the driver clears the ISR RBE bit), so it stays equal to RWP, and while RRP == RWP, the card thinks it is always in

Re: [PATCH 1/3] dp8393x: put the DMA buffer in the state structure

2019-11-05 Thread Hervé Poussineau
insertions(+), 55 deletions(-) Reviewed-by: Hervé Poussineau

Re: [PATCH v3] fdc/i8257: implement verify transfer mode

2019-11-03 Thread Hervé Poussineau
as described for transfer operations, except that no memory or I/O read/write control signals will be generated. Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more clear boundary between DMA and FDC, so this patch also does that. Suggested-by: Hervé Poussineau Signed-off-by: Sven

Re: [PATCH v2] fdc/i8257: implement verify transfer mode

2019-11-01 Thread Hervé Poussineau
as described for transfer operations, except that no memory or I/O read/write control signals will be generated. Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more clear boundary between DMA and FDC, so this patch also does that. Suggested-by: Hervé Poussineau Signed-off-by: Sven

Re: [PATCH] fdc: support READ command with VERIFY DMA mode

2019-10-29 Thread Hervé Poussineau
Le 29/10/2019 à 12:00, John Snow a écrit : > > > On 10/20/19 2:38 AM, Sven Schnelle wrote: >> While working on the Tulip driver i tried to write some Teledisk images to >> a floppy image which didn't work. Turned out that Teledisk checks the written >> data by issuing a READ command to the FDC

Re: [Qemu-devel] [PATCH 3/3] hw/mips/mips_jazz: Remove no-longer-necessary override of do_unassigned_access

2019-09-09 Thread Hervé Poussineau
changed, 4 insertions(+), 23 deletions(-) Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 2/3] target/mips: Switch to do_transaction_failed() hook

2019-09-09 Thread Hervé Poussineau
per.c | 24 3 files changed, 14 insertions(+), 20 deletions(-) Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 1/3] hw/mips/mips_jazz: Override do_transaction_failed hook

2019-09-09 Thread Hervé Poussineau
overriding of both hooks, or with a simple "global memory region to ignore bad accesses of all types", so it doesn't provide evidence either way, unfortunately. Signed-off-by: Peter Maydell Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 1/2] dma/rc4030: Fix off-by-one error in specified memory region size

2019-07-01 Thread Hervé Poussineau
Reviewed-by: Hervé Poussineau --- hw/dma/rc4030.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c index 6ccafec..88ff271 100644 --- a/hw/dma/rc4030.c +++ b/hw/dma/rc4030.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h"

Re: [Qemu-devel] [PATCH 2/2] dma/rc4030: Minor code style cleanup

2019-07-01 Thread Hervé Poussineau
Le 25/06/2019 à 16:27, Aleksandar Markovic a écrit : From: Aleksandar Markovic Fix some simple checkpatch.pl warnings in rc4030.c. Signed-off-by: Aleksandar Markovic Reviewed-by: Hervé Poussineau --- hw/dma/rc4030.c | 18 +++--- 1 file changed, 11 insertions(+), 7

Re: [Qemu-devel] [PATCH 1/5] tests/acceptance: Add test that runs NetBSD installer on PRep/40p

2019-07-01 Thread Hervé Poussineau
--- tests/acceptance/ppc_prep_40p.py | 63 1 file changed, 63 insertions(+) create mode 100644 tests/acceptance/ppc_prep_40p.py Hervé, in v2 I plan to rename it machine_ppc_prep_40p.py and add an entry in MAINTAINERS: With the change you want to do: Review

Re: [Qemu-devel] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year

2019-04-14 Thread Hervé Poussineau
Le 14/04/2019 à 20:53, Artyom Tarasenko a écrit : On Sun, Apr 14, 2019 at 7:01 PM Hervé Poussineau wrote: Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit : AIX 5.1 expects the base year to be 1900. Adjust accordingly. Signed-off-by: Artyom Tarasenko --- hw/isa/i82378.c | 4 +++- 1

Re: [Qemu-devel] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year

2019-04-14 Thread Hervé Poussineau
Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit : AIX 5.1 expects the base year to be 1900. Adjust accordingly. Signed-off-by: Artyom Tarasenko --- hw/isa/i82378.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index a5d67bc..546c928

Re: [Qemu-devel] [PATCH 3/4] target/ppc: improve performance of large BAT invalidations

2019-04-14 Thread Hervé Poussineau
Tarasenko --- target/ppc/mmu_helper.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810

2019-04-14 Thread Hervé Poussineau
Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit : AIX/PReP does access to the aliased IO registers of 53810. Implement aliasing to make the AIX driver work. Signed-off-by: Artyom Tarasenko --- hw/scsi/lsi53c895a.c | 31 ++- 1 file changed, 26 insertions(+), 5

Re: [Qemu-devel] [PATCH 2/4] 40p and prep: implement PCI bus mastering

2019-04-14 Thread Hervé Poussineau
Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit : Signed-off-by: Artyom Tarasenko --- hw/pci-host/prep.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] How to correctly use more than 2 floppy drives?

2019-04-05 Thread Hervé Poussineau
with "#define MAX_FD 2" - 2008-04-29 78ae820cfeb0 (Hervé Poussineau): Supports up to 4 floppy drives if MAX_FD is set to 4 Migration stream knows about runtime value of MAX_FD - 2009-09-10 d7a6c2703577 (Juan Quintela): FDC vmstate-ified Migration stream use compile time value of MAX

Re: [Qemu-devel] [PATCH] Categorize devices

2019-03-26 Thread Hervé Poussineau
insertions(+) i82374 part: Reviewed-by: Hervé Poussineau diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c index 892f655a..5b42dd1b 100644 --- a/hw/dma/i82374.c +++ b/hw/dma/i82374.c @@ -147,6 +147,8 @@ static void i82374_class_init(ObjectClass *klass, void *data) dc->realize = i82374_real

Re: [Qemu-devel] [PATCH 3/3] hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"

2019-02-04 Thread Hervé Poussineau
Le 04/02/2019 à 22:04, Philippe Mathieu-Daudé a écrit : In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v2 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig

2019-02-02 Thread Hervé Poussineau
Le 31/01/2019 à 14:53, Thomas Huth a écrit : Select the required devices in hw/ppc/Kconfig instead, so that ppc-softmmu.mak only contains the user-selectable PREP switch. Plug-in devices like NE2000_ISA are pulled in automatically by the Kconfig build system now. Cc: Hervé Poussineau Signed

Re: [Qemu-devel] [PATCH-for-3.1] [REGRESSION FIX] ps2kbd: default to scan enabled after reset

2018-11-22 Thread Hervé Poussineau
Ping again. Le 18/11/2018 à 11:09, Hervé Poussineau a écrit : Ping again. v3.0 didn't contain 143c04c7e0639e53086519592ead15d2556bfbf2, so this commit fixes a regression. Le 10/11/2018 à 21:53, Hervé Poussineau a écrit : Ping. Le 21/10/2018 à 21:07, Hervé Poussineau a écrit : A check

Re: [Qemu-devel] [PATCH-for-3.1] ps2kbd: default to scan enabled after reset

2018-11-18 Thread Hervé Poussineau
Ping again. v3.0 didn't contain 143c04c7e0639e53086519592ead15d2556bfbf2, so this commit fixes a regression. Le 10/11/2018 à 21:53, Hervé Poussineau a écrit : Ping. Le 21/10/2018 à 21:07, Hervé Poussineau a écrit : A check for scan_enabled has been added to ps2_keyboard_event in commit

Re: [Qemu-devel] [PATCH for-3.1] fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled

2018-11-12 Thread Hervé Poussineau
erface reference and release method is only invoked if fdctrl->dma_chann has been set. (This issue was discovered by Martin testing a recent change in the NetBSD installer under qemu-system-sparc) Reported-by: Martin Husemann Signed-off-by: Mark Cave-Ayland Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH] ps2kbd: default to scan enabled after reset

2018-11-10 Thread Hervé Poussineau
Ping. Le 21/10/2018 à 21:07, Hervé Poussineau a écrit : A check for scan_enabled has been added to ps2_keyboard_event in commit 143c04c7e0639e53086519592ead15d2556bfbf2 to prevent stream corruption. This works well as long as operating system is resetting keyboard, or enabling it. This fixes

Re: [Qemu-devel] [PATCH v5 08/11] hw/m68k: add Nubus support for macfb video card

2018-10-30 Thread Hervé Poussineau
changed, 77 insertions(+) Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 10/11] dp8393x: manage big endian bus

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/scsi/esp.c | 292 +- include/hw/scsi/esp.h | 7 ++ 2

Re: [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller

2018-10-30 Thread Hervé Poussineau
SWIM_H +#define SWIM_H + +#include "qemu/osdep.h" +#include "hw/sysbus.h" + +#define MAX_FD 2 Maybe rename MAX_FD to SWIM_MAX_FD, to prevent conflicts with MAX_FD in other files? Excepted that: Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 04/11] hw/m68k: add macfb video card

2018-10-30 Thread Hervé Poussineau
Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 07/11] hw/m68k: add Nubus support

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/nubus/Makefile.objs | 4 +

Re: [Qemu-devel] [PATCH v5 02/11] hw/m68k: implement ADB bus support for via

2018-10-30 Thread Hervé Poussineau
++ 2 files changed, 197 insertions(+) Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 01/11] hw/m68k: add via support

2018-10-30 Thread Hervé Poussineau
++ include/hw/misc/mac_via.h | 107 3 files changed, 774 insertions(+) create mode 100644 hw/misc/mac_via.c create mode 100644 include/hw/misc/mac_via.h Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier This is broken as the linux driver seems broken too... Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/audio/Makefile.objs | 1 + hw/audio/asc.c | 446

Re: [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

2018-10-30 Thread Hervé Poussineau
-- include/hw/char/escc.h | 1 + 2 files changed, 25 insertions(+), 6 deletions(-) Reviewed-by: Hervé Poussineau

[Qemu-devel] [PATCH] ps2kbd: default to scan enabled after reset

2018-10-21 Thread Hervé Poussineau
KBD_CMD_RESET, KBD_CMD_ENABLE or KBD_CMD_RESET_ENABLE before trying to use the keyboard. Signed-off-by: Hervé Poussineau --- hw/input/ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index fdfcadf9a1..eded4f0f8d 100644 --- a/hw/input/ps2.c +++ b/hw

Re: [Qemu-devel] [PATCH v3 0/2] 40p: fix PCI interrupt routing

2018-09-12 Thread Hervé Poussineau
e raven PCI interrupt routing Mark Cave-Ayland (2): lsi53c895a: add optional external IRQ via qdev 40p: add fixed IRQ routing for LSI SCSI device hw/ppc/prep.c| 11 ++- hw/scsi/lsi53c895a.c | 16 ++-- 2 files changed, 20 insertions(+), 7 deletions(-) Reviewed-by: Hervé Poussineau Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v3] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-09-08 Thread Hervé Poussineau
Le 08/09/2018 à 18:20, Stefan Weil a écrit : Am 08.09.2018 um 18:14 schrieb Hervé Poussineau: [...] diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index f123b15e3e..f865822e32 100644 --- a/tests/boot-serial-test.c +++ b/tests/boot-serial-test.c @@ -75,12 +75,12 @@ typedef

[Qemu-devel] [PATCH v3] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-09-08 Thread Hervé Poussineau
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff Use it, instead of relying on an unmaintained and very limited firmware. Signed-off-by: Hervé Poussineau --- Changes v2->v3: - rebased on dgibson/ppc-for-3.1 Changes v1->v2: - rebased on master - fixed tests hw/ppc/

Re: [Qemu-devel] [PATCH v2 0/3] 40p: fix PCI interrupt routing

2018-09-08 Thread Hervé Poussineau
t still be preserved. This is done by introducing a new "is-legacy-prep" qdev property to the raven PCI host bridge which preserves the old routing for -M prep until that code is finally removed. Reviewed-by: Hervé Poussineau Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v2 0/3] scsi: replace lsi53c895a_create() and lsi53c810_create() functions

2018-09-08 Thread Hervé Poussineau
3 ++- hw/hppa/machine.c| 4 +++- hw/ppc/prep.c| 4 +++- hw/scsi/lsi53c895a.c | 11 ++- include/hw/pci/pci.h | 3 +-- 6 files changed, 13 insertions(+), 15 deletions(-) Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-09-04 Thread Hervé Poussineau
Le 31/08/2018 à 16:16, Mark Cave-Ayland a écrit : On 20/08/18 04:16, David Gibson wrote: On Fri, Aug 10, 2018 at 04:41:54PM +1000, David Gibson wrote: On Fri, Aug 10, 2018 at 07:37:12AM +0200, Hervé Poussineau wrote: OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff Use

[Qemu-devel] [PATCH v2] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-09-04 Thread Hervé Poussineau
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff Use it, instead of relying on an unmaintained and very limited firmware. Signed-off-by: Hervé Poussineau --- hw/ppc/prep.c| 2 +- tests/boot-serial-test.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

[Qemu-devel] [PATCH] qemu-doc: mark ppc/prep machine as deprecated

2018-08-10 Thread Hervé Poussineau
40p machine type should be used instead. Signed-off-by: Hervé Poussineau --- qemu-deprecated.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 9920a85adc..9c7ff3fe2d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi

Re: [Qemu-devel] [PATCH] 40p: don't use legacy fw_cfg_init_mem() function

2018-08-10 Thread Hervé Poussineau
this, as this function is also used in other places? However, Acked-by: Hervé Poussineau Hervé

Re: [Qemu-devel] [PATCH 2/2] hw/ppc: deprecate the machine type 'prep', replaced by '40p'

2018-08-10 Thread Hervé Poussineau
Hello, Le 10/08/2018 à 18:17, Programmingkid a écrit : Can a real 40p machine boot Windows NT 4.0 PowerPC? Yes. A real 40p machine is able to run (at least): - Windows NT (up to 4.0 SP1) - AIX (up to 4.3.3) - the beta of OS/2 PowerPC - Solaris - Linux - NetBSD/PReP However, Windows NT

Re: [Qemu-devel] [PATCH 1/2] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-08-09 Thread Hervé Poussineau
Le 10/08/2018 à 03:04, David Gibson a écrit : On Thu, Aug 09, 2018 at 10:40:09PM +0200, Hervé Poussineau wrote: OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff Use it, instead of relying on the presence of a proprietary firmware. Uh.. openhackware might be, well

[Qemu-devel] [PATCH] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-08-09 Thread Hervé Poussineau
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff Use it, instead of relying on an unmaintained and very limited firmware. Signed-off-by: Hervé Poussineau --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c

[Qemu-devel] [PATCH 1/2] hw/ppc: on 40p machine, change default firmware to OpenBIOS

2018-08-09 Thread Hervé Poussineau
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff Use it, instead of relying on the presence of a proprietary firmware. Signed-off-by: Hervé Poussineau --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index

[Qemu-devel] [PATCH 0/2] ppc: deprecate 'prep' machine

2018-08-09 Thread Hervé Poussineau
Hello, These two small patches deprecate the PPC 'prep' machine in favor of the '40p' machine. This is already flagged as 'Future candidate' for removal in https://wiki.qemu.org/Features/LegacyRemoval Herv� Hervé Poussineau (2): hw/ppc: on 40p machine, change default firmware to OpenBIOS

[Qemu-devel] [PATCH 2/2] hw/ppc: deprecate the machine type 'prep', replaced by '40p'

2018-08-09 Thread Hervé Poussineau
system (like NetBSD 7.1.2) Signed-off-by: Hervé Poussineau --- hw/ppc/prep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 1558855247..fbcaebabc0 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -676,6 +676,7 @@ static void ppc_prep_init(MachineState

Re: [Qemu-devel] [PATCH 1/2] hw/display/vga-isa-mm: Convert away from old_mmio

2018-08-02 Thread Hervé Poussineau
ay/vga-isa-mm.c | 60 + 1 file changed, 13 insertions(+), 47 deletions(-) Note: this device is only used by the MIPS "pica61" board, not the "magnum" one. The commit message may be changed accordingly. Reviewed-by: Hervé Poussineau Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 1/3] hw/ppc/prep: Remove ifdeffed-out stub of XCSR code

2018-08-02 Thread Hervé Poussineau
functions. Remove it entirely. Signed-off-by: Peter Maydell --- hw/ppc/prep.c | 97 +++ 1 file changed, 4 insertions(+), 93 deletions(-) Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [RFC v3 09/10] dp8393x: manage big endian bus

2018-07-08 Thread Hervé Poussineau
Le 08/07/2018 à 23:11, Peter Maydell a écrit : On 28 June 2018 at 00:29, Laurent Vivier wrote: This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau --- hw/net/dp8393x.c | 88

Re: [Qemu-devel] [RFC v3 08/10] hw/m68k: add a dummy SWIM floppy controller

2018-06-28 Thread Hervé Poussineau
Le 28/06/2018 à 01:29, Laurent Vivier a écrit : Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/block/Makefile.objs | 1 + hw/block/swim.c | 284 include/hw/block/swim.h |

Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function

2018-06-27 Thread Hervé Poussineau
include/hw/scsi/esp.h |  5 -   3 files changed, 16 insertions(+), 38 deletions(-) Ping? Is anyone able to test the MIPS jazz board with these patches at all? Tested-by: Hervé Poussineau

Re: [Qemu-devel] [RFC 12/13] dp8393x: put DMA temp buffer in the state, not in the stack

2018-06-09 Thread Hervé Poussineau
deletions(-) Works OK on NetBSD 5.1/arc on MIPS Magnum. Tested-by: Hervé Poussineau

Re: [Qemu-devel] [RFC 06/13] ESP: add pseudo-DMA as used by Macintosh

2018-06-09 Thread Hervé Poussineau
deletions(-) Works OK on NetBSD 5.1/arc on MIPS Magnum. Tested-by: Hervé Poussineau

Re: [Qemu-devel] [RFC 13/13] dp8393x: fix receiving buffer exhaustion

2018-06-09 Thread Hervé Poussineau
insertions(+), 15 deletions(-) Works OK on NetBSD 5.1/arc on MIPS Magnum. Tested-by: Hervé Poussineau

Re: [Qemu-devel] [RFC 11/13] dp8393x: manage big endian bus

2018-06-09 Thread Hervé Poussineau
deletions(-) Works OK on NetBSD 5.1/arc on MIPS Magnum. Tested-by: Hervé Poussineau

Re: [Qemu-devel] [RFC 10/13] dp8393x: fix dp8393x_receive

2018-06-09 Thread Hervé Poussineau
p8393x_reset(DeviceState *dev) NACK. This breaks NetBSD 5.1/arc networking. This seems to revert the following commit and change the function return value. commit 409b52bfe199d8106dadf7c5ff3d88d2228e89b5 Author: Hervé Poussineau Date: Wed Jun 3 22:45:48 2015 +0200 net/dp8393x: correc

Re: [Qemu-devel] [PATCH] prep: fix keyboard for the 40p machine

2018-05-24 Thread Hervé Poussineau
k> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- hw/ppc/prep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index a1e7219db6..be4db6a687 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -770,7 +770,6 @@ static void ibm_40p_init(MachineState *ma

Re: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-15 Thread Hervé Poussineau
390x, and the third patch adds a test that certain machines can at least still be started with the "-cdrom" parameter (i.e. that test would have catched the mistake that I did with my SCSI cleanup patch). Reviewed-by: Hervé Poussineau <hpous...@reactos.org> v2: - Use g_spawn

Re: [Qemu-devel] [PATCH] hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices

2018-03-08 Thread Hervé Poussineau
com> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- hw/mips/mips_jazz.c | 7 --- hw/scsi/esp.c | 12 +++- include/hw/scsi/esp.h | 10 +- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c i

Re: [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-08 Thread Hervé Poussineau
Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- hw/ppc/prep.c| 2 +- hw/scsi/lsi53c895a.c | 7 +++ include/hw/pci/pci.h | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/

Re: [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-07 Thread Hervé Poussineau
Le 07/03/2018 à 10:08, Thomas Huth a écrit : The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the 40p machine you now get: $ ppc64-softmmu/qemu-system-ppc64 -M 40p -cdrom x.iso

Re: [Qemu-devel] [PATCH] tests/boot-serial: Check the 40p machine, too

2018-03-07 Thread Hervé Poussineau
ot; machine, so that this test now also checks some CLI parameters. Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- NB: The 40p machine is currently broken - when the emulator is quit, there is a rcu_read_unlock assertion mess

Re: [Qemu-devel] [PATCH] g364fb: switch to using DirtyBitmapSnapshot

2018-02-08 Thread Hervé Poussineau
Le 08/02/2018 à 19:22, Paolo Bonzini a écrit : This removes the last user of memory_region_test_and_clear_dirty outside memory.c. Cc: Hervé Poussineau <hpous...@reactos.org> Cc: Aurelien Jarno <aurel...@aurel32.net> Cc: Yongbok Kim <yongbok@mips.com> Signed-off-by: Pa

Re: [Qemu-devel] [PATCH] Revert "smbus: do not immediately complete commands"

2018-01-21 Thread Hervé Poussineau
is racy, anyway, if you get interrupted or something while processing, you may miss step (c) in your algorithm and fail. Cc: Hervé Poussineau <hpous...@reactos.org> Cc: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Corey Minyard <cminy...@mvista.com> Would it be possible to l

[Qemu-devel] [PATCH v4 13/16] piix4: add a speaker as specified in datasheet

2018-01-06 Thread Hervé Poussineau
Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> --- hw/isa/piix4.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.

[Qemu-devel] [PATCH v4 15/16] piix4: rename PIIX4 object to piix4-isa

2018-01-06 Thread Hervé Poussineau
Other piix4 parts are already named piix4-ide and piix4-usb-uhci. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> ---

[Qemu-devel] [PATCH v4 11/16] piix4: add a floppy controller, 1 parallel port and 2 serial ports

2018-01-06 Thread Hervé Poussineau
Remove their instanciation from malta board, to not have them twice. Automatically create serial/parallel ports in PIIX4 if not provided. Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.o

[Qemu-devel] [PATCH v4 14/16] piix4: convert reset function to QOM

2018-01-06 Thread Hervé Poussineau
Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> --- hw/isa/piix4.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.

[Qemu-devel] [PATCH v4 12/16] piix4: add a mc146818rtc controller as specified in datasheet

2018-01-06 Thread Hervé Poussineau
Remove mc146818rtc instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> --- hw/isa/piix4.c | 12 hw/mips/mips_mal

[Qemu-devel] [PATCH v4 09/16] piix4: add a i8254 pit controller as specified in datasheet

2018-01-06 Thread Hervé Poussineau
Remove i8254 instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> --- hw/isa/piix4.c | 4 hw/mips/mips_malta.c | 3 ---

[Qemu-devel] [PATCH v4 16/16] piix4: we can now instanciate a PIIX4 with -device

2018-01-06 Thread Hervé Poussineau
Note that the PIC master can't be connected to CPU using the command line, but it's not necessary to have a working ISA bus (for I/O, memory and DMA). Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous

[Qemu-devel] [PATCH v4 10/16] piix4: add a i8042 keyboard/mouse controller as specified in datasheet

2018-01-06 Thread Hervé Poussineau
Remove i8042 instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> --- hw/isa/piix4.c | 3 +++ hw/mips/mips_malta.c | 2 --

  1   2   3   4   5   6   7   8   9   10   >