At Wed, 15 Jun 2016 18:14:37 +0200,
Laurent Vivier wrote:
>
> This patch is the result of coccinelle script
> scripts/coccinelle/typecast.cocci
>
> CC: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
> CC: qemu-bl...@nongnu.org
> Signed-off-by: Laurent Vivier <lviv
On Mon, Apr 4, 2016 at 10:04 PM, Paolo Bonzini wrote:
> I am curious about why overlapping_queue is required for sheepdog.
> Overlapping requests have unspecified outcome so the CoQueue is not
> necessary as long as the server doesn't crash or return an error.
>
> Hitoshi,
On Tue, Mar 22, 2016 at 1:33 PM, Takashi Menjo <menjo.taka...@lab.ntt.co.jp>
wrote:
> Errors have been ignored or not propagated in some code paths
> in sd_snapshot_delete(). This patch adds error handling.
>
> Cc: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
> Cc:
On Thu, Mar 3, 2016 at 1:36 AM, Jeff Cody wrote:
> On Wed, Mar 02, 2016 at 05:32:11PM +0100, Max Reitz wrote:
> > On 02.03.2016 17:24, Jeff Cody wrote:
> > > The function qemu_strtoul() reads 'unsigned long' sized data,
> > > which is larger than uint32_t on 64-bit machines.
>
+
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
Thanks a lot for your fix!
Reviewed-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
Thanks,
Hitoshi
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 8739acc..87f0027 100644
> -
On Wed, Dec 23, 2015 at 9:22 PM, Hitoshi Mitake <
mitake.hito...@lab.ntt.co.jp> wrote:
> From: Vasiliy Tolstov <v.tols...@selfip.ru>
>
> This patch implements a blockdriver function bdrv_snapshot_delete() in
> the sheepdog driver. With the new function, snapshots of sheepd
From: Vasiliy Tolstov <v.tols...@selfip.ru>
This patch implements a blockdriver function bdrv_snapshot_delete() in
the sheepdog driver. With the new function, snapshots of sheepdog can
be deleted from libvirt.
Cc: Jeff Cody <jc...@redhat.com>
Signed-off-by: Hitoshi Mitake
On Wed, Dec 2, 2015 at 1:12 AM, Vasiliy Tolstov wrote:
> Signed-off-by: Vasiliy Tolstov
> ---
> block/sheepdog.c | 59
> ++--
> 1 file changed, 57 insertions(+), 2 deletions(-)
>
Seems that your
On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov <v.tols...@selfip.ru> wrote:
> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>:
>> n the commit 96b14ff85acf, requests for overlapping areas are
>> serialized. However, it cannot handle a case of
On Fri, Sep 18, 2015 at 6:49 PM, Kevin Wolf wrote:
> Am 18.09.2015 um 11:03 hat Vasiliy Tolstov geschrieben:
>> 2015-09-18 12:02 GMT+03:00 Kevin Wolf :
>> > Doesn't sheepdog already support storing snapshots in the same image?
>> > I thought it would just work;
On Fri, Sep 4, 2015 at 5:51 PM, Hitoshi Mitake <mitake.hito...@gmail.com> wrote:
> On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov <v.tols...@selfip.ru> wrote:
>> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>:
>>> This patch refines di
On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov <v.tols...@selfip.ru> wrote:
> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>:
>> This patch refines discard support of the sheepdog driver. The
>> existing discard mechanism was implemented
unconditionally.
With this patch, the driver just updates an inode object for updating
reference. Removing the object is done in sheep process side.
Cc: Teruaki Ishizaki <ishizaki.teru...@lab.ntt.co.jp>
Cc: Vasiliy Tolstov <v.tols...@selfip.ru>
Cc: Jeff Cody <jc...@redhat.com>
Signed-off-
. This patch solves the problem.
Hitoshi Mitake (2):
sheepdog: use per AIOCB dirty indexes for non overlapping requests
sheepdog: refine discard support
block/sheepdog.c | 92 +---
1 file changed, 55 insertions(+), 37 deletions(-)
--
1.9.1
i.teru...@lab.ntt.co.jp>
Cc: Vasiliy Tolstov <v.tols...@selfip.ru>
Cc: Jeff Cody <jc...@redhat.com>
Signed-off-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
---
block/sheepdog.c | 63 +++-
1 file changed, 35 insertions(+), 28 delet
, why don't you fork the block
driver, too?
Thanks,
Hitoshi
Cc: Jeff Cody jc...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Teruaki Ishizaki ishizaki.teru...@lab.ntt.co.jp
Cc: Vasiliy Tolstov v.tols...@selfip.ru
Cc: Hitoshi Mitake mitake.hito
...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Teruaki Ishizaki ishizaki.teru...@lab.ntt.co.jp
Cc: Vasiliy Tolstov v.tols...@selfip.ru
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 152 ++-
1 file changed
header to use block_size_shift specified by user.
---
block/sheepdog.c | 155
++---
include/block/block_int.h |1 +
2 files changed, 134 insertions(+), 22 deletions(-)
Looks good to me.
Acked-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
At Thu, 12 Feb 2015 15:42:17 +0800,
Liu Yuan wrote:
On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote:
At Thu, 12 Feb 2015 15:00:49 +0800,
Liu Yuan wrote:
On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote:
At Tue, 10 Feb 2015 18:35:58 +0800,
Liu Yuan
At Thu, 12 Feb 2015 15:00:49 +0800,
Liu Yuan wrote:
On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote:
At Tue, 10 Feb 2015 18:35:58 +0800,
Liu Yuan wrote:
On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote:
(2015/02/10 17:58), Liu Yuan wrote:
On Tue
At Tue, 10 Feb 2015 18:35:58 +0800,
Liu Yuan wrote:
On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote:
(2015/02/10 17:58), Liu Yuan wrote:
On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote:
(2015/02/10 12:10), Liu Yuan wrote:
On Tue, Jan 27, 2015 at
At Mon, 2 Feb 2015 12:36:00 +0100,
Kevin Wolf wrote:
Am 02.02.2015 um 10:51 hat Hitoshi Mitake geschrieben:
At Thu, 22 Jan 2015 18:08:11 +0900,
Hitoshi Mitake wrote:
Calling error_get_progname() in the context of qemu-io can cause
segmentation fault because qemu-io doesn't
Hi Peter,
Sorry for my late reply.
At Thu, 22 Jan 2015 10:07:27 +,
Peter Maydell wrote:
On 22 January 2015 at 09:08, Hitoshi Mitake
mitake.hito...@lab.ntt.co.jp wrote:
Calling error_get_progname() in the context of qemu-x86_64 can cause
segmentation fault because linux-user/main.c
At Thu, 22 Jan 2015 18:08:11 +0900,
Hitoshi Mitake wrote:
Calling error_get_progname() in the context of qemu-io can cause
segmentation fault because qemu-io doesn't initialize its progname
with error_set_progname(). This patch adds the initialization.
Currently, the missing call
specified by user.
---
block/sheepdog.c | 140
++---
include/block/block_int.h |1 +
2 files changed, 119 insertions(+), 22 deletions(-)
Looks good to me.
Acked-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
Thanks,
Hitoshi
it soon).
v2:
- pass argv[0] directly to error_set_progname() without calling basename
- add initialization to commands other than qemu-io
The thread of v1 can be found here:
http://lists.gnu.org/archive/html/qemu-devel/2014-08/msg01502.html
Hitoshi Mitake (4):
qemu-io: initialize progname
doesn't use error_get_progname(). This patch
is a proactive action.
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
qemu-nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index
qemu-x86_64 doesn't use error_get_progname(). This
patch is a proactive action.
Cc: Riku Voipio riku.voi...@iki.fi
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
linux-user/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux
use error_get_progname(). This patch
is a proactive action.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
qemu-io.c | 1 +
1 file changed, 1 insertion(+)
v2:
- pass
error_get_progname(). This patch
is a proactive action.
Cc: Michael Roth mdr...@linux.vnet.ibm.com
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
qga/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/main.c b/qga/main.c
index 9939a2b
At Tue, 20 Jan 2015 16:14:28 +0900,
Teruaki Ishizaki wrote:
Previously, qemu block driver of sheepdog used hard-coded VDI object size.
This patch enables users to handle block_size_shift value for
calculating VDI object size.
When you start qemu, you don't need to specify additional
At Tue, 13 Jan 2015 17:41:12 +0900,
Teruaki Ishizaki wrote:
Previously, qemu block driver of sheepdog used hard-coded VDI object size.
This patch enables users to handle block_size_shift value for
calculating VDI object size.
When you start qemu, you don't need to specify additional
At Mon, 22 Dec 2014 17:41:33 +0800,
$B=y.$AAz(B wrote:
[1 text/plain; UTF-8 (7bit)]
hi,all,
when i use `qemu-img snapshot -c test-s sheepdog:test` to create a
snapshot of sheepdog vdi,the snapshot's lock not be released.
root@hty-compute1:~/qemu# ./qemu-img create sheepdog:test
Hi Stefan, Eric, Sorry for my late reply.
At Tue, 2 Sep 2014 16:29:14 +0100,
Stefan Hajnoczi wrote:
[1 text/plain; us-ascii (quoted-printable)]
On Thu, Aug 28, 2014 at 03:18:48PM +0900, Hitoshi Mitake wrote:
At Wed, 27 Aug 2014 06:43:49 -0600,
Eric Blake wrote:
[1 text/plain
At Wed, 27 Aug 2014 06:43:49 -0600,
Eric Blake wrote:
[1 text/plain; UTF-8 (quoted-printable)]
On 08/26/2014 11:34 PM, Hitoshi Mitake wrote:
{execute: blkdebug-set-rules, arguments: {device: ide0-hd0,
rules:[{event: write_aio, type: inject-error, immediately:
Why 'write_aoi'? New
://docs.openstack.org/developer/swift/howto_installmultinode.html
[3] http://www.amazon.com/dp/B00C93QFHI
[4] https://github.com/adrahon/vagrant-kvm
Cc: Eric Blake ebl...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Hitoshi Mitake mitake.hito
At Tue, 26 Aug 2014 20:54:57 -0600,
Eric Blake wrote:
On 08/26/2014 07:59 PM, Hitoshi Mitake wrote:
This patch makes the fault injection functionality of blkdebug
callable from QMP. Motivation of this change is for testing and
debugging distributed systems. Ordinal distributed systems
At Wed, 13 Aug 2014 08:20:53 -0600,
Eric Blake wrote:
[1 text/plain; UTF-8 (quoted-printable)]
On 08/12/2014 10:48 PM, Hitoshi Mitake wrote:
This patch makes the fault injection functionality of blkdebug
callable from QMP. Motivation of this change is for testing and
debugging
At Wed, 13 Aug 2014 15:33:38 +0100,
Stefan Hajnoczi wrote:
[1 text/plain; us-ascii (quoted-printable)]
On Wed, Aug 13, 2014 at 01:48:41PM +0900, Hitoshi Mitake wrote:
@@ -485,6 +493,10 @@ static BlockDriverAIOCB
*blkdebug_aio_readv(BlockDriverState *bs,
BDRVBlkdebugState *s = bs
/B00C93QFHI
[4] https://github.com/adrahon/vagrant-kvm
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/blkdebug.c | 80 +++-
qapi-schema.json | 39
Calling error_get_progname() in the context of qemu-io can cause
segmentation fault because qemu-io doesn't initialize its progname
with error_set_progname(). This patch adds the initialization.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Hitoshi Mitake
At Mon, 11 Aug 2014 13:20:38 +0200,
Markus Armbruster wrote:
Hitoshi Mitake mitake.hito...@lab.ntt.co.jp writes:
Calling error_get_progname() in the context of qemu-io can cause
segmentation fault because qemu-io doesn't initialize its progname
with error_set_progname(). This patch adds
At Mon, 11 Aug 2014 15:38:21 +0100,
Stefan Hajnoczi wrote:
[1 text/plain; us-ascii (quoted-printable)]
On Mon, Aug 11, 2014 at 03:50:03PM +0900, Hitoshi Mitake wrote:
Calling error_get_progname() in the context of qemu-io can cause
segmentation fault because qemu-io doesn't initialize its
At Fri, 8 Aug 2014 15:49:37 +0800,
Liu Yuan wrote:
On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote:
At Fri, 8 Aug 2014 13:20:39 +0800,
Liu Yuan wrote:
On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote:
The update is required for supporting iSCSI
At Fri, 8 Aug 2014 14:43:16 +0800,
Liu Yuan wrote:
On Fri, Aug 08, 2014 at 03:17:59PM +0900, Hitoshi Mitake wrote:
At Fri, 8 Aug 2014 13:31:39 +0800,
Liu Yuan wrote:
On Thu, Aug 07, 2014 at 04:28:40PM +0900, Hitoshi Mitake wrote:
Recently, sheepdog revived its VDI locking
Recently, sheepdog revived VDI locking functionality. This patchset
updates sheepdog driver of QEMU for this feature.
v2:
- don't handle SD_RES_VDI_NOT_LOCKED as a special case
Hitoshi Mitake (2):
sheepdog: adopting protocol update for VDI locking
sheepdog: improve error handling for a case
Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@gmail.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
v2:
- don't handle SD_RES_VDI_NOT_LOCKED as a special case
block/sheepdog.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
...@gmail.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 8d9350c..36f76f0 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -103,6 +103,9
Recently, sheepdog revived VDI locking functionality. This patchset
updates sheepdog driver of QEMU for this feature.
v3:
- keep backward compatibility
v2:
- don't handle SD_RES_VDI_NOT_LOCKED as a special case
Hitoshi Mitake (2):
sheepdog: adopting protocol update for VDI locking
...@gmail.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
v3:
- keep backward compatibility
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 8d9350c..3da5ea2 100644
--- a/block/sheepdog.c
+++ b
Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@gmail.com
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 2 ++
1 file changed, 2 insertions(+)
v2:
- don't handle SD_RES_VDI_NOT_LOCKED as a special case
diff --git
At Fri, 8 Aug 2014 13:20:39 +0800,
Liu Yuan wrote:
On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote:
The update is required for supporting iSCSI multipath. It doesn't
affect behavior of QEMU driver but adding a new field to vdi request
struct is required.
Cc: Kevin Wolf
At Fri, 8 Aug 2014 13:31:39 +0800,
Liu Yuan wrote:
On Thu, Aug 07, 2014 at 04:28:40PM +0900, Hitoshi Mitake wrote:
Recently, sheepdog revived its VDI locking functionality. This patch
updates sheepdog driver of QEMU for this feature:
1. Improve error message when QEMU fails to acquire
: Stefan Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index
Recently, sheepdog revived VDI locking functionality. This patch
updates sheepdog driver of QEMU for this feature.
Hitoshi Mitake (2):
sheepdog: adopting protocol update for VDI locking
sheepdog: improve error handling for a case of failed lock
block/sheepdog.c | 12 +++-
1 file
...@lab.ntt.co.jp
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 8d9350c..36f76f0 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -103,6 +103,9
:
- corrrect wrong spelling in the commit log of 2nd patch
Hitoshi Mitake (2):
sheepdog: fix vdi object update after live snapshot
sheepdog: reload only header in a case of live snapshot
block/sheepdog.c | 49 +
1 files changed, 29 insertions(+), 20
sheepdog driver doesn't need to read data_vdi_id[] when a live snapshot is
created.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Hitoshi Mitake mitake.hito
, it results object
leaking
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
v3:
- update commit log
block/sheepdog.c | 40
-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 40 +++-
1 files changed, 23 insertions(+), 17 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 4ecbf5f..637e57f 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
in the commit log of 2nd patch
Hitoshi Mitake (2):
sheepdog: fix vdi object update after live snapshot
sheepdog: reload only header in a case of live snapshot
block/sheepdog.c | 49 +
1 files changed, 29 insertions(+), 20 deletions(-)
sheepdog driver doesn't need to read data_vdi_id[] when a live
snapshot is created.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Hitoshi Mitake mitake.hito
On Tue, Jun 3, 2014 at 9:41 PM, Liu Yuan namei.u...@gmail.com wrote:
On Tue, Jun 03, 2014 at 01:54:21PM +0900, Hitoshi Mitake wrote:
sheepdog driver should decide a write request is COW or not based on
inode object which is active when the write request is issued.
Cc: Kevin Wolf kw
Current sheepdog driver has two problems in a mechanism of inode
object reloading for live snapshot. It causes inconsistent state of
snapshot volumes. A new GC algorithm implemented in sheepdog exposes
the problems. This patchset contains bugfixes for them.
Hitoshi Mitake (2):
sheepdog: fix vdi
-off-by: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp
---
block/sheepdog.c | 40 +++-
1 file changed, 23 insertions(+), 17 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 2c3fb01..8266382 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
sheepdog dirver doesn't need to read data_vdi_id[] when a live
snapshot is created.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Liu Yuan namei.u...@gmail.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Hitoshi Mitake mitake.hito
On Tue, Jun 3, 2014 at 12:48 AM, Eric Blake ebl...@redhat.com wrote:
On 06/02/2014 09:06 AM, Hitoshi Mitake wrote:
sheepdog dirver doesn't need to read data_vdi_id[] when a live
s/dirver/driver/
Thanks for your comment. I'll send v2 later.
Thanks,
Hitoshi
snapshot is created.
--
Eric
Hi QEMU list,
I have a question about life cycle of QEMU's stable branches. Is there
an explicit support period for the stable branches?
We are maintaining stable branches of sheepdog, distributed block
storage system for QEMU. The stable branches of sheepdog corresponds
to the stable branches
68 matches
Mail list logo