Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code

2016-07-15 Thread Hulin, Patrick - 0559 - MITLL
Hi all, Just noticed this patch and wanted to leave a quick comment. The original issue wasn't with cross-page writes - it was with cross-TB writes. Cross-page writes become an issue once you reverse the order of the loop, so that part of the patch is necessary. But someone might want to leave

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-20 Thread Hulin, Patrick - 0559 - MITLL
On Aug 19, 2014, at 2:16 AM, Paolo Bonzini wrote: > Il 18/08/2014 22:50, Hulin, Patrick - 0559 - MITLL ha scritto: >>>> Correct. Doesn¹t work. Haven¹t fully diagnosed why, but it doesn¹t seem >>>> to ever hit the current_tb_modified passage if you invalidate beforehand

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-18 Thread Hulin, Patrick - 0559 - MITLL
On 8/18/14, 1:47 PM, "Hulin, Patrick - 0559 - MITLL" wrote: >On Aug 18, 2014, at 1:37 PM, Richard Henderson wrote: > >>On 08/16/2014 10:21 PM, Paolo Bonzini wrote: >>>>>Would it work to just call tb_invalidate_phys_page_range before the >>>>>

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-18 Thread Hulin, Patrick - 0559 - MITLL
On 8/18/14, 1:47 PM, "Hulin, Patrick - 0559 - MITLL" wrote: >On Aug 17, 2014, at 1:21 AM, Paolo Bonzini wrote: > >> Il 15/08/2014 23:49, Hulin, Patrick - 0559 - MITLL ha scritto: >>>>> In this case, the write is 8 bytes and unaligned, so it gets split >

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-18 Thread Hulin, Patrick - 0559 - MITLL
On Aug 17, 2014, at 1:21 AM, Paolo Bonzini wrote: > Il 15/08/2014 23:49, Hulin, Patrick - 0559 - MITLL ha scritto: >>>> In this case, the write is 8 bytes and unaligned, so it gets split >>>> into 8 single-byte writes. In stock QEMU, these writes are done in >>

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-18 Thread Hulin, Patrick - 0559 - MITLL
On Aug 18, 2014, at 1:37 PM, Richard Henderson wrote: > On 08/16/2014 10:21 PM, Paolo Bonzini wrote: Would it work to just call tb_invalidate_phys_page_range before the helper_ret_stb loop? > > I doubt it. Correct. Doesn’t work. Haven’t fully diagnosed why, but it doesn’t seem to eve

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-15 Thread Hulin, Patrick - 0559 - MITLL
On Aug 15, 2014, at 4:48 PM, Paolo Bonzini wrote: > Il 13/08/2014 20:36, Hulin, Patrick - 0559 - MITLL ha scritto: >> Hi QEMU devs, >> >> QEMU 2.10 does not currently run Windows 7 64-bit without KVM. There >> have been a few threads about this over the past

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-14 Thread Hulin, Patrick - 0559 - MITLL
I suppose I should probably add a tl;dr. I have a diagnosis of the reason Windows 7 64-bit won’t run without KVM, as well as a hack to fix it, but I’d like input on a real fix. Details below. On Aug 13, 2014, at 2:36 PM, Hulin, Patrick - 0559 - MITLL wrote: > Hi QEMU devs, > >

[Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-13 Thread Hulin, Patrick - 0559 - MITLL
Hi QEMU devs, QEMU 2.10 does not currently run Windows 7 64-bit without KVM. There have been a few threads about this over the past few years (such as  https://bugs.launchpad.net/qemu/+bug/921208 and  http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02603.html), but the problem was never