Daniel P. Berrangé writes ("Re: [RFC v3 13/32] rust: use vendored-sources"):
> On Thu, Sep 09, 2021 at 08:29:58PM +0400, Marc-André Lureau wrote:
> > True, at least on Fedora, there is machinery to package "regular" Rust
> > programs/crates in an automated way. Vendoring dependencies should work
>
Daniel P. Berrangé writes ("Re: [RFC v3 13/32] rust: use vendored-sources"):
> Yes, distros do have machinery for this, although it is often
> hard to fit in with it when you have a mixed language project.
> Their machinery typically assumes pure single language project,
> so would work nicer if an
Marc-André Lureau writes ("Re: [RFC v3 13/32] rust: use vendored-sources"):
> Yes, this is the shim to provide a C ABI QMP handler from Rust. This is where
> all the FFI<->Rust conversion takes place.
>
> The "safe" code is qga/qmp/vcpus.rs. However, there is no
> documentation there, since it's n
Marc-André Lureau writes ("Re: [RFC v3 13/32] rust: use vendored-sources"):
> You can start by reading `cargo doc -p common --open`. The generated
> code needs some environment variables set, so `cargo doc -p qga`
> will fail unless you set the environment variable
>
> MESON_BUILD_ROOT=`pwd` cargo
Marc-André Lureau writes ("Re: [RFC v3 13/32] rust: use vendored-sources"):
> On Wed, Sep 8, 2021 at 7:55 PM Ian Jackson wrote:
> > git submodules are just awful IMO.
>
> Yes, but it's often (always?) the user fault.
I must disagree in the strongest possib
Marc-André Lureau writes ("Re: [RFC v3 13/32] rust: use vendored-sources"):
> Hmm, I do "cargo vendor --versioned-dirs ../rust/vendored" to vendor crates.
>
> It seems cc was updated, and I didn't update the submodule accordingly. For
> reference, this is the dependency tree that WFM:
git submodu
marcandre.lur...@redhat.com writes ("[RFC v3 13/32] rust: use
vendored-sources"):
> Most likely, QEMU will want tighter control over the sources, rather
> than relying on crates.io downloading, use a git submodule with all the
> dependencies. However, cargo --offline was added in 1.36.
Hi.
pm215
Peter Maydell writes ("Re: [PULL v2 00/13] misc patches removing deprecated
features"):
> On Thu, 18 Mar 2021 at 09:30, Daniel P. Berrangé wrote:
> >
> > Remove many old deprecated features
> >
> > The following features have been d
Eric Blake writes ("Re: [RFC PATCH 1/7] error reporting: Introduce errnoval
parameter to vreport"):
> On 04/26/2018 12:32 PM, Ian Jackson wrote:
> > But, 0 might be fed to strerror. This is not normally deliberate, but
> > it does occor. It is not unusual for peopl
-by from Thomas
Huth. I have stripped off the per-patch-series-verson update
comments.
Anthony PERARD (1):
xen: link against xentoolcore
Ian Jackson (13):
checkpatch: Add xendevicemodel_handle to the list of types
Peter Maydell writes ("Re: [PULL v9 00/16] xen: xen-domid-restrict
improvements"):
> On 26 April 2018 at 18:36, Ian Jackson wrote:
> > I can do that. Alternatively you could manually verify the signature
> > on my email and observe that it mentions the correct commit
Eric Blake writes ("Re: [RFC PATCH 5/7] error reporting: Provide
error_report_errnoval (and error_vreport_errnoval)"):
> On 04/26/2018 11:53 AM, Ian Jackson wrote:
> > I have chosen to provide all of
> >error_report_errno error_vreport_errno
>
Eric Blake writes ("Re: [RFC PATCH 3/7] error reporting: Use error_report_errno
in obvious places"):
> Misses a lot of two-line instances, such as:
> $ git grep -A1 error_report | grep -C1 strerror.errno
> ...
...
> If we're going to clean up these instances, we might as well look harder
> for the
Peter Maydell writes ("Re: [PULL v9 00/16] xen: xen-domid-restrict
improvements"):
> Hi -- my apply-pullreq script thinks this isn't a signed tag:
>
> error: remotes/iwj/for-upstream.depriv-2: cannot verify a non-tag object of
> type commit. Does not appear to be a signed tag
It isn't. It's not
Eric Blake writes ("Re: [RFC PATCH 1/7] error reporting: Introduce errnoval
parameter to vreport"):
> On 04/26/2018 11:53 AM, Ian Jackson wrote:
> > We use strerror rather than strerror_r because strerror_r presents
> > portability difficulties. Replacing str
still at least 30-40 potential callers of the latter.
No callers yet so no functional change.
Signed-off-by: Ian Jackson
---
include/qemu/error-report.h | 5 +
util/qemu-error.c | 28
2 files changed, 33 insertions(+)
diff --git a/include/qemu/error
This will let us replace a lot of open coded calls to perror,
strerror, etc.
No callers yet so no functional change.
Signed-off-by: Ian Jackson
---
include/qemu/error-report.h | 2 ++
util/qemu-error.c | 28
2 files changed, 30 insertions(+)
diff --git
his patch does not
contain any cleanups of the occasional idiosyncratic messages. That
is left to the future.
No functional change, since error_report_errnoval does exactly what
this previous open-coded pattern does.
Signed-off-by: Ian Jackson
---
block/nvme.c | 2 +-
blo
.
No functional change yet.
Signed-off-by: Ian Jackson
---
util/qemu-error.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/util/qemu-error.c b/util/qemu-error.c
index a25d3b9..9acc4b5 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -191,12
ot contain
any cleanups of the occasional idiosyncratic messages. That is left
to the future.
No functional change, since error_report_errno does exactly what this
previous open-coded pattern does.
Signed-off-by: Ian Jackson
---
audio/wavcapture.c | 2 +-
hw/i386/xen/xen-hvm.c| 2 +-
Signed-off-by: Ian Jackson
---
HACKING | 1 +
1 file changed, 1 insertion(+)
diff --git a/HACKING b/HACKING
index 4125c97..95563a3 100644
--- a/HACKING
+++ b/HACKING
@@ -189,6 +189,7 @@ error_report() or error_vreport() from error-report.h.
This ensures the
error is reported in the right
erence from the previous patch.
The effect is that a lot of messages which used to say
something went wrong,
now say
something went wrong:
And of course we remove a lot of open-coded calls.
Signed-off-by: Ian Jackson
---
block/sheepdog.c | 16
scsi/qemu-pr-helper.c
From: Ian Jackson
This is apropos if a suggestion from Philippe. I've compile-tested
this but not executed it yet. Let me know what you think.
Thanks,
Ian.
Ian Jackson (7):
error reporting: Introduce errnoval parameter to vreport
error reporting: Provide error_report_errno
perror() is defined to fprintf(stderr,...). HACKING says
fprintf(stderr,...) is wrong. So perror() is too.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
CC: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
os-posix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index
x27;t
know what gid we ought to use (since uids may eppear in multiple
passwd file entries with different gids).
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
Reviewed-by: Markus Armbruster
---
not bash, it is necessary to say bash
./configure to get the extra debug info in the log.
Suggested-by: Eric Blake
Signed-off-by: Ian Jackson
CC: Kent R. Spillner
CC: Janosch Frank
CC: Thomas Huth
CC: Peter Maydell
CC: Paolo Bonzini
Tested-by: Thomas Huth
---
configure | 5 +
1 file
I'm going to be editing this function and it makes sense to clean up
this style problem in advance.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
Reviewed-by: Peter Maydell
Reviewed-by: Thomas Huth
---
os-posix.c
This is called just before os_setup_post. Currently none of the
accelerators provide this hook, but the Xen one is going to provide
one in a moment.
Signed-off-by: Ian Jackson
Reviewed-by: Eduardo Habkost
---
accel/accel.c | 9 +
include/sysemu/accel.h | 3 +++
vl.c
The last user was just removed; remove this function, accordingly.
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
---
include/hw/xen/xen_common.h | 22 --
1 file changed, 22 deletions(-)
diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
index
xc_interface_open etc. is not going to work if we have dropped
privilege, but xendevicemodel_shutdown will if everything is new
enough.
xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so
provide a stub for earlier versions.
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
From: Anthony PERARD
Xen libraries in 4.10 include a new xentoolcore library. This
contains the xentoolcore_restrict_all function which we are about to
want to use.
Signed-off-by: Ian Jackson
Acked-by: Stefano Stabellini
---
configure | 9 +++--
1 file changed, 7 insertions(+), 2
ers would be at the bottom of the
file, so that they can naturally benefit from the compatibility layers
for earlier version. But that's rather too much for this series.)
No functional change.
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
includ
From: Ian Jackson
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
The following changes since commit b8846a4d6352b2a1d2012f8b3b9115640524aeda:
vl.c: new function serial_max_hds() (2018-04-26 13:58:29 +0100)
are available in the git repository at:
https://xenbits.xen.org/git-http/people
CC: Paolo Bonzini
CC: Daniel P. Berrange
Signed-off-by: Ian Jackson
Reviewed-by: Eric Blake
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d52207a..5b8735d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts
fails silently.
* Fix the return values when an error occurs. The functions now
consistently return -1 and set errno.
CC: Ian Jackson
Signed-off-by: Ross Lagerwall
Reviewed-by: Ian Jackson
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
---
configure | 19
, because the
restriction needs to be done very late - after qemu has opened all of
its control fds.
xentoolcore_restrict_all and xentoolcore.h are available in Xen 4.10
and later, only. Provide a compatibility stub. And drop the
compatibility stubs for the old functions.
Signed-off-by: Ian Jackson
is is not a regression in this patch, because
previously the -xen-restrict-domid call was, in fact, simply
ineffective!) We will revisit this in the Xen 4.11 release cycle.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini (maintainer:X86)
CC: Richard Henderson (maintainer:X86)
CC: Eduardo Ha
isten for
state changes.
CC: Ian Jackson
Signed-off-by: Ross Lagerwall
Reviewed-by: Ian Jackson
Acked-by: Anthony PERARD
---
hw/xen/xen-common.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/xen/xen-common.c b/hw/xen/xen-common.c
index 454777c..6ec14c7 100644
---
We are going to want to reuse this.
No functional change.
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
hw/i386/xen/xen-hvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index
> If no one has commented on what seems pretty trivial (especially since
> checkpatch.pl has no official maintainer, but is more of a
> "whoever-touched-it-last" file at the moment), then including the patch
> in your pull request is perfectly acceptable. As a maintainer, it is
> also perfectly ac
(expanding the CC to include everyone that get_maintainer suggests)
Ian Jackson writes ("[PATCH 01/16] checkpatch: Add xendevicemodel_handle to the
list of types"):
> This avoids checkpatch misparsing (as statements) long function
> definitions or declarations, which some
not bash, it is necessary to say bash
./configure to get the extra debug info in the log.
Suggested-by: Eric Blake
Signed-off-by: Ian Jackson
CC: Kent R. Spillner
CC: Janosch Frank
CC: Thomas Huth
CC: Peter Maydell
CC: Paolo Bonzini
---
v8: Fix so that it actually works as intended with bash
perror() is defined to fprintf(stderr,...). HACKING says
fprintf(stderr,...) is wrong. So perror() is too.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
CC: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
---
v7: New
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
Reviewed-by: Philippe Mathieu-Daudé
---
v8: Remove one remaining spurious "\n"
v7: New patch
---
os-posix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
x27;t
know what gid we ought to use (since uids may eppear in multiple
passwd file entries with different gids).
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
Reviewed-by: Markus Armbruster
---
v7: Be
The last user was just removed; remove this function, accordingly.
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
---
include/hw/xen/xen_common.h | 22 --
1 file changed, 22 deletions(-)
diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
index
xc_interface_open etc. is not going to work if we have dropped
privilege, but xendevicemodel_shutdown will if everything is new
enough.
xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so
provide a stub for earlier versions.
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
ers would be at the bottom of the
file, so that they can naturally benefit from the compatibility layers
for earlier version. But that's rather too much for this series.)
No functional change.
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
v2: New pat
We are going to want to reuse this.
No functional change.
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
hw/i386/xen/xen-hvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index
I'm going to be editing this function and it makes sense to clean up
this style problem in advance.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
---
os-posix.c | 10 +-
1 file changed, 5 insertions(+), 5 dele
This is called just before os_setup_post. Currently none of the
accelerators provide this hook, but the Xen one is going to provide
one in a moment.
Signed-off-by: Ian Jackson
Reviewed-by: Eduardo Habkost
---
v7: New patch in this version of the series
---
accel/accel.c | 9
is is not a regression in this patch, because
previously the -xen-restrict-domid call was, in fact, simply
ineffective!) We will revisit this in the Xen 4.11 release cycle.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini (maintainer:X86)
CC: Richard Henderson (maintainer:X86)
CC: Eduardo Ha
, because the
restriction needs to be done very late - after qemu has opened all of
its control fds.
xentoolcore_restrict_all and xentoolcore.h are available in Xen 4.10
and later, only. Provide a compatibility stub. And drop the
compatibility stubs for the old functions.
Signed-off-by: Ian Jackson
From: Anthony PERARD
Xen libraries in 4.10 include a new xentoolcore library. This
contains the xentoolcore_restrict_all function which we are about to
want to use.
Signed-off-by: Ian Jackson
Acked-by: Stefano Stabellini
---
v8: In pkg-config branch, add xentoolcore conditionally.
This
CC: Paolo Bonzini
CC: Daniel P. Berrange
Signed-off-by: Ian Jackson
---
v7: Added comment to commit message about why we are not renaming
this type to CamelCase.
v6.1: New patch
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts
This series provides necessary support for running qemu as a Xen
device model without power equivalent to root. In particular, it
makes -xen-domid-restrict effective.
Compared to v8, it addresses review comments.
01/16 checkpatch: Add xendevicemodel_handle to the list of
r 02/16 AccelC
isten for
state changes.
CC: Ian Jackson
Signed-off-by: Ross Lagerwall
Reviewed-by: Ian Jackson
Acked-by: Anthony PERARD
---
v6: New patch in this version of the series
---
hw/xen/xen-common.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/xen/xen-common.c b/hw/xe
fails silently.
* Fix the return values when an error occurs. The functions now
consistently return -1 and set errno.
CC: Ian Jackson
Signed-off-by: Ross Lagerwall
Reviewed-by: Ian Jackson
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
---
v6.1: Fix printf formats to match types in
Anthony PERARD writes ("Re: [PATCH 05/16] xen: defer call to xen_restrict until
just before os_setup_post"):
> I think this include is not needed anymore, and can go away from the
> patch series.
Yes.
Thanks,
Ian.
Eric Blake writes ("Re: [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump
some extra info under bash"):
> That's still fork-heavy. You could do:
>
> test -n "$BASH_VERSION" && eval '
> echo >>config.log "
> funcs: ${FUNCNAME[*]}
> lines: ${BASH_LINENO[*]}
> files: ${BASH_SOURCE[*]}"'
>
>
Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 15/16] os-posix:
cleanup: Replace perror with error_report"):
> On 04/19/2018 01:45 PM, Ian Jackson wrote:
> > -perror("mlockall");
> > +error_report("mlockall: %s", strerror(
Anthony PERARD writes ("Re: [PATCH 03/16] xen: link against xentoolcore"):
> On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote:
> > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab"
> > -xen_pc="$xen_pc xenevtchn xendevicem
Daniel P. Berrangé writes ("Re: [Qemu-devel] [PATCH 16/16] configure:
do_compiler: Dump some extra info under bash"):
> Personally I'd suggest we add informative messages throughout the
> configure script for each check being run. If people really hate the
> idea of a verbose output from configure
Anthony PERARD writes ("Re: [PATCH 16/16] configure: do_compiler: Dump some
extra info under bash"):
> On Thu, Apr 19, 2018 at 05:45:19PM +0100, Ian Jackson wrote:
> > +funcs: ${FUNCNAME}
> > +lines: ${BASH_LINENO}
> > +files: ${BASH_SOURCE}"
> &
Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 14/16] os-posix:
cleanup: Replace fprintf with error_report in remaining call sites"):
> On 04/19/2018 01:45 PM, Ian Jackson wrote:
> > -fprintf(stderr, "Change of process name not supported by your OS\n");
ed if configure is run with bash. On
systems where /bin/sh is not bash, it is necessary to say bash
./configure to get the extra debug info in the log.
Signed-off-by: Ian Jackson
CC: Kent R. Spillner
CC: Janosch Frank
CC: Thomas Huth
CC: Peter Maydell
CC: Paolo Bonzini
---
v6: Fix commit message wo
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
---
v7: New patch
---
os-posix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index 0f59566..d4cf466 100644
--- a/os-posix.c
+++ b
I'm going to be editing this function and it makes sense to clean up
this style problem in advance.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
---
os-posix.c | 10 +-
1 file changed, 5 insertions(+), 5 dele
perror() is defined to fprintf(stderr,...). HACKING says
fprintf(stderr,...) is wrong. So perror() is too.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
CC: Alistair Francis
---
v7: New patch
---
os-posix.c | 8
1
x27;t
know what gid we ought to use (since uids may eppear in multiple
passwd file entries with different gids).
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
---
v7: Be much more explicit a
This is called just before os_setup_post. Currently none of the
accelerators provide this hook, but the Xen one is going to provide
one in a moment.
Signed-off-by: Ian Jackson
Reviewed-by: Eduardo Habkost
---
v7: New patch in this version of the series
---
accel/accel.c | 9
, because the
restriction needs to be done very late - after qemu has opened all of
its control fds.
xentoolcore_restrict_all and xentoolcore.h are available in Xen 4.10
and later, only. Provide a compatibility stub. And drop the
compatibility stubs for the old functions.
Signed-off-by: Ian Jackson
The last user was just removed; remove this function, accordingly.
Signed-off-by: Ian Jackson
---
include/hw/xen/xen_common.h | 22 --
1 file changed, 22 deletions(-)
diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
index 2eed6fc..5f1402b 100644
--- a
ers would be at the bottom of the
file, so that they can naturally benefit from the compatibility layers
for earlier version. But that's rather too much for this series.)
No functional change.
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
v2: New pat
isten for
state changes.
CC: Ian Jackson
Signed-off-by: Ross Lagerwall
Reviewed-by: Ian Jackson
Acked-by: Anthony PERARD
---
v6: New patch in this version of the series
---
hw/xen/xen-common.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/xen/xen-common.c b/hw/xe
is is not a regression in this patch, because
previously the -xen-restrict-domid call was, in fact, simply
ineffective!) We will revisit this in the Xen 4.11 release cycle.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini (maintainer:X86)
CC: Richard Henderson (maintainer:X86)
CC: Eduardo Ha
xc_interface_open etc. is not going to work if we have dropped
privilege, but xendevicemodel_shutdown will if everything is new
enough.
xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so
provide a stub for earlier versions.
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
From: Anthony PERARD
Xen libraries in 4.10 include a new xentoolcore library. This
contains the xentoolcore_restrict_all function which we are about to
want to use.
Signed-off-by: Ian Jackson
Acked-by: Stefano Stabellini
---
v5: More truthful commit message.
---
configure | 8 +---
1
We are going to want to reuse this.
No functional change.
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
hw/i386/xen/xen-hvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index
fails silently.
* Fix the return values when an error occurs. The functions now
consistently return -1 and set errno.
CC: Ian Jackson
Signed-off-by: Ross Lagerwall
Reviewed-by: Ian Jackson
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
---
v6.1: Fix printf formats to match types in
CC: Paolo Bonzini
CC: Daniel P. Berrange
Signed-off-by: Ian Jackson
---
v7: Added comment to commit message about why we are not renaming
this type to CamelCase.
v6.1: New patch
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts
This series provides necessary support for running qemu as a Xen
device model without power equivalent to root. In particular, it
makes -xen-domid-restrict effective.
Compared to v7, it addresses review comments. As a result, it has
grown a couple of new cleanup patches, including a few that I t
Ian Jackson writes ("Re: [PATCH 01/12] checkpatch: Add xendevicemodel_handle to
the list of types"):
> Paolo Bonzini writes ("Re: [PATCH 01/12] checkpatch: Add
> xendevicemodel_handle to the list of types"):
> > Or just rename it so that it is CamelCase. Then
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new
-runas : facility"):
> Ian Jackson writes:
> > That would defer the getpwnam from argument parsing to os_setup_post.
> > I think that's undesriable.
>
> No argument. But why can
ng global @user_pwd by @user_uid, @user_gid
> and @user_name? --runas with numeric uid and gid would leave @user_name
> null.
That would defer the getpwnam from argument parsing to os_setup_post.
I think that's undesriable.
> Ian Jackson writes:
> > static struct passw
Paolo Bonzini writes ("Re: [PATCH 01/12] checkpatch: Add xendevicemodel_handle
to the list of types"):
> On 08/03/2018 20:02, Ian Jackson wrote:
> > This avoids checkpatch misparsing (as statements) long function
> > definitions or declarations, which sometimes start with
I have folded in the comments so far and made a prototype v7 series,
which is here:
http://xenbits.xen.org/gitweb/?p=people/iwj/qemu.git;a=summary
https://xenbits.xen.org/git-http/people/iwj/qemu.git
git://xenbits.xen.org/people/iwj/qemu.git
In the branch
master..xen-restrict-v7.0
I hav
Ian Jackson writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping
VGA memory"):
> Anthony PERARD writes ("Re: [PATCH 10/12] xen: Use newly added dmops for
> mapping VGA memory"):
> > This patch seems to remove the last users of
> > xen_xc_dom
a separate patch for that.
>From 15dedc627cad96301e4015f1f777fcab3906aba7 Mon Sep 17 00:00:00 2001
From: Ian Jackson
Date: Fri, 27 Oct 2017 11:23:10 +0100
Subject: [PATCH 5/5] scripts/get_maintainer.pl: Print proper error message for
missing $file
If you pass scripts/get_maintainer.pl the name
Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until
just before os_setup_post"):
> Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until
> just before os_setup_post"):
> > How about this ?
>
> And here
Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until
just before os_setup_post"):
> How about this ?
And here's the corresponding change to the Xen-specific patch.
>From d6140681a877c4d468c4fcf5cac075cdffbea22c Mon Sep 17 00:00:00 2001
From: Ian Jack
Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until
just before os_setup_post"):
> Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict
> until just before os_setup_post"):
> > I don't think we should have accele
Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict
until just before os_setup_post"):
> On Thu, Mar 08, 2018 at 05:39:09PM +, Ian Jackson wrote:
> [...]
> > diff --git a/vl.c b/vl.c
> > +xen_setup_post();
>
> I don't think w
For reasons I still don't quite understand, this cover letter was not
sent to the whole CC list so I am doing that by hand now.
Ian Jackson writes ("[PATCH v6 00/11] xen: xen-domid-restrict improvements"):
> This series provides necessary support for running qemu as a Xen
>
no-re...@patchew.org writes ("Re: [Qemu-devel] [PATCH v6 00/11] xen:
xen-domid-restrict improvements"):
> This series seems to have some coding style problems. See output below for
> more information:
Obviously I should have run checkpatch myself. I will send a v6.1.
Ian.
. Berrange
Signed-off-by: Ian Jackson
---
v6.1: New patch
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d1fe79b..3e488f7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -266,6 +266,7 @@ our
x27;t
know what gid we ought to use (since uids may eppear in multiple
passwd file entries with different gids).
Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
---
v6.1: Fix constness of qemu_strtoul end pointer paramete
or message.
Signed-off-by: Ian Jackson
CC: Thomas Huth
CC: Paolo Bonzini
CC: Stefano Stabellini
CC: Anthony PERARD
---
v6: New patch in this version of the series
---
scripts/get_maintainer.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/get_maintainer.pl
ers would be at the bottom of the
file, so that they can naturally benefit from the compatibility layers
for earlier version. But that's rather too much for this series.)
No functional change.
Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
Acked-by: Stefano Stabellini
---
v2: New pat
1 - 100 of 301 matches
Mail list logo
