Re: [PATCH] tcg/tci: fix logic error when registering helpers via FFI

2022-10-28 Thread Icenowy Zheng
在 2022-10-29星期六的 06:28 +1100,Richard Henderson写道: > On 10/28/22 18:21, Icenowy Zheng wrote: > > When registering helpers via FFI for TCI, the inner loop that > > iterates > > parameters of the helper reuses (and thus pollutes) the same > > variable > > used by

Re: [PATCH] linux-user: always translate cmsg when recvmsg

2022-10-28 Thread Icenowy Zheng
在 2022-10-28星期五的 16:12 +0800,Icenowy Zheng写道: > It's possible that a message contains both normal payload and > ancillary > data in the same message, and even if no ancillary data is available > this information should be passed to the target, otherwise the target >

Re: [PATCH] tcg/tci: fix logic error when registering helpers via FFI

2022-10-28 Thread Icenowy Zheng
在 2022-10-28星期五的 10:13 +0100,Alex Bennée写道: > > Icenowy Zheng writes: > > > When registering helpers via FFI for TCI, the inner loop that > > iterates > > parameters of the helper reuses (and thus pollutes) the same > > variable > > used by the outer lo

[PATCH] linux-user: always translate cmsg when recvmsg

2022-10-28 Thread Icenowy Zheng
lized memory if it expects cmsg. Always call the function that translate cmsg when recvmsg, because that function should be empty-cmsg-safe (it creates an empty cmsg in the target). Signed-off-by: Icenowy Zheng --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH] tcg/tci: fix logic error when registering helpers via FFI

2022-10-28 Thread Icenowy Zheng
inner loop. Signed-off-by: Icenowy Zheng --- tcg/tcg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 612a12f58f..adfaf61a32 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -619,6 +619,7 @@ static void tcg_context_init(unsigned max_cpus

Re: [PATCH] hw/sd/allwinner-sdhost: report FIFO water level as 1 when data ready

2022-05-23 Thread Icenowy Zheng
在 2022-05-23星期一的 15:14 +0100,Peter Maydell写道: > On Fri, 20 May 2022 at 13:42, Icenowy Zheng wrote: > > > > U-Boot queries the FIFO water level to reduce checking status > > register > > when doing PIO SD card operation. > > > > Report a FIFO water level

[PATCH] hw/sd/allwinner-sdhost: report FIFO water level as 1 when data ready

2022-05-20 Thread Icenowy Zheng
U-Boot queries the FIFO water level to reduce checking status register when doing PIO SD card operation. Report a FIFO water level of 1 when data is ready, to prevent the code from trying to read 0 words from the FIFO each time. Signed-off-by: Icenowy Zheng --- hw/sd/allwinner-sdhost.c | 7

Re: [PATCH v4] fcntl: Add 32bit filesystem mode

2022-05-19 Thread Icenowy Zheng
hat using 32-bit file syscalls in 32-bit QEMU user on 64-bit hosts are still broken today, and google sent me here. This mail does not get any reply according to linux-ext4 patchwork, so could I ping it? Thanks, Icenowy Zheng > This adds a flag to the fcntl() F_GETFD and F_SETFD operatio

[Qemu-devel] [Bug 1660010] [NEW] AArch64 system emulation cannot execute virt uefi in 2.7 or 2.8

2017-01-27 Thread Icenowy Zheng
Public bug reported: The UEFI firmware file is retrieved from http://snapshots.linaro.org/components/kernel/linaro- edk2/latest/release/qemu64/QEMU_EFI.fd . The error is: ``` TODO /var/lib/abbs/build/tmp.p2dMBBlJ0D/qemu-2.7.0/tci.c:1049: tcg_qemu_tb_exec() /var/lib/abbs/build/tmp.p2dMBBlJ0D/qemu

Re: [Qemu-devel] [PATCH] linux-user: correctly pack target_epoll_event for i386 target

2016-07-23 Thread Icenowy Zheng
22.07.2016, 23:06, "Peter Maydell" : > On 22 July 2016 at 03:30, Icenowy Zheng wrote: >>  According to comments in /usr/include/linux/eventpoll.h, x86_64 have >>  the same memory layout of struct target_epoll_event as i386. So on a >>  aligned host, if x86_64 s

[Qemu-devel] [PATCH] linux-user: correctly pack target_epoll_event for i386 target

2016-07-21 Thread Icenowy Zheng
(core). Signed-off-by: Icenowy Zheng --- linux-user/syscall_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index b43966e..7380bf5 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@ -2547,7

[Qemu-devel] [Bug 1605443] Re: QEMU epoll for i386-linux-user on arm host is broken in 2.6

2016-07-21 Thread Icenowy Zheng
Oh I have sent a patch to qemu-devel mailing list... (maybe the mail is rejected, as I'm using Yandex mail service...) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1605443 Title: QEMU epoll for i

[Qemu-devel] [Bug 1605443] [NEW] QEMU epoll for i386-linux-user on arm host is broken in 2.6

2016-07-21 Thread Icenowy Zheng
Public bug reported: I'm trying to get wine running on qemu-i386 on arm. I found that 2.5.1 is OK, but 2.6 is not. By bisecting, I found commit 928bed6a057cedd6110e634865e021a24029785a is the problem. I reverted this commit, and then epoll is OK now. It seems that the commit broke epoll of qem