** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1913344
Title:
Exynos4210 UART peripheral data loss
Status in QEMU:
Fix Committed
Bug
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1913341
Title:
Chardev behavior breaks polling based devices
Status in QEMU:
Fix Committed
imulate
the hardware environment of an M1 based mac mini.
Feedback would be appreciated on desire for this, implementation
suggestions, critiques (although there's some cleanup I'm saving for
later once I've decided on a more correct approach)
Thanks
Iris Johnson
worse with smaller buffers.
Buglink: https://bugs.launchpad.net/qemu/+bug/1913341
Signed-off-by: Iris Johnson
---
hw/char/exynos4210_uart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c
index 6361df2ad3..51ba862d0b 100644
--- a/hw/char
this
functionality into the exynos4210_uart code instead of modifying
the chardev handling itself.
You can safely disregard this patch. Sorry about the confusion.
Iris
On Sat, Jan 30, 2021 at 9:54 AM Iris Johnson wrote:
> > I don't think this works well enough: if the source isn't r
ou provide a simple use-case or reproducer where we can
> > evaluate how your patch improves the situation?
I can do this, but I don't have anything ready immediately, my test case
isn't
ideal for others to reproduce. But I can attach one later today when I have
that done.
Thanks,
Iris Johnson
and to
add the poll again.
We solve this issue by removing the logic that removes the poll, keeping
the existing logic to only create the poll once there's space for the
first read.
Buglink: https://bugs.launchpad.net/qemu/+bug/1913341
Signed-off-by: Iris Johnson
---
chardev/char-io.c | 6 ++
1 file
properly when the
FIFO is not being used.
Buglink: https://bugs.launchpad.net/qemu/+bug/1913344
Signed-off-by: Iris Johnson
---
hw/char/exynos4210_uart.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c
index 6361df2ad3
Public bug reported:
Currently the Exynos4210 UART (hw/char/exynos4210_uart.c) incorrectly
reports however many empty bytes are available in the FIFO when queried
for receive capacity. However this peripheral supports a polled mode
where only a single byte can be submitted at a time and the FIFO
Public bug reported:
Currently in latest QEMU (9cd69f1a270235b652766f00b94114f48a2d603f at
this time) the behavior of chardev sources is that when processed
(before IO polling occurs), the chardev source will check the amount of
space for reading.
If it reports more than 0 bytes available to
10 matches
Mail list logo