Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 05:55:45PM +0200, Andreas Färber wrote: Am 30.08.2012 20:00, schrieb Jason Baron: Add support for ahci migration. This patch builds upon the patches posted previously by Andreas Faerber: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html (I

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: On 31.08.2012, at 07:23, Jason Baron wrote: On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wrote: Am 23.08.2012 23:09, schrieb Jason Baron: While testing q35, I found that windows 7 (specifically, windows 7 ultimate

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 01:29:46PM -0700, Alexander Graf wrote: On 31.08.2012, at 12:15, Jason Baron jba...@redhat.com wrote: On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: On 31.08.2012, at 07:23, Jason Baron wrote: On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 01:29:46PM -0700, Alexander Graf wrote: On 31.08.2012, at 12:15, Jason Baron jba...@redhat.com wrote: On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: On 31.08.2012, at 07:23, Jason Baron wrote: On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf

[Qemu-devel] [PATCH 0/2] pcie migration fixes

2012-08-30 Thread Jason Baron
Hi, A couple of pcie related migration fixes that I found while testing q35 migration. Thanks, -Jason Jason Baron (2): pcie: drop version_id field for live migration pcie_aer: clear cmask for Advanced Error Interrupt Message Number hw/pci.c |2 +- hw/pcie.h |1 - hw

[Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-30 Thread Jason Baron
. Its valid to update these bits and we must restore this state across migration. Signed-off-by: Jason Baron jba...@redhat.com --- hw/pcie_aer.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/pcie_aer.c b/hw/pcie_aer.c index 3b6981c..6edcd79 100644 --- a/hw

[Qemu-devel] [PATCH 1/2] pcie: drop version_id field for live migration

2012-08-30 Thread Jason Baron
- PCIEDevice to differentiate it from vmstate_pci_device. Signed-off-by: Jason Baron jba...@redhat.com --- hw/pci.c |2 +- hw/pcie.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 3727afa..5386a4f 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -439,7

[Qemu-devel] [PATCH] ahci: add migration support

2012-08-30 Thread Jason Baron
guests on both piix with ahci attached and on q35 (which has a built-in ahci controller). Signed-off-by: Jason Baron jba...@redhat.com --- hw/ide/ahci.c | 64 - hw/ide/ahci.h | 10 + hw/ide/ich.c | 11 +++-- 3 files changed

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-30 Thread Jason Baron
On Fri, Aug 24, 2012 at 06:39:02AM +0200, Alexander Graf wrote: While testing q35, I found that windows 7 (specifically, windows 7 ultimate with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. The failure message is: 'A required cd/dvd device driver is missing.

Re: [Qemu-devel] [RFC v2] ahci: Add support for migration

2012-08-24 Thread Jason Baron
On Thu, Aug 09, 2012 at 10:49:23AM -0400, Jason Baron wrote: On Thu, Aug 09, 2012 at 02:59:54PM +0200, Andreas Färber wrote: Define generic VMState for AHCI and reuse it together with PCI for ICH and on its own for the SysBus version. Note: ICH9 initializes AHCI with 6 ports, which

[Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-23 Thread Jason Baron
with this change. Signed-off-by: Jason Baron jba...@redhat.com --- hw/ide/ahci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 9fe89a5..06c236f 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1199,6 +1199,7 @@ void ahci_reset(AHCIState *s

[Qemu-devel] Q35 OS install status

2012-08-15 Thread Jason Baron
Hi, Linux - Fedora 17: installs and ran memory tests (requires ahci cdrom fixes I posted to install) Fedora 16: installs and ran memory tests Windows --- Windows 7: Wouldn't install due to this error: 'A required cd/dvd device driver is missing. If you have a

Re: [Qemu-devel] Hard freeze for 1.2 today

2012-08-15 Thread Jason Baron
On Wed, Aug 15, 2012 at 09:22:20AM -0500, anth...@codemonkey.ws wrote: Hi, Today is the hard freeze for 1.2. If you have any pull requests and/or patches targetted for the hard freeze, please send them by 3pm US/Central time today and clearly mark them for-1.2. If there are existing

Re: [Qemu-devel] [RFC v2] ahci: Add support for migration

2012-08-09 Thread Jason Baron
field type to uint32_t for compatibility with VMState macros. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Alexander Graf ag...@suse.de Cc: Jason Baron jba...@redhat.com Cc: Kevin Wolf kw...@redhat.com Cc: Juan Quintela quint...@redhat.com Cc: Igor Mitsyanko i.mitsya...@samsung.com

[Qemu-devel] [PATCH] pcie: drop version_id field for live migration

2012-08-08 Thread Jason Baron
- PCIEDevice to differentiate it from vmstate_pci_device. Signed-off-by: Jason Baron jba...@redhat.com --- hw/pci.c |2 +- hw/pcie.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e4e6ad9..8745a55 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -439,7

Re: [Qemu-devel] ahci live migration

2012-08-07 Thread Jason Baron
On Tue, Aug 07, 2012 at 06:13:25PM +0200, Andreas Färber wrote: Hi Jason, Am 07.08.2012 18:01, schrieb Jason Baron: Hi, vmstate_ahci has its 'unmigratable' bit set. Gerd suggested that there was work in this area. Anybody know the status on it? That was me working on it. I have

[Qemu-devel] ahci live migration

2012-08-07 Thread Jason Baron
Hi, vmstate_ahci has its 'unmigratable' bit set. Gerd suggested that there was work in this area. Anybody know the status on it? Thanks, -Jason

[Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption

2012-08-03 Thread Jason Baron
be triggered by guest) 0 sglist fields Jason Baron (2): ahci: Fix ahci cdrom read corruptions for reads 128k ahci: Fix sglist memleak in ahci_dma_rw_buf() dma-helpers.c |1 + hw/ide/ahci.c | 44 +--- hw/ide/internal.h |1 + 3 files

[Qemu-devel] [PATCH 1/2 v2] ahci: Fix ahci cdrom read corruptions for reads 128k

2012-08-03 Thread Jason Baron
that the sglist is property initialized. I've tested this patch using 'dd' testing, and Fedora 17 now correctly boots and installs on q35 with the cdrom ahci controller. Signed-off-by: Jason Baron jba...@redhat.com Tested-by: Andreas Färber afaer...@suse.de --- hw/ide/ahci.c | 41

[Qemu-devel] [PATCH 2/2 v2] ahci: Fix sglist memleak in ahci_dma_rw_buf()

2012-08-03 Thread Jason Baron
the sglist. Signed-off-by: Jason Baron jba...@redhat.com --- dma-helpers.c |1 + hw/ide/ahci.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 35cb500..13593d1 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -65,6 +65,7 @@ void

[Qemu-devel] [PATCH v3] memory: add -machine dump-guest-core=on|off

2012-08-02 Thread Jason Baron
, rename option dump - dump-guest-core Signed-off-by: Jason Baron jba...@redhat.com --- exec.c | 21 + osdep.h |7 +++ qemu-config.c |4 qemu-options.hx |5 - 4 files changed, 36 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c

[Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump

2012-08-01 Thread Jason Baron
down from 384MB to 6MB on a 2GB guest. Changelog: v2: move the option from -m to -machine, rename option dump - dump_guest_core Signed-off-by: Jason Baron jba...@redhat.com --- exec.c | 13 + osdep.h |7 +++ qemu-config.c |4 qemu-options.hx |5

Re: [Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump

2012-08-01 Thread Jason Baron
On Wed, Aug 01, 2012 at 01:21:57PM -0500, Anthony Liguori wrote: Jason Baron jba...@redhat.com writes: Add a new '[,dump_guest_core=on|off]' option to the '-machine' option. When 'dump_guest_core=off' is specified, guest memory is omitted from the core dump. The default behavior

[Qemu-devel] [PATCH] memory: add cmd line option to omit guest memory from qmeu core dump

2012-07-31 Thread Jason Baron
on a 2GB guest. Thanks to Avi Kivity for the command line syntax. Signed-off-by: Jason Baron jba...@redhat.com --- exec.c | 13 + osdep.h |7 +++ qemu-options.hx | 11 +++ sysemu.h|1 + vl.c| 51

Re: [Qemu-devel] [PATCH 1/2] ahci: Fix ahci cdrom read corruptions for reads 128k

2012-07-27 Thread Jason Baron
On Fri, Jul 27, 2012 at 09:59:01AM +0200, Kevin Wolf wrote: Am 26.07.2012 21:40, schrieb Jason Baron: While testing q35, which has its cdrom attached to the ahci controller, I found that the Fedora 17 install would panic on boot. The panic occurs while squashfs is trying to read from

[Qemu-devel] [PATCH 1/2] ahci: Fix ahci cdrom read corruptions for reads 128k

2012-07-26 Thread Jason Baron
that the sglist is property initialized. I've tested this patch using 'dd' testing, and Fedora 17 now correctly boots and installs on q35 with the cdrom ahci controller. Signed-off-by: Jason Baron jba...@redhat.com --- hw/ide/ahci.c | 41 ++--- hw/ide/internal.h |1

[Qemu-devel] [PATCH 2/2] ahci: Fix sglist memleak in ahci_dma_rw_buf()

2012-07-26 Thread Jason Baron
. However, I see that ahci_start_transfer() always calls the free if the return is 0. Signed-off-by: Jason Baron jba...@redhat.com --- hw/ide/ahci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 9c95714..b48401d 100644 --- a/hw/ide

[Qemu-devel] [PATCH 0/2] ahci: fix cdrom read corruption

2012-07-26 Thread Jason Baron
Hi, While testing q35 I found data corruption on reads from the cdrom on the ahci controller. The first patch addresses this issue. I also notice that there is a memory leak in the ahci code, which is addressed in the second patch. Thanks, -Jason Jason Baron (2): ahci: Fix ahci cdrom read

Re: [Qemu-devel] q35 and ahci

2012-07-20 Thread Jason Baron
On Thu, Jul 05, 2012 at 05:07:43PM +0200, Alexander Graf wrote: On 07/05/2012 04:06 PM, Jason Baron wrote: On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: On 04.07.2012, at 03:29, Jason Baron wrote: On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote

Re: [Qemu-devel] q35 and ahci

2012-07-17 Thread Jason Baron
On Tue, Jul 17, 2012 at 09:31:46AM -0600, Eric Blake wrote: Update on q35 testing with various os's. Linux - -RHEL6.3 installs + runs -Fedora 16 install + runs -Fedora 17 - squashfs errors running on already installed f17 seems ok. Pardon my high-level question (I

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-07-06 Thread Jason Baron
On Thu, Jul 05, 2012 at 09:04:18PM -0300, Marcelo Tosatti wrote: On Mon, May 21, 2012 at 01:53:36PM -0400, Jason Baron wrote: On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: Add a command line parameter to not dump guest memory in the core dump, the command line is: -dont

Re: [Qemu-devel] q35 and ahci

2012-07-05 Thread Jason Baron
On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: On 04.07.2012, at 03:29, Jason Baron wrote: On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: On 03.07.2012, at 22:37, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote

[Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
Hi, Update on q35 testing with various os's. Linux - -RHEL6.3 installs + runs -Fedora 16 install + runs -Fedora 17 - squashfs errors running on already installed f17 seems ok. Windows --- -W7 - install error: A required cd/dvd device driver is missing. If you have a driver floppy

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: On 03.07.2012, at 18:16, Jason Baron wrote: Hi, Update on q35 testing with various os's. Linux - -RHEL6.3 installs + runs -Fedora 16 install + runs -Fedora 17 - squashfs errors running on already

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: On 03.07.2012, at 20:38, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: On 03.07.2012, at 18:16, Jason Baron wrote: Hi, Update on q35 testing with various os's. Linux

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: On 03.07.2012, at 20:46, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: On 03.07.2012, at 20:38, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: On 03.07.2012, at 22:37, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: On 03.07.2012, at 20:46, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote

[Qemu-devel] [PATCH 0/3] iommu: isa dma engine support

2012-06-20 Thread Jason Baron
the iommu context is tied to the isa device structure, it can be set independently of the bus on which the isa device resides. Thus, I'm hoping that this patchset allows us to correctly model more complex chipset topologies. Thanks, -Jason Jason Baron (3): iommu: remove extra 'typedef struct

[Qemu-devel] [PATCH 1/3] iommu: remove extra 'typedef struct DMAContext'

2012-06-20 Thread Jason Baron
There are several instances of 'typedef struct DMAContext DMAContext'. Remove them all except for the one in qemu-common.h. Signed-off-by: Jason Baron jba...@redhat.com --- dma.h |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dma.h b/dma.h index 0d57e50..862373d

[Qemu-devel] [PATCH 2/3] iommu: add support for the isa dma engine

2012-06-20 Thread Jason Baron
with the existing dma engine by changing the prototype of DMA_register channel: -void DMA_register_channel (int nchan, +void DMA_register_channel (ISADevice *dev, int nchan, DMA_transfer_handler transfer_handler, void *opaque) Signed-off-by: Jason

[Qemu-devel] [PATCH 3/3] iommu: add generic mapping support for the isa bus

2012-06-20 Thread Jason Baron
Introduce 'isa_setup_iommu()' to allow chipsets to associate an iommu mapping function with the isa bus. This allows isa devices which sit behind an iommu to be correctly configured. This is based on Benjamin Herrenschmidt's iommu series. It has no consumers for now. Signed-off-by: Jason Baron

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Jason Baron
On Mon, Jun 18, 2012 at 05:35:02PM +0300, Michael S. Tsirkin wrote: On Mon, Jun 18, 2012 at 09:16:24AM -0500, Anthony Liguori wrote: On 06/17/2012 03:25 AM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: The Q35 is much more sophisticated. The

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Jason Baron
On Mon, Jun 18, 2012 at 09:05:17AM -0500, Anthony Liguori wrote: On 06/18/2012 08:51 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 06/15/2012 02:04 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 06/14/2012 02:54 PM, Jason

Re: [Qemu-devel] q35 chipset support

2012-06-15 Thread Jason Baron
On Thu, Jun 14, 2012 at 03:16:03PM -0500, Anthony Liguori wrote: On 06/14/2012 02:54 PM, Jason Baron wrote: Hi, I recently updated Isaku Yamahata's q35 patches to work on the latest qemu and seabios trees. On the qemu side, most of the changes revolved around updating to use QOM

[Qemu-devel] q35 chipset support

2012-06-14 Thread Jason Baron
Hi, I recently updated Isaku Yamahata's q35 patches to work on the latest qemu and seabios trees. On the qemu side, most of the changes revolved around updating to use QOM and updates to the memory API. I was also able to drop quite a few patches that had already been resolved by the current qemu

[Qemu-devel] memory.c: ml-printed is never set to true

2012-06-12 Thread Jason Baron
Hi, I was looking at mtree_info() and noticed that ml-printed is never set to true, so it does not appear to be doing anything. It seems like we want to print the hierarchy for all aliases so perhaps it should just be dropped? Thanks, -Jason

Re: [Qemu-devel] [PATCH] seabios: correct setting of datalow_base for large rom images

2012-06-07 Thread Jason Baron
On Tue, Jun 05, 2012 at 08:09:21PM -0400, Kevin O'Connor wrote: On Tue, Jun 05, 2012 at 12:09:18PM -0400, Jason Baron wrote: I've been creating 256kb rom images with larger acpi tables for second level buses. After a recent re-base, my rom images no longer built. Bisected to: commit

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-06-07 Thread Jason Baron
On Tue, Jun 05, 2012 at 12:52:02AM +0300, Michael S. Tsirkin wrote: On Mon, Jun 04, 2012 at 04:15:56PM -0400, Jason Baron wrote: On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would

[Qemu-devel] [PATCH] seabios: correct setting of datalow_base for large rom images

2012-06-05 Thread Jason Baron
. Signed-off-by: Jason Baron jba...@redhat.com --- tools/layoutrom.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/layoutrom.py b/tools/layoutrom.py index 74b410f..01f9bed 100755 --- a/tools/layoutrom.py +++ b/tools/layoutrom.py @@ -219,10 +219,10 @@ def doLayout

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-06-04 Thread Jason Baron
On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. | (qemu) device_del virti0-0-0 | (qemu) ** |ERROR:qom/object.c:389:object_delete: assertion failed: (obj-ref ==

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-05-21 Thread Jason Baron
On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: Add a command line parameter to not dump guest memory in the core dump, the command line is: -dont-dump-guest. This brought the core dump down from 383MB to 13 MB on a 1GB guest. Signed-off-by: Jason Baron jba...@redhat.com

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-11 Thread Jason Baron
On Fri, May 11, 2012 at 04:45:21PM +1000, Alexey Kardashevskiy wrote: Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is being built by QEMU. In the case of VFIO the capability may already exist and adding

[Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-05-04 Thread Jason Baron
Add a command line parameter to not dump guest memory in the core dump, the command line is: -dont-dump-guest. This brought the core dump down from 383MB to 13 MB on a 1GB guest. Signed-off-by: Jason Baron jba...@redhat.com --- exec.c | 13 + osdep.h |7

[Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes

2012-05-02 Thread Jason Baron
cleanup its state. Thanks, -Jason Jason Baron (2): qdev: release parent properties on dc-init failure pci_bridge_dev: fix error path in pci_bridge_dev_initfn() hw/pci_bridge_dev.c |4 +++- hw/qdev.c |1 + 2 files changed, 4 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 1/2] qdev: release parent properties on dc-init failure

2012-05-02 Thread Jason Baron
it */ object_unparent(OBJECT(dev)); qdev_free(dev); return 0; } Signed-off-by: Jason Baron jba...@redhat.com --- hw/qdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 0bcde20..cff7f4c 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -150,6 +150,7

[Qemu-devel] [PATCH 2/2] pci_bridge_dev: fix error path in pci_bridge_dev_initfn()

2012-05-02 Thread Jason Baron
Currently, we do not properly cleanup, if pci_bridge_dev_initfn fails to initialize properly. Make sure to call pci_bridge_exitfn() in the error path. Signed-off-by: Jason Baron jba...@redhat.com --- hw/pci_bridge_dev.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP

2012-04-27 Thread Jason Baron
On Tue, Apr 24, 2012 at 10:42:16AM +1200, Michael Kerrisk wrote: Jason, On Thu, Mar 8, 2012 at 6:00 AM, Jason Baron jba...@redhat.com wrote: Hi, The motivation for this change was that I was looking at a way for a qemu-kvm process, to exclude the guest memory from its core dump

[Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jason Baron
after reset (INTx mode), and we avoid touching msi memory mapped space on any subsequent 'kvm_deassign_irq()', since we're in INTx mode. Thanks to Michael S. Tsirkin for help in understanding what was going on here. Signed-off-by: Jason Baron jba...@redhat.com Signed-off-by: Alex Williamson

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jason Baron
On Fri, Mar 30, 2012 at 09:29:23PM +0200, Jan Kiszka wrote: On 2012-03-30 21:18, Jason Baron wrote: We've hit a kernel host panic, when issuing a 'system_reset' with a 82576 nic assigned and a Windows guest. Host system is a PowerEdge R815. [Hardware Error]: Hardware error from APEI

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jason Baron
On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: The root cause of the problem is that the 'reset_assigned_device()' code first writes a 0 to the command register. Then, when qemu subsequently does a kvm_deassign_irq() (called by assign_irq(), in the system_reset path), the

[Qemu-devel] [PATCH] kvm: set gsi_bits and max_gsi correctly

2012-03-28 Thread Jason Baron
assigned_dev_update_msix_mmio(). Signed-off-by: Jason Baron jba...@redhat.com --- kvm-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index ab88c7c..b616c7d 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -873,7 +873,7 @@ static void kvm_init_irq_routing

[Qemu-devel] [PATCH 1/2] qemu kvm: Set up gsi bitmap correctly

2012-03-27 Thread Jason Baron
() in assigned_dev_update_msix_mmio(). Signed-off-by: Jason Baron jba...@redhat.com --- kvm-all.c |4 ++-- qemu-kvm.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index ab88c7c..7d602af 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -873,9 +873,9 @@ static void

[Qemu-devel] [PATCH 0/2] qemu kvm: correct gsi bitmap

2012-03-27 Thread Jason Baron
Hi, While testing pci passthrough, I ran out of gsi bits, b/c the bitmap is not initialized correctly. Fix the initialization of the bitmap, and add extra error reporting for this condition. Thanks, -Jason Jason Baron (2): qemu kvm: Set up gsi bitmap correctly qemu kvm: add better error

[Qemu-devel] [PATCH 2/2] qemu kvm: add better error reporting when kvm_get_irq_route_gsi() fails

2012-03-27 Thread Jason Baron
When kvm_get_irq_route_gsi() fails in assigned_dev_update_msix_mmio, it would be nice to have a better error message. Signed-off-by: Jason Baron jba...@redhat.com --- hw/device-assignment.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/device-assignment.c b/hw

Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

2012-03-07 Thread Jason Baron
On Wed, Mar 07, 2012 at 09:59:58AM -0800, Roland McGrath wrote: On Wed, Mar 7, 2012 at 9:00 AM, Jason Baron jba...@redhat.com wrote: +       if (vma_name) { +               if ((strcmp(vma_name, [vdso]) == 0) || +                   (strcmp(vma_name, [vectors]) == 0

Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

2012-03-07 Thread Jason Baron
. Signed-off-by: Jason Baron jba...@redhat.com --- arch/arm/kernel/process.c |2 +- arch/hexagon/kernel/vdso.c |3 +-- arch/mips/kernel/vdso.c|3 +-- arch/powerpc/kernel/vdso.c |3 +-- arch/s390/kernel/vdso.c|3 +-- arch/sh/kernel

[Qemu-devel] [PATCH 2/2] core dump: add a new VM_DONTDUMP flag

2012-03-07 Thread Jason Baron
is qemu: we can add a flag there that wouldn't dump all of guest memory when qemu dumps core. This flag might also be useful for security sensitive apps that want to absolutely make sure that parts of memory are not dumped. Signed-off-by: Jason Baron jba...@redhat.com --- fs/binfmt_elf.c

Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

2012-03-07 Thread Jason Baron
On Wed, Mar 07, 2012 at 04:26:46PM -0500, Chris Metcalf wrote: On 3/7/2012 4:19 PM, Jason Baron wrote: On Wed, Mar 07, 2012 at 11:43:02AM -0800, Roland McGrath wrote: well, sure, we can provide an arch interface, for this check. I'm more concerned with the general idea. If it seems ok, I

[Qemu-devel] [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP

2012-03-07 Thread Jason Baron
for security sensitive apps, which might want to select which areas are dumped. Thanks, -Jason Jason Baron (2): core dump: drop VM_ALWAYSDUMP flag core dump: add a new VM_DONTDUMP flag arch/arm/kernel/process.c |2 +- arch/hexagon/kernel/vdso.c |3 +-- arch/mips

[Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

2012-03-07 Thread Jason Baron
-by: Jason Baron jba...@redhat.com --- arch/arm/kernel/process.c |2 +- arch/hexagon/kernel/vdso.c |3 +-- arch/mips/kernel/vdso.c|3 +-- arch/powerpc/kernel/vdso.c |3 +-- arch/s390/kernel/vdso.c|3 +-- arch/sh/kernel/vsyscall

Re: [Qemu-devel] [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP

2012-03-07 Thread Jason Baron
On Wed, Mar 07, 2012 at 02:30:28PM -0800, Andrew Morton wrote: On Wed, 7 Mar 2012 12:00:46 -0500 Jason Baron jba...@redhat.com wrote: Hi, The motivation for this change was that I was looking at a way for a qemu-kvm process, to exclude the guest memory from its core dump, which can

<    1   2   3