have reviewed this patch, and the new libcacard module. Modulo a few
minor nits (which Marc-André agreed to fix on irc), it all works well.
I think this is a sensible change and I'm willing to help with
libcacard maintenance, if we were to establish it as a project.
Reviewed-by: Jeremy
Hey Marc-André,
Thanks for the review.
On 03/16/2015 11:22 AM, Marc-André Lureau wrote:
> Hi Jeremy
>
> I have checked no regression for spice, but not the new pcsc backend.
> Do you have a spice-gtk branch or are you using vscclient only?
I'm using spice-gtk with this patch:
http://lists.fre
A physical smartcard with an ATR of
3B 95 95 40 FF AE 01 0E 00 00
was parsed incorrectly.
The '40' should have been the second TD; instead
the FF is used, incorrectly.
Signed-off-by: Jeremy White
---
hw/usb/ccid-card-passthru.c |2 +-
1 file changed, 1 insertion(+), 1 deletio
That option can be achieved using -e "use_hw=yes hw_type=passthru"
Signed-off-by: Jeremy White
---
libcacard/vscclient.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index fa6041d..8573f50 10
This uses libpcsclite to provide direct communication with a smartcard.
Signed-off-by: Jeremy White
---
Makefile.objs|5 +
libcacard/capcsc.c | 498 ++
libcacard/capcsc.h | 18 ++
libcacard/card_7816.c|2
Signed-off-by: Jeremy White
---
libcacard/vcard.c |2 +-
libcacard/vcard.h |2 +-
libcacard/vcard_emul_nss.c | 29 -
libcacard/vcard_emul_type.c |3 ++-
4 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/libcacard
As far as I can tell, the vreader_remove_reader function is not presently in
use anywhere; I have an upcoming patch set that uses it.
Signed-off-by: Jeremy White
---
libcacard/vreader.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/vreader.c b/libcacard
some performance issues arising from libpccslite's
heavy handed thread safety code
Jeremy White (7):
Bug fix: delete the reader entry after queueing an event, not before.
Retrieve the correct TD byte when checking an ATR.
Add a configure check for libpcsclite, and an option to enable or
Signed-off-by: Jeremy White
---
configure | 38 ++
1 file changed, 38 insertions(+)
diff --git a/configure b/configure
index b858756..f22dbae 100755
--- a/configure
+++ b/configure
@@ -307,6 +307,7 @@ trace_file="trace"
spice=""
r
Also add an alias of 'nssemul' for the default card
of hw=yes hw_type=cac, and an alias of 'passthru' for
the new card type of hw=yes hw_type=passthru.
This allows the spice-gtk client to take a more human
friendly set of arguments and relay them through to this code.
Signed-
Ping? Anything I can do to get review/motion on these patches?
Cheers,
Jeremy
On 01/20/2015 09:38 AM, Jeremy White wrote:
> This differs from v1 by:
> * checkpatch review
> * Patch series, instead of one patch
> * Remove internal queue in favor of relying on thread safety
Also add an alias of 'nssemul' for the default card
of hw=yes hw_type=cac, and an alias of 'passthru' for
the new card type of hw=yes hw_type=passthru.
This allows the spice-gtk client to take a more human
friendly set of arguments and relay them through to this code.
Signed-
vcard_emul_options() behavior such that the
spice-gtk client can pass arguments along directly. This allows the spice-gtk
client to make use of the new passthru mode option.
Jeremy White (1):
Add error checking to vcard_emul_options.
libcacard/vcard_emul_nss.c | 49
This uses libpcsclite to provide direct communication with a smartcard.
Signed-off-by: Jeremy White
---
Makefile.objs|5 +
libcacard/capcsc.c | 488 ++
libcacard/capcsc.h | 18 ++
libcacard/libcacard.syms |1 +
4
Signed-off-by: Jeremy White
---
libcacard/vcard.c |2 +-
libcacard/vcard.h |2 +-
libcacard/vcard_emul_nss.c | 29 -
libcacard/vcard_emul_type.c |3 ++-
4 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/libcacard
That option can be achieved using -e "use_hw=yes hw_type=passthru"
Signed-off-by: Jeremy White
---
libcacard/vscclient.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index fa6041d..8573f50 10
This differs from v1 by:
* checkpatch review
* Patch series, instead of one patch
* Remove internal queue in favor of relying on thread safety of pcsclite
* Remove glib from configure
* Use glib thread and allocation functions
Jeremy White (4):
Add a configure check for libpcsclite
Signed-off-by: Jeremy White
---
configure | 38 ++
1 file changed, 38 insertions(+)
diff --git a/configure b/configure
index 5ea1014..4529764 100755
--- a/configure
+++ b/configure
@@ -307,6 +307,7 @@ trace_file="trace"
spice=""
r
ould fix your patch to pass qemu scripts/checkpatch.pl (too many
> errors to report here)
*blush* Yup.
>
> Some review notes follow.
>
> On Mon, Jan 19, 2015 at 4:00 PM, Jeremy White wrote:
>> This enables a passthru mode in the spice client, where we relay
>> apdu
27; to hold the upper 4 bits of T0, and then, if
present, the upper 4 bits of TD1. So what is read imprecisely is the
upper 4 bits of TD1.
I don't know qemu patch protocol; that seems like a very minor detail in
the comment; does it justify a resubmit?
>
>>
>> Signed-off-by:
This enables a passthru mode in the spice client, where we relay
apdus from the client to the host, rather than passing through nss
and emulating a card.
Signed-off-by: Jeremy White
---
Makefile.objs |5 +
configure | 38 +++
libcacard/capcsc.c
A physical smartcard with an ATR of
3B 95 95 40 FF AE 01 0E 00 00
was parsed incorrectly.
The '40' should have been the second TD; instead
the FF is used, incorrectly.
Signed-off-by: Jeremy White
---
hw/usb/ccid-card-passthru.c |2 +-
1 file changed, 1 insertion(+), 1 deletio
As far as I can tell, the vreader_remove_reader function is not presently in
use anywhere; I have an upcoming patch set that uses it.
Signed-off-by: Jeremy White
---
libcacard/vreader.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/vreader.c b/libcacard
Signed-off-by: Jeremy White
---
configure| 24 +++-
hw/display/Makefile.objs |1 +
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index cae588c..6c698ed 100755
--- a/configure
+++ b/configure
@@ -2034,6 +2034,15
Signed-off-by: Jeremy White
---
audio/spiceaudio.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index 5af436c..fceee50 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -25,8 +25,17
25 matches
Mail list logo
