Re: device compatibility interface for live migration with assigned devices

2020-08-05 Thread Jiri Pirko
Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote: >On Wed, Aug 05, 2020 at 04:02:48PM +0800, Jason Wang wrote: >> >> On 2020/8/5 下午3:56, Jiri Pirko wrote: >> > Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redhat.com wrote: >> > > On 2020/8/5

Re: device compatibility interface for live migration with assigned devices

2020-08-05 Thread Jiri Pirko
Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redhat.com wrote: > >On 2020/8/5 上午10:16, Yan Zhao wrote: >> On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote: >> > On 2020/8/5 上午12:35, Cornelia Huck wrote: >> > > [sorry about not chiming in earlier] >> > > >> > > On Wed, 29 Jul 2020 16:05

[Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse

2014-05-19 Thread Jiri Pirko
: Jiri Pirko --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 1bb9259..f3be494 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s) PCIDevice *d

[Qemu-devel] [patch qemu] net: move queue number into NICPeers

2014-05-26 Thread Jiri Pirko
It indicates the number of elements in ncs field and makes sense to have int inside NICPeers. Also in parse_netdev we do not need to access container and work with NICPeers only. Signed-off-by: Jiri Pirko --- hw/core/qdev-properties-system.c | 3 +-- hw/net/virtio-net.c | 2

[Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko Add property to specify rocker world. All ports will be assigned to this world. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c

[Qemu-devel] [patch qemu 1/3] rocker: forbid to change world type

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko Port to world assignment should be permitted only by qemu user. Driver should not be able to do it, so forbid that possibility. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.c| 8 +++- hw/net/rocker/rocker_fp.c | 5 + hw/net/rocker/rocker_fp.h | 1 + 3 files

[Qemu-devel] [patch qemu 0/3] rocker: prepare for easy addition of other worlds

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko This patchset does couple of small changes in order to prepare for smooth addition of other worlds, like P4 and BPF. qemu user will be able to request desired rocker world by "world=worldname" property. Jiri Pirko (3): rocker: forbid to change world type rocker

[Qemu-devel] [patch qemu 2/3] rocker: add name field into WorldOps ale let world specify its name

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko Also use this in world_name getter function. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker_of_dpa.c | 1 + hw/net/rocker/rocker_world.c | 7 +-- hw/net/rocker/rocker_world.h | 1 + 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/rocker

Re: [Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread Jiri Pirko
m an off-by-one error, if a >descriptor was to have more than allowed(ROCKER_TX_FRAGS_MAX) >fragments. Fix an incorrect bounds check to avoid it. > >Reported-by: Qinghao Tang >Signed-off-by: Prasad J Pandit Reviewed-by: Jiri Pirko

Re: [Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property

2016-02-22 Thread Jiri Pirko
Mon, Feb 22, 2016 at 06:51:50PM CET, stefa...@gmail.com wrote: >On Fri, Feb 19, 2016 at 11:06:43AM +0100, Jiri Pirko wrote: >> @@ -1297,7 +1310,18 @@ static int pci_rocker_init(PCIDevice *dev) >> /* allocate worlds */ >> >> r->worlds[ROCKER_WORLD_TYPE_

Re: [Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property

2016-02-25 Thread Jiri Pirko
Thu, Feb 25, 2016 at 12:31:58PM CET, stefa...@gmail.com wrote: >On Mon, Feb 22, 2016 at 07:06:34PM +0100, Jiri Pirko wrote: >> Mon, Feb 22, 2016 at 06:51:50PM CET, stefa...@gmail.com wrote: >> >On Fri, Feb 19, 2016 at 11:06:43AM +0100, Jiri Pirko wrote: >> >> @@

[Qemu-devel] [patch qemu v2 0/4] rocker: prepare for easy addition of other worlds

2016-02-25 Thread Jiri Pirko
From: Jiri Pirko This patchset does couple of small changes in order to prepare for smooth addition of other worlds, like P4 and BPF. qemu user will be able to request desired rocker world by "world=worldname" property. v1->v2: patch 2/4: - new patch patch 4/4: - goto error

[Qemu-devel] [patch qemu v2 1/4] rocker: forbid to change world type

2016-02-25 Thread Jiri Pirko
From: Jiri Pirko Port to world assignment should be permitted only by qemu user. Driver should not be able to do it, so forbid that possibility. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.c| 8 +++- hw/net/rocker/rocker_fp.c | 5 + hw/net/rocker/rocker_fp.h | 1 + 3 files

[Qemu-devel] [patch qemu v2 2/4] rocker: return -ENOMEM in case of some world alloc fails

2016-02-25 Thread Jiri Pirko
From: Jiri Pirko Until now, 0 is returned in this error case. Fix it ro return -ENOMEM. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- hw/net/rocker/rocker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index a1d921d..104c

[Qemu-devel] [patch qemu v2 4/4] rocker: allow user to specify rocker world by property

2016-02-25 Thread Jiri Pirko
From: Jiri Pirko Add property to specify rocker world. All ports will be assigned to this world. Signed-off-by: Jiri Pirko --- v1->v2: - goto error path in case world type is not found for name - move worlds alloc check right after worlds alloc --- hw/net/rocker/rocker.c |

[Qemu-devel] [patch qemu v2 3/4] rocker: add name field into WorldOps ale let world specify its name

2016-02-25 Thread Jiri Pirko
From: Jiri Pirko Also use this in world_name getter function. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker_of_dpa.c | 1 + hw/net/rocker/rocker_world.c | 7 +-- hw/net/rocker/rocker_world.h | 1 + 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/rocker

Re: [Qemu-devel] [PATCH v5 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM

2015-01-22 Thread Jiri Pirko
Thu, Jan 22, 2015 at 09:03:59AM CET, sfel...@gmail.com wrote: >From: David Ahern > >Signed-off-by: David Ahern >Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko >--- > hw/net/rocker/rocker.h | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) &

Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

2015-09-24 Thread Jiri Pirko
Thu, Sep 24, 2015 at 06:18:43PM CEST, arm...@redhat.com wrote: >Michael, could you take this one through trivial? Assuming Scott and >Jiri don't mind, and with s/patchas/patch as/ in the commit message. I don't mind :)

Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

2015-09-14 Thread Jiri Pirko
;more type errors. > >This commit only touches allocations with size arguments of the form >sizeof(T). Same Coccinelle semantic patchas in commit b45c03f. ^ typo :) Other than that: Acked-by: Jiri Pirko

Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

2015-09-14 Thread Jiri Pirko
Mon, Sep 14, 2015 at 05:55:40PM CEST, ebl...@redhat.com wrote: >On 09/14/2015 05:57 AM, Jiri Pirko wrote: >> Mon, Sep 14, 2015 at 01:52:23PM CEST, arm...@redhat.com wrote: >>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, >>> for two reasons.

[Qemu-devel] [patch qemu] rocker: fix 32bit build

2015-02-27 Thread Jiri Pirko
For printf format of uint64_t and size_t use TARGET_FMT_plx and %zu Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.c | 32 +--- hw/net/rocker/rocker_desc.c | 6 +++--- 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/hw/net/rocker/rocker.c b

Re: [Qemu-devel] [PATCH] rocker: fix clang compiler errors

2015-03-07 Thread Jiri Pirko
Sat, Mar 07, 2015 at 01:06:24AM CET, dsah...@gmail.com wrote: >Consolidate all forward typedef declarations to rocker.h. > >Signed-off-by: David Ahern >Acked-by: Scott Feldman Thanks for taking care of this David. Acked-by: Jiri Pirko

[Qemu-devel] [patch qemu] MAINTAINERS: release Scott from being a rocker maintainer

2016-07-11 Thread Jiri Pirko
From: Jiri Pirko As requested by Scott, removing him. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d0e2c3..5928f22 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -971,7 +971,6 @@ F

Re: hw/net/rocker: Dubious code in tx_consume()

2020-02-15 Thread Jiri Pirko
Sat, Feb 15, 2020 at 02:15:22PM CET, phi...@redhat.com wrote: >Hi Jiri, > >I am trying to understand this code Scott Feldman added in commit >dc488f88806: > > 157 static int tx_consume(Rocker *r, DescInfo *info) > 158 { > ... > 212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) { > 213 tx_tso_mss = r

Re: [Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size

2016-10-12 Thread Jiri Pirko
e is written to >register 'TEST_DMA_SIZE'. When performing TEST_DMA_CTRL_INVERT >test, if DMA buffer size was greater than 'INT_MAX', it leads to >an invalid buffer access. Limit the DMA buffer size to avoid it. > >Reported-by: Huawei PSIRT >Signed-off-by: Prasad J Pandit Reviewed-by: Jiri Pirko

Re: [PATCH v3 for 9.1 0/6] virtio, vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-16 Thread Jiri Pirko
Fri, Mar 15, 2024 at 05:55:51PM CET, jonah.pal...@oracle.com wrote: >The goal of these patches are to add support to a variety of virtio and >vhost devices for the VIRTIO_F_NOTIFICATION_DATA transport feature. This >feature indicates that a driver will pass extra data (instead of just a >virtqueue'

Re: [PATCH v3 for 9.1 0/6] virtio, vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-18 Thread Jiri Pirko
Mon, Mar 18, 2024 at 12:22:02PM CET, jonah.pal...@oracle.com wrote: > > >On 3/16/24 11:45 AM, Jiri Pirko wrote: >> Fri, Mar 15, 2024 at 05:55:51PM CET, jonah.pal...@oracle.com wrote: >> > The goal of these patches are to add support to a variety of virtio and &g