Re: [v2] hw: misc: edu: fix 2 off-by-one errors

2022-10-17 Thread Jiri Slaby
On 17. 10. 22, 15:44, Alexander Bulekov wrote: On 221015 1710, Chris Friedt wrote: From: Christopher Friedt In the case that size1 was zero, because of the explicit 'end1 > addr' check, the range check would fail and the error message would read as shown below. The correct comparison is 'end1

Re: [v2] hw: misc: edu: fix 2 off-by-one errors

2022-10-17 Thread Jiri Slaby
On 17. 10. 22, 16:13, Peter Maydell wrote: * for situations where the guest has misprogrammed the device, log that with qemu_log_mask(LOG_GUEST_ERROR, ...) and continue with whatever the real hardware would do, or some reasonable choice if the h/w spec is vague As I wrote in the p

Re: [v2] hw: misc: edu: fix 2 off-by-one errors

2022-10-17 Thread Jiri Slaby
On 15. 10. 22, 23:10, Chris Friedt wrote: From: Christopher Friedt In the case that size1 was zero, because of the explicit 'end1 > addr' check, the range check would fail and the error message would read as shown below. The correct comparison is 'end1 >= addr' (or 'addr <= end1'). EDU: DMA ra

Re: [PATCH] slirp: samba, set 'server min protocol' to NT1

2020-02-25 Thread Jiri Slaby
On 25. 02. 20, 11:43, Daniel P. Berrangé wrote: > On Tue, Feb 25, 2020 at 11:27:58AM +0100, Jiri Slaby wrote: >> Samba changed the default of server min protocol from LANMAN1 (very old >> protocol) to SMB2_02 (only Vista and newer) in commit 840b8501b436 >> (docs-xml: change

[PATCH] slirp: samba, set 'server min protocol' to NT1

2020-02-25 Thread Jiri Slaby
but older than SMB2_02: NT1 protocol. So set 'server min protocol' in the samba config used in qemu to NT1. This restores support for WinNT and newer (WXP including). Signed-off-by: Jiri Slaby --- net/slirp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/slirp.c b/net/slirp.

[Qemu-devel] [PATCH] target/i386: sev: fix failed message typos

2019-07-19 Thread Jiri Slaby
In these multiline messages, there were typos. Fix them -- add a missing space and remove a superfluous apostrophe. Inspired by Tom's patch. Signed-off-by: Jiri Slaby Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-triv...@nongnu.org Cc: Brijesh Singh Cc: Tom Len

Re: [Qemu-devel] [PATCH v3 2/3] edu: mmio: allow 64-bit access in read dispatch

2019-05-03 Thread Jiri Slaby
On 22. 04. 19, 16:11, Li Qiang wrote: > The edu spec says when address >= 0x80, the MMIO area can > be accessed by 64-bit. > > Signed-off-by: Li Qiang > --- > Change since v2: > Fix an error per Phillippe's advice > > hw/misc/edu.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v3 3/3] edu: uses uint64_t in dma operation

2019-05-03 Thread Jiri Slaby
On 22. 04. 19, 16:11, Li Qiang wrote: > The dma related variable dma.dst/src/cnt is dma_addr_t, it is > uint64_t in x64 platform. Change these usage from uint32_to > uint64_t to avoid trancation in edu_dma_timer. > > Signed-off-by: Li Qiang > Reviewed-by: Philippe Mathieu-Daude > --- > hw/misc/

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-07 Thread Jiri Slaby
On 07. 01. 19, 18:29, Markus Armbruster wrote: >static void pci_edu_uninit(PCIDevice *pdev) >{ >EduState *edu = EDU(pdev); > >qemu_mutex_lock(&edu->thr_mutex); >edu->stopping = true; >qemu_mutex_unlock(&edu->thr_mutex); >qemu_cond_signal(&edu->thr_co

Re: [Qemu-devel] [PATCH v2 21/30] hw/misc: use the BYTE-based definitions

2018-03-05 Thread Jiri Slaby
On 03/05/2018, 12:27 PM, Philippe Mathieu-Daudé wrote: > --- a/hw/misc/auxbus.c > +++ b/hw/misc/auxbus.c > @@ -68,7 +68,7 @@ AUXBus *aux_init_bus(DeviceState *parent, const char *name) > > /* Memory related. */ > bus->aux_io = g_malloc(sizeof(*bus->aux_io)); > -memory_region_init(bu

Re: [Qemu-devel] [PATCH] misc: edu: free dma timer in device unit

2017-02-07 Thread Jiri Slaby
On 02/08/2017, 04:40 AM, Li Qiang wrote: > From: Li Qiang > > This can avoid a memory leak when hotplug and unplug. > > Signed-off-by: Li Qiang > --- > hw/misc/edu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/misc/edu.c b/hw/misc/edu.c > index 401039c..7565552 100644 > --- a/

Re: [Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Jiri Slaby
On 01/22/2015, 04:53 PM, Paolo Bonzini wrote: > On 22/01/2015 16:39, Eric Blake wrote: >> On 01/22/2015 01:22 AM, Jiri Slaby wrote: >>> Signed-off-by: Jiri Slaby --- docs/specs/edu.txt >>> | 4 hw/misc/edu.c | 2 +- 2 files changed, 5 >>> insertions(+)

Re: [Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Jiri Slaby
On 01/22/2015, 10:04 AM, Markus Armbruster wrote: > Jiri Slaby writes: > >> Signed-off-by: Jiri Slaby >> --- >> docs/specs/edu.txt | 4 >> hw/misc/edu.c | 2 +- >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/

[Qemu-devel] [PATCH 1/1] edu: fix license information

2015-01-22 Thread Jiri Slaby
Signed-off-by: Jiri Slaby --- docs/specs/edu.txt | 4 hw/misc/edu.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/specs/edu.txt b/docs/specs/edu.txt index 360af27ec8b1..1a23df9d21f6 100644 --- a/docs/specs/edu.txt +++ b/docs/specs/edu.txt @@ -2,6 +2,10

[Qemu-devel] [PATCH v5 1/1] hw: misc, add educational driver

2015-01-21 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5

Re: [Qemu-devel] [PATCH v4 1/1] pci-host: add educational driver

2015-01-21 Thread Jiri Slaby
On 01/21/2015, 05:40 PM, Paolo Bonzini wrote: > > > On 21/01/2015 17:28, Jiri Slaby wrote: >> +if (atomic_fetch_or(&edu->status, EDU_STATUS_COMPUTING) & >> EDU_STATUS_COMPUTING) { > > Theoretically the other thread could see EDU_STATUS_COMPUTING

[Qemu-devel] [PATCH v4 1/1] pci-host: add educational driver

2015-01-21 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5

Re: [Qemu-devel] [PATCH v2 1/1] pci-host: add educational driver

2014-12-05 Thread Jiri Slaby
On 12/05/2014, 11:35 AM, Paolo Bonzini wrote: > Hi Jirka, > > because this is supposed to be a poster of good QEMU practices, the > review is going to be a bit picky. Most comments are trivial to apply. Hi, OK :). >> --- /dev/null >> +++ b/hw/misc/edu.c >> @@ -0,0 +1,351 @@ ... >> +static void

[Qemu-devel] [PATCH v3 1/1] pci-host: add educational driver

2014-12-05 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5

[Qemu-devel] [PATCH v2 1/1] pci-host: add educational driver

2014-12-05 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby Cc: Paolo Bonzini --- MAINTAINERS

Re: [Qemu-devel] [PATCH v2 1/1] pci-host: add educational driver

2014-12-05 Thread Jiri Slaby
On 12/05/2014, 10:52 AM, Jiri Slaby wrote: > hw/misc/edu.c | 351 > > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -593,6 +593,11 @@ F: hw/net/opencores_eth.c > > Devices > --- > +EDU > +M: Jiri Sl

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-12-03 Thread Jiri Slaby
On 10/13/2014, 03:00 PM, Paolo Bonzini wrote: >> +static void edu_dma_timer(void *opaque) >> +{ >> +EduState *edu = opaque; >> +bool raise_irq = false; >> + >> +qemu_mutex_lock(&edu->dma_mutex); > > dma_mutex and mutex and irq_mutex are not necessary. All I/O happens > under the big Q

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-13 Thread Jiri Slaby
On 10/10/2014, 04:54 PM, Claudio Fontana wrote: > Hello, > > On 10.10.2014 14:09, Jiri Slaby wrote: >> I am using qemu for teaching the Linux kernel at our university. I >> wrote a simple PCI device that can answer to writes/reads, generate >> interrupts and perfo

[Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-10 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5

[Qemu-devel] [patch] qemu educational device

2014-10-10 Thread Jiri Slaby
Hello guys, I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, would you be interested in including it upstream? thanks, -- js suse labs tra

Re: [Qemu-devel] qemu is missing monitor

2014-10-10 Thread Jiri Slaby
On 10/10/2014, 09:38 AM, Gerd Hoffmann wrote: > On Do, 2014-10-09 at 17:05 +0100, Peter Maydell wrote: >> On 9 October 2014 14:37, Jiri Slaby wrote: >>> Hi guys, >>> >>> qemu in opensuse latest (factory) does not have monitor. Despite >>> libvte-devel

Re: [Qemu-devel] qemu is missing monitor

2014-10-10 Thread Jiri Slaby
On 10/09/2014, 06:05 PM, Peter Maydell wrote: > On 9 October 2014 14:37, Jiri Slaby wrote: >> Hi guys, >> >> qemu in opensuse latest (factory) does not have monitor. Despite >> libvte-devel is installed, it is not detected by qemu. The problem is >> that configur

[Qemu-devel] qemu is missing monitor

2014-10-09 Thread Jiri Slaby
Hi guys, qemu in opensuse latest (factory) does not have monitor. Despite libvte-devel is installed, it is not detected by qemu. The problem is that configure looks for vte-2.90, but we have vte-2.91 in factory. The attached patch fixes that for factory, but it's dirty, of course. Any better idea

[Qemu-devel] Cannot load initrd > 32M via TFTP

2012-09-09 Thread Jiri Slaby
Hi, it looks like the largest initrd qemu can pass/pxe can load from the qemu's TFTP server is 33553920 bytes long. If a larger file is passed, the laoding in pxelinux hangs (stops printing dots). It seems that qemu supports tsize, but now it looks like it does not work well? The command-line I u