Re: [PATCH] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-06-10 Thread Joel Holdsworth
Hi Stafford, thanks for your response. > - You sent this 2 times, is the only change in v2 the sender address? Yes, I was just having some difficulty with Git and SMTP. Should be fixed now. >> In the existing design, TTCR is prone to undercounting when running in >> continuous mode. This manife

[PATCH] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-06-07 Thread Joel Holdsworth via
accumulating error over time. Signed-off-by: Joel Holdsworth --- hw/openrisc/cputimer.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 835986c4db..ddc129aa48 100644 --- a/hw/openrisc/cputimer.c +++ b/hw

Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve

2016-06-20 Thread Joel Holdsworth
On 20/06/16 22:40, Peter Maydell wrote: On 20 June 2016 at 22:27, Joel Holdsworth wrote: The current behaviour was quite unexpected to me - there were no warnings, and the need to link qemu statically isn't documented anywhere. If you really believe that static linking is the best answer

Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve

2016-06-20 Thread Joel Holdsworth
On 20/06/16 21:29, Laurent Vivier wrote: Le 20/06/2016 à 21:51, Joel Holdsworth a écrit : On 15/06/16 20:59, Laurent Vivier wrote: Le 14/06/2016 à 21:26, Joel Holdsworth a écrit : Previously, when emulating execve(2), qemu would execute a child instance of the emulator with the environment

Re: [Qemu-devel] [PATCH v2 1/4] linux-user: add option to intercept execve() syscalls

2016-06-20 Thread Joel Holdsworth
On 15/06/16 20:31, Laurent Vivier wrote: Le 14/06/2016 à 21:26, Joel Holdsworth a écrit : From: Petros Angelatos In order for one to use QEMU user mode emulation under a chroot, it is required to use binfmt_misc. This can be avoided by QEMU never doing a raw execve() to the host system

Re: [Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve

2016-06-20 Thread Joel Holdsworth
On 15/06/16 21:37, Laurent Vivier wrote: This is not needed: if you use QEMU_STRACE environment variable, it is propagated to the child processes (this is also true for "-L" and QEMU_LD_PREFIX). I would say that breaks the rule of least surprise for the user. If we're going to invoke a child ins

Re: [Qemu-devel] [PATCH v2 3/4] linux-user: pass elf interpreter prefix in execve

2016-06-20 Thread Joel Holdsworth
On 15/06/16 21:06, Laurent Vivier wrote: More details: why do we need this? Add your Signed-off-by. Le 14/06/2016 à 21:26, Joel Holdsworth a écrit : --- linux-user/syscall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c

Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve

2016-06-20 Thread Joel Holdsworth
On 15/06/16 20:59, Laurent Vivier wrote: Le 14/06/2016 à 21:26, Joel Holdsworth a écrit : Previously, when emulating execve(2), qemu would execute a child instance of the emulator with the environment variables provided by the parent process. This caused problems with qemu if any of the

[Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve

2016-06-14 Thread Joel Holdsworth
--- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1513f0f..00ee7a6 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6778,6 +6778,8 @@ static abi_long qemu_execve(char *filename, char *argv[], qem

[Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve

2016-06-14 Thread Joel Holdsworth
Previously, when emulating execve(2), qemu would execute a child instance of the emulator with the environment variables provided by the parent process. This caused problems with qemu if any of the variables affected the child emulator's behaviour e.g. LD_LIBRARY_PATH. This patch solves this issue

[Qemu-devel] [PATCH v2 3/4] linux-user: pass elf interpreter prefix in execve

2016-06-14 Thread Joel Holdsworth
--- linux-user/syscall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 440986e..1513f0f 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6667,7 +6667,7 @@ static abi_long qemu_execve(char *filename, char *ar

[Qemu-devel] [PATCH v2 1/4] linux-user: add option to intercept execve() syscalls

2016-06-14 Thread Joel Holdsworth
From: Petros Angelatos In order for one to use QEMU user mode emulation under a chroot, it is required to use binfmt_misc. This can be avoided by QEMU never doing a raw execve() to the host system. Introduce a new option, -execve, that uses the current QEMU interpreter to intercept execve(). qe

[Qemu-devel] linux-user: add option to intercept execve() syscalls

2016-06-14 Thread Joel Holdsworth
This patch-set includes Peter Angelatos's previous patch-set [1] and adds code to pass arguments for setting the environment variables, passing the interpeter prefix, and passing the strace option. Changes since v1: - Fixed argument array overflows. [1] https://patchwork.ozlabs.org/patch/582756/

Re: [Qemu-devel] linux-user: add option to intercept execve() syscalls

2016-05-31 Thread Joel Holdsworth
On 30/05/16 08:52, Riku Voipio wrote: On Wed, May 25, 2016 at 05:07:48PM +0100, Joel Holdsworth wrote: Considering the messiness this serieas adds to QEMU, I do wonder how much of win this avoidance really is. Suggestions on how to make it less messy would be welcome. If you have permissions

[Qemu-devel] [PATCH 2/4] linux-user: pass environment arguments in execve

2016-05-25 Thread Joel Holdsworth
Previously, when emulating execve(2), qemu would execute a child instance of the emulator with the environment variables provided by the parent process. This caused problems with qemu if any of the variables affected the child emulator's behaviour e.g. LD_LIBRARY_PATH. This patch solves this issue

[Qemu-devel] [PATCH 1/4] linux-user: add option to intercept execve() syscalls

2016-05-25 Thread Joel Holdsworth
From: Petros Angelatos In order for one to use QEMU user mode emulation under a chroot, it is required to use binfmt_misc. This can be avoided by QEMU never doing a raw execve() to the host system. Introduce a new option, -execve, that uses the current QEMU interpreter to intercept execve(). qe

[Qemu-devel] [PATCH 3/4] linux-user: pass elf interpreter prefix in execve

2016-05-25 Thread Joel Holdsworth
--- linux-user/syscall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b95f75a..fb75c09 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5855,7 +5855,7 @@ static abi_long qemu_execve(char *filename, char *ar

[Qemu-devel] linux-user: add option to intercept execve() syscalls

2016-05-25 Thread Joel Holdsworth
This patch-set includes Peter Angelatos's previous patch-set [1] and adds code to pass arguments for setting the environment variables, passing the interpeter prefix, and passing the strace option. [1] https://patchwork.ozlabs.org/patch/582756/

[Qemu-devel] [PATCH 4/4] linux-user: pass strace argument in execve

2016-05-25 Thread Joel Holdsworth
--- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fb75c09..314a890 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5966,6 +5966,8 @@ static abi_long qemu_execve(char *filename, char *argv[], arg