Re: [PULL 07/11] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-07-07 Thread John Högberg
Alright, thanks. Where should I go from here? Should I send in another patch that tries to debug this? /John -Original Message- From: Peter Maydell To: John Högberg Cc: phi...@linaro.org , richard.hender...@linaro.org , qemu-devel@nongnu.org Subject: Re: [PULL 07/11] tests/tcg/aarch64

Re: [PULL 07/11] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-07-06 Thread John Högberg
> That is enough to get it to build, but then in the CI the test > consistently fails: > > https://gitlab.com/pm215/qemu/-/jobs/4606447875 > > TEST icivau on aarch64 > make[1]: *** [Makefile:178: run-icivau] Error 1 > > I'm going to drop this patch from the pullreq until we > can figure out what's

Re: [PATCH qemu v4 0/2] target/arm: Improve user-mode compatibility with JITs

2023-06-27 Thread John Högberg
> Since there were only a couple of minor nits in this version > of the patchset I'm going to apply it to target-arm.next > and make those fixups in my tree. Thanks for this bug fix! Great, thanks for reviewing it :-) /John

Re: [PATCH qemu v3 1/2] target/arm: Handle IC IVAU to improve compatibility with JITs

2023-06-26 Thread John Högberg
Peter Maydell To: ~jhogberg Cc: qemu-devel@nongnu.org Subject: Re: [PATCH qemu v3 1/2] target/arm: Handle IC IVAU to improve compatibility with JITs Date: Mon, 26 Jun 2023 13:38:16 +0100 On Tue, 20 Jun 2023 at 02:04, ~jhogberg wrote: > > From: John Högberg > > Unlike architecture

Re: [PATCH qemu v2 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-19 Thread John Högberg
code > * execute it > * modify it > * execute again and check we got the changed version > > I don't see why we need four "compare" functions to do that. Sure, the self-modification test alone should suffice. Thanks again :) Regards, John Högberg

Re: [PATCH 1/2] target/arm: Handle IC IVAU to improve compatibility with JITs

2023-06-11 Thread John Högberg
Sorry, something went sideways on my end. I'll try re-sending the patchset tomorrow through the web-based interface mentioned in the documentation, hopefully that will be foolproof. :) Regards, John Högberg -Original Message- From: Michael Tokarev To: John Högberg , qemu-devel

[PATCH 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-11 Thread John Högberg
https://gitlab.com/qemu-project/qemu/-/issues/1034 Signed-off-by: John Högberg --- tests/tcg/aarch64/Makefile.target | 3 +- tests/tcg/aarch64/icivau.c| 204 ++ 2 files changed, 206 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/aarch64/icivau.c

[PATCH 1/2] target/arm: Handle IC IVAU to improve compatibility with JITs

2023-06-11 Thread John Högberg
. This commit works around the issue by invalidating code in IC IVAU instructions. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1034 Co-authored-by: Richard Henderson Signed-off-by: John Högberg --- target/arm/helper.c | 47 ++--- 1 file changed, 44

[PATCH 0/2] target/arm: Improve user-mode compatibility with JITs

2023-06-11 Thread John Högberg
. See https://gitlab.com/qemu-project/qemu/-/issues/1034 for more details John Högberg (2): target/arm: Handle IC IVAU to improve compatibility with JITs tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code target/arm/helper.c | 47 ++- tests/tcg/aarch64