Re: [PATCH v5 0/2] block/blkio: support fd passing for virtio-blk-vhost-vdpa driver

2023-05-31 Thread Jonathon Jongsma
On 5/30/23 2:19 AM, Stefano Garzarella wrote: v5: - moved `features` to the object level to simplify libvirt code [Jonathon] - wrapped a line too long in the documentation [Markus] - added Stefan R-b tags v4: https://lore.kernel.org/qemu-devel/20230526150304.158206-1-sgarz...@redhat.com/ - adde

Re: [PATCH v4 2/2] qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa

2023-05-26 Thread Jonathon Jongsma
On 5/26/23 10:03 AM, Stefano Garzarella wrote: The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the fd passing through the new 'fd' property. Since now we are using qemu_open() on '@path' if the virtio-blk driver supports the fd passing, let's announce it. In this way, the management

Re: [PATCH v3 1/1] block/blkio: use qemu_open() to support fd passing for virtio-blk

2023-05-25 Thread Jonathon Jongsma
On 5/25/23 1:30 PM, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 17, 2023 at 09:19:26AM +0200, Stefano Garzarella wrote: CCing Markus for some advice. On Tue, May 16, 2023 at 11:04:21AM -0500, Jonathon Jongsma wrote: [...] I need some way to determine that the particular

Re: [PATCH v3 1/1] block/blkio: use qemu_open() to support fd passing for virtio-blk

2023-05-16 Thread Jonathon Jongsma
On 5/15/23 5:10 AM, Stefano Garzarella wrote: On Thu, May 11, 2023 at 11:03:22AM -0500, Jonathon Jongsma wrote: On 5/11/23 4:15 AM, Stefano Garzarella wrote: The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' property. Let's expose this to the user, so

Re: [PATCH v3 1/1] block/blkio: use qemu_open() to support fd passing for virtio-blk

2023-05-11 Thread Jonathon Jongsma
On 5/11/23 4:15 AM, Stefano Garzarella wrote: The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' property. Let's expose this to the user, so the management layer can pass the file descriptor of an already opened vhost-vdpa character device. This is useful especially when the

Re: [PATCH v2 0/2] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-10 Thread Jonathon Jongsma
On 5/4/23 4:28 AM, Stefano Garzarella wrote: v2: - added patch 01 to use monitor_fd_param() in the blkio module - use monitor_fd_param() to parse the fd like vhost devices [Stefan] v1: https://lore.kernel.org/qemu-devel/20230502145050.224615-1-sgarz...@redhat.com/ The virtio-blk-vhost-vdpa dri

Re: [Qemu-devel] [Spice-devel] [PATCH spice 1/3] QXL interface: add a function to identify monitors in the guest

2019-01-14 Thread Jonathon Jongsma
On Fri, 2019-01-11 at 11:15 +0100, Lukáš Hrázký wrote: > On Wed, 2019-01-09 at 11:36 -0600, Jonathon Jongsma wrote: > > On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote: > > > Adds a function to let QEMU provide information to identify > > > graphics > > &g

Re: [Qemu-devel] [Spice-devel] [PATCH spice 2/3] QXL interface: deprecate spice_qxl_set_max_monitors

2019-01-09 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote: > Replace it by spice_qxl_set_device_info. Note we can't use > monitors_count for what's stored in max_monitors, because > monitors_count > denotes the length of the device_di

Re: [Qemu-devel] [Spice-devel] [PATCH spice 1/3] QXL interface: add a function to identify monitors in the guest

2019-01-09 Thread Jonathon Jongsma
On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote: > Adds a function to let QEMU provide information to identify graphics > devices and their monitors in the guest. The function > (spice_qxl_set_device_info) sets the device address (e.g. a PCI path) > and monitor ID -> device display ID mapping

Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-08 Thread Jonathon Jongsma
On Thu, 2018-11-08 at 11:05 +0100, Lukáš Hrázký wrote: > Hello, > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > + * The device_display_id_{start,count} denotes the sequence of > > > device display > > > + * IDs that map to the zero-based sequence of monitor IDs > >

Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest

2018-10-09 Thread Jonathon Jongsma
On Tue, 2018-10-09 at 15:10 +0200, Lukáš Hrázký wrote: > Adds two functions to let QEMU provide information to identify > graphics > devices and their monitors in the guest: > > * device path - The path identifying the device on the system (e.g. > PCI > path): > spice_qxl_device_set_path(...)

[Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state

2017-05-10 Thread Jonathon Jongsma
: Jonathon Jongsma --- ui/spice-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 8eeebdb..7fd283b 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -87,7 +87,7 @@ static void kbd_leds(void *opaque, int ledstate) if