Updated invitation: QEMU developers fortnightly conference call @ Every 2 weeks from 15:00 to 16:00 on Tuesday from Tue 2024-01-09 to Tue 2024-01-23 (GMT+1) (qemu-devel@nongnu.org)

2024-01-18 Thread Juan Quintela
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02

Updated invitation: QEMU developers fortnightly conference call @ Every 2 weeks from 15:00 to 16:00 on Tuesday from Tue 2024-01-23 to Wed 2023-02-22 (GMT+1) (qemu-devel@nongnu.org)

2024-01-18 Thread Juan Quintela
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02

Updated invitation: QEMU developers fortnightly conference call @ Every 2 weeks from 15:00 to 16:00 on Tuesday from Tue 2022-08-23 to Tue 2024-01-23 (GMT+2) (qemu-devel@nongnu.org)

2024-01-18 Thread Juan Quintela
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02

Re: [PATCH 1/1] Leaving Migration

2024-01-06 Thread Juan Quintela via
Bin Meng wrote: > On Wed, Jan 3, 2024 at 4:20 AM Juan Quintela wrote: >> >> I am leaving Red Hat, and as part of that I am leaving Migration >> maintenarship. > > maintainership? You are right, as usual O:-) >> >> You are left in good hands with Peter and

QEMU developers call

2024-01-02 Thread Juan Quintela
Uv Nf V nz yrnivat DRZH qrirybczrag, V pna'g unaqyr guvf pnyy. Fubhyq nalbar gnxr pner bs vg? V unir gnyxrq nobhg guvf jvgu Crgre, naq V guvax gung vs abobql fgrcf hc, ur pna "ibyhagrre" gb unaqyr vg. Yngre, Whna.

[PATCH 1/1] Leaving Migration

2024-01-02 Thread Juan Quintela
I am leaving Red Hat, and as part of that I am leaving Migration maintenarship. You are left in good hands with Peter and Fabiano. Thanks for all the fish. Signed-off-by: Juan Quintela --- MAINTAINERS | 3 --- .mailmap| 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 0/1] Leaving Red Hat

2024-01-02 Thread Juan Quintela
working with you. Looking at git logs, it appears that my 1st commit is from: commit 4f3a1d56e45bcd325f1e8a976290142bc8662bee Author: Juan Quintela Date: Thu Jun 25 00:07:59 2009 +0200 Rename OBJS to obj-y So it have been almost 15 years. As you can see for the commit, I changed

Updated invitation: QEMU developers fortnightly conference call @ Every 2 weeks from 15:00 to 16:00 on Tuesday (CEST) (qemu-devel@nongnu.org)

2023-12-27 Thread Juan Quintela
-NUM-GUESTS=0:mailto:f4...@amsat.org ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=Joao Martins;X-NUM-GUESTS=0:mailto:joao.m.mart...@oracle.com ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE ;CN=Juan Quintela;X-NUM-GUESTS=0

Updated invitation: QEMU developers fortnightly conference call @ Every 2 weeks from 15:00 to 16:00 on Tuesday (CET) (qemu-devel@nongnu.org)

2023-12-27 Thread Juan Quintela
-GUESTS=0:mailto:f4...@amsat.org ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=Joao Martins;X-NUM-GUESTS=0:mailto:joao.m.mart...@oracle.com ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=DECLINED;RSVP=TRUE ;CN=Juan Quintela;X-NUM-GUESTS=0:mailto:quint

QEMU developers fortnightly conference call for agenda for 2023-12-12

2023-12-05 Thread Juan Quintela
Hi If you have any topics for the last qemu conference call of the year, feel free to answer to this email. Later, Juan. QEMU developers fortnightly conference call Tuesday 2023-12-12 ⋅ 15:00 – 16:00 Central European Time - Madrid Location https://meet.jit.si/kvmcallmeeting

[PULL 1/2] migration/multifd: Stop setting p->ioc before connecting

2023-11-30 Thread Juan Quintela
From: Fabiano Rosas This is being shadowed but the assignments at multifd_channel_connect() and multifd_tls_channel_connect() . Signed-off-by: Fabiano Rosas Message-ID: <20231110200241.20679-2-faro...@suse.de> Signed-off-by: Juan Quintela --- migration/multifd.c | 3 +-- 1 file chan

[PULL 0/2] Migration 20231130 patches

2023-11-30 Thread Juan Quintela
The following changes since commit abf635ddfe3242df907f58967f3c1e6763bbca2d: Update version for v8.2.0-rc2 release (2023-11-28 16:31:16 -0500) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20231130-pull-request for you to fetch changes up

[PULL 2/2] migration: free 'saddr' since be no longer used

2023-11-30 Thread Juan Quintela
ion containing allocated strings,and will be used after that. So just free 'saddr' itself without doing a deep free on the contents of the SocketAddress. Fixes: 72a8192e225c ("migration: convert migration 'uri' into 'MigrateAddress'") Signed-off-by: Zongmin Zhou Reviewed-by: Juan Quintela Review

QEMU developers fortnightly conference call for agenda for 2023-11-28

2023-11-21 Thread Juan Quintela
Hi This is a call for topics for the agenda for 2023-11-28. I have asked Steven Sistare to describe its plans for merging patches for CPR and other updates in place. Later, Juan. QEMU developers fortnightly conference call Tuesday 2023-11-28 ⋅ 15:00 – 16:00 Central European Time - Madrid

Re: [RFC PATCH v2 1/4] migration/multifd: Stop setting p->ioc before connecting

2023-11-16 Thread Juan Quintela
Fabiano Rosas wrote: > This is being shadowed but the assignments at > multifd_channel_connect() and multifd_tls_channel_connect() . > > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [RFC PATCH 2/2] migration/multifd: Move semaphore release into main thread

2023-11-16 Thread Juan Quintela
Fabiano Rosas wrote: > Fabiano Rosas writes: > >> Peter Xu writes: >> >>> On Thu, Nov 09, 2023 at 01:58:56PM -0300, Fabiano Rosas wrote: >> I think we historically stumbled upon the fact that qemu_thread_join() >> is not the same as pthread_join(). The former takes a pointer and is not >> safe

Re: [PATCH-for-8.2 v4 09/10] hw/char/pl011: Add transmit FIFO to PL011State

2023-11-16 Thread Juan Quintela
Richard Henderson wrote: > On 11/9/23 11:28, Philippe Mathieu-Daudé wrote: >> @@ -436,6 +438,24 @@ static const VMStateDescription vmstate_pl011_clock = { >> } >> }; >> +static bool pl011_xmit_fifo_state_needed(void *opaque) >> +{ >> +PL011State* s = opaque; >> + >> +return

Re: [RFC PATCH 2/2] migration/multifd: Move semaphore release into main thread

2023-11-16 Thread Juan Quintela
Fabiano Rosas wrote: > Peter Xu writes: > >> On Thu, Nov 09, 2023 at 01:58:56PM -0300, Fabiano Rosas wrote: >>> We cannot operate on the multifd semaphores outside of the multifd >>> channel thread >>> because multifd_save_cleanup() can run in parallel and >>> attempt to destroy the mutexes,

Re: [RFC PATCH 2/2] migration/multifd: Move semaphore release into main thread

2023-11-16 Thread Juan Quintela
Peter Xu wrote: > On Thu, Nov 09, 2023 at 01:58:56PM -0300, Fabiano Rosas wrote: >> We cannot operate on the multifd semaphores outside of the multifd >> channel thread >> because multifd_save_cleanup() can run in parallel and >> attempt to destroy the mutexes, which causes an assert. >> >>

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

2023-11-16 Thread Juan Quintela
Michael Tokarev wrote: > 14.11.2023 22:05, Thomas Huth wrote: >> On 14/11/2023 17.58, Michael Tokarev wrote: >>> Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards >>> compatiblity" >>> Cc: Juan Quintela >>> Signed-off-by:

Re: [PATCH trivial 05/21] docs/about/deprecated.rst: spelling fix: becase

2023-11-16 Thread Juan Quintela
Michael Tokarev wrote: > Fixes: 864128df465a "migration: Deprecate old compression method" > Cc: Juan Quintela > Signed-off-by: Michael Tokarev > --- > docs/about/deprecated.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs

Re: [PATCH v2] migration: free 'saddr' since be no longer used

2023-11-16 Thread Juan Quintela
Zongmin Zhou wrote: > Since socket_parse() will allocate memory for 'saddr',and its value > will pass to 'addr' that allocated by migrate_uri_parse(), > then 'saddr' will no longer used,need to free. > But due to 'saddr->u' is shallow copying the contents of the union, > the members of this union

Re: Configuring migration

2023-11-14 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Tue, Nov 14, 2023 at 11:28:28AM +0100, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >> > On Thu, Nov 02, 2023 at 03:25:25PM +0100, Markus Armbruster wrote: >> >> Now let's try to apply this to migration. >> >> >&

Re: Configuring migration

2023-11-14 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Thu, Nov 02, 2023 at 03:25:25PM +0100, Markus Armbruster wrote: >> Now let's try to apply this to migration. >> >> As long as we can have just one migration, we need just one QAPI object >> to configure it. >> >> We could create the object with -object /

Re: Configuring migration

2023-11-14 Thread Juan Quintela
Markus Armbruster wrote: D> Cc: Paolo for QOM expertise. > > Peter Xu writes: > >> On Thu, Nov 02, 2023 at 03:25:25PM +0100, Markus Armbruster wrote: > > [...] > >>> Migration has its own idiosyncratic configuration interface, even though >>> its configuration needs are not special at all. This

Re: [PATCH v3 0/6] migration: check required entries and sections are loaded

2023-11-07 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Mon, Nov 06, 2023 at 03:35:54PM +0400, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> Surprisingly, the migration code doesn't check that required migration >> entries >> and subsections are loaded. Either optional or required

Re: [PULL 38/40] migration: Implement MigrateChannelList to qmp migration flow.

2023-11-06 Thread Juan Quintela
Peter Maydell wrote: > On Thu, 2 Nov 2023 at 11:46, Juan Quintela wrote: >> >> From: Het Gala >> >> Integrate MigrateChannelList with all transport backends >> (socket, exec and rdma) for both src and dest migration >> endpoints for qmp migration. &

Re: [PATCH 66/71] migration: Constify VMState

2023-11-06 Thread Juan Quintela
Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Juan Quintela > --- > migration/global_state.c | 2 +- > migration/savevm.c | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/migration/globa

Re: [PATCH 01/71] migration: Make VMStateDescription.subsections const

2023-11-06 Thread Juan Quintela
Richard Henderson wrote: > Allow the array of pointers to itself be const. > Propagate this through the copies of this field. > > Signed-off-by: Richard Henderson Reviewed-by: Juan Quintela > static const VMStateDescription * > -vmstate_get_subsection(const VMStateDescr

Re: [PATCH 70/71] tests/unit/test-vmstate: Constify VMState

2023-11-06 Thread Juan Quintela
Richard Henderson wrote: > While const data in tests is not particularly important, > this makes a grep test clear across the tree. > > Signed-off-by: Richard Henderson Reviewed-by: Juan Quintela

Re: [PATCH 71/71] docs: Constify VMstate in examples

2023-11-06 Thread Juan Quintela
Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Juan Quintela

[PULL 4/7] tests/migration: Introduce dirty-ring-size option into guestperf

2023-11-03 Thread Juan Quintela
/guestperf.py --dirty-ring-size 4096 xxx Signed-off-by: Hyman Huang Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <8a388cec5c1f73a34d42515bbc43837e97ee3839.1698847223.git.yong.hu...@smartx.com> --- tests/migration/guestperf/engine.py | 6 +- tests/migration/gue

[PULL 7/7] migration: Unlock mutex in error case

2023-11-03 Thread Juan Quintela
We were not unlocking bitmap mutex on the error case. To fix it forever change to enclose the code with WITH_QEMU_LOCK_GUARD(). Coverity CID 1523750. Fixes: a2326705e5 ("migration: Stop migration immediately in RDMA error paths") Reviewed-by: Alex Bennée Signed-off-by: Juan Quintela

[PULL 5/7] tests/migration: Introduce dirty-limit into guestperf

2023-11-03 Thread Juan Quintela
-host localhost --transport unix \ --filter compr-dirty-limit* --output outputdir Signed-off-by: Hyman Huang Reviewed-by: Fabiano Rosas Message-Id: <516e7a55dfc6e33d33510be37eb24223de5dc072.1697815117.git.yong.hu...@smartx.com> Message-ID: Signed-off-by: Juan Quintela --- tests/mig

[PULL 3/7] tests: Add migration dirty-limit capability test

2023-11-03 Thread Juan Quintela
pre-switchover phase. Note that this test case involves many passes, so it runs in slow mode only. Signed-off-by: Hyman Huang Acked-by: Peter Xu Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: --- tests/qtest/migration-test.c | 164

[PULL 2/7] system/dirtylimit: Drop the reduplicative check

2023-11-03 Thread Juan Quintela
From: Hyman Huang Checking if dirty limit is in service is done by the dirtylimit_query_all function, drop the reduplicative check in the qmp_query_vcpu_dirty_limit function. Signed-off-by: Hyman Huang Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela

[PULL 6/7] docs/migration: Add the dirty limit section

2023-11-03 Thread Juan Quintela
From: Hyman Huang The dirty limit feature has been introduced since the 8.1 QEMU release but has not reflected in the document, add a section for that. Signed-off-by: Hyman Huang Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID

[PULL 0/7] Migration 20231103 patches

2023-11-03 Thread Juan Quintela
/migration: Introduce dirty-ring-size option into guestperf tests/migration: Introduce dirty-limit into guestperf docs/migration: Add the dirty limit section Juan Quintela (1): migration: Unlock mutex in error case docs/devel/migration.rst| 71 ++ migration/ram.c

[PULL 1/7] system/dirtylimit: Fix a race situation

2023-11-03 Thread Juan Quintela
From: Hyman Huang Fix a race situation for global variable dirtylimit_state. Also, replace usleep by g_usleep to increase platform accessibility to the sleep function. Signed-off-by: Hyman Huang Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID

Re: [PATCH v15 12/14] migration: Implement MigrateChannelList to qmp migration flow.

2023-11-03 Thread Juan Quintela
lement (single interface) as runtime check. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

[PATCH v2] migration: Unlock mutex in error case

2023-11-03 Thread Juan Quintela
We were not unlocking bitmap mutex on the error case. To fix it forever change to enclose the code with WITH_QEMU_LOCK_GUARD(). Coverity CID 1523750. Fixes: a2326705e5 ("migration: Stop migration immediately in RDMA error paths") Signed-off-by: Juan Quintela --- migration/r

Re: [PATCH] migration: Unlock mutex in error case

2023-11-03 Thread Juan Quintela
Alex Bennée wrote: > Juan Quintela writes: > >> We were not unlocking bitmap mutex on the error case. >> Coverity discovered the problem. >> >> Fixes: a2326705e5 ("migration: Stop migration immediately in RDMA error >> paths") >> Signed-o

[PULL 32/40] migration: convert socket backend to accept MigrateAddress

2023-11-02 Thread Juan Quintela
Retnakaran Signed-off-by: Het Gala Reviewed-by: Daniel P. Berrangé Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-6-faro...@suse.de> --- migration/socket.h| 7 --- migration/migration.

[PULL 34/40] migration: convert exec backend to accept MigrateAddress.

2023-11-02 Thread Juan Quintela
-by: Het Gala Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-8-faro...@suse.de> --- migration/exec.h | 4 +-- migration/exec.c | 73 +++ migration/migration.c | 8 ++

[PULL 13/40] migration: Use vmstate_register_any() for eeprom93xx

2023-11-02 Thread Juan Quintela
We can have more than one eeprom93xx. For instance: e100_nic_realize() -> eeprom93xx_new() Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-13-quint...@redhat.com> --- hw/nvram/eeprom93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PULL 39/40] migration: Implement MigrateChannelList to hmp migration flow.

2023-11-02 Thread Juan Quintela
aro...@suse.de> Signed-off-by: Juan Quintela --- migration/migration.h | 3 ++- migration/migration-hmp-cmds.c | 23 +-- migration/migration.c | 5 ++--- 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/migration/migration.h b/migration/migration.h

[PULL 35/40] migration: Convert the file backend to the new QAPI syntax

2023-11-02 Thread Juan Quintela
From: Fabiano Rosas Convert the file: URI to accept a FileMigrationArgs to be compatible with the new migration QAPI. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-9-faro...@suse.de> --- migration/file.h

[PULL 25/40] tests/qtest: migration: add reboot mode test

2023-11-02 Thread Juan Quintela
From: Steve Sistare [ Maintainer note: I put the test as flaky because our CI has problems with shared memory. We will remove the flaky bits as soon as we get a solution. ] Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <1698263069-40697

[PULL 19/40] migration: Add tracepoints for downtime checkpoints

2023-11-02 Thread Juan Quintela
then have unified prefix for all downtime relevant tracepoints. Co-developed-by: Joao Martins Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231030163346.765724-6-pet...@redhat.com> --- migration/migration.c | 16 +++- migration/s

[PULL 30/40] migration: New QAPI type 'MigrateAddress'

2023-11-02 Thread Juan Quintela
. Fabiano fixed for "file" transport. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Reviewed-by: Juan Quintela Reviewed-by: Daniel P. Berrangé Acked-by: Markus Armbruster Signed-off-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-2-faro...@sus

[PULL 04/40] hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init()

2023-11-02 Thread Juan Quintela
From: Thomas Huth We must not call register_savevm_live() from an instance_init() function (since this could be called multiple times during device introspection). Move this to the realize() function instead. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Signed-off-by: Juan Quintela

[PULL 40/40] migration: modify test_multifd_tcp_none() to use new QAPI syntax.

2023-11-02 Thread Juan Quintela
From: Het Gala modify multifd tcp common test to incorporate the new QAPI syntax defined. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-15-faro...@suse

[PULL 36/40] migration: New migrate and migrate-incoming argument 'channels'

2023-11-02 Thread Juan Quintela
'MigrateChannel' to make migration QAPIs future proof. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Acked-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-10-f

[PULL 38/40] migration: Implement MigrateChannelList to qmp migration flow.

2023-11-02 Thread Juan Quintela
Retnakaran Signed-off-by: Het Gala Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-13-faro...@suse.de> --- migration/migration.c | 101 +++--- 1 file changed, 55 insertions(+), 46 del

[PULL 33/40] migration: convert rdma backend to accept MigrateAddress

2023-11-02 Thread Juan Quintela
-by: Aravind Retnakaran Signed-off-by: Het Gala Reviewed-by: Daniel P. Berrangé Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-7-faro...@suse.de> --- migration/rdma.h | 6 -- migration/migration.

[PULL 23/40] cpr: relax vhost migration blockers

2023-11-02 Thread Juan Quintela
of these blockers so they only apply to normal mode. They will not block cpr modes when they are added in subsequent patches. No functional change until a new mode is added. Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <1698263069-406971-5-git-s

[PULL 18/40] migration: migration_stop_vm() helper

2023-11-02 Thread Juan Quintela
From: Peter Xu Provide a helper for non-COLO use case of migration to stop a VM. This prepares for adding some downtime relevant tracepoints to migration, where they may or may not apply to COLO. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID

[PULL 31/40] migration: convert migration 'uri' into 'MigrateAddress'

2023-11-02 Thread Juan Quintela
: Het Gala Signed-off-by: Fabiano Rosas Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231023182053.8711-4-faro...@suse.de> Message-ID: <20231023182053.8711-5-faro...@suse.de> --- migration/exec.h | 4 +++ migr

[PULL 28/40] tests/migration-test: Add a test for postcopy hangs during RECOVER

2023-11-02 Thread Juan Quintela
is based on Fabiano's version here: https://lore.kernel.org/r/877cowmdu0@suse.de Signed-off-by: Fabiano Rosas [peterx: write commit message, remove case 1, fix bugs, and more] Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231017202633.29675

[PULL 37/40] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax

2023-11-02 Thread Juan Quintela
nel' : migration_channels_and_uri_compatible() -> migration_channels_and_transport_compatible() passes object as argument and check for valid transport mechanism. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Reviewed-by: Daniel P. Berrangé Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Sign

[PULL 22/40] cpr: relax blockdev migration blockers

2023-11-02 Thread Juan Quintela
for cpr. Narrow the scope of these blockers so they only apply to normal mode. They will not block cpr modes when they are added in subsequent patches. No functional change until a new mode is added. Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message

[PULL 27/40] migration: Allow network to fail even during recovery

2023-11-02 Thread Juan Quintela
eded using migrate-pause when needed. After bouncing back to PAUSED stage, one can recover again. Reported-by: Xiaohui Li Reviewed-by: Fabiano Rosas Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2111332 Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Qu

[PULL 24/40] cpr: reboot mode

2023-11-02 Thread Juan Quintela
-volatile across reboot, such as by backing it with a dax device, but this is not enforced. The restarted qemu arguments must match those used to initially start qemu, plus the -incoming option. Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID

[PULL 26/40] migration: Refactor error handling in source return path

2023-11-02 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231017202633.296756-2-pet...@redhat.com> --- migration/migration.h | 1 - migration/qemu-file.h | 1 + migration/ram.h| 5 +- migration/migration.c

[PULL 29/40] migration: Change ram_dirty_bitmap_reload() retval to bool

2023-11-02 Thread Juan Quintela
Quintela Signed-off-by: Juan Quintela Message-ID: <20231017202633.296756-5-pet...@redhat.com> --- migration/ram.h | 2 +- migration/migration.c | 18 +- migration/ram.c | 24 3 files changed, 22 insertions(+), 22 deletions(-) diff

[PULL 16/40] migration: Add migration_downtime_start|end() helpers

2023-11-02 Thread Juan Quintela
From: Peter Xu Unify the three users on recording downtimes with the same pair of helpers. Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231030163346.765724-3-pet...@redhat.com> --- migration/migration.

[PULL 12/40] migration: Use vmstate_register_any() for audio

2023-11-02 Thread Juan Quintela
We can have more than one audio backend. void audio_init_audiodevs(void) { AudiodevListEntry *e; QSIMPLEQ_FOREACH(e, , next) { audio_init(e->dev, _fatal); } } Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-12-quint...@redh

[PULL 17/40] migration: Add per vmstate downtime tracepoints

2023-11-02 Thread Juan Quintela
an save() super fast, but load() super slow, vice versa. We can't figure that out without tracing both. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231030163346.765724-4-pet...@redhat.com> --- m

[PULL 14/40] migration: Use vmstate_register_any() for vmware_vga

2023-11-02 Thread Juan Quintela
I have no idea if we can have more than one vmware_vga device, so play it safe. Reviewed-by: Stefan Berger Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-14-quint...@redhat.com> --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion

[PULL 20/40] migration: mode parameter

2023-11-02 Thread Juan Quintela
that the mode is shown by the 'info migrate' command. Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <1698263069-406971-2-git-send-email-steven.sist...@oracle.com> --- qapi/migration.json | 27 --- include/h

[PULL 11/40] migration: Improve example and documentation of vmstate_register()

2023-11-02 Thread Juan Quintela
Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-11-quint...@redhat.com> --- docs/devel/migration.rst | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index be91

[PULL 09/40] migration: Hack to maintain backwards compatibility for ppc

2023-11-02 Thread Juan Quintela
k_for_ppc() with warnings left and right that it is a hack. CC: Cedric Le Goater CC: Daniel Henrique Barboza CC: David Gibson CC: Greg Kurz Reviewed-by: Nicholas Piggin Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-8-quint...@redhat.com> --- include/migration/vmstat

[PULL 21/40] migration: per-mode blockers

2023-11-02 Thread Juan Quintela
Error object may be added to multiple lists. When a block is deleted, it is removed from every list, and the Error is freed. No functional change until a new mode is added. Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <1698263069-406971-3-

[PULL 15/40] migration: Set downtime_start even for postcopy

2023-11-02 Thread Juan Quintela
in postcopy_start() along the way. Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231030163346.765724-2-pet...@redhat.com> --- migration/migration.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PULL 07/40] migration: Use vmstate_register_any() for isa-ide

2023-11-02 Thread Juan Quintela
exit status 1 (expected 0) Aborted (core dumped) $ Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-4-quint...@redhat.com> --- hw/ide/isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/isa.c b/hw/ide/isa.c index 9505

[PULL 00/40] Migration 20231102 patches

2023-11-02 Thread Juan Quintela
MigrateChannelList to hmp migration flow. migration: modify test_multifd_tcp_none() to use new QAPI syntax. Juan Quintela (9): migration: Create vmstate_register_any() migration: Use vmstate_register_any() migration: Use vmstate_register_any() for isa-ide migration: Use VMSTATE_INSTANCE_ID_ANY

[PULL 10/40] migration: Check in savevm_state_handler_insert for dups

2023-11-02 Thread Juan Quintela
Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-10-quint...@redhat.com> --- migration/savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/migration/savevm.c b/migratio

[PULL 05/40] migration: Create vmstate_register_any()

2023-11-02 Thread Juan Quintela
-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-2-quint...@redhat.com> --- include/migration/vmstate.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 1af181877c..1ea9

[PULL 08/40] migration: Use VMSTATE_INSTANCE_ID_ANY for slirp

2023-11-02 Thread Juan Quintela
/qtest/libqtest.c:195: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) Aborted (core dumped) Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-6-quint...@redhat.com> --- net/slirp.c | 5 +++-- 1 file chan

[PULL 06/40] migration: Use vmstate_register_any()

2023-11-02 Thread Juan Quintela
This are the easiest cases, where we were already using VMSTATE_INSTANCE_ID_ANY. Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-3-quint...@redhat.com> --- backends/dbus-vmstate.c | 3 +-- backends/tpm/tpm_emulator.c | 3 +-- hw/i2c/

[PULL 01/40] hw/ipmi: Don't call vmstate_register() from instance_init() functions

2023-11-02 Thread Juan Quintela
From: Thomas Huth instance_init() can be called multiple times, e.g. during introspection of the device. We should not install the vmstate handlers here. Do it in the realize() function instead. Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela Acked-by: Corey Minyard Signed-off-by: Juan

[PULL 02/40] hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init()

2023-11-02 Thread Juan Quintela
quite a bit. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Acked-by: Juan Quintela Signed-off-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231020150554.664422-2-th...@redhat.com> --- hw/s390x/s390-skeys.c | 36 +--- 1 file ch

[PULL 03/40] hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property

2023-11-02 Thread Juan Quintela
From: Thomas Huth There's no need for dedicated handlers here if they don't do anything special. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Acked-by: Juan Quintela Signed-off-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231020150554.664422-3-th...@redhat.

Re: [v3 6/6] docs/migration: Add the dirty limit section

2023-11-02 Thread Juan Quintela
ff8e898030c827a3.1697815117.git.yong.hu...@smartx.com> Reviewed-by: Juan Quintela I queued the whole series. I didn't comment about the guestperf script changes because I am not familiar with that part. > --- > docs/devel/migration.rst | 71 > 1

Re: [v3 3/6] tests: Add migration dirty-limit capability test

2023-11-02 Thread Juan Quintela
capability > 5. check if migration satisfy the convergence condition >during pre-switchover phase. > > Note that this test case involves many passes, so it runs > in slow mode only. > > Signed-off-by: Hyman Huang > Acked-by: Peter Xu > Reviewed-by: Fabiano Rosas > Message-Id: > Reviewed-by: Juan Quintela

Re: [v3 1/6] system/dirtylimit: Fix a race situation

2023-11-02 Thread Juan Quintela
Hyman Huang wrote: > Fix a race situation for global variable dirtylimit_state. > > Also, replace usleep by g_usleep to increase platform > accessibility to the sleep function. > > Signed-off-by: Hyman Huang > Reviewed-by: Fabiano Rosas > Message-Id: > Reviewed-by: Juan Quintela queued.

Re: [v3 2/6] system/dirtylimit: Drop the reduplicative check

2023-11-02 Thread Juan Quintela
osas > Message-Id: > <31384f768279027560ab952ebc2bbff1ddb62531.1697815117.git.yong.hu...@smartx.com> Reviewed-by: Juan Quintela queued.

[PATCH] migration: Unlock mutex in error case

2023-11-02 Thread Juan Quintela
We were not unlocking bitmap mutex on the error case. Coverity discovered the problem. Fixes: a2326705e5 ("migration: Stop migration immediately in RDMA error paths") Signed-off-by: Juan Quintela --- migration/ram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/ram.c b

Re: [PATCH v15 13/14] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-31 Thread Juan Quintela
Het Gala wrote: > On 01/11/23 12:25 am, Juan Quintela wrote: >> I intrehated al parches until this forma next pull. > I should just add the last 2 patches as individual ones, is that what > you mean ? Take a look at: https://gitlab.com/juan.quintela/qemu/-/commits/migration-n

Re: [PATCH v4 3/5] tests/migration-test: Add a test for postcopy hangs during RECOVER

2023-10-31 Thread Juan Quintela
Fabiano Rosas wrote: > Peter Xu writes: > >> From: Fabiano Rosas >> >> To do so, create two paired sockets, but make them not providing real data. >> Feed those fake sockets to src/dst QEMUs for recovery to let them go into >> RECOVER stage without going out. Test that we can always kick it

Re: [PATCH v15 13/14] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-31 Thread Juan Quintela
I intrehated al parches until this forma next pull. On Tue, Oct 31, 2023, 19:51 Het Gala wrote: > > On 31/10/23 11:12 pm, Juan Quintela wrote: > > Fabiano Rosas wrote: > >> From: Het Gala > >> > >> Integrate MigrateChannelList with all transport backend

Re: [PATCH v15 12/14] migration: Implement MigrateChannelList to qmp migration flow.

2023-10-31 Thread Juan Quintela
lement (single interface) as runtime check. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 13/14] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-31 Thread Juan Quintela
Fabiano Rosas wrote: > From: Het Gala > > Integrate MigrateChannelList with all transport backends > (socket, exec and rdma) for both src and dest migration > endpoints for hmp migration. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Signed-off-by: Fabiano Rosas >

Re: [PATCH v15 09/14] migration: New migrate and migrate-incoming argument 'channels'

2023-10-31 Thread Juan Quintela
e 'MigrateChannelList' > as the new argument over 'MigrateChannel' to make migration > QAPIs future proof. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Acked-by: Markus Armbruster > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 10/14] fixup! migration: New migrate and migrate-incoming argument 'channels'

2023-10-31 Thread Juan Quintela
Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela

Re: [PATCH v15 14/14] migration: modify test_multifd_tcp_none() to use new QAPI syntax.

2023-10-31 Thread Juan Quintela
Fabiano Rosas wrote: > From: Het Gala > > modify multifd tcp common test to incorporate the new QAPI > syntax defined. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 11/14] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax

2023-10-31 Thread Juan Quintela
> Reviewed-by: Daniel P. Berrangé > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 08/14] migration: Convert the file backend to the new QAPI syntax

2023-10-31 Thread Juan Quintela
Fabiano Rosas wrote: > Convert the file: URI to accept a FileMigrationArgs to be compatible > with the new migration QAPI. > > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 07/14] migration: convert exec backend to accept MigrateAddress.

2023-10-31 Thread Juan Quintela
n into strList struct. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 06/14] migration: convert rdma backend to accept MigrateAddress

2023-10-31 Thread Juan Quintela
ion into well defined InetSocketAddress struct. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

  1   2   3   4   5   6   7   8   9   10   >