Hi Eric,
thank you for your comments. My answers are inlined.
On 08.03.2017 03:36, Eric Blake wrote:
>
> I'm just focusing on the QMP interface portion of this.
>
> Is any of this information...
>
>> This patch moves the logic of the rdmsr and wrmsr functions to helper.c and
>> replaces their
On 08.03.2017 04:09, Richard Henderson wrote:
> On 03/08/2017 11:16 AM, Julian Kirsch wrote:
>> For instance, many modern x86-64 operating systems maintain access to
>> internal
>> data structures via the MSR_GSBASE/MSR_KERNELGSBASE MSRs. Giving
>> introspection ut
On 08.03.2017 12:59, Dr. David Alan Gilbert wrote:
> * Julian Kirsch (g...@kirschju.re) wrote:
>
> I'll leave those who know more about gdb to answer whether that's the best way
> of doing it; but I can see them being useful to those just trying to debug
> stuff from the
On 08.03.2017 14:57, Eduardo Habkost wrote:
>>
>> This should be abstracted some how so that we don't need
>> x86 specifics in cpus.c; perhaps just an architecture call
>> back on the CPU.
>
> If it's only supported by x86, I would just move the
> implementation to a x86-specific file, and add a
On 09.03.2017 18:27, Eduardo Habkost wrote:
> On Thu, Mar 09, 2017 at 05:32:08PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 08/03/2017 19:44, Eduardo Habkost wrote:
> If it's only supported by x86, I would just move the
> implementation to a x86-specific file, and add a stub for the
> othe
On 10.03.2017 15:09, Igor Mammedov wrote:
> we are trying no to use cpu_index in outside interfaces and
> make it disappear from there.
> It's possible to use qom-path instead or more natural
> CpuInstanceProperties to specify a CPU.
>
> PS:
> Comment applies to all QMP/monitor commands/structure
Good catch, thanks!
-Julian
On 24.04.2017 18:32, Dr. David Alan Gilbert wrote:
> Shouldn't the use of '-' be '_' in those to match the .name (and in the -set
> variant
> below) ?
>
> Dave
ping
I kindly request your comments.
On 29.03.2017 20:30, Julian Kirsch wrote:
> Provide read/write access to x86 model specific registers (MSRs) by means of
> two new HMP commands "msr_get" and "msr_set". The rationale behind this
> is to improve introspe
> I can't find the original series on either qemu-devel archives,
> or on my own mail archive.
>
> Searching for the Message-Id you were replying to, I can't find
> any matches:
> https://www.mail-archive.com/search?l=mid&q=20170329183017.14026-1-git%40kirschju.re
>
On 13.03.2017 18:12, Eric Blake wrote:
> Most HMP commands still use '_'; it is only QMP where we insist on '-'
> in new interfaces. (And yes, there's not much rhyme or reason to that
> other than backwards consistency.)
Hi Eric,
sorry, I got confused about the "-"/"_" matter by a comment on an
Hi Eduardo,
thanks for taking the time to look through the patch series. To recapitulate for
the next iteration:
1.) Let the rd/wrmsr functions set the valid variable in case of
CONFIG_USER_ONLY being set.
2.) Split up patch into code movement followed by reordering
3.) I included only MSR_KV
11 matches
Mail list logo
