[Qemu-devel] [PATCH v4 2/2] qga/qmp_guest_fstrim: Return per path fstrim result

2015-05-11 Thread Justin Ossevoort
some mountpoints that error is returned and the guest-fstrim continue with any additional mountpoints. The returned values for errors, minimum and trimmed are dependant on the filesystem, storage stacks and kernel version. Signed-off-by: Justin Ossevoort --- qga/commands-posix.c | 54

[Qemu-devel] [PATCH v4 0/2] Fix guest-fstrim behaviour

2015-05-11 Thread Justin Ossevoort
h 2 to indicate returned values are filesystem, storage stack and kernel version dependant Justin Ossevoort (2): qga/commands-posix: Fix bug in guest-fstrim qga/commands-posix: Return per path fstrim result qga/commands-posix.c | 63

[Qemu-devel] [PATCH v4 1/2] qga/commands-posix: Fix bug in guest-fstrim

2015-05-11 Thread Justin Ossevoort
. If a previous filesystem would have trimmed 0 bytes, than the next filesystem would report an error 'Invalid argument' because a FITRIM request with length 0 is not valid. This change resets the fstrim_range structure for each filesystem. Signed-off-by: Justin Ossevoort --- qga/comman

Re: [Qemu-devel] [PATCH v3 2/2] qga/commands-posix: Return per path fstrim result

2015-05-01 Thread Justin Ossevoort
On 30-04-15 18:35, Thomas Huth wrote: On Thu, 30 Apr 2015 16:29:58 +0200 Justin Ossevoort wrote: The current guest-fstrim support only returns an error if some mountpoint was unable to be trimmed, skipping any possible additional mountpoints. The result of the TRIM operation itself is also

[Qemu-devel] [PATCH v3 0/2] Fix guest-fstrim behaviour

2015-04-30 Thread Justin Ossevoort
timate details about the filesystem layout of the guest. Justin Ossevoort (2): qga/commands-posix: Fix bug in guest-fstrim qga/commands-posix: Return per path fstrim result qga/commands-posix.c | 63 qga/qapi-schema.json | 32

[Qemu-devel] [PATCH v3 2/2] qga/commands-posix: Return per path fstrim result

2015-04-30 Thread Justin Ossevoort
some mountpoints that error is returned and the guest-fstrim continue with any additional mountpoints. Signed-off-by: Justin Ossevoort --- qga/commands-posix.c | 54 ++-- qga/qapi-schema.json | 32 --- 2 files changed, 69

[Qemu-devel] [PATCH v3 1/2] qga/commands-posix: Fix bug in guest-fstrim

2015-04-30 Thread Justin Ossevoort
. If a previous filesystem would have trimmed 0 bytes, than the next filesystem would report an error 'Invalid argument' because a FITRIM request with length 0 is not valid. This change resets the fstrim_range structure for each filesystem. Signed-off-by: Justin Ossevoort --- qga/comman

Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-04-02 Thread Justin Ossevoort
Hello, I posted a PATCH v2 yesterday that does this. It returns the result per filesystem, with the name, mountpoint and filesystem type. Eric requested output similar to fsinfo (that's why name and type is included), but I'm not really convinced it is meaningful. Especially 'name' is someth

[Qemu-devel] [PATCH v2] qga/commands-posix: Fix bug in guest-fstrim

2015-04-01 Thread Justin Ossevoort
with their status. If the trime operation succeeded it returns the amount of bytes trimmed and the effective minimum chunk size. On error it returns the value of the errno for that filesystem operation (instead of aborting the request). Signed-off-by: Justin Ossevoort --- qga/commands-pos

[Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-03-31 Thread Justin Ossevoort
ilesystems, providing a hint to the caller about how effective the guest-fstrim request was. Signed-off-by: Justin Ossevoort --- qga/commands-posix.c | 19 +++ qga/qapi-schema.json | 5 +++-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/qga/commands-posix.c b/qg