Em qui., 23 de dez. de 2021 às 09:54, Cédric Le Goater escreveu:
>
> [ Adding Klaus ]
Thanks Cedric. It's been a while since I've looked at this but I'll do my best..
>
> On 12/22/21 03:22, Troy Lee wrote:
> > Accumulative mode will supply a initial state and append padding bit at
> > the end
Goater
Reviewed-by: Klaus Heinrich Kiwi
---
tests/qtest/aspeed_hace-test.c | 321 +
MAINTAINERS| 1 +
tests/qtest/meson.build| 3 +
3 files changed, 325 insertions(+)
create mode 100644 tests/qtest/aspeed_hace-test.c
diff --git a
mented",
+ __func__);
+}
+if (data & BIT(1)) {
+qemu_log_mask(LOG_UNIMP,
+ "%s: Cascaded mode not implemented",
+ __func__);
+ if the guest is requesting a command that is not implemented, wouldn't
it be safer to bail out
and return instead of just logging and continue?
-Klaus
--
Klaus Heinrich Kiwi
3-j...@jms.id.au>
Signed-off-by: Cédric Le Goater
Reviewed-by: Klaus Heinrich Kiwi
---
docs/system/arm/aspeed.rst | 2 +-
include/hw/arm/aspeed_soc.h | 3 +++
hw/arm/aspeed_ast2600.c | 15 +++
hw/arm/aspeed_soc.c | 16
4 files changed, 35 inse
if it's Friday evening :-(
But I'm guessing this can be fixed on merge or if a (real)
next version is necessary. Let me know otherwise.
-Klaus
--
Klaus Heinrich Kiwi
Complement the Aspeed HACE support with Scatter-Gather hash support for
sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
Signed-off-by: Klaus Heinrich Kiwi
---
docs/system/arm/aspeed.rst | 2 +-
hw/misc/aspeed_hace.c | 126 +++--
2
These operations are supported on AST2600 series of machines.
Signed-off-by: Klaus Heinrich Kiwi
---
Changes since V2:
* Fixed spurious comment removing conditional
Changes since V1:
* Use address_space_ldl_le() to load single addresses instead of
address_space_map()
* Updated
Expand current Aspeed HACE testsuite to also include Scatter-Gather of
sha256 and sha512 operations.
Signed-off-by: Klaus Heinrich Kiwi
---
tests/qtest/aspeed_hace-test.c | 156 +++--
1 file changed, 147 insertions(+), 9 deletions(-)
diff --git a/tests/qtest
Expand current Aspeed HACE testsuite to also include Scatter-Gather of
sha256 and sha512 operations.
Signed-off-by: Klaus Heinrich Kiwi
---
tests/qtest/aspeed_hace-test.c | 156 +++--
1 file changed, 147 insertions(+), 9 deletions(-)
diff --git a/tests/qtest
On 3/26/2021 4:30 PM, Klaus Heinrich Kiwi wrote:
Complement the Aspeed HACE support with Scatter-Gather hash support for
+
+/*
+ * Set status bits to indicate completion. Testing shows hardware sets
+ * these irrespective of HASH_IRQ_EN.
+ */
+//if (!rc) {
+s
Complement the Aspeed HACE support with Scatter-Gather hash support for
sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
Signed-off-by: Klaus Heinrich Kiwi
---
docs/system/arm/aspeed.rst | 2 +-
hw/misc/aspeed_hace.c | 126 +++--
2
This series adds support for scatter-gather sha256 and sha512 operations
on Aspeed's HACE (Hash And Crypto Engine) to the Aspeed model, as well
as testcases for them.
These operations are supported on AST2600 series of machines.
Signed-off-by: Klaus Heinrich Kiwi
---
Changes since V1:
* Use
uint32_t src_direct;
You could leave this one the same.
+uint32_t src_sg;
You add this, but haven't written a new test to use it.
Turns out there's nothing special about src/dst/len masking
when using HASH_SG_EN, so I'll remove those.
Thanks,
-Klaus
--
Klaus Heinrich Kiwi
On 3/25/2021 4:55 AM, Cédric Le Goater wrote:
On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote:
Complement the Aspeed HACE support with Scatter-Gather hash support for
sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
Signed-off-by: Klaus Heinrich Kiwi
this looks good
Hi Joel,
On 3/25/2021 12:40 AM, Joel Stanley wrote:
On Wed, 24 Mar 2021 at 22:39, Klaus Heinrich Kiwi
wrote:
Complement the Aspeed HACE support with Scatter-Gather hash support for
sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
Please update the documentation
Hi Cedric,
On 3/24/2021 7:57 PM, Cédric Le Goater wrote:
On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote:
Basically using camelCase for some variables...
I don't think CamelCase applies to variables, only types.
Thanks, I think I mis-interpreted your comment on this.
Will re-factor
Expand current Aspeed HACE testsuite to also include Scatter-Gather of
sha256 and sha512 operations.
Signed-off-by: Klaus Heinrich Kiwi
---
tests/qtest/aspeed_hace-test.c | 164 ++---
1 file changed, 153 insertions(+), 11 deletions(-)
diff --git a/tests/qtest
Complement the Aspeed HACE support with Scatter-Gather hash support for
sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
Signed-off-by: Klaus Heinrich Kiwi
---
hw/misc/aspeed_hace.c | 127 --
include/hw/misc/aspeed_hace.h | 6 ++
2
Basically using camelCase for some variables...
Signed-off-by: Klaus Heinrich Kiwi
---
hw/misc/aspeed_hace.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
index 6e5b447a48..93313d2b80 100644
--- a/hw
This series adds support for scatter-gather sha256 and sha512 operations
on Aspeed's HACE (Hash And Crypto Engine) to the Aspeed model. These
operations are supported on AST2600 series of machines.
-Klaus
Hi,
since the ppc64 target is broken for a while now, I was hoping to use
Qemu's user mode emulation to test some ppc64 packages and
cross-building/debugging.
I couldn't find much documentation about this in Fabrice's page, so I was
hoping to get help about what do I need to run ppc64
21 matches
Mail list logo
