time sending. Please refer to:
I'll take a look at it, thanks.
--
Leandro Dorileo
On Wed, Apr 30, 2014 at 10:28:26AM +0200, Markus Armbruster wrote:
Leandro Dorileo l...@dorileo.org writes:
Hi Andreas,
On Mon, Apr 28, 2014 at 09:02:12PM +0200, Andreas Färber wrote:
Am 28.04.2014 20:55, schrieb Leandro Dorileo:
ping?
On Tue, Mar 25, 2014 at 10:27:19AM
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered in future improvements.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
Notes
On Tue, Apr 29, 2014 at 05:08:10PM +0800, Chunyan Liu wrote:
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
util/qemu-option.c | 28
...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
Changes to V25:
* split v25 patch into two: this one and next one.
* this patch is the same as v22 which is reviewed-by Eric.
include/qemu/option.h | 3 ++-
util/qemu-option.c| 56
with
print_option_parameters, remove last printf and print size/number with
opt-value.uint instead of opt-str.
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
util/qemu-option.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/util/qemu
On Tue, Apr 29, 2014 at 05:08:13PM +0800, Chunyan Liu wrote:
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l
and malloced strings everywhere, the
usage of this struct becomes clearer.
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option_int.h | 4 ++--
qapi/opts-visitor.c | 10
-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
util/qemu-option.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 69cdf3f..4d2d4d1
...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 6 +++
util/qemu-option.c| 116
--
2 files changed, 109 insertions(+), 13 deletions(-)
diff
...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 1 +
util/qemu-option.c| 13 +
2 files changed, 14 insertions(+)
diff --git a/include/qemu/option.h b/include/qemu/option.h
index 6653e43..fbf5dc2
.
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 9 +++
util/qemu-option.c| 153
On Tue, Apr 29, 2014 at 05:08:20PM +0800, Chunyan Liu wrote:
To simplify later using of qemu_opts_del, accept NULL input.
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l
'
+qemu-img: Invalid parameter 'foo'
qemu-img: Invalid options for file format 'qcow2'
Changing the cluster size is not supported.
qemu-img: Error while amending options: Operation not supported
Regards...
--
Leandro Dorileo
error_report(Invalid options for file format '%s', fmt
Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
Did you send the patch series twice? I commented in the first v26 emails...
--
Leandro Dorileo
---
Changes to V25:
* fix Eric's comments:
* update bdrv_create_co_entry and bdrv_amend_options code, to let
Hi Chunyan,
I haven't found enough time the last versions you've sent for review. I've buit
your
patch series and the final result builds nicely, but it fails the test 061, I
haven't
had the time to investigate it yet.
I'm leaving on vacation next Friday so I'll try to review all you patches
ping?
On Tue, Mar 25, 2014 at 10:27:19AM -0300, Leandro Dorileo wrote:
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his
QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered
Hi Andreas,
On Mon, Apr 28, 2014 at 09:02:12PM +0200, Andreas Färber wrote:
Am 28.04.2014 20:55, schrieb Leandro Dorileo:
ping?
On Tue, Mar 25, 2014 at 10:27:19AM -0300, Leandro Dorileo wrote:
Cover basic aspects and API usage for QemuOpt. The current implementation
covers
On Thu, Apr 10, 2014 at 11:36:05AM +0800, Chunyan Liu wrote:
2014-04-08 9:31 GMT+08:00 Leandro Dorileo l...@dorileo.org:
On Thu, Apr 03, 2014 at 05:54:20PM +0800, Chunyan Liu wrote:
Add def_value_str (default value) to QemuOptDesc, to replace function of
the
default value
On Thu, Apr 10, 2014 at 11:20:46AM +0800, Chunyan Liu wrote:
2014-04-08 9:12 GMT+08:00 Leandro Dorileo l...@dorileo.org:
On Thu, Apr 03, 2014 at 05:54:18PM +0800, Chunyan Liu wrote:
This patch series is to replace QEMUOptionParameter with QemuOpts, so
that only
one Qemu Option
/nfs.c is missing conversion. Have you tested your own patches?
A simple git am config make is enough to break the build.
--
Leandro Dorileo
block.c | 96
block/cow.c | 52 ++--
block/gluster.c | 73 +++---
block/iscsi.c | 32
On Thu, Apr 03, 2014 at 05:54:19PM +0800, Chunyan Liu wrote:
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
util/qemu-option.c | 28 ++--
1 file changed, 14 insertions(+), 14
(stderr, %s=%s , desc-name, value);
+}
}
fprintf(stderr, \n);
I see you removed this fprintf() in the commit
afe65f5c92694d551aaebc128233b623e8665d5e
Please do this change in this commit and avoid breaking the block tests in
further commits.
--
Leandro Dorileo
-return 0
...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
Changes:
* check non-empty list
include/qemu/option.h | 1 +
util/qemu-option.c| 13 +
2 files changed, 14 insertions(+)
diff --git a/include/qemu/option.h b/include/qemu/option.h
index 6653e43..fbf5dc2
(since 2.1).
But if you feel comfortable with the current text you can add:
Reviewed-by: Leandro Dorileo l...@dorileo.org
--
Leandro Dorileo
# Since 1.5
##
{ 'type': 'CommandLineParameterInfo',
'data': { 'name': 'str',
'type': 'CommandLineParameterType',
-'*help
and malloced strings everywhere, the
usage of this struct becomes clearer.
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
Changes:
* Add explaination to this change.
* Remove extra space before char *name, char *str;
include/qemu
-by: Eric Blake ebl...@redhat.com
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
util/qemu-option.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index eab5102..25abd65
On Thu, Mar 27, 2014 at 09:59:21AM +, Alex Bennée wrote:
Leandro Dorileo l...@dorileo.org writes:
On Wed, Mar 26, 2014 at 02:37:12PM +, alex.ben...@linaro.org wrote:
From: Alex Bennée alex.ben...@linaro.org
When debugging stuff that occurs over several forks it would
)?
The patch looks good, I tested it and it works properly, so
Reviewed-by: Leandro Dorileo l...@dorileo.org
+abort();
+}
return;
}
}
diff --git a/vl.c b/vl.c
index 0464494..bd44c52 100644
--- a/vl.c
+++ b/vl.c
@@ -111,7 +111,6 @@ int
CPU registers before each executed TB (lots of logs) },
what about s/lots of logs/hight volume log/ or maybe s/lots of logs/hight
volume/ ?
Regards
--
Leandro Dorileo
{ CPU_LOG_PCALL, pcall,
x86 only: show protected mode far calls/returns/exceptions },
{ CPU_LOG_RESET
(filename, getpid());
+} else {
+g_error(Bad logfile format: %s, filename);
+}
+} else {
+logfilename = g_strdup(filename);
+}
qemu_log_close();
qemu_set_log(qemu_loglevel);
}
Looks good to me.
--
Leandro Dorileo
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered in future improvements.
Signed-off-by: Leandro Dorileo l...@dorileo.org
Reviewed
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered in future improvements.
Signed-off-by: Leandro Dorileo l...@dorileo.org
Reviewed
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered in future improvements.
Signed-off-by: Leandro Dorileo l...@dorileo.org
Reviewed
stuffs I could not successfuly run
the io tests.
Testing with all your patches applied I could also not run
the io tests, they all failed.
Regards...
--
Leandro Dorileo
);
-}
-
/* If dst is NULL, after realloc, some area of dst should be initialized
* before adding options to it.
*/
@@ -1543,6 +1125,5 @@ QemuOptsList *qemu_opts_append(QemuOptsList *dst,
}
}
-g_free(tmp_list);
return dst;
}
--
1.7.12.4
--
Leandro
a test in the test-opts-visitor.c test suite so we can
understand
the problem you're fixing here?
Regards...
--
Leandro Dorileo
const QemuOptDesc *desc;
union {
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 5d830a2..7a64f4e 100644
--- a/qapi/opts-visitor.c
...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 1 +
util/qemu-option.c| 11 +++
2 files changed, 12 insertions(+)
diff --git a/include/qemu/option.h b/include/qemu/option.h
index 6653e43..fbf5dc2 100644
--- a/include/qemu/option.h
+++ b
On Fri, Mar 21, 2014 at 06:12:20PM +0800, Chunyan Liu wrote:
For later merge .create_opts of drv and proto_drv in qemu-img commands.
Signed-off-by: Chunyan Liu cy...@suse.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
Changes:
* Following Eric's suggestion, qemu_opts_append
-qcow_filename = NULL;
return ret;
--
1.7.12.4
--
Leandro Dorileo
ignoring/silencing an informed option, I think it's fear enough to
notify the caller
about it - even if we're never using it for amend.
Regards...
--
Leandro Dorileo
} else if (!strcmp(options[i].name, size)) {
new_size = options[i].value.n;
} else if (!strcmp
(stderr, %s=%s , desc-name, value);
+printf(%s=%s , desc-name, value);
}
}
-fprintf(stderr, \n);
+printf(\n);
This new line is breaking most of the io tests since it changes
the expected output.
Regards...
--
Leandro Dorileo
}
static int
On Tue, Mar 25, 2014 at 06:09:40PM +, Leandro Dorileo wrote:
On Fri, Mar 21, 2014 at 06:12:11PM +0800, Chunyan Liu wrote:
This patch series is to replace QEMUOptionParameter with QemuOpts, so that
only
one Qemu Option structure is kept in QEMU code.
---
Changes to v21
Hi Chunyan,
On Mon, Mar 24, 2014 at 11:02:14AM +0800, Chunyan Liu wrote:
2014-03-21 20:31 GMT+08:00 Leandro Dorileo l...@dorileo.org:
On Fri, Mar 21, 2014 at 06:09:22PM +0800, Chunyan Liu wrote:
2014-03-21 8:07 GMT+08:00 Leandro Dorileo l...@dorileo.org:
Hi Chunyan,
On Mon
On Mon, Mar 24, 2014 at 02:06:15PM +0800, Deepak Kathayat wrote:
Signed-off-by: Deepak Kathayat deepak.m...@gmail.com
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
block/qcow2.h |1 -
1 file changed, 1 deletion(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 0b0eac8
-img.c:588
1 __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
2 _start ()
(gdb)
Signed-off-by: Prasad Joshi prasadjoshi.li...@gmail.com
Patch looks good to me.
Reviewed-by: Leandro Dorileo l...@dorileo.org
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi Kevin,
On Fri, Mar 21, 2014 at 11:34:53AM +0100, Kevin Wolf wrote:
Am 21.03.2014 um 01:07 hat Leandro Dorileo geschrieben:
Hi Chunyan,
On Mon, Mar 10, 2014 at 03:31:36PM +0800, Chunyan Liu wrote:
This patch series is to replace QEMUOptionParameter with QemuOpts, so
that only
On Fri, Mar 21, 2014 at 06:09:22PM +0800, Chunyan Liu wrote:
2014-03-21 8:07 GMT+08:00 Leandro Dorileo l...@dorileo.org:
Hi Chunyan,
On Mon, Mar 10, 2014 at 03:31:36PM +0800, Chunyan Liu wrote:
This patch series is to replace QEMUOptionParameter with QemuOpts, so
that only
one
On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote:
On 21.03.2014 01:13, Leandro Dorileo wrote:
Do the directly migration from QemuOptionParameter to QemuOpts on
iscsi block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/iscsi.c | 32
On Fri, Mar 21, 2014 at 01:31:42PM +, Leandro Dorileo wrote:
On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote:
On 21.03.2014 01:13, Leandro Dorileo wrote:
Do the directly migration from QemuOptionParameter to QemuOpts on
iscsi block driver.
Signed-off-by: Leandro
On Fri, Mar 21, 2014 at 02:42:35PM +0100, Peter Lieven wrote:
On 21.03.2014 14:31, Leandro Dorileo wrote:
On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote:
On 21.03.2014 01:13, Leandro Dorileo wrote:
Do the directly migration from QemuOptionParameter to QemuOpts on
iscsi block
Hi Eric,
On Fri, Mar 21, 2014 at 08:37:40AM -0600, Eric Blake wrote:
On 03/17/2014 05:10 PM, Leandro Dorileo wrote:
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his
QEMUOptionParameter
replacement
Hi Laszlo,
On Fri, Mar 21, 2014 at 04:30:32PM +0100, Laszlo Ersek wrote:
On 03/21/14 15:56, Leandro Dorileo wrote:
Hi Eric,
On Fri, Mar 21, 2014 at 08:37:40AM -0600, Eric Blake wrote:
On 03/17/2014 05:10 PM, Leandro Dorileo wrote:
Cover basic aspects and API usage for QemuOpt
what
I mean and have some more room for discussion. It doesn't mean I want to overlap
you work, I just needed to have a little more input on that.
Regards
--
Leandro Dorileo
From: Chunyan Liu cy...@suse.com
Add def_value_str (default value) to QemuOptDesc, to replace function of the
default value in QEMUOptionParameter. And improved related functions.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
---
From: Chunyan Liu cy...@suse.com
The qemu_opts_append() function is intended to merge to different
QemuOptsList's. The resulting list must be freed by its user.
Signed-off-by: Chunyan Liu cy...@suse.com
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 1 +
util/qemu
Do the directly migration from QemuOptionParameter to QemuOpts on
vpc block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/vpc.c | 54 +++---
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/block/vpc.c b/block
Use a pointer to a structure holding the primitive types and avoid
parsing the default value representation.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 20 +++-
util/qemu-config.c| 4 ++--
util/qemu-option.c| 45
Finally remove all the remaining QEMUOptionParameter bits.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 40 ---
util/qemu-option.c| 296 --
2 files changed, 336 deletions(-)
diff --git a/include/qemu
Do the directly migration from QemuOptionParameter to QemuOpts on
gluster block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/gluster.c | 68 +++--
1 file changed, 37 insertions(+), 31 deletions(-)
diff --git a/block
Analogous to print_option_help(QEMUOptionParameter *list) this function
displays the available key and help for each described QemuOptDesc in
QemuOptList.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/option.h | 1 +
util/qemu-option.c| 12
2 files changed
Do the directly migration from QemuOptionParameter to QemuOpts on
cow block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/cow.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index
Do the directly migration from QemuOptionParameter to QemuOpts on
qed block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/qed.c | 79 +++--
1 file changed, 35 insertions(+), 44 deletions(-)
diff --git a/block/qed.c b
Do the directly migration from QemuOptionParameter to QemuOpts on
raw-posix block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/raw-posix.c | 50 +++---
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/block/raw
Do the directly migration from QemuOptionParameter to QemuOpts on
iscsi block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/iscsi.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index
Do the directly migration from QemuOptionParameter to QemuOpts on
nfs block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/nfs.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
index 98aa363..c01f109 100644
--- a/block
Do the directly migration from QemuOptionParameter to QemuOpts on
vhdx block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/vhdx.c | 88
1 file changed, 41 insertions(+), 47 deletions(-)
diff --git a/block/vhdx.c b
Do the directly migration from QemuOptionParameter to QemuOpts on
qcow2 block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/qcow2.c | 263 --
1 file changed, 128 insertions(+), 135 deletions(-)
diff --git a/block/qcow2
Do the directly migration from QemuOptionParameter to QemuOpts on
qemu-img.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
qemu-img.c | 166 +++--
1 file changed, 95 insertions(+), 71 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
Do the directly migration from QemuOptionParameter to QemuOpts on
raw-win32 block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/raw-win32.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32
Do the directly migration from QemuOptionParameter to QemuOpts on
raw_bsd block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/raw_bsd.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 01ea692
Do the directly migration from QemuOptionParameter to QemuOpts on
vmdk block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/vmdk.c | 105 ++-
1 file changed, 53 insertions(+), 52 deletions(-)
diff --git a/block/vmdk.c b
Do the directly migration from QemuOptionParameter to QemuOpts on
vvfat block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/vvfat.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index f966ea5
.
--
Dorileo
Chunyan Liu (3):
qapi: output def_value_str when query command line options
add def_value_str to QemuOptDesc
QemuOpt: introduce qemu_opts_append()
Leandro Dorileo (23):
QemuOpt: improve default value
QemuOpt: add qemu_opt_print_help()
block: migrate block later QemuOptionParameter
Do the directly migration from QemuOptionParameter to QemuOpts on
sheepdog block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/sheepdog.c | 104 ---
1 file changed, 53 insertions(+), 51 deletions(-)
diff --git a/block
From: Chunyan Liu cy...@suse.com
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
---
qapi-schema.json | 6 +-
qmp-commands.hx| 2 ++
Do the directly migration from QemuOptionParameter to QemuOpts on
qcow block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/qcow.c | 59 +--
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/block/qcow.c b
Do the directly migration from QemuOptionParameter to QemuOpts on
vdi block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/vdi.c | 73 -
1 file changed, 34 insertions(+), 39 deletions(-)
diff --git a/block/vdi.c b
Do the directly migration from QemuOptionParameter to QemuOpts on
ssh block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/ssh.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index aa63c9d..b55c518
Do the directly migration from QemuOptionParameter to QemuOpts on
block layer.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block.c | 133 --
include/block/block.h | 7 ++-
include/block/block_int.h | 8 ++-
3 files
Do the directly migration from QemuOptionParameter to QemuOpts on
rbd block driver.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
block/rbd.c | 60 +---
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/block/rbd.c b
://tia.mat.br/blog/html/2012/09/29/asynchronous_i_o_in_c_with_coroutines.html
Regards...
--
Leandro Dorileo
On Mon, Mar 17, 2014 at 10:16:12AM -0600, Eric Blake wrote:
On 03/16/2014 03:18 PM, Leandro Dorileo wrote:
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planed to be changed by Chunyan Liu in his
QEMUOptionParameter
s/planed/planned
patches.
Regards...
--
Leandro Dorileo
Hi,
On Mon, Mar 10, 2014 at 03:31:41PM +0800, Chunyan Liu wrote:
Add some qemu_opt functions to replace the same functionality of
QEMUOptionParameter handling.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Chunyan Liu cy...@suse.com
---
include/qemu/option.h | 9
Hi,
On Mon, Mar 17, 2014 at 07:29:29PM +, Leandro Dorileo wrote:
Hi,
On Mon, Mar 10, 2014 at 03:32:01PM +0800, Chunyan Liu wrote:
Now all places using QEMUOptionParameter could use QemuOpts too, remove
QEMUOptionParameter related code.
Signed-off-by: Dong Xu Wang address@hidden
Hi,
On Mon, Mar 10, 2014 at 03:31:39PM +0800, Chunyan Liu wrote:
Improve opt_get and opt_set group of functions. For opt_get, check and handle
NULL input; for opt_set, when set to an existing option, rewrite the option
with new value.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered in future improvements.
Signed-off-by: Leandro Dorileo l...@dorileo.org
Changes:
v2
Cover basic aspects and API usage for QemuOpt. The current implementation
covers the API's planed to be changed by Chunyan Liu in his QEMUOptionParameter
replacement/cleanup job.
Other APIs should be covered in future improvements.
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
tests
Hi Chunyan,
On Tue, Mar 11, 2014 at 09:00:04PM +, Leandro Dorileo wrote:
Hi,
On Tue, Mar 11, 2014 at 03:26:51PM +0800, Chunyan Liu wrote:
2014-03-11 5:21 GMT+08:00 Eric Blake ebl...@redhat.com:
On 03/10/2014 02:29 PM, Eric Blake wrote:
+opt = qemu_opt_find(opts, name
Hi Erick,
On Tue, Mar 11, 2014 at 09:22:54AM -0600, Eric Blake wrote:
On 03/11/2014 08:09 AM, Leandro Dorileo wrote:
Hi Kevin,
On Tue, Mar 11, 2014 at 12:06:16PM +0100, Kevin Wolf wrote:
Am 08.03.2014 um 19:47 hat Leandro Dorileo geschrieben:
The following patchset introduces
Hi Kevin,
On Tue, Mar 11, 2014 at 12:06:16PM +0100, Kevin Wolf wrote:
Am 08.03.2014 um 19:47 hat Leandro Dorileo geschrieben:
The following patchset introduces a general purpose argument parser and
migrates
qemu-img to make use of it. qemu-img is just the first user of it, if we
see
how many things need to be tested, how many things need to
be
covered?
The testsuite should test the QemuOpts implementation, not the current users.
Regards...
--
Leandro Dorileo
Hi Paolo,
On Sun, Mar 09, 2014 at 08:30:28AM +0100, Paolo Bonzini wrote:
Il 08/03/2014 19:47, Leandro Dorileo ha scritto:
Remove the arg parsing implementations using getopt and use qemu-arg.
Also remove the qemu-img-cmds.hx since it's now generated on building time,
adapted the build system
On Sun, Mar 09, 2014 at 01:03:12PM +, Peter Maydell wrote:
On 9 March 2014 12:37, Leandro Dorileo l...@dorileo.org wrote:
Hi Paolo,
On Sun, Mar 09, 2014 at 08:30:28AM +0100, Paolo Bonzini wrote:
Il 08/03/2014 19:47, Leandro Dorileo ha scritto:
Remove the arg parsing implementations
Hi Andreas,
On Sun, Mar 09, 2014 at 05:32:17PM +0100, Andreas Färber wrote:
Am 08.03.2014 19:47, schrieb Leandro Dorileo:
The following patchset introduces a general purpose argument parser and
migrates
qemu-img to make use of it. qemu-img is just the first user of it, if we
see
The following patchset introduces a general purpose argument parser and migrates
qemu-img to make use of it. qemu-img is just the first user of it, if we see a
good feedback here I move forward and migrate all the other possible users.
Leandro Dorileo (2):
qemu-arg: introduce a general purpose
arguments (--argument value and
--argument=value
are valid)
Signed-off-by: Leandro Dorileo l...@dorileo.org
---
include/qemu/qemu-arg.h | 287
util/Makefile.objs | 1 +
util/qemu-arg.c | 887
3 files changed, 1175
Hi Peter,
On Sat, Mar 08, 2014 at 06:55:50PM +, Peter Maydell wrote:
On 8 March 2014 18:47, Leandro Dorileo l...@dorileo.org wrote:
The following patchset introduces a general purpose argument parser and
migrates
qemu-img to make use of it. qemu-img is just the first user of it, if we
On Wed, Feb 19, 2014 at 09:39:09PM +, Mark Cave-Ayland wrote:
On 19/02/14 13:35, Leandro Dorileo wrote:
Hi Leandro,
+static void cg3_realizefn(DeviceState *dev, Error **errp)
+{
+SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
+CG3State *s = CG3(dev);
+int ret;
+char
1 - 100 of 105 matches
Mail list logo
