Re: [RFC v2] virtio-net: check the mac address for vdpa device

2024-07-15 Thread Lei Yang
Hi Cindy If needed, QE can help test this MR before merging into the master branch. Best Regards Lei On Tue, Jul 16, 2024 at 9:14 AM Cindy Lu wrote: > > When using a VDPA device, it is important to ensure that the MAC address > in the hardware matches the MAC address from the QEMU command

Re: [RFC v3 0/6] virtio,vhost: Add VIRTIO_F_IN_ORDER support

2024-04-15 Thread Lei Yang
QE tested this series with packed=on/off, in_order=true and vhost=off under regression tests, everything are works fine. Tested-by: Lei Yang On Mon, Apr 8, 2024 at 11:34 PM Jonah Palmer wrote: > > The goal of these patches is to add support to a variety of virtio and > vhos

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-14 Thread Lei Yang
QE tested this patch with regression tests, everything works fine. Tested-by: Lei Yang On Fri, Apr 12, 2024 at 2:37 PM Cindy Lu wrote: > > Hi All > I apologize for bothering you again > I send the new patch is because I found that the function > kvm_virtio_pci

Re: [PATCH v1 0/8] virtio, vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-08 Thread Lei Yang
00/:00:01.3/:05:00.0/virtio1/features Tested-by: Lei Yang On Thu, Mar 7, 2024 at 7:18 PM Eugenio Perez Martin wrote: > > On Wed, Mar 6, 2024 at 8:34 AM Michael S. Tsirkin wrote: > > > > On Wed, Mar 06, 2024 at 08:07:31AM +0100, Eugenio Perez Martin wrote: > >

Re: [PATCH for 9.0 00/12] Map memory at destination .load_setup in vDPA-net migration

2023-12-24 Thread Lei Yang
QE tested this series with regression tests, there are no new regression issues. Tested-by: Lei Yang On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > Current memory operations like pinning may take a lot of time at the > destination. Currently they are done after t

Re: [PATCH v4 01/13] vdpa: add VhostVDPAShared

2023-12-22 Thread Lei Yang
QE tested this series v4 with regression tests. It has fixed the qemu core issues that hit last time.And everything works fine. Tested-by: Lei Yang On Fri, Dec 22, 2023 at 1:43 AM Eugenio Pérez wrote: > > It will hold properties shared among all vhost_vdpa instances asso

Re: [PATCH 9.0 00/13] Consolidate common vdpa members in VhostVDPAShared

2023-11-30 Thread Lei Yang
On Thu, Nov 30, 2023 at 3:38 PM Eugenio Perez Martin wrote: > > On Thu, Nov 30, 2023 at 4:22 AM Lei Yang wrote: > > > > Hi Eugenio > > > > QE performed regression testing after applying this patch. This series > > patch introduced a qemu core dump bug, for

Re: [PATCH 9.0 00/13] Consolidate common vdpa members in VhostVDPAShared

2023-11-29 Thread Lei Yang
Hi Eugenio QE performed regression testing after applying this patch. This series patch introduced a qemu core dump bug, for the core dump information please review the attached file. Tested-by: Lei Yang On Sat, Nov 25, 2023 at 1:14 AM Eugenio Pérez wrote: > > Current memory oper

Re: [PATCH 0/3] vhost: clean up device reset

2023-10-02 Thread Lei Yang
QE tested a regression testing on this series with vhost-vdpa device, everything is working fine. Tested-by: Lei Yang On Thu, Sep 28, 2023 at 6:40 PM Eugenio Perez Martin wrote: > > On Wed, Sep 27, 2023 at 9:27 PM Stefan Hajnoczi wrote: > > > > Stateful vhost device

Re: [PATCH v2 0/3] Follow VirtIO initialization properly at vdpa net cvq isolation probing

2023-09-20 Thread Lei Yang
QE tested this series with regression testing, everything works fine. Tested-by: Lei Yang On Sat, Sep 16, 2023 at 1:08 AM Eugenio Pérez wrote: > > This series solves a few issues. The most obvious is that the feature set was > done previous to ACKNOWLEDGE | DRIVER status bit set.

Re: [PATCH] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-09-14 Thread Lei Yang
QE tested this patch with real nic,guest can works well after cancelling migration. Tested-by: Lei Yang On Thu, Sep 14, 2023 at 11:23 AM Jason Wang wrote: > > On Wed, Sep 13, 2023 at 8:34 PM Eugenio Pérez wrote: > > > > Not zeroing it causes a SIGSEGV if the live migr

Re: [PATCH v3 0/5] Enable vdpa net migration with features depending on CVQ

2023-08-28 Thread Lei Yang
QE tested this series with MAC and MQ changes, and the guest migrated successfully with "x-svq=off" or without this parameter. Tested-by: Lei Yang On Tue, Aug 22, 2023 at 4:53 PM Eugenio Pérez wrote: > > At this moment the migration of net features that depends on CVQ i

Re: [PATCH v3 0/4] Vhost-vdpa Shadow Virtqueue VLAN support

2023-08-02 Thread Lei Yang
QE tested v3 of this series using the test steps provided by Hawkins and everything works fine. Tested-by: Lei Yang On Sun, Jul 23, 2023 at 8:10 PM Hawkins Jiawei wrote: > > This series enables shadowed CVQ to intercept VLAN commands > through shadowed CVQ, update the virtio NIC dev

Re: [PATCH 0/4] Vhost-vdpa Shadow Virtqueue VLAN support

2023-07-20 Thread Lei Yang
QE tested this series patch with real hardware, it can support setup vlan for the nic, and the vlan id still can be found after finished migrate. In addition, this series patch also help to test another patch, can got the expect result. Tested-by: Lei Yang On Wed, Jul 19, 2023 at 6:54 PM

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-20 Thread Lei Yang
() = 23296 us Case 2, applied this series Source: qemu-system-x86_64: vhost_vdpa_net_load() = 6558 us Dest: qemu-system-x86_64: vhost_vdpa_net_load() = 6539 us Tested-by: Lei Yang On Thu, Jul 20, 2023 at 6:54 AM Lei Yang wrote: > > On Wed, Jul 19, 2023 at 11:25 PM Hawkins Jiawei wrote: >

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Lei Yang
On Wed, Jul 19, 2023 at 11:25 PM Hawkins Jiawei wrote: > > 在 2023/7/19 20:44, Lei Yang 写道: > > Hello Hawkins and Michael > > > > Looks like there are big changes about vp_vdpa, therefore, if needed, > > QE can test this series in QE's environment before the patch

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Lei Yang
Hello Hawkins and Michael Looks like there are big changes about vp_vdpa, therefore, if needed, QE can test this series in QE's environment before the patch is merged, and provide the result. BR Lei On Wed, Jul 19, 2023 at 8:37 PM Hawkins Jiawei wrote: > > 在 2023/7/19 17:11, Michael S.

Re: [PATCH v3 0/3] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR

2023-07-06 Thread Lei Yang
On Wed, Jul 5, 2023 at 7:03 PM Hawkins Jiawei wrote: > > On 2023/7/5 15:59, Lei Yang wrote: > > Hello Hawkins > > > > QE can help test this series before it is merged into master, I would > > like to know what test steps can cover this series related scenario? >

Re: [PATCH v3 0/3] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR

2023-07-05 Thread Lei Yang
Hello Hawkins QE can help test this series before it is merged into master, I would like to know what test steps can cover this series related scenario? Thanks Lei On Tue, Jul 4, 2023 at 11:36 AM Hawkins Jiawei wrote: > > According to VirtIO standard, "The class, command and >

Re: [PATCH v3 0/2] vdpa: Refactor vdpa_feature_bits array

2023-07-03 Thread Lei Yang
QE tested this series with regression tests and live migration test on the vhost_vdpa device, there are no new problems. Tested-by: Lei Yang On Fri, Jun 30, 2023 at 9:27 PM Hawkins Jiawei wrote: > > This patchset removes the duplicated VIRTIO_NET_F_RSS entry > in vdpa_feature_b

Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices

2023-06-07 Thread Lei Yang
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang On Tue, Jun 6, 2023 at 9:33 AM Jason Wang wrote: > > On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez wrote: > > > > QEMU does not emulate it so it must be disabled as l

Re: [PATCH] vdpa: fix not using CVQ buffer in case of error

2023-06-07 Thread Lei Yang
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang On Tue, Jun 6, 2023 at 9:32 AM Jason Wang wrote: > > On Sat, Jun 3, 2023 at 1:35 AM Eugenio Pérez wrote: > > > > Bug introducing when refactoring. Otherway, the gu

Re: [PATCH v2 1/3] vdpa: do not block migration if device has cvq and x-svq=on

2023-06-02 Thread Lei Yang
QE tested this series with vhost_vdpa and x-svq=on, guest can migrate and everything works well. Tested-by: Lei Yang On Fri, Jun 2, 2023 at 10:39 PM Eugenio Pérez wrote: > > It was a mistake to forbid in all cases, as SVQ is already able to send > all the CVQ messages before start f

Re: [PATCH v4 0/6] Vhost-vdpa Shadow Virtqueue Offloads support

2023-06-02 Thread Lei Yang
work with features 0x4" after applied this series of patches. Tested-by: Lei Yang On Fri, Jun 2, 2023 at 7:55 PM Hawkins Jiawei wrote: > > This series enables shadowed CVQ to intercept Offloads commands > through shadowed CVQ, update the virtio NIC device model so qemu > send it in a migr

Re: [PATCH v4 0/2] Move ASID test to vhost-vdpa net initialization

2023-06-02 Thread Lei Yang
QE did a sanity test on v4 of this series using the vdpa_sim device,everything is working fine. Tested-by: Lei Yang On Fri, May 26, 2023 at 11:31 PM Eugenio Pérez wrote: > > QEMU v8.0 is able to switch dynamically between vhost-vdpa passthrough > and SVQ mode as long as the net de

Re: [PATCH v3 0/6] Vhost-vdpa Shadow Virtqueue Offloads support

2023-06-02 Thread Lei Yang
a svq is not available for feature 4". [1] -device '{"driver": "virtio-net-pci", "mac": "00:11:22:33:44:00", "id": "net0", "netdev": "hostnet0", "ctrl_guest_offloads": true, "bus": "pcie-ro

Re: [PATCH v2 0/6] Vhost-vdpa Shadow Virtqueue Offloads support

2023-06-01 Thread Lei Yang
I'm a QE responsible for vhost_vdpa parts. Could you please provide me with the test steps for this series? I can test it in my environment and update the test results. On Thu, Jun 1, 2023 at 4:29 PM Hawkins Jiawei wrote: > > This series enables shadowed CVQ to intercept Offloads commands >

Re: [PATCH v3 0/5] Move ASID test to vhost-vdpa net initialization

2023-05-17 Thread Lei Yang
QE tested this series with sanity testing on the vdpa_sim device, everything are works fine and there is no any new regression problems. Tested-by: Lei Yang On Tue, May 9, 2023 at 11:44 PM Eugenio Pérez wrote: > > QEMU v8.0 is able to switch dynamically between vhost-vdpa passt

Re: [PATCH RESEND] vhost: fix possible wrap in SVQ descriptor ring

2023-05-10 Thread Lei Yang
QE applied this patch to do sanity testing on vhost-vdpa, there is no any regression problem. Tested-by: Lei Yang On Wed, May 10, 2023 at 9:32 AM Lei Yang wrote: > QE applied this patch to do sanity testing on vhost-net, there is no > any regression problem. > > Tested-

Re: [PATCH RESEND] vhost: fix possible wrap in SVQ descriptor ring

2023-05-09 Thread Lei Yang
QE applied this patch to do sanity testing on vhost-net, there is no any regression problem. Tested-by: Lei Yang On Tue, May 9, 2023 at 1:28 AM Eugenio Perez Martin wrote: > > On Sat, May 6, 2023 at 5:01 PM Hawkins Jiawei wrote: > > > > QEMU invokes vhost_svq_add() whe

Re: [PATCH v5 00/14] Dynamically switch to vhost shadow virtqueues at vdpa net migration

2023-03-07 Thread Lei Yang
QE tested this series's V5 again. Creating two vdpa_sim device, and boot two VMs without shadow virtqueues. The migration was successful and everything worked fine. Tested-by: Lei Yang Eugenio Pérez 于2023年3月4日周六 01:24写道: > It's possible to migrate vdpa net devices if they are shadowed f

Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration

2023-02-16 Thread Lei Yang
QE tested this series's v3 again. Creating two vdpa_sim devices, and boot two VMs without shadow virtqueues. The migration was successful and everything worked fine. Tested-by: Lei Yang Eugenio Perez Martin 于2023年2月16日周四 02:41写道: > > On Fri, Feb 10, 2023 at 1:58 PM Gautam Dawar

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-02-14 Thread Lei Yang
QE uses the sim_vdpa device to test this patch and add "ctrl_vq=off" in the qemu command line. Guest can find this device, there are no any error messages in guest dmesg, and can migrate successfully. Tested-by: Lei Yang Eugenio Perez Martin 于2023年2月14日周二 14:53写道: > > On Tue, J

Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration

2023-02-09 Thread Lei Yang
QE tested this series on the rhel. Creating two vdpa_sim devices, and boot two VMs without shadow vq. The migration was successful and everything worked fine Tested-by: Lei Yang Alvaro Karsz 于2023年2月8日周三 18:29写道: > > HI Eugenio, thanks for the series! > > I tested the series

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

2022-11-17 Thread Lei Yang
QE tries to test the parameter "event_idx=on". In both environments "virtio-vdpa + vp_vdpa" and "vhost_vdpa + vp_vdpa", there is no network connectivity issue after the guest boot up. Tested-by: Lei Yang > From: Jason Wang > Date: Tue, Nov 1, 2022 a

Re: [PULL 3/3] vdpa: Fix memory listener deletions of iova tree

2022-07-28 Thread Lei Yang
Jason Wang 于2022年7月28日周四 14:27写道: > On Thu, Jul 28, 2022 at 2:14 PM Lei Yang wrote: > > > > I tried to manually changed this line then test this branch on local > host. After the migration is successful, the qemu core dump occurs on the > shutdown inside guest. > &

Re: [PULL 3/3] vdpa: Fix memory listener deletions of iova tree

2022-07-28 Thread Lei Yang
, if the next action is a map. > * Next unmap will cause to try to unmap again iova = 0, causing the > device to complain that no region was mapped at iova = 0. > > Fixes: 34e3c94edaef ("vdpa: Add custom IOTLB translations to SVQ") > Reported-by: Lei Yang > Signed-off