Re: [Qemu-devel] question: guest will hang when call system function in migration thread.

2014-12-05 Thread Li Guang
Hi, which version you tested? do you let vm continue to run after migration? can you provide more info? can't reproduce it on latest version. Thanks! On 12/04/2014 11:14 PM, 陈梁 wrote: > Hi all > > guest will hang when call system function in migration thread. The cpu usage > of vcpu thread is

[Qemu-devel] 答复: [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Li, Guang
> -邮件原件- > 发件人: qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org > [mailto:qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org] 代表 Peter > Maydell > 发送时间: 2014年9月18日 0:09 > 收件人: Gerd Hoffmann > 抄送: Stefano Stabellini; Markus Armbruster; qemu-devel; > xen-de...@lists.xen.org; Anthony

Re: [Qemu-devel] [PATCH v3 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-03-16 Thread Li Guang
在 2014-03-15六的 14:01 +0100,Beniamino Galvani写道: > The model was generating interrupts for all enabled timers after the > expiration of one of them. Avoid this by passing explicitly the timer > index to the callback function. > > Signed-off-by: Beniamino Galvani Review

Re: [Qemu-devel] [PATCH v3 5/7] allwinner-a10-pit: implement prescaler and source selection

2014-03-16 Thread Li Guang
在 2014-03-15六的 14:01 +0100,Beniamino Galvani写道: > This implements the prescaler and source fields of the timer control > register as described in the A10 user manual. > > Signed-off-by: Beniamino Galvani Reviewed-by: Li Guang > --- > hw/timer/allwinner-a10-pi

Re: [Qemu-devel] [PATCH v3 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-03-16 Thread Li Guang
lemented at the moment and thus the first > pending interrupt is returned. > > Signed-off-by: Beniamino Galvani > Reviewed-by: Peter Crosthwaite Reviewed-by: Li Guang > --- > hw/intc/allwinner-a10-pic.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH v3 2/7] allwinner-a10-pic: fix behaviour of pending register

2014-03-16 Thread Li Guang
在 2014-03-15六的 14:01 +0100,Beniamino Galvani写道: > The pending register is read-only and the value returned upon a read > reflects the state of irq input pins (interrupts are level triggered). > This patch implements such behaviour. > > Signed-off-by: Beniamino Galvani Review

Re: [Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

2014-02-25 Thread Li Guang
Li Guang wrote: Michael R. Hines wrote: On 02/19/2014 09:00 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-24 Thread Li Guang
Beniamino Galvani wrote: On Mon, Feb 24, 2014 at 02:45:06PM +0800, Li Guang wrote: Beniamino Galvani wrote: On Wed, Feb 19, 2014 at 10:02:36AM +0800, Li Guang wrote: Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote

Re: [Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

2014-02-23 Thread Li Guang
Michael R. Hines wrote: On 02/19/2014 09:00 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with the state machi

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-23 Thread Li Guang
Beniamino Galvani wrote: On Wed, Feb 19, 2014 at 10:02:36AM +0800, Li Guang wrote: Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote: Beniamino Galvani wrote: According to this mail thread [1], writing to pending register seems to

Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing

2014-02-20 Thread Li Guang
Dr. David Alan Gilbert wrote: * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 02/19/2014 07:27 PM, Dr. David Alan Gilbert wrote: I was just wondering if a separate 'max buffer size' knob would allow you to more reasonably bound memory without setting policy; I don't think pe

Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

2014-02-18 Thread Li Guang
Michael R. Hines wrote: On 02/19/2014 09:07 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migration-checkpoin

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-18 Thread Li Guang
Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote: Beniamino Galvani wrote: According to this mail thread [1], writing to pending register seems to have no effect on actual pending status of interrupts. This means that the only way to clear a pending

Re: [Qemu-devel] [PATCH 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-02-18 Thread Li Guang
Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 12:17:04PM +0800, Li Guang wrote: Beniamino Galvani wrote: The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this by passing to the timer callback function a structure containing the

Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

2014-02-18 Thread Li Guang
Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migration-checkpoint.c | 1565 1 file changed, 1565 insertions(+

Re: [Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

2014-02-18 Thread Li Guang
Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with the state machine so that we can later handle failure and recovery scenarios. Signed-off-by:

Re: [Qemu-devel] [RFC PATCH v2 00/12] mc: fault tolerante through micro-checkpointing

2014-02-18 Thread Li Guang
Hi, Michael this patch-set will break normal build(without --enable-mc): migration.c: In function ‘migrate_rdma_pin_all’: migration.c:564: error: ‘MIGRATION_CAPABILITY_X_RDMA_PIN_ALL’ undeclared (first use in this function) migration.c:564: error: for each function it appears in.) Thanks! Li

Re: [Qemu-devel] [PATCH 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-02-17 Thread Li Guang
did you detect spurious? didn't by my limited test, code will disable any expired timer, unless be re-armed, so it will never generate interrupt any more. Thanks! Beniamino Galvani wrote: The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this

Re: [Qemu-devel] [PATCH 4/7] allwinner-a10-pit: use level triggered interrupts

2014-02-17 Thread Li Guang
Beniamino Galvani wrote: Converts the interrupt generation logic to the use of level triggered interrupts. any real difference, or block something? Signed-off-by: Beniamino Galvani --- hw/timer/allwinner-a10-pit.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-17 Thread Li Guang
pending registers are also clear registers by a10 datasheet, also you found bits are marked as 'R', so, ..., contradict itself. Beniamino Galvani wrote: According to this mail thread [1], writing to pending register seems to have no effect on actual pending status of interrupts. This means that

Re: [Qemu-devel] [PATCH 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-02-17 Thread Li Guang
Hi, Beniamino Galvani wrote: This patch implements proper updating of the vector register which should hold, according to the A10 user manual, the vector address for the interrupt currently active on the CPU IRQ input. Interrupt priority is not implemented at the moment and thus the first pendi

Re: [Qemu-devel] [PATCH v2] hw/misc/blob-loader: add a generic blob loader

2014-01-15 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Jan 15, 2014 at 5:06 PM, Li Guang wrote: ping ... any other comments? or new suggestions? No new suggestions from me, but PMM has a point about load_image_targphys@realize doing exactly whats needed, so something closer to V1 WRT to that may

Re: [Qemu-devel] [PATCH v2] hw/misc/blob-loader: add a generic blob loader

2014-01-14 Thread Li Guang
ping ... any other comments? or new suggestions? Thanks! Li Guang wrote: this blob loader will be used to load a specified blob into a specified RAM address. Signed-off-by: Li Guang Suggested-by: Peter Crosthwaite --- hw/misc/Makefile.objs |2 + hw/misc/blob-loader.c

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-07 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 10:13 PM, Paolo Bonzini wrote: Il 06/01/2014 08:56, Peter Crosthwaite ha scritto: What are the guidelines for when to use one or the other? "-machine firmware=" if you want to load a firmware blob in a board specific way. Thi

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-07 Thread Li Guang
Beniamino Galvani wrote: On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote: Hi, please use prefix AwA10 for names instead of Aw, also PATCH 1/2. Hi, I agree with you that there is an inconsistency in the naming of EMAC and other A10 devices (timer, interrupt controller). But

[Qemu-devel] [PATCH v2] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
this blob loader will be used to load a specified blob into a specified RAM address. Signed-off-by: Li Guang Suggested-by: Peter Crosthwaite --- hw/misc/Makefile.objs |2 + hw/misc/blob-loader.c | 112 + include/hw/misc/blob-loader.h

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 3:24 PM, Li Guang wrote: Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoid init. This way you can use an Error* to report the er

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoid init. This way you can use an Error* to report the error. Also, the actual load_image_targphys call probably should be done in a reset handler, not at re

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoid init. This way you can use an Error* to report the error. Also, the actual load_image_targphys call probably should be done in a reset handler, not at realize time. Ok I t

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-05 Thread Li Guang
Hi, please use prefix AwA10 for names instead of Aw, also PATCH 1/2. Thanks for your effort on this! Beniamino Galvani wrote: Signed-off-by: Beniamino Galvani --- hw/arm/allwinner-a10.c | 20 include/hw/arm/allwinner-a10.h |4 2 files changed, 24 inser

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-01 Thread Li Guang
Peter Crosthwaite wrote: On Thu, Jan 2, 2014 at 3:35 PM, Li Guang wrote: this blob loader will be used to load a specified blob into a specified RAM address. Suggested-by: Peter Crosthwaite Signed-off-by: Li Guang --- it can be used now for allwinner-a10, like: "-device

[Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-01 Thread Li Guang
this blob loader will be used to load a specified blob into a specified RAM address. Signed-off-by: Li Guang --- it can be used now for allwinner-a10, like: "-device blob-loader,addr=0x4300,file=/path/script.bin" reference: http://linux-sunxi.org/Sunxi-tools script file add

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

2013-12-26 Thread Li Guang
Peter Maydell wrote: On 26 December 2013 19:40, Hans de Goede wrote: I'm one of the linux-sunxi developers, the only reason we've this fex file abomination, is because we've inherited it from the android-allwinner sources. Thanks for the clarification; I suspected that might be the c

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 26 December 2013 01:09, Peter Crosthwaite wrote: Can you just provide a generic solution to the "blob some random data into RAM" problem (If one doesn't exist already)? Well, we do already have that (see -machine firmware=whatever), but... Yes, right.

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

2013-12-25 Thread Li Guang
Peter Crosthwaite wrote: On Thu, Dec 26, 2013 at 10:47 AM, Peter Maydell wrote: On 26 December 2013 00:39, Li Guang wrote: Peter Maydell wrote: On 26 December 2013 00:14, Li Guang wrote: it's the approach sunxi-linux kernel config hardware, the bina

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 26 December 2013 00:39, Li Guang wrote: Peter Maydell wrote: On 26 December 2013 00:14, Li Guang wrote: it's the approach sunxi-linux kernel config hardware, the binary is actually a transformed text script, and context of script is

Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 26 December 2013 00:22, Li Guang wrote: Peter Maydell wrote: On 25 December 2013 07:21, liguang wrote: This is where your patch should have had an explanation for why you're making this change. What is the user outside of hw/sd/ that needs this header

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 26 December 2013 00:14, Li Guang wrote: Peter Maydell wrote: On 25 December 2013 08:35, liguang wrote: sunxi-linux kernel parse config script to do hardware configurations Signed-off-by: liguang --- hw/arm/allwinner-a10.c | 18

Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 25 December 2013 07:21, liguang wrote: This is where your patch should have had an explanation for why you're making this change. What is the user outside of hw/sd/ that needs this header that means we should move it into include/ ? I don't mean someone will inclu

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 25 December 2013 08:35, liguang wrote: sunxi-linux kernel parse config script to do hardware configurations Signed-off-by: liguang --- hw/arm/allwinner-a10.c | 18 ++ hw/arm/cubieboard.c|2 ++ include/hw/arm/allwinner-a1

Re: [Qemu-devel] [PULL 00/13] QMP queue

2013-12-19 Thread Li Guang
Peter Maydell wrote: On 18 December 2013 16:59, Luiz Capitulino wrote: qerror: Remove assert_no_error() This broke my target-arm pullreq :-( Yes, QMP queue and qemu-arm queue will conflict, because patch "target-arm/cpu: Convert reset CBAR to a property" used assert_no_e

Re: [Qemu-devel] [PATCH v12 2/5] hw/timer: add allwinner a10 timer

2013-12-15 Thread Li Guang
/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c new file mode 100644 index 000..8bba5e2 --- /dev/null +++ b/hw/timer/allwinner-a10-pit.c @@ -0,0 +1,254 @@ +/* + * Allwinner A10 timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free

Re: [Qemu-devel] [PATCH v12 1/5] vmstate: Add support for an array of ptimer_state *

2013-12-12 Thread Li Guang
Peter Crosthwaite wrote: On Fri, Dec 13, 2013 at 11:19 AM, liguang wrote: From: Peter Maydell Add support for defining a vmstate field which is an array of pointers to structures, and use this to define a VMSTATE_PTIMER_ARRAY() which allows an array of ptimer_state* to be used by devices.

Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-12 Thread Li Guang
Peter Maydell wrote: On 11 December 2013 08:08, liguang wrote: +static void aw_a10_pic_set_irq(void *opaque, int irq, int level) +{ +AwA10PICState *s = opaque; + +if (level) { +set_bit(irq%32, (void *)&s->irq_pending[irq/32]); The % and / operators here should have sp

Re: [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-12 Thread Li Guang
Peter Maydell wrote: On 11 December 2013 08:08, liguang wrote: +static int get_ptimer(QEMUFile *f, void *pv, size_t size) +{ +ptimer_state *v = pv; +uint64_t count; + +count = qemu_get_be64(f); +if (count != -1) { +ptimer_set_count(v, count); +} else { +p

Re: [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-12 Thread Li Guang
ping ... this patch is not changed since v8, can it get some comments? Thanks! liguang wrote: Signed-off-by: liguang --- include/migration/vmstate.h |4 savevm.c| 31 +++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-11 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Dec 11, 2013 at 8:31 PM, Peter Maydell wrote: On 11 December 2013 10:24, Peter Crosthwaite wrote: On Wed, Dec 11, 2013 at 7:56 PM, Peter Maydell wrote: On 11 December 2013 05:59, Peter Crosthwaite wrote: On Mon, Dec 9, 2013 at

Re: [Qemu-devel] [PATCH v10 2/5] hw/timer: add allwinner a10 timer

2013-12-10 Thread Li Guang
/allwinner-a10-pit.c new file mode 100644 index 000..9f898e7 --- /dev/null +++ b/hw/timer/allwinner-a10-pit.c @@ -0,0 +1,254 @@ +/* + * Allwinner A10 timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it

Re: [Qemu-devel] [PATCH v10 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-10 Thread Li Guang
-a10-pic.c b/hw/intc/allwinner-a10-pic.c new file mode 100644 index 000..9345741 --- /dev/null +++ b/hw/intc/allwinner-a10-pic.c @@ -0,0 +1,217 @@ +/* + * Allwinner A10 interrupt controller device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-08 Thread Li Guang
Hmm..., this is interface, but device, a bold opinion, can have something like TYPE_HOTPLUG_INTERFACE ... ? +/** + * hotplug_fn: + * @hotplug_dev: a device performing hotplug/uplug action s/uplug/unplug Thanks! Li Guang + * @hotplugged_dev: a device that has been hotplugged +

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-04 Thread Li Guang
url at: http://dl.dbank.com/c0jaibr54s reference: http://linux-sunxi.org/Main_Page Li Guang (5) vmstate: add VMSTATE_PTIMER_ARRAY hw/timer: add allwinner a10 timer hw/intc: add allwinner A10 interrupt controller hw/arm: add allwinner a10 SoC support

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-04 Thread Li Guang
/5 A10 SoC support TODO: 1. add BROM support 2. add more devices test: can boot-up officially released linux kernel build with PLL disabled. can find test zImage url at: http://dl.dbank.com/c0jaibr54s reference: http://linux-sunxi.org/Main_Page Li Guang (5) vmstate: add VMSTATE_PTIMER

Re: [Qemu-devel] [PATCH v8 2/5] hw/timer: add allwinner a10 timer

2013-12-04 Thread Li Guang
/allwinner-a10-pit.c new file mode 100644 index 000..2305813 --- /dev/null +++ b/hw/timer/allwinner-a10-pit.c @@ -0,0 +1,253 @@ +/* + * Allwinner A10 timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or

Re: [Qemu-devel] [PATCH v8 4/5] hw/arm: add allwinner a10 SoC support

2013-12-04 Thread Li Guang
t_obj; +/*< public>*/ + +ARMCPU cpu; +qemu_irq irq[AW_A10_PIC_INT_NR]; +qemu_irq cpu_irq[2]; I dont see the need to keep these as device state. They appear to be just local variables to realize(). +AwA10PITState timer; +AwA10PICState intc; +} AwA10State; + +#define ALLWINNER_H_ +#endif -- 1.7.2.5 OK, will fix. Thanks! Li Guang

Re: [Qemu-devel] [PATCH 2/5] hw/timer: add allwinner a10 timer

2013-12-03 Thread Li Guang
00..2f9b458 --- /dev/null +++ b/hw/timer/allwinner-a10_pit.c @@ -0,0 +1,253 @@ +/* + * Allwinner A10 timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Pub

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Li Guang
Andreas Färber wrote: Am 03.12.2013 13:01, schrieb Peter Crosthwaite: On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c d

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-12-01 Thread Li Guang
Andreas Färber wrote: Am 29.11.2013 09:06, schrieb Li Guang: Andreas Färber wrote: Am 29.11.2013 01:46, schrieb Li Guang: Andreas Färber wrote: Am 27.11.2013 10:22, schrieb Andreas Färber: [...] To my understanding, "sunxi" is the

Re: [Qemu-devel] [PATCH v6 1/5] hw/ptimer: add VMSTATE_PTIMER_ARRAY

2013-12-01 Thread Li Guang
Peter Maydell wrote: On 29 November 2013 11:01, Peter Maydell wrote: On 27 November 2013 08:23, liguang wrote: Signed-off-by: liguang --- include/hw/ptimer.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h index

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-29 Thread Li Guang
Bamvor Jian Zhang wrote: Hi, >>>Li Guang wrote: Andreas Färber wrote: Am 29.11.2013 01:46, schrieb Li Guang: Andreas Färber wrote: Am 27.11.2013 10:22, schrieb Andreas Färber: Hi, Am 26.11.2013 10:22, schrieb Peter Cr

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-29 Thread Li Guang
Peter Maydell wrote: On 29 November 2013 08:06, Li Guang wrote: what I design is: we have a sunxi series as a machine, then for sunx4i, we specify -M sunxi -cpu cortex-a8 -device x1 ... for sunx5i, we specify -M sunxi -cpu cortex-a8 -device x2 ... for sunx7i, we specify -M sunxi -cpu

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-29 Thread Li Guang
Andreas Färber wrote: Am 29.11.2013 01:46, schrieb Li Guang: Andreas Färber wrote: Am 27.11.2013 10:22, schrieb Andreas Färber: Hi, Am 26.11.2013 10:22, schrieb Peter Crosthwaite: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by

Re: [Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device

2013-11-28 Thread Li Guang
) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or + * (at your option) any later version

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-28 Thread Li Guang
/sunxi-soc.c @@ -0,0 +1,98 @@ +/* + * Allwinner sunxi series SoC emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free

Re: [Qemu-devel] [PATCH v6 0/5] add sunxi machine type

2013-11-27 Thread Li Guang
weigh in as well. OK, thanks! just a little busy on other jobs, :-) TODO: 1. add BROM support 2. add more devices 3. add sunxi-7i support test: can boot-up officially released linux kernel. reference: http://linux-sunxi.org/Main_Page Li Guang (5) hw/ptimer

Re: [Qemu-devel] [fixed-up][PATCH v5 3/5] hw/intc: add sunxi interrupt controller device

2013-11-27 Thread Li Guang
obj-$(CONFIG_ARM_GIC_KVM) += arm_gic_kvm.o diff --git a/hw/intc/sunxi-pic.c b/hw/intc/sunxi-pic.c new file mode 100644 index 000..a588c30 --- /dev/null +++ b/hw/intc/sunxi-pic.c @@ -0,0 +1,247 @@ +/* + * Allwinner sunxi interrupt controller device emulation + * + * Copyright (C) 2013 Li Guang

Re: [Qemu-devel] [PATCH v5 2/5] hw/timer: add sunxi timer device

2013-11-26 Thread Li Guang
/null +++ b/hw/timer/sunxi-pit.c @@ -0,0 +1,276 @@ +/* + * Allwinner sunxi timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc: add sunxi interrupt controller device

2013-11-26 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Nov 27, 2013 at 1:36 PM, Li Guang wrote: Li Guang wrote: Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc: add sunxi interrupt controller device

2013-11-26 Thread Li Guang
Li Guang wrote: Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 238

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-26 Thread Li Guang
Igor Mammedov wrote: On Wed, 27 Nov 2013 08:15:31 +0800 Li Guang wrote: Igor Mammedov wrote: On Tue, 26 Nov 2013 08:29:27 +0800 Li Guang wrote: Igor Mammedov wrote: On Fri, 22 Nov 2013 08:57:40 +0800 Li Guangwrote: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-26 Thread Li Guang
pxa2xx_pic.o obj-y += omap1.o omap2.o strongarm.o +obj-y += sunxi-soc.o diff --git a/hw/arm/sunxi-soc.c b/hw/arm/sunxi-soc.c new file mode 100644 index 000..b45af6d --- /dev/null +++ b/hw/arm/sunxi-soc.c @@ -0,0 +1,98 @@ +/* + * Allwinner sunxi series SoC emulation + * + * Copyright (C) 2013 Li Guang

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-26 Thread Li Guang
Igor Mammedov wrote: On Tue, 26 Nov 2013 08:29:27 +0800 Li Guang wrote: Igor Mammedov wrote: On Fri, 22 Nov 2013 08:57:40 +0800 Li Guang wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:32:27PM +0800, Li Guang wrote: Michael S

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 6:59 PM, Li Guang wrote: Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc: add sunxi interrupt controller device

2013-11-26 Thread Li Guang
obj-$(CONFIG_ARM_GIC_KVM) += arm_gic_kvm.o diff --git a/hw/intc/sunxi-pic.c b/hw/intc/sunxi-pic.c new file mode 100644 index 000..e84fc55 --- /dev/null +++ b/hw/intc/sunxi-pic.c @@ -0,0 +1,238 @@ +/* + * Allwinner sunxi interrupt controller device emulation + * + * Copyright (C) 2013 Li Guang

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Li Guang
/null +++ b/hw/timer/sunxi-pit.c @@ -0,0 +1,295 @@ +/* + * Allwinner sunxi timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as

Re: [Qemu-devel] [PATCH v3 1/4] hw/timer: add sunxi timer device

2013-11-25 Thread Li Guang
--- /dev/null +++ b/hw/timer/sunxi-pit.c @@ -0,0 +1,260 @@ +/* + * Allwinner sunxi timer device emulation + * + * Copyright (C) 2013 Li Guang + * Written by Li Guang + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as

Re: [Qemu-devel] [PATCH v3 2/4] hw/intc: add sunxi interrupt controller device

2013-11-25 Thread Li Guang
obj-$(CONFIG_ARM_GIC_KVM) += arm_gic_kvm.o diff --git a/hw/intc/sunxi-pic.c b/hw/intc/sunxi-pic.c new file mode 100644 index 000..09a3d09 --- /dev/null +++ b/hw/intc/sunxi-pic.c @@ -0,0 +1,301 @@ +/* + * Allwinner sunxi interrupt controller device emulation + * + * Copyright (C) 2013 Li Guang

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-25 Thread Li Guang
Igor Mammedov wrote: On Fri, 22 Nov 2013 08:57:40 +0800 Li Guang wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:32:27PM +0800, Li Guang wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: Hu Tao

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Li Guang
Igor Mammedov wrote: On Thu, 21 Nov 2013 16:32:27 +0800 Li Guang wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: Hu Tao wrote: On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: On Thu

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Li Guang
Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:32:27PM +0800, Li Guang wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: Hu Tao wrote: On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Li Guang
Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: Hu Tao wrote: On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: it fixes IRQ storm since guest

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Li Guang
Hu Tao wrote: On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: it fixes IRQ storm since guest isn't able to lower SCI IRQ after it has been handled when it clears GPE event. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-20 Thread Li Guang
Igor Mammedov wrote: Along with conversion extend -m option to support following parameters ... +if (!opts) { exit(1); } -sz = QEMU_ALIGN_UP((uint64_t)value, 8192); + +/* fixup legacy sugffix-less format

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-20 Thread Li Guang
Hi, Igor Igor Mammedov wrote: Add DimmBus for memory hotplug below 4Gb or above 4Gb depending on initial memory size and hotplug memory size. ... +static +void pc_hotplug_memory_init_impl(Object *owner, + MemoryRegion *system_memory, +

Re: [Qemu-devel] [PATCH 0/4] add sunxi machine

2013-11-20 Thread Li Guang
Hi, Peter Peter Maydell wrote: On 20 November 2013 07:53, liguang wrote: this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... Li Guang (4) hw/arm: add new machine type sunxi hw/arm/sunxi-soc

Re: [Qemu-devel] Prohibit Windows from running in QEMU

2013-10-29 Thread Li Guang
Michael S. Tsirkin wrote: On Tue, Oct 29, 2013 at 10:48:07AM +0100, Peter Lieven wrote: Hi all, this question might seem a bit weird, but does anyone see a good way to avoid that Windows is able to boot inside qemu? We have defined several profiles for different operation systems and I wan

Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled

2013-09-03 Thread Li Guang
在 2013-09-04三的 08:23 +0200,Paolo Bonzini写道: > Il 04/09/2013 03:07, Li Guang ha scritto: > > 在 2013-09-03二的 10:39 +0200,Andreas Färber写道: > >> Am 03.09.2013 08:59, schrieb liguang: > >>> Signed-off-by: liguang > >>> --- > >>> exec.c |4 +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cputlb: remove dead function tlb_update_dirty

2013-09-03 Thread Li Guang
the fallout. ;) > > Similarly target-i386 TCG is not suited for qemu-trivial IMO, instead > rth or someone who works on and/or reviews it (rth?) should volunteer as > proper maintainer. I'd like to maintain cputlb.c, can I? > With the larger part of the community using KVM these > days, we simply can't have that be handled by the community at large any > more. > > So yes, I know you were on vacation and you seem eager to take up work > again, that's great; I'm just cautioning that CC'ing everything on > qemu-trivial (not your fault, you're on the receiving end) can't be the > new solution, so feel encouraged to push back a little. :) > > Cheers, > Andreas > -- Thanks! Li Guang

Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled

2013-09-03 Thread Li Guang
can help to assure whether Xen & QTest need tcg_commit? > > > +memory_listener_register(&tcg_memory_listener, > > &address_space_memory); > > +} > > } > > > > MemoryRegion *get_system_memory(void) > -- Thanks! Li Guang

Re: [Qemu-devel] [PATCH v2 1/2] tcg/mips: detect available host instructions at runtime

2013-08-27 Thread li guang
Hi, Aurelien, to nitpick, use_mips32r2_instructions may already indicate use_mips32_instructions,right? so during ISA detection, we may first do mips32r2, then mips32 detection is unnecessary, I think. 在 2013-08-28三的 00:11 +0200,Aurelien Jarno写道: > Now that TCG supports enabling and disabling o

Re: [Qemu-devel] [PATCH] i386: Use #defines instead of magic numbers for CPUID cache information

2013-08-26 Thread li guang
在 2013-08-26一的 19:23 -0300,Eduardo Habkost写道: > This is an attempt to make the CPUID cache topology code clearer, by > replacing the magic numbers in the code with #defines, and moving all > the cache information to the same place in the file. > > I took care of comparing the assembly output of co

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 3/5] qemu-char: use bool in qemu_chr_open_socket

2013-06-19 Thread li guang
在 2013-06-19三的 12:28 +0400,Michael Tokarev写道: > 18.06.2013 07:45, liguang wrote: > > local variables is_* should be bool by usage, > > and last parameter of qemu_opt_get_bool is bool, > > so pass true/false for it. > > > > Signed-off-by: liguang > > --- > > qemu-char.c | 20 ++-

Re: [Qemu-devel] [PATCH RFC v2 0/7] coordinate cpu hotplug/unplug bewteen QEMU and kernel by EC

2013-06-18 Thread li guang
在 2013-06-18二的 11:14 +0200,Igor Mammedov写道: > On Tue, 18 Jun 2013 10:47:15 +0800 > li guang wrote: > > > Hi, Igor and Micheal > > > > 在 2013-06-06四的 16:33 +0800,li guang写道: > > > 在 2013-06-06四的 11:13 +0300,Michael S. Tsirkin写道: > > > > On Thu,

Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending

2013-06-17 Thread li guang
在 2013-06-18二的 07:50 +0400,Michael Tokarev写道: > 18.06.2013 06:32, li guang пишет: > > 在 2013-06-11二的 15:34 +0400,Michael Tokarev写道: > >> 11.06.2013 09:15, liguang wrote: > >>> because memory_region_update_pending is bool > >>> > >>> Si

Re: [Qemu-devel] [PATCH RFC v2 0/7] coordinate cpu hotplug/unplug bewteen QEMU and kernel by EC

2013-06-17 Thread li guang
Hi, Igor and Micheal 在 2013-06-06四的 16:33 +0800,li guang写道: > 在 2013-06-06四的 11:13 +0300,Michael S. Tsirkin写道: > > On Thu, Jun 06, 2013 at 11:16:53AM +0800, liguang wrote: > > > v2: > > > 1.remove PIIX4_PROC_BASE operations for cpu hotplug > > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-17 Thread li guang
在 2013-06-18二的 06:35 +0400,Michael Tokarev写道: > 11.06.2013 15:50, Michael Tokarev wrote: > > 11.06.2013 09:15, liguang wrote: > >> type last parameter of vnc_connect if bool, > >> so pass 'false' instead of '0' for it. > > > > There's another parameter in here, `skipauth', which should be > > bool

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-17 Thread li guang
在 2013-06-11二的 15:50 +0400,Michael Tokarev写道: > 11.06.2013 09:15, liguang wrote: > > type last parameter of vnc_connect if bool, > > so pass 'false' instead of '0' for it. > > There's another parameter in here, `skipauth', which should be > bool in vnc_connect(), and should be bool in vnc_display_

  1   2   3   4   >