RE: [PATCH] target/i386: Raise the highest index value used for any VMCS encoding

2024-07-25 Thread Li, Xin3
> On Wed, Jul 24, 2024 at 10:09 AM Lei Wang wrote: > > Because the index value of the VMCS field encoding of Secondary > > VM-exit controls, 0x44, is larger than any existing index value, raise > > the highest index value used for any VMCS encoding to 0x44. > > > > Because the index value of the V

RE: [PATCH v3 4/6] target/i386: add support for VMX FRED controls

2024-07-06 Thread Li, Xin3
On 7/6/2024 9:23 AM, Paolo Bonzini wrote: > > > Il sab 6 lug 2024, 17:57 Li, Xin3 <mailto:xin3...@intel.com>> ha scritto: > > >> The bits in the secondary vmexit controls are not supported, and > in general the same > >> is true for the s

RE: [PATCH v3 4/6] target/i386: add support for VMX FRED controls

2024-07-06 Thread Li, Xin3
>> The bits in the secondary vmexit controls are not supported, and in general >> the same >> is true for the secondary vmexit case. I think it's better to not include >> the vmx-entry- >> load-fred bit either, and only do the vmxcap changes. > Right, we don't need it at all. Hi Paolo, We act

RE: [PATCH v3 4/6] target/i386: add support for VMX FRED controls

2024-06-07 Thread Li, Xin3
> The bits in the secondary vmexit controls are not supported, and in general > the same > is true for the secondary vmexit case. I think it's better to not include > the vmx-entry- > load-fred bit either, and only do the vmxcap changes. Right, we don't need it at all. > > Also, in patch 1 th

RE: [PATCH v3A 1/6] target/i386: add support for FRED in CPUID enumeration

2023-12-22 Thread Li, Xin3
> > > NULL, NULL, NULL, NULL, @@ -1552,6 +1552,14 @@ static > > > FeatureDep feature_dependencies[] = { > > > .from = { FEAT_VMX_SECONDARY_CTLS, > VMX_SECONDARY_EXEC_ENABLE_USER_WAIT_PAUSE }, > > > .to = { FEAT_7_0_ECX, CPUID_7_0_ECX_WAITPKG }, > > >

RE: [PATCH v3 1/6] target/i386: add support for FRED in CPUID enumeration

2023-12-21 Thread Li, Xin3
>> @@ -1552,6 +1552,14 @@ static FeatureDep feature_dependencies[] = { >> .from = { FEAT_VMX_SECONDARY_CTLS, >> VMX_SECONDARY_EXEC_ENABLE_USER_WAIT_PAUSE }, >> .to = { FEAT_7_0_ECX, CPUID_7_0_ECX_WAITPKG }, >> }, >> +{ >> +.from = { FEAT_7_1_EAX

RE: [PATCH 4/4] target/i386: add live migration support for FRED

2023-09-25 Thread Li, Xin3
> > FRED CPU states are managed in 10 FRED MSRs, in addtion to a few > > existing CPU registers and MSRs, e.g., the CR4.FRED bit. > > > > Add the 10 new FRED MSRs to x86 CPUArchState for live migration support. > > > > IMO, it's better to split this patch into two, one is for FRED MSR access, > t