Ping.
Li Qiang 于2019年5月9日周四 下午5:57写道：
> Ping this serials.
>
> Thanks,
> Li Qiang
>
> Li Qiang 于2019年4月24日周三 下午10:07写道：
>
>> In the disscuss of adding reboot timeout test case:
>> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html
&
gt; (vfio_region_read/vfio_region_write)
> > * the bar access
> > * triggers (vfio_eoi->vfio_intx_eoi) which unmasks (using
> vfio-pci) the interrupt
> > the idea is that first few bar accesses should ack the interrupt
> and thus avoid flood
> > but some interrupts could still happen (one per bar access)
>
> Full points :) Thanks,
>
Thanks very much Alex and Maxim!
I appreciate it.
Thanks,
Li Qiang
>
> Alex
>
Auger Eric 于2019年5月15日周三 下午6:16写道：
> Hi,
>
> On 5/15/19 12:01 PM, Li Qiang wrote:
> > Hello Paolo, Alex and all,
> >
> > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the
> > umask function(vfio_pci_intx_unmask_handler in linux).
>
rrupt)
occurs?
I only find a place(vfio_basic_config_write) calls vfio_pci_intx_mask.
I think when the guest process the interrupt it may mask this
interrupt(finally call vfio_pci_set_intx_mask), but I can't find the code
path related with vfio_basic_config_write.
Any hints?
Thanks,
Li Qiang
Peter Xu 于2019年5月11日周六 上午7:53写道：
> On Fri, May 10, 2019 at 09:43:46AM -0700, Li Qiang wrote:
> > Recently I am considering write a driver for edu device.
>
> I don't know why you wanted to write it, but there's one (though I
> don't even remember wh
The dma related variable dma.dst/src/cnt is dma_addr_t, it is
uint64_t in x64 platform. Change these usage from uint32_to
uint64_t to avoid trancation in edu_dma_timer.
Signed-off-by: Li Qiang
---
Change since v3:
Change 'size2' para of 'edu_check_range' to 64-bits.
hw/misc/edu.c | 17
format compile error
Li Qiang (3):
edu: mmio: allow 64-bit access
edu: mmio: allow 64-bit access in read dispatch
edu: uses uint64_t in dma operation
hw/misc/edu.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
--
2.17.1
The edu spec says when address >= 0x80, the MMIO area can
be accessed by 64-bit.
Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daude
---
hw/misc/edu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 65fc32b928..33de051
The edu spec says the MMIO area can be accessed by 64-bit.
However currently the 'max_access_size' is not so the MMIO
access dispatch can only access 32-bit one time. This patch fixes
this to respect the spec.
Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daude
---
hw/misc/edu.c | 9
e
> information.
>
> Signed-off-by: Stefan Hajnoczi
> Acked-by: Stefano Garzarella
> Reviewed-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Daudé
> ---
>
Reviewed-by: Li Qiang
> Makefile | 2 +-
> docs/security.texi | 131
.
>
> Signed-off-by: Stefan Hajnoczi
> Acked-by: Stefano Garzarella
> Reviewed-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
> docs/devel/index.rst | 1 +
> docs/devel/secure-coding-practices.rst | 106 ++
Ping this serials.
Thanks,
Li Qiang
Li Qiang 于2019年4月24日周三 下午10:07写道：
> In the disscuss of adding reboot timeout test case:
> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html
>
> Philippe suggested we should uses the only related option for one
> specifi
Thomas Huth 于2019年4月29日周一 下午9:18写道：
> On 29/04/2019 07.09, Li Qiang wrote:
> >
> >
> > Li Qiang mailto:liq...@gmail.com>> 于2019年4月25日周
> > 四 下午10:29写道：
> >
> >
> >
> > Thomas Huth mailto:th...@redhat.com>> 于2019年4月
> >
Li Qiang 于2019年4月25日周四 下午10:29写道：
>
>
> Thomas Huth 于2019年4月25日周四 下午5:57写道：
>
>> On 24/04/2019 16.06, Li Qiang wrote:
>> > In the disscuss of adding reboot timeout test case:
>> > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html
>>
Thomas Huth 于2019年4月25日周四 下午5:57写道：
> On 24/04/2019 16.06, Li Qiang wrote:
> > In the disscuss of adding reboot timeout test case:
> > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html
> >
> > Philippe suggested we should uses the only related optio
Gerd Hoffmann 于2019年4月25日周四 下午4:15写道：
> On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote:
> > Thomas Huth 于2019年4月24日周三 上午12:29写道：
> >
> > > Is this endianess-safe? Or do you need to byteswap reboot_timeout if
> the
> > > host and guest endianess d
', this need add a uninit function
2. Convert every test case in a separate QTestState
After this patch, we can add fw_cfg test case freely and will not
have effect on other test cases.
Signed-off-by: Li Qiang
Acked-by: Thomas Huth
---
tests/fw_cfg-test.c | 86
So that if the guest and host endianess does not match it
can still work as expection.
Signed-off-by: Li Qiang
---
hw/nvram/fw_cfg.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 5c3a46ce6f..df4242fc9c 100644
--- a/hw/nvram
This is useful to write qtest about fw_cfg file entry.
Signed-off-by: Li Qiang
Acked-by: Thomas Huth
---
tests/libqos/fw_cfg.c | 45 +++
tests/libqos/fw_cfg.h | 2 ++
2 files changed, 47 insertions(+)
diff --git a/tests/libqos/fw_cfg.c b/tests/libqos
idea, I split the test case
for its own QTestState. As this patchset has changed a lot, I don't bump
the version.
Change since v1:
Add a patch to store the reboot_timeout as little endian
Fix the endian issue per Thomas's review
Li Qiang (5):
tests: refactor fw_cfg_test
tests: fw_cfg: add
Signed-off-by: Li Qiang
---
Change since v1:
Converting little endian splash time to cpu endian
tests/fw_cfg-test.c | 20
1 file changed, 20 insertions(+)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 6c6add54db..c6a3d6bb23 100644
--- a/tests/fw_cfg-test.c
Signed-off-by: Li Qiang
---
Change since v1:
Converting little endian reboot_timeout to cpu endian
tests/fw_cfg-test.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index c22503619f..6c6add54db 100644
--- a/tests/fw_cfg
Thomas Huth 于2019年4月24日周三 下午3:31写道：
> On 24/04/2019 03.16, Li Qiang wrote:
> >
> > Thomas Huth mailto:th...@redhat.com>> 于2019年4月24日
> > 周三 上午12:29写道：
> >
> > On 20/04/2019 12.00, Li Qiang wrote:
> > > Signed-off-by: Li Qiang mailto:liq...
Thomas Huth 于2019年4月24日周三 下午3:31写道：
> On 24/04/2019 03.16, Li Qiang wrote:
> >
> > Thomas Huth mailto:th...@redhat.com>> 于2019年4月24日
> > 周三 上午12:29写道：
> >
> > On 20/04/2019 12.00, Li Qiang wrote:
> > > Signed-off-by: Li Qiang mailto:liq...
Thomas Huth 于2019年4月24日周三 上午12:29写道：
> On 20/04/2019 12.00, Li Qiang wrote:
> > Signed-off-by: Li Qiang
> > ---
> > tests/fw_cfg-test.c | 19 +++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-
.
Just like usb-fuzzer recently added to syzkaller.
I'm not sure how much qemu communicate with the real device in
pass-thru(VFIO?).
If there are too much, it may be take consideration.
Thanks,
Li Qiang
> > > +Guest Isolation
> > > +~~~
> > > +Guest iso
Philippe Mathieu-Daudé 于2019年4月23日周二 上午12:28写道：
> On 4/22/19 3:17 AM, Li Qiang wrote:
> >
> >
> > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于
> > 2019年4月21日周日 下午6:28写道：
> >
> > Hi Li,
> >
> > The patch
format compile error
Li Qiang (3):
edu: mmio: allow 64-bit access
edu: mmio: allow 64-bit access in read dispatch
edu: uses uint64_t in dma operation
hw/misc/edu.c | 30 ++
1 file changed, 22 insertions(+), 8 deletions(-)
--
2.17.1
The edu spec says when address >= 0x80, the MMIO area can
be accessed by 64-bit.
Signed-off-by: Li Qiang
---
Change since v2:
Fix an error per Phillippe's advice
hw/misc/edu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
in
The dma related variable dma.dst/src/cnt is dma_addr_t, it is
uint64_t in x64 platform. Change these usage from uint32_to
uint64_t to avoid trancation in edu_dma_timer.
Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daude
---
hw/misc/edu.c | 15 ---
1 file changed, 8
The edu spec says the MMIO area can be accessed by 64-bit.
However currently the 'max_access_size' is not so the MMIO
access dispatch can only access 32-bit one time. This patch fixes
this to respect the spec.
Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daude
---
hw/misc/edu.c | 9
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:44写道：
> Hi Li,
>
> On 4/20/19 6:14 PM, Li Qiang wrote:
> > The edu spec said when address >= 0x80, the MMIO area can
>
> "says"
>
> > be accessed by 8 bytes.
> >
> > Signed-off-by: Li Qiang
>
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:32写道：
> On 4/20/19 6:14 PM, Li Qiang wrote:
> > The dma related variable is dma_addr_t, it is uint64_t in
> > x64 platform. Change these usage from uint32_to uint64_t to
> > avoid trancation.
>
> "to avoid address trunc
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:28写道：
> Hi Li,
>
> The patch title is not very descriptive, maybe "allow 64-bit access"
>
>
> On 4/20/19 6:14 PM, Li Qiang wrote:
> > The edu spec said, the MMIO area can be accessed by 8 bytes.
>
&
Recently I am considering write a driver for edu device.
After reading the spec, I found these three small issue.
Two first two related the MMIO access and the third is
related the DMA operation.
Change since v1:
Fix format compile error on Windows
Li Qiang (3):
edu: mmio: set 'max_access_size
The dma related variable is dma_addr_t, it is uint64_t in
x64 platform. Change these usage from uint32_to uint64_t to
avoid trancation.
Signed-off-by: Li Qiang
---
Change since v1:
Fix format compile error on Windows
hw/misc/edu.c | 15 ---
1 file changed, 8 insertions(+), 7
.
Signed-off-by: Li Qiang
---
hw/misc/edu.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 91af452c9e..65fc32b928 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops = {
.read = edu_mmio_read
The edu spec said when address >= 0x80, the MMIO area can
be accessed by 8 bytes.
Signed-off-by: Li Qiang
---
hw/misc/edu.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 65fc32b928..4018dddcb8 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -18
.
Signed-off-by: Li Qiang
---
hw/misc/edu.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 91af452c9e..65fc32b928 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops = {
.read = edu_mmio_read
Recently I am considering write a driver for edu device.
After reading the spec, I found these three small issue.
Two first two related the MMIO access and the third is
related the DMA operation.
Change since v1:
Fix format compile error on Windows
Li Qiang (3):
tests: fw_cfg: add splash time
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 9f75dbb5f4..de8e81ea9d 100644
--- a/tests/fw_cfg-test.c
+++ b/tests/fw_cfg-test.c
@@ -192,6 +192,24 @@ static void
The edu spec said when address >= 0x80, the MMIO area can
be accessed by 8 bytes.
Signed-off-by: Li Qiang
---
Change since v1:
Fix format compile error on Windows
hw/misc/edu.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 65fc32b928..4018ddd
The dma related variable is dma_addr_t, it is uint64_t in
x64 platform. Change these usage from uint32_to uint64_t to
avoid trancation.
Signed-off-by: Li Qiang
---
hw/misc/edu.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
.
Signed-off-by: Li Qiang
---
hw/misc/edu.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 91af452c9e..65fc32b928 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops = {
.read = edu_mmio_read
Recently I am considering write a driver for edu device.
After reading the spec, I found these three small issue.
Two first two related the MMIO access and the third is
related the DMA operation.
Li Qiang (3):
edu: mmio: set 'max_access_size' to 8
edu: mmio: allow mmio read dispatch accept 8
The edu spec said when address >= 0x80, the MMIO area can
be accessed by 8 bytes.
Signed-off-by: Li Qiang
---
hw/misc/edu.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 65fc32b928..4018dddcb8 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -18
Philippe Mathieu-Daudé 于2019年4月19日周五 上午5:01写道：
> Hi Li,
>
> On 3/19/19 3:30 AM, Li Qiang wrote:
> > Signed-off-by: Li Qiang
> > ---
> > tests/fw_cfg-test.c | 15 ++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --gi
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 9f75dbb5f4..de8e81ea9d 100644
--- a/tests/fw_cfg-test.c
+++ b/tests/fw_cfg-test.c
@@ -192,6 +192,24 @@ static void
idea, I split the test case
for its own QTestState. As this patchset has changed a lot, I don't bump
the version.
Li Qiang (4):
tests: refactor fw_cfg_test
tests: fw_cfg: add a function to get the fw_cfg file
tests: fw_cfg: add reboot_timeout test case
tests: fw_cfg: add splash time test
This is useful to write qtest about fw_cfg file entry.
Signed-off-by: Li Qiang
---
tests/libqos/fw_cfg.c | 45 +++
tests/libqos/fw_cfg.h | 2 ++
2 files changed, 47 insertions(+)
diff --git a/tests/libqos/fw_cfg.c b/tests/libqos/fw_cfg.c
index
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index c22503619f..9f75dbb5f4 100644
--- a/tests/fw_cfg-test.c
+++ b/tests/fw_cfg-test.c
@@ -174,6 +174,24 @@ static void
', this need add a uninit function
2. Convert every test case in a separate QTestState
After this patch, we can add fw_cfg test case freely and will not
have efect other test cases.
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 86 ++-
tests/libqos
Philippe Mathieu-Daudé 于2019年4月19日周五 上午5:01写道：
> Hi Li,
>
> On 3/19/19 3:30 AM, Li Qiang wrote:
> > Signed-off-by: Li Qiang
> > ---
> > tests/fw_cfg-test.c | 15 ++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --gi
Paolo Bonzini 于2019年4月11日周四 下午3:44写道：
> On 11/04/19 02:57, Li Qiang wrote:
> >
> >
> > Paolo Bonzini mailto:pbonz...@redhat.com>> 于2019
> > 年4月10日周三 下午11:55写道：
> >
> > On 10/04/19 16:33, Li Qiang wrote:
> > > Hi all,
> >
Paolo Bonzini 于2019年4月10日周三 下午11:55写道：
> On 10/04/19 16:33, Li Qiang wrote:
> > Hi all,
> >
> >
> >
> > I see the link device ‘_PRS’ uses irq line 5, 10, 11 in
> > ‘build_link_dev’ function.
> >
> > But I never see the 5 lines uses in the
Hi all,
I see the link device ‘_PRS’ uses irq line 5, 10, 11 in ‘build_link_dev’
function.
But I never see the 5 lines uses in the guest, just uses 10 and 11.
Why this happen? Maybe related with the guest?
Thanks,
Li Qiang
Lidong Chen 于2019年4月9日周二 上午3:51写道：
> Due to an off-by-one error, the assert statements allow an
> out-of-bounds array access.
>
> Signed-off-by: Lidong Chen
>
Reviewed-by: Li Qiang
> ---
> hw/sd/sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
ks for an index less than the array size.
>
> Signed-off-by: Liam Merwick
>
Reviewed-by: Li Qiang
> ---
> qobject/json-lexer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qobject/json-lexer.c b/qobject/json-lexer.c
> index a7df2093aa30
This is useful to write qtest about fw_cfg file entry.
Signed-off-by: Li Qiang
---
tests/libqos/fw_cfg.c | 45 +++
tests/libqos/fw_cfg.h | 2 ++
2 files changed, 47 insertions(+)
diff --git a/tests/libqos/fw_cfg.c b/tests/libqos/fw_cfg.c
index
The first patch adds a util function to get the fw_cfg file entry.
And second adds the reboot-timeout test case.
Li Qiang (2):
tests: fw_cfg: add a function to get the fw_cfg file
tests: fw_cfg: add reboot_timeout test case
tests/fw_cfg-test.c | 15 ++-
tests/libqos/fw_cfg.c
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 1c5103fe1c..551b51e38f 100644
--- a/tests/fw_cfg-test.c
+++ b/tests/fw_cfg-test.c
@@ -99,6 +99,17 @@ static void
The 'queue_index' of create/close_session function
is from guest and can be exceed 'MAX_CRYPTO_QUEUE_NUM'.
This leads oob access. This patch avoid this.
Signed-off-by: Li Qiang
---
backends/cryptodev-builtin.c| 4
backends/cryptodev-vhost-user.c | 4
2 files changed, 8 insertions
-by: Li Qiang
---
v1->v2: Use ldl_he_p per Peter's advice
ui/vnc-enc-tight.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 0b4a5ac71f..d20cd1d86d 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -886,11 +886
Peter Maydell 于2019年3月17日周日 下午10:10写道：
> On Sun, 17 Mar 2019 at 12:09, Li Qiang wrote:
> >
> > When adding '-fsanitize=undefined' in compiling configuration
> > and connect VM with vnc, it reports following error:
> >
> > ui/vnc-enc-tight.c:910:13: runtime erro
-by: Li Qiang
---
ui/vnc-enc-tight.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 0b4a5ac71f..7e1be63af3 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -886,11 +886,11 @@ static int tight_compress_data(VncState *vs
The 'queue_index' of create/close_session function
is from guest and can be exceed 'MAX_CRYPTO_QUEUE_NUM'.
This leads oob access. This patch avoid this.
Signed-off-by: Li Qiang
---
backends/cryptodev-vhost-user.c | 4
1 file changed, 4 insertions(+)
diff --git a/backends/cryptodev-vhost
Philippe Mathieu-Daudé 于2019年3月10日周日 下午10:34写道：
> On 3/10/19 12:34 PM, Li Qiang wrote:
> > Fixes: 2dbfadf
>
> ^ Please keep tags together (with Signed-off-by, ...)
>
> > Spotted by ASAN when 'make check'.
>
> I'm not native English speaker but I'd say:
Spotted by ASAN while running 'make check'.
Fixes: 4b9b7000(tests: Add a test for qemu
self announcements)
Suggested-by: Thomas Huth
Signed-off-by: Li Qiang
---
Changes since v1: Use Thomas's patch
tests/test-announce-self.c | 21 ++---
1 file changed, 6 insertions(+), 15
Spotted by ASAN when 'make check'.
Signed-off-by: Li Qiang
---
tests/test-qgraph.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c
index f6a6565e31..5c7e457075 100644
--- a/tests/test-qgraph.c
+++ b/tests/test-qgraph.c
@@ -122,7
Spotted by ASAN when 'make check'.
Signed-off-by: Li Qiang
---
tests/test-announce-self.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/tests/test-announce-self.c b/tests/test-announce-self.c
index 1644d34a3f..3f370d8bf5 100644
--- a/tests/test
Hi Jason,
What's the status of this patch? I don't see it in upstream.
Thanks,
Li Qiang
Jason Wang 于2018年11月22日周四 上午10:22写道：
>
> On 2018/11/22 上午1:39, Michael S. Tsirkin wrote:
> > On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote:
> >> On 11/21/18 6:23 AM, Mic
Fixes: 2dbfadf
Spotted by ASAN when 'make check'.
Signed-off-by: Li Qiang
---
tests/test-bdrv-graph-mod.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
index 458dfa6661..8bf0fe735d 100644
--- a/tests/test-bdrv-graph-mod.c
+++ b
Thanks Emilio,
I found the ssh connection is very slow and the submodule wasn’t checked out
completely.
I uses the https connection and it works as normal.
Thanks,
Li Qiang
发件人: Emilio G. Cota
发送时间: 2019年3月10日 1:38
收件人: Li Qiang
抄送: qemu-devel@nongnu.org
主题: Re: 'make check' error
On Sat, Mar
emu.org/?p=qemu.git;a=commitdiff;h=3ac1f81329f4dfdc10a51e180f9cf28dbcb02a3c;hp=b44b5abeae4a3b54ccbd7137f59c0a8923cecec9
Seems it’s old commit, I think I got ‘make check’ work after this commit.
So I don’t know anywhere wrong.
Any hints?
Thanks,
Li Qiang
Laszlo Ersek 于2019年1月22日周二 上午5:38写道：
> On 01/20/19 08:13, Li Qiang wrote:
> > Signed-off-by: Li Qiang
> > ---
> > tests/fw_cfg-test.c | 13 -
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/fw_cfg-test.c b/t
Laszlo Ersek 于2019年1月22日周二 上午5:32写道：
> On 01/20/19 08:13, Li Qiang wrote:
> > This is useful to write qtest about fw_cfg file entry.
> >
> > Signed-off-by: Li Qiang
> > ---
> > tests/libqos/fw_cfg.c | 33 +
> > tests/libqo
at most once, on the realize
> > path of the board-specific fw_cfg sysbus device.)
> >
> > While at it, clean up the name and the assignment of the object as well.
>
> Reviewed-by: Gerd Hoffmann
>
> >
> > Cc: Gerd Hoffmann
> > Cc: Markus Armbruster
>
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 1c5103fe1c..c28e6c3fb5 100644
--- a/tests/fw_cfg-test.c
+++ b/tests/fw_cfg-test.c
@@ -99,6 +99,15 @@ static void
This is useful to write qtest about fw_cfg file entry.
Signed-off-by: Li Qiang
---
tests/libqos/fw_cfg.c | 33 +
tests/libqos/fw_cfg.h | 2 ++
2 files changed, 35 insertions(+)
diff --git a/tests/libqos/fw_cfg.c b/tests/libqos/fw_cfg.c
index d0889d1e22
The first patch adds a util function to get
the fw_cfg file entry.
And second adds a reboot-timeout test case.
Li Qiang (2):
tests: fw_cfg: add a function to get the fw_cfg file entry
tests: fw_cfg: add reboot_timeout test case
tests/fw_cfg-test.c | 13 -
tests/libqos
at /home/test/qemu1/qemu/cpus.c:1281
12 0x55dbaf6d in qemu_thread_start (args=0x569438a0)
at util/qemu-thread-posix.c:502
13 0x75dc86db in start_thread (arg=0x7fffe9735700)
at pthread_create.c:463
14 0x75af188f in clone ()
at ../sysdeps/unix/sysv/linux/x86_64/clone.S:
There is no need to make another reference.
Signed-off-by: Li Qiang
Reviewed-by: Max Reitz
Reviewed-by: Philippe Mathieu-Daud??
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 0b77b49b36..8325b5e88a 100644
This patchset contains small fix.
Change since v2:
For patch 2:
1. add nvme command
2. check num_queues first
Change since v1:
1. drop the patch of checking return value of msix_init_exclusive_bar
2. return when nvme's num_queues configuration is 0
Li Qiang (3):
nvme: use TYPE_NVME instead
Signed-off-by: Li Qiang
Reviewed-by: Max Reitz
Reviewed-by: Philippe Mathieu-Daud??
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 7c8c63e8f5..f206391e8e 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
There is no need to make another reference.
Signed-off-by: Li Qiang
Reviewed-by: Max Reitz
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 0ded74fa9a..0a1da749fc 100644
--- a/hw/block/nvme.c
+++ b/hw/block
s=0x6032c170) at
util/qemu-thread-posix.c:504
13 0x7fffdadbd494 in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
14 0x7fffdaaffacf in clone () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) q
Signed-off-by: Li Qiang
---
hw/block/nvme.c | 5 +
1 file changed, 5 insertions(+)
Signed-off-by: Li Qiang
Reviewed-by: Max Reitz
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 7c8c63e8f5..f206391e8e 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1381,7 +1381,7 @@ static void
This patchset contains small fix.
Change since v1:
1. drop the patch of checking return value of msix_init_exclusive_bar
2. return when nvme's num_queues configuration is 0
Li Qiang (3):
nvme: use TYPE_NVME instead of constant string
nvme: ensure the num_queues is not zero
nvme: use
Ping...
Thanks,
Li Qiang
Li Qiang 于2018年12月17日周一 下午2:34写道：
> Signed-off-by: Li Qiang
> ---
> util/main-loop.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/util/main-loop.c b/util/main-loop.c
> index affe0403c5..845a4b1f13 100644
> --- a/util/main-loop.c
Max Reitz 于2019年1月9日周三 下午10:52写道：
> On 30.10.18 06:18, Li Qiang wrote:
> > As this function can fail.
> >
> > Signed-off-by: Li Qiang
> > ---
> > hw/block/nvme.c | 5 -
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff
Max Reitz 于2019年1月9日周三 下午10:38写道：
> On 30.10.18 06:18, Li Qiang wrote:
> > When it is zero, it causes segv. Backtrack:
> > Thread 5 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
> > [Switching to Thread 0x7fffc6c17700 (LWP 51808)]
> > 0x0
When getting the 'pbdev', the if...else has no default branch.
>From Coverity, the 'pbdev' maybe null when the 'dev' is not
the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE.
This patch adds a default branch for device plug and unplug.
Spotted by Coverity: CID 1398593
Signed-off-by:
Currently, pvrdma_qp_send() function leak the 'comp_ctx',
Since 'comp_ctx' is used after the two checks, just relocate
the allocation & initialization after the two check.
Spotted by Coverity: CID 1398595
Fixes: 2b05705dc8
Signed-off-by: Li Qiang
---
hw/rdma/vmw/pvrdma_qp_ops.c
Make them more QOMConventional.
Cc:qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
hw/i386/kvm/ioapic.c | 2 +-
hw/i386/pc.c | 4 ++--
hw/intc/ioapic.c | 2 +-
include/hw/i386/ioapic.h | 3 +++
4 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/i386
What do you think of ‘g_assert_not_reached();’. For example:
else {
g_assert_not_reached();
}
Thanks,
Li Qiang
发件人: Cornelia Huck
发送时间: 2019年1月4日 22:10
收件人: Li Qiang
抄送: wall...@linux.ibm.com; r...@twiddle.net; da...@redhat.com;
pa...@linux.ibm.com; borntrae...@de.ibm.com; qemu-s3
I’m inspired by the function ‘ich9_pm_device_unplug_cb’.
>From the ‘plug’ ich9_pm_device_plug_cb it set an error.
So I think we can also set this is this s390 device plug.
I will send out revised patch soon.
Thanks,
Li Qiang
发件人: Cornelia Huck
发送时间: 2019年1月3日 22:54
收件人: Li Qiang
抄送: w
When getting the 'pbdev', the if...else has no default branch.
>From Coverity, the 'pbdev' maybe null when the 'dev' is not
the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE.
This patch adds a default branch for device plug and unplug.
Spotted by Coverity: CID 1398593
Signed-off-by:
When getting the 'pbdev', the if...else has no default branch.
>From Coverity, the 'pbdev' maybe null when the 'dev' is not
the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE.
Spotted by Coverity: CID 1398593
Signed-off-by: Li Qiang
---
hw/s390x/s390-pci-bus.c | 4
1 file changed
Oh, sorry, I always forget to add this “Fixs: xxx” for these small issues.
Thanks,
Li Qiang
发件人: Philippe Mathieu-Daudé
发送时间: 2019年1月3日 21:38
收件人: Li Qiang; kra...@redhat.com
抄送: peter.mayd...@linaro.org; qemu-devel@nongnu.org
主题: Re: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error
Spotted by Coverity: CID 1397070
Signed-off-by: Li Qiang
---
hw/usb/dev-mtp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index b19b576278..666bafd9e8 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -666,6 +666,7 @@ static void
401 - 500 of 832 matches
Mail list logo
