Re: [PATCH] docs/devel: remove incorrect claim about git send-email

Alyssa Ross writes: > Alyssa Ross writes: > >> Linus Heckemann writes: >> >>> While it's unclear to me what git send-email actually does with the >>> -v2 parameter (it is not documented, but also not rejected), it does >>> not add a v2 ta

[PATCH v6] 9pfs: use GHashTable for fid table

improving the performance of the 9p filesystem. The runtime of NixOS's simple installer test, which copies ~122k files totalling ~1.8GiB from 9p, decreased by a factor of about 10. Signed-off-by: Linus Heckemann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Greg Kurz Messa

Re: [PATCH v5] 9pfs: use GHashTable for fid table

Linus Heckemann writes: > static void coroutine_fn virtfs_reset(V9fsPDU *pdu) > { > V9fsState *s = pdu->s; > V9fsFidState *fidp; > +GList *freeing; > +/* Get a list of all the values (fid states) in the table, which we > then... */ >

[PATCH v5] 9pfs: use GHashTable for fid table

improving the performance of the 9p filesystem. The runtime of NixOS's simple installer test, which copies ~122k files totalling ~1.8GiB from 9p, decreased by a factor of about 10. Signed-off-by: Linus Heckemann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Greg Kurz Messa

Re: [PATCH 1/1] 9pfs: avoid iterator invalidation in v9fs_mark_fids_unreclaim

Christian Schoenebeck writes: > Ah, you sent this fix as a separate patch on top. I actually just meant that > you would take my already queued patch as the latest version (just because I > had made some minor changes on my end) and adjust that patch further as v4. > > Anyway, there are still s

[PATCH 1/1] 9pfs: avoid iterator invalidation in v9fs_mark_fids_unreclaim

Previously, the yielding in v9fs_reopen_fid and put_fid could result in other parts of the code modifying the fid table. This would invalidate the hash table iterator, causing misbehaviour. Now we ensure that we complete the iteration before yielding, so that the iterator remains valid throughout

Re: [PATCH v3] 9pfs: use GHashTable for fid table

Christian Schoenebeck writes: > On Freitag, 9. September 2022 15:10:48 CEST Christian Schoenebeck wrote: >> On Donnerstag, 8. September 2022 13:23:53 CEST Linus Heckemann wrote: >> > The previous implementation would iterate over the fid table for >> > lookup

[PATCH] docs/devel: remove incorrect claim about git send-email

While it's unclear to me what git send-email actually does with the -v2 parameter (it is not documented, but also not rejected), it does not add a v2 tag to the email's subject, which is what led to the mishap in [1]. [1]: https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg00679.html ---

Re: [PATCH v3] 9pfs: use GHashTable for fid table

(sorry for the dup @Greg, forgot to reply-all) Greg Kurz writes: >> > g_hash_table_steal_extended() [1] actually allows to do just that. >> >> g_hash_table_steal_extended unfortunately isn't available since it was >> introduced in glib 2.58 and we're maintaining compatibility to 2.56. >> > > Ha

[PATCH v3] 9pfs: use GHashTable for fid table

improving the performance of the 9p filesystem. The runtime of NixOS's simple installer test, which copies ~122k files totalling ~1.8GiB from 9p, decreased by a factor of about 10. Signed-off-by: Linus Heckemann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Greg Kurz --- Greg Kurz w

[PATCH] 9pfs: use GHashTable for fid table

improving the performance of the 9p filesystem. The runtime of NixOS's simple installer test, which copies ~122k files totalling ~1.8GiB from 9p, decreased by a factor of about 10. Signed-off-by: Linus Heckemann --- hw/9pfs/9p.c | 130 +++ hw

Re: [PATCH] 9pfs: use GHashMap for fid table

Hi all, thanks for your reviews. > @@ -4226,7 +4232,7 @@ int v9fs_device_realize_common(V9fsState *s, const > V9fsTransport *t, > s->ctx.fmode = fse->fmode; > s->ctx.dmode = fse->dmode; > > -QSIMPLEQ_INIT(&s->fid_list); > +s->fids = g_hash_table_new(NULL, NULL); > qemu_co_

[PATCH] 9pfs: use GHashMap for fid table

, significantly improving the performance of the 9p filesystem. The runtime of NixOS's simple installer test, which copies ~122k files totalling ~1.8GiB from 9p, decreased by a factor of about 10. Signed-off-by: Linus Heckemann --- hw/9pfs/9p.c | 130 +++---