On 7/18/2022 1:43 PM, Brice Goglin wrote:
Le 18/07/2022 à 05:17, Liu, Jingqi a écrit :
On 7/11/2022 6:44 PM, Hesham Almatary via wrote:
From: Brice Goglin
The "Memory Proximity Domain Attributes" structure of the ACPI HMAT
has a "Processor Proximity Domain Valid" fl
On 7/11/2022 6:44 PM, Hesham Almatary via wrote:
From: Brice Goglin
The "Memory Proximity Domain Attributes" structure of the ACPI HMAT
has a "Processor Proximity Domain Valid" flag that is currently
always set because Qemu -numa requires an initiator=X value
when hmat=on. Unsetting this flag
Hello,
On 7/11/2022 6:44 PM, Hesham Almatary via wrote:
From: Brice Goglin
The "Memory Proximity Domain Attributes" structure of the ACPI HMAT
has a "Processor Proximity Domain Valid" flag that is currently
always set because Qemu -numa requires an initiator=X value
when hmat=on. Unsetting this
Hi Igor,
Any comments ?
Thanks,
Jingqi
On 8/23/2021 9:12 AM, Liu, Jingqi wrote:
Since commits aa57020774b ("numa: move numa global variable
nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move
numa global variable numa_info into MachineState"), we can get
NUMA in
On 8/16/2021 6:05 PM, Philippe Mathieu-Daudé wrote:
On 8/6/21 5:19 AM, Jingqi Liu wrote:
Maybe prepend with:
Since commits aa57020774b ("numa: move numa global variable
nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move
numa global variable numa_info into MachineState"), we can .
Hi Igor,
Any comments on this 2nd version of the patch ?
Thanks,
Jingqi
On 8/6/2021 11:19 AM, Liu, Jingqi wrote:
We can get NUMA information completely from MachineState::numa_state.
Remove PCMachineState::numa_nodes and PCMachineState::node_mem,
since they are just copied from MachineState
On 8/12/2021 11:06 PM, Peter Maydell wrote:
In the alignment check added to qemu_ram_alloc_from_fd() in commit
ce317be98db0dfdfa, the condition includes a check that 'mr' is not
NULL. This check is unnecessary because we can assume that the
caller always passes us a valid MemoryRegion, and in
On 8/12/2021 11:15 PM, Peter Maydell wrote:
The realpath() function can return NULL on error, so we need to check
for it to avoid crashing when we try to strstr() into it.
This can happen if we run out of memory, or if /sys/ is not mounted,
among other situations.
Fixes: Coverity 1459913, 1460
On 8/5/2021 5:26 PM, Igor Mammedov wrote:
On Tue, 3 Aug 2021 14:30:05 +0800
Jingqi Liu wrote:
The NUMA information in PCMachineState is copied from MachineState.
We get this information uniformly from struct NumaState in MachineState.
Is there a another reason behind this patch?
As clean
Hi Igor,
On 7/29/2021 8:44 PM, Igor Mammedov wrote:
On Mon, 19 Jul 2021 10:01:53 +0800
Jingqi Liu wrote:
Linux kernel version 5.1 brings in support for the volatile-use of
persistent memory as a hotplugged memory region (KMEM DAX).
When this feature is enabled, persistent memory can be seen a
Hi Igor,
Thanks for your comments.
On 6/30/2021 11:00 PM, Igor Mammedov wrote:
On Fri, 25 Jun 2021 10:25:18 +0800
Jingqi Liu wrote:
Linux kernel version 5.1 brings in support for the volatile-use of
persistent memory as a hotplugged memory region (KMEM DAX).
When this feature is enabled, p
Hi Milan,
On 4/30/2021 8:18 PM, Milan Zamazal wrote:
Hi,
I work on NVDIMM support in oVirt/RHV, I think other virtualization
management software built on top of QEMU may have similar concerns.
When a virtual NVDIMM device size is specified, it's not necessarily the
eventual NVDIMM device size
Hi Paolo,
Any comments for this patch ?
Thanks,
Jingqi
On 7/15/2020 10:54 AM, Liu, Jingqi wrote:
At the end of live migration, QEMU uses msync() to flush the data to
the backend storage. When the backend file is a character device dax,
the pages explicitly avoid the page cache. It will
Ping for comments.
On 7/15/2020 10:54 AM, Liu, Jingqi wrote:
At the end of live migration, QEMU uses msync() to flush the data to
the backend storage. When the backend file is a character device dax,
the pages explicitly avoid the page cache. It will return failure from msync().
The following
On 4/28/2020 9:28 AM, Verma, Vishal L wrote:
NVDIMMs can belong to their own proximity domains, as described by the
NFIT. In such cases, the SRAT needs to have Memory Affinity structures
in the SRAT for these NVDIMMs, otherwise Linux doesn't populate node
data structures properly during NUMA init
On 4/29/2020 12:23 AM, Joao Martins wrote:
On 4/15/20 4:35 AM, Jingqi Liu wrote:
Add a pair of configure options --{enable,disable}-libdaxctl to control
whether QEMU is compiled with libdaxctl [1]. Libdaxctl is a utility
library for managing the device dax subsystem.
QEMU uses mmap(2) to maps v
On 4/29/2020 12:22 AM, Joao Martins wrote:
On 4/15/20 4:35 AM, Jingqi Liu wrote:
For device dax (e.g., /dev/dax0.0), the NUM of 'align=NUM' option
needs to match the alignment requirement of the device dax.
It must be larger than or equal to the 'align' of device dax.
Signed-off-by: Jingqi Liu
Ping for comments.
Hi Paolo, Dan, Joao,
Any comments for this series.
Thanks,
Jingqi
On 4/15/2020 11:35 AM, Liu, Jingqi wrote:
This series adds libdaxctl support and fetchs the alignment of
device dax through libdaxctl [1] APIs.
QEMU uses mmap(2) to maps vNVDIMM backends and aligns the
On 4/10/2020 12:46 AM, Dan Williams wrote:
On Thu, Apr 9, 2020 at 7:33 AM Liu, Jingqi wrote:
On 4/8/2020 5:42 PM, Joao Martins wrote:
On 4/8/20 3:25 AM, Liu, Jingqi wrote:
On 4/8/2020 2:28 AM, Joao Martins wrote:
On 4/7/20 5:55 PM, Dan Williams wrote:
On Tue, Apr 7, 2020 at 4:01 AM Joao
On 4/8/2020 5:42 PM, Joao Martins wrote:
On 4/8/20 3:25 AM, Liu, Jingqi wrote:
On 4/8/2020 2:28 AM, Joao Martins wrote:
On 4/7/20 5:55 PM, Dan Williams wrote:
On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote:
Perhaps, you meant instead:
/sys/dev/char/%d:%d/align
Hmm, are you
On 4/8/2020 2:28 AM, Joao Martins wrote:
On 4/7/20 5:55 PM, Dan Williams wrote:
On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote:
On 4/1/20 4:13 AM, Jingqi Liu wrote:
If the backend file is devdax pmem character device, the alignment
specified by the option 'align=NUM' in the '-object memory
On 4/7/2020 11:51 PM, Joao Martins wrote:
On 4/7/20 3:31 PM, Paolo Bonzini wrote:
On 07/04/20 12:59, Joao Martins wrote:
Perhaps, you meant instead:
/sys/dev/char/%d:%d/align
?
Hi Joao,
In my machine with real NVDIMM, the devdax device is as follows:
$ ll /dev/dax0.0
crw---
On 4/7/2020 4:08 PM, Paolo Bonzini wrote:
On 07/04/20 09:29, Liu, Jingqi wrote:
Ping.
Any comments are appreciated.
Hi Paolo, Richard,
Any comments about this ?
I was hoping to get a review from someone else because I have no way to
test it. But I've now queued the patch, thanks.
Ping.
Any comments are appreciated.
Hi Paolo, Richard,
Any comments about this ?
Thanks,
Jingqi
On 4/1/2020 11:13 AM, Liu, Jingqi wrote:
If the backend file is devdax pmem character device, the alignment
specified by the option 'align=NUM' in the '-object memory-backend
On 3/10/2020 5:12 PM, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 04:58:38PM +0800, Liu, Jingqi wrote:
On 3/9/2020 9:35 PM, Peter Maydell wrote:
On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote:
On 3/6/2020 12:40 AM, Peter Maydell wrote:
On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote
On 3/9/2020 9:35 PM, Peter Maydell wrote:
On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote:
On 3/6/2020 12:40 AM, Peter Maydell wrote:
On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote:
On a Thursday in 2020, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always not defined in this file.
This fixes
On 3/6/2020 12:40 AM, Peter Maydell wrote:
On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote:
On a Thursday in 2020, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always not defined in this file.
This fixes that "config-host.h" header file is not included
for getting macros.
Signed-off-by: Jingqi L
On 3/6/2020 8:14 PM, Peter Maydell wrote:
On Fri, 6 Mar 2020 at 12:12, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always undefined before including "qemu/osdep.h".
Use __linux__ to check if target OS is linux instead of CONFIG_LINUX.
Signed-off-by: Jingqi Liu
---
util/mmap-alloc.c | 6 +++
On 3/6/2020 12:40 AM, Peter Maydell wrote:
On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote:
On a Thursday in 2020, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always not defined in this file.
This fixes that "config-host.h" header file is not included
for getting macros.
Signed-off-by: Jingqi L
On 3/6/2020 12:10 AM, Ján Tomko wrote:
On a Thursday in 2020, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always not defined in this file.
This fixes that "config-host.h" header file is not included
for getting macros.
Signed-off-by: Jingqi Liu
---
util/mmap-alloc.c | 2 ++
1 file changed, 2 i
> -Original Message-
> From: Xu, Tao3
> Sent: Thursday, September 12, 2019 1:37 PM
> To: imamm...@redhat.com; ebl...@redhat.com; ehabk...@redhat.com
> Cc: Xu, Tao3 ; Liu, Jingqi ;
> Williams, Dan J ;
> jonathan.came...@huawei.com; Du, Fan ; qemu-devel@nongnu.org
>
> -Original Message-
> From: Xu, Tao3
> Sent: Tuesday, July 16, 2019 10:51 PM
> To: imamm...@redhat.com; ebl...@redhat.com; ehabk...@redhat.com
> Cc: Xu, Tao3 ; Liu, Jingqi ;
> Williams, Dan J ;
> jonathan.came...@huawei.com; Du, Fan ; qemu-devel@nongnu.org
>
> -Original Message-
> From: Xu, Tao3
> Sent: Tuesday, July 16, 2019 10:51 PM
> To: imamm...@redhat.com; ebl...@redhat.com; ehabk...@redhat.com
> Cc: Xu, Tao3 ; Liu, Jingqi ;
> Williams, Dan J ;
> jonathan.came...@huawei.com; Du, Fan ; qemu-devel@nongnu.org
>
/archive/html/qemu-devel/2018-07/msg02330.html
since umonitor/umwait/tpause cpu features are not ready yet.
v1:
Sent out with umonitor/umwait/tpause cpu features.
Liu Jingqi (2):
x86/cpu: Enable MOVDIRI cpu feature
x86/cpu: Enable MOVDIR64B cpu feature
target/i386/cpu.c | 4
:
https://software.intel.com/sites/default/files/managed/c5/15/\
architecture-instruction-set-extensions-programming-reference.pdf
Cc: Xu Tao
Signed-off-by: Liu Jingqi
---
target/i386/cpu.c | 2 +-
target/i386/cpu.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/i386
:
https://software.intel.com/sites/default/files/managed/c5/15/\
architecture-instruction-set-extensions-programming-reference.pdf
Cc: Xu Tao
Signed-off-by: Liu Jingqi
---
target/i386/cpu.c | 2 +-
target/i386/cpu.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/i386
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Thursday, October 11, 2018 4:35 AM
> To: Liu, Jingqi
> Cc: Xu, Tao3 ; pbonz...@redhat.com; r...@twiddle.net;
> qemu-devel@nongnu.org; Robert Hoo
> Subject: Re: [PATCH 1/1] i386: Add new
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Thursday, October 11, 2018 4:35 AM
> To: Liu, Jingqi
> Cc: Xu, Tao3 ; pbonz...@redhat.com; r...@twiddle.net;
> qemu-devel@nongnu.org; Robert Hoo
> Subject: Re: [PATCH 1/1] i386: Add new
Hi Eduardo/Paolo,
Do you have any comments about this patch ?
Thanks
Jingqi
> -Original Message-
> From: Xu, Tao3
> Sent: Wednesday, September 19, 2018 11:11 AM
> To: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com
> Cc: qemu-devel@nongnu.org; Liu, Ji
On Thursday, September 13, 2018 7:38 PM, Igor Mammedov wrote:
> On Wed, 12 Sep 2018 01:12:43 +
> "Liu, Jingqi" wrote:
>
> > On Monday, July 16, 2018 8:29 PM, Igor Mammedov
> wrote:
> > > On Tue, 19 Jun 2018 23:20:57 +0800
> > > Liu Jingqi
On Wednesday, September 12, 2018 10:34 PM, Eric Blake wrote:
> On 7/16/18 6:54 AM, Igor Mammedov wrote:
>
> >> +
> >> +#include "unistd.h"
> >> +#include "fcntl.h"
> >> +#include "qemu/osdep.h"
> >> +#include "sysemu/numa.h"
> >> +#include "hw/i386/pc.h"
> >> +#include "hw/i386/acpi-build.h"
> >>
On Monday, July 16, 2018 8:29 PM, Igor Mammedov wrote:
> On Tue, 19 Jun 2018 23:20:57 +0800
> Liu Jingqi wrote:
>
> > OSPM evaluates HMAT only during system initialization.
> > Any changes to the HMAT state at runtime or information regarding HMAT
> > for hot plug
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Tuesday, August 7, 2018 6:03 AM
> To: Liu, Jingqi
> Cc: pbonz...@redhat.com; r...@twiddle.net; Wang, Wei W
> ; qemu-devel@nongnu.org; Michael S. Tsirkin
>
> Subject: Re: [Qemu-de
Hi Paolo & Eduardo,
Do you have any comments for the series ?
Thanks
On 7/16/2018 10:59 PM, Paolo Bonzini wrote:
On 10/07/2018 10:57, Jingqi Liu wrote:
Enable a few new cpu features including UMONITOR, UMWAIT, TPAUSE,
MOVDIRI and MOVDIR64B.
UMONITOR, UMWAIT, and TPAUSE are a set of user wait
On 7/16/2018 10:59 PM, Paolo Bonzini wrote:
On 10/07/2018 10:57, Jingqi Liu wrote:
Enable a few new cpu features including UMONITOR, UMWAIT, TPAUSE,
MOVDIRI and MOVDIR64B.
UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions.
MOVDIRI moves doubleword or quadword from register to mem
On 05/07/2018 03:43, Eduardo Habkost wrote:
> On Wed, Jul 04, 2018 at 09:21:06PM +0800, Jingqi Liu wrote:
> > The MSR (33H) controls support for #AC exception for split locked
> > accesses. When bit 29 of the MSR (33H) is set, the processor causes an
> > #AC exception to be issued instead of supp
On 04/07/2018 21:37, Paolo Bonzini wrote:
> On 04/07/2018 15:21, Jingqi Liu wrote:
> > The MSR (33H) controls support for #AC exception for split locked
> > accesses. When bit 29 of the MSR (33H) is set, the processor causes an
> > #AC exception to be issued instead of suppressing LOCK on bus (du
On 6/19/2018 11:39 PM, Eric Blake wrote:
On 06/19/2018 10:20 AM, Liu Jingqi wrote:
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous
information
at runtime. _HMA provides OSPM with the latest HMAT in entirety
overriding existing HMAT.
Signed-off-by: Liu Jingqi
---
hw/acpi/hmat.c | 356 +++
hw/acpi/hmat.h | 71 ++
hw/i386/acpi-build.c | 2 +
hw/i386/pc.c
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
---
numa.c | 124
as hint for optimization.
Signed-off-by: Liu Jingqi
---
hw/acpi/hmat.c | 98 ++
hw/acpi/hmat.h | 76 +
2 files changed, 174 insertions(+)
diff --git a/hw/acpi/hmat.c b/hw/acpi/hmat.c
index d4e586d
memory usage.
Signed-off-by: Liu Jingqi
---
default-configs/x86_64-softmmu.mak | 1 +
hw/acpi/Makefile.objs | 1 +
hw/acpi/hmat.c | 139 +
hw/acpi/hmat.h | 73 +++
hw/i386/acpi-build.c
Add -numa hmat-cache option to provide Memory Side Cache Information.
These memory attributes help to build Memory Side Cache Information
Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
---
numa.c | 72
the system
memory that use the memory side cache.
Signed-off-by: Liu Jingqi
---
hw/acpi/hmat.c | 56
hw/acpi/hmat.h | 44
2 files changed, 100 insertions(+)
diff --git a/hw/acpi/hmat.c b/hw
software is expected to use this information as hint for optimization.
OSPM evaluates HMAT only during system initialization. Any changes to the HMAT
state at runtime or information regarding HMAT for hot plug are communicated
using the _HMA method.
Liu Jingqi (6):
hmat acpi: Build Memory Subsystem
On Tue, May 15, 2018 10:36 PM, Igor Mammedov wrote:
> On Wed, 9 May 2018 16:34:29 +0800
> Liu Jingqi wrote:
>
> > HMAT is defined in ACPI 6.2: 5.2.27 Heterogeneous Memory Attribute Table
> (HMAT).
> > The specification references below link:
> > http://ww
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, May 11, 2018 10:33 PM
> To: Liu, Jingqi
> Cc: pbonz...@redhat.com; r...@twiddle.net; m...@redhat.com;
> imamm...@redhat.com; marcel.apfelb...@gmail.com; qemu-
> de...@nongnu.org
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, May 11, 2018 10:41 PM
> To: Liu, Jingqi
> Cc: pbonz...@redhat.com; r...@twiddle.net; m...@redhat.com;
> imamm...@redhat.com; marcel.apfelb...@gmail.com; qemu-
> de...@nongnu.org
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Wednesday, May 9, 2018 9:16 PM
> To: Liu, Jingqi ; pbonz...@redhat.com; r...@twiddle.net;
> ehabk...@redhat.com
> Cc: imamm...@redhat.com; qemu-devel@nongnu.org; m...@redhat.com
> Subject: Re
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Wednesday, May 9, 2018 9:13 PM
> To: Liu, Jingqi ; pbonz...@redhat.com; r...@twiddle.net;
> ehabk...@redhat.com
> Cc: imamm...@redhat.com; qemu-devel@nongnu.org; m...@redhat.com
> Subject: Re
information
at runtime. _HMA provides OSPM with the latest HMAT in entirety
overriding existing HMAT.
Signed-off-by: Liu Jingqi
---
hw/acpi/hmat.c | 355 +++
hw/acpi/hmat.h | 71 +++
hw/i386/acpi-build.c | 2 +
hw/i386/pc.c
Add -numa hmat-cache option to provide Memory Side Cache Information.
These memory attributes help to build Memory Side Cache Information
Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
---
numa.c | 95
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
---
numa.c | 142
An initiator proximity domain (memory initiator) is any device
such as a CPU or a separate memory I/O device that can initiate
a memory request. A target proximity domain (memory target)
is a CPU-accessible physical address range.
Signed-off-by: Liu Jingqi
---
numa.c | 7 +++
1 file changed
as hint for optimization.
Signed-off-by: Liu Jingqi
---
hw/acpi/hmat.c | 75
hw/acpi/hmat.h | 77 +-
2 files changed, 151 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/hmat.c b/hw
the system
memory that use the memory side cache.
Signed-off-by: Liu Jingqi
---
hw/acpi/hmat.c | 56
hw/acpi/hmat.h | 44
2 files changed, 100 insertions(+)
diff --git a/hw/acpi/hmat.c b/hw
memory usage.
Signed-off-by: Liu Jingqi
---
default-configs/x86_64-softmmu.mak | 1 +
hw/acpi/Makefile.objs | 1 +
hw/acpi/hmat.c | 174 +
hw/acpi/hmat.h | 75
hw/i386/acpi-build.c
Yes. The corresponding patch in KVM refers to the following link:
https://www.spinics.net/lists/kernel/msg2792864.html
Thanks.
-Original Message-
From: Eduardo Habkost [mailto:ehabk...@redhat.com]
Sent: Thursday, May 3, 2018 11:05 AM
To: Liu, Jingqi
Cc: qemu-devel@nongnu.org; pbonz
68 matches
Mail list logo
