Signed-off-by: Lukas Straub
---
migration/ram.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7a8f540737..9072d70f7c 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -32,7 +32,6 @@
#include "qemu/bitmap.h"
#include "qemu/madvi
Make ram-compress.c target independent.
Signed-off-by: Lukas Straub
---
migration/meson.build| 2 +-
migration/ram-compress.c | 16 +---
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/migration/meson.build b/migration/meson.build
index 262e3c9754..16f642031c
This makes the core compress code more independend from ram.c.
Signed-off-by: Lukas Straub
---
migration/ram.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7ab008145b..f55eb0e587 100644
--- a/migration/ram.c
This will be used in the next commits to move save_page_header()
out of compress code.
Signed-off-by: Lukas Straub
---
migration/ram.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 9d1817ab7b
Instead introduce a extra parameter to trigger the compress thread.
Now, when the compress thread is done, we know what RAMBlock and
offset it did compress.
This will be used in the next commits to move save_page_header()
out of compress code.
Signed-off-by: Lukas Straub
---
migration/ram.c
-off-by: Lukas Straub
---
migration/ram.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 96e8a19a58..9d1817ab7b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -688,12 +688,11 @@ exit:
* @offset: offset
There has never been a test for migration with compress enabled.
Add a suitable test, testing with compress-wait-thread = false
too.
iterations = 2 is intentional, so it also tests that no invalid
thread state is left over from the previous iteration.
Signed-off-by: Lukas Straub
---
tests
-off-by: Lukas Straub
---
migration/ram.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 96e8a19a58..9d1817ab7b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -688,12 +688,11 @@ exit:
* @offset: offset
There has never been a test for migration with compress enabled.
Add a suitable test, testing with compress-wait-thread = false
too.
iterations = 2 is intentional, so it also tests that no invalid
thread state is left over from the previous iteration.
Signed-off-by: Lukas Straub
---
tests
ing
> nbd: move s->state under requests_lock
> nbd: take receive_mutex when reading requests[].receiving
> nbd: document what is protected by the CoMutexes
>
> block/coroutines.h | 4 +-
> block/nbd.c| 298 +++------
> 2 fi
On Thu, 26 Aug 2021 05:49:23 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Sunday, August 22, 2021 12:25 AM
> > To: Xu, Tao3
> > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
> > jasow...@redhat.com; qe
When introducing yank functionality in the migration code I forgot
to cover the multifd send side.
Signed-off-by: Lukas Straub
Tested-by: Leonardo Bras
Reviewed-by: Leonardo Bras
---
-v2:
-add Tested-by and Reviewed-by tags
migration/multifd.c | 6 +-
migration/multifd.h | 2 ++
2
On Wed, 4 Aug 2021 21:26:32 +0200
Lukas Straub wrote:
> Unconditionally unregister yank function in multifd_load_cleanup().
> If it is not unregistered here, it will leak and cause a crash
> in yank_unregister_instance(). Now if the ioc is still in use
> afterwards, it will only lead
On Thu, 19 Aug 2021 09:27:17 +0800
Tao Xu wrote:
> When COLO use only one vnet_hdr_support parameter between
> COLO network filter(filter-mirror, filter-redirector or
> filter-rewriter and colo-compare, packet will not be parsed
> correctly. Acquire network driver related to COLO, if it is
> nirt
On Wed, 4 Aug 2021 15:39:55 -0400
Peter Xu wrote:
> On Wed, Aug 04, 2021 at 09:26:32PM +0200, Lukas Straub wrote:
> > Unconditionally unregister yank function in multifd_load_cleanup().
> > If it is not unregistered here, it will leak and cause a crash
> > in yan
When introducing yank functionality in the migration code I forgot
to cover the multifd send side.
Signed-off-by: Lukas Straub
---
@Leonardo Could you check if this fixes your issue?
migration/multifd.c | 6 +-
migration/multifd.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion
checking the code, i am pretty sure that ref is always 1
when arriving here. So all this currently does is remove the
unneeded check.
Signed-off-by: Lukas Straub
---
This is similar to Peter Xu's
39675b3394d44b880d083a214c5e44786170
"migration: Move the yank unregister of channel
On Tue, 3 Aug 2021 04:18:42 -0300
Leonardo Bras Soares Passos wrote:
> Hello Lukas,
>
> On Tue, Aug 3, 2021 at 3:42 AM Lukas Straub wrote:
> > Hi,
> > There is an easier explanation: I forgot the send side of multifd
> > altogether (I thought it was covered b
hould properly fail the migration.
BTW: You can shutdown outgoing sockets from outside of qemu with the
'ss' utility, like this: 'sudo ss -K dst dport = '
Regards,
Lukas Straub
pgpUAwiOJ57ws.pgp
Description: OpenPGP digital signature
gt; migration/qemu-file-channel.c | 11 ++-
> migration/qemu-file.c | 17 ++-
> migration/qemu-file.h | 4 ++-
> migration/ram.c | 3 +-
> migration/savevm.c| 11 +--
> migration/yank_functions.c| 42 ++
> migration/yank_functions.h| 3 ++
> 11 files changed, 138 insertions(+), 48 deletions(-)
>
Looks good to me,
Reviewed-by: Lukas Straub
--
pgpxZj4aaOqBP.pgp
Description: OpenPGP digital signature
In preparation for the next patch, initialize s->hidden_disk and
s->secondary_disk later and replace access to them with local variables
in the places where they aren't initialized yet.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replica
round in
secondary_do_checkpoint() can be removed.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 25bbdf5d4b..b7
do_checkpoint() and _stop() are only called by COLO migration code
and COLO-migration activates all disks via bdrv_invalidate_cache_all()
before it calls these functions.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 12 +---
1 fi
s->active_disk is bs->file. Remove it and use local variables instead.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/block/replicati
tev due to missing permissions and removes
a workaround that was put in place back then.
Tested with full COLO-migration setup in my COLO testsuite.
Regards,
Lukas Straub
Changes:
-v6:
-Drop "replication: Assert that children are writable"
-Added Reviewed-by tags
-v5:
-Asse
do_checkpoint() and _stop() are only called by COLO migration code
and COLO-migration activates all disks via bdrv_invalidate_cache_all()
before it calls these functions.
Signed-off-by: Lukas Straub
---
block/replication.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff
Assert that the children are writable where it's needed.
While there is no test-case for the
BLOCK_REPLICATION_FAILOVER_FAILED state, this at least ensures that
s->secondary_disk is always writable in case replication might go
into that state.
Signed-off-by: Lukas Straub
---
block/repli
round in
secondary_do_checkpoint() can be removed.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 25bbdf5d4b..b7
In preparation for the next patch, initialize s->hidden_disk and
s->secondary_disk later and replace access to them with local variables
in the places where they aren't initialized yet.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replica
s->active_disk is bs->file. Remove it and use local variables instead.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/block/replicati
tev due to missing permissions and removes
a workaround that was put in place back then.
Tested with full COLO-migration setup in my COLO testsuite.
Regards,
Lukas Straub
Changes:
-v5:
-Assert that children are writable where it's needed
-v4:
-minor style fixes
-clarify why childre
On Mon, 12 Jul 2021 13:06:19 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 11.07.2021 23:33, Lukas Straub wrote:
> > On Fri, 9 Jul 2021 10:49:23 +0300
> > Vladimir Sementsov-Ogievskiy wrote:
> >
> >> 07.07.2021 21:15, Lukas Straub wrote:
> >>>
do_checkpoint() and _stop() are only called by COLO migration code
and COLO-migration activates all disks via bdrv_invalidate_cache_all()
before it calls these functions.
Signed-off-by: Lukas Straub
---
block/replication.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff
In preparation for the next patch, initialize s->hidden_disk and
s->secondary_disk later and replace access to them with local variables
in the places where they aren't initialized yet.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replica
s->active_disk is bs->file. Remove it and use local variables instead.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/block/replicati
round in
secondary_do_checkpoint() can be removed.
Signed-off-by: Lukas Straub
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/replication.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 25bbdf5d4b..b7
tev due to missing permissions and removes
a workaround that was put in place back then.
Regards,
Lukas Straub
Changes:
-v4:
-minor style fixes
-clarify why children areguaranteed to be writable in
"replication: Remove workaround"
-Added Reviewed-by tags
-v3:
-Sp
On Fri, 9 Jul 2021 10:49:23 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 07.07.2021 21:15, Lukas Straub wrote:
> > Remove the workaround introduced in commit
> > 6ecbc6c52672db5c13805735ca02784879ce8285
> > "replication: Avoid blk_make_empty() on read-only child&q
On Fri, 9 Jul 2021 10:11:15 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 07.07.2021 21:15, Lukas Straub wrote:
> > s->active_disk is bs->file. Remove it and use local variables instead.
> >
> > Signed-off-by: Lukas Straub
> > -
with
bdrv_attach_child() and requesting the required permissions.
Signed-off-by: Lukas Straub
---
block/replication.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 74adf30f54..c0d4a6c264 100644
--- a/
In preparation for the next patch, initialize s->hidden_disk and
s->secondary_disk later and replace access to them with local variables
in the places where they aren't initialized yet.
Signed-off-by: Lukas Straub
---
block/replication.c | 45 -
do_checkpoint() and _stop() are only called by COLO migration code
and COLO-migration doesn't inactivate disks.
Signed-off-by: Lukas Straub
---
block/replication.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/block/replication.c b/block/replication.
back then.
Regards,
Lukas Straub
Changes:
-v3:
-Split up into multiple patches
-Remove s->active_disk
-Clarify child permissions in commit message
-v2: Test for BDRV_CHILD_PRIMARY in replication_child_perm, since
bs->file might not be set yet. (Vladimir)
Lukas Straub (4
s->active_disk is bs->file. Remove it and use local variables instead.
Signed-off-by: Lukas Straub
---
block/replication.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 5216
Hi,
Thanks for your review. More below.
Btw: There is a overview of the replication design in
docs/block-replication.txt
On Wed, 7 Jul 2021 16:01:31 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 06.07.2021 19:11, Lukas Straub wrote:
> > The replication driver needs access to the child
emove a workaround introduced in commit
6ecbc6c52672db5c13805735ca02784879ce8285
"replication: Avoid blk_make_empty() on read-only child".
Signed-off-by: Lukas Straub
---
-v2: Test for BDRV_CHILD_PRIMARY in replication_child_perm, since
bs->file might not be set yet.
One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.
Signed-off-by: Lukas Straub
---
migration/ram.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 723af67c2e
On Sat, 3 Jul 2021 18:31:15 +0200
Lukas Straub wrote:
> On Wed, 30 Jun 2021 16:08:05 -0400
> Peter Xu wrote:
>
> > Taking the mutex every time for each dirty bit to clear is too slow,
> > especially
> > we'll take/release even if the dirty bit is cleared
Although unlikely, qemu might hang in nbd_send_request().
Allow recovery in this case by registering the yank function before
calling it.
Signed-off-by: Lukas Straub
---
Fix CC: email address so the mailing list doesn't reject it.
block/nbd.c | 8 +---
1 file changed, 5 insertions(
emove a workaround introduced in commit
6ecbc6c52672db5c13805735ca02784879ce8285
"replication: Avoid blk_make_empty() on read-only child".
Signed-off-by: Lukas Straub
---
Fix CC: email address so the mailing list doesn't reject it.
bloc
This is a test. The mailing list seems to reject my patches
--
pgp8mmJ0JCegG.pgp
Description: OpenPGP digital signature
On Thu, 17 Jun 2021 10:47:12 +0800
Lei Rao wrote:
> From: "Rao, Lei"
>
> When a PVM completed its SVM failover steps and begins to run in
> the simplex mode, QEMU would encounter a 'Segmentation fault' if
> the guest poweroff with the following calltrace:
>
> Program received signal SIGSEGV, S
irty() calls.
Hi,
I don't think COLO needs it, colo_flush_ram_cache() only runs on
the secondary (incoming) side and AFAIK the bitmap is only set in
ram_load_precopy() and they don't run in parallel.
Although I'm not sure what ramblock_sync_dirty_bitmap() does. I guess
it's on
On Tue, 15 Jun 2021 19:37:35 +0800
Zhang Chen wrote:
> Since the real user scenario does not need COLO to monitor all traffic.
> Add colo-passthrough-add and colo-passthrough-del to maintain
> a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands.
> All the fields of IPFlowS
ster each function. In
> what
> case will the ref be not one?
>
If a return path is opened with qemu_file_get_return_path(), it will
take additional references:
qemu_file_get_return_path() (qemu-file.c)
f->ops->get_return_path() -> channel_get_input_return_path()
(qemu-file-channel.c)
qemu_fopen_channel_input() (qemu-file-channel.c)
object_ref(OBJECT(ioc))
Regards,
Lukas Straub
--
pgpFsXknGErXS.pgp
Description: OpenPGP digital signature
t; Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1964326
> Signed-off-by: Leonardo Bras
>
Looks good to me,
Reviewed-by: Lukas Straub
> --
> Changes since v2:
> - Dropped all references to ioc->master
> - yank_register_function() and yank_unregister_function()
gt; On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote:
> > > > > On Wed, 26 May 2021 16:40:35 -0400
> > > > > Peter Xu wrote:
> > > > >
> > > > > > On Wed, May 26, 2021 at 05:05:40PM -0300, Leonardo Bras wrote:
> &
migration_yank_iochannel,
> QIO_CHANNEL(p->c));
The code here should be the same as in channel_close. So for the
tls-channel you have to unregister with QIO_CHANNEL(tioc->master) like
below.
Regards,
Lukas Straub
> diff --git a/migrat
> final tls ioc?
>
> Lukas, is there a reason?
>
Hi,
There is no specific reason. Both ways work equally well in preventing
qemu from hanging. shutdown() for tls-channel just makes it abort a
little sooner (by not attempting to encrypt and send data anymore).
I don't lean eithe
On Wed, 12 May 2021 15:49:57 +0800
Zhang Chen wrote:
> Fix the issue from this patch:
> [PATCH] block: Flush all children in generic code
> From 883833e29cb800b4d92b5d4736252f4004885191
>
> Quorum driver do not have the primary child.
> It will caused guest block flush issue when use quorum and
On Tue, 20 Apr 2021 23:15:37 +0800
Zhang Chen wrote:
> Use connection protocol,src port,dst port,src ip,dst ip as the key
> to bypass certain network traffic in COLO compare.
>
> Signed-off-by: Zhang Chen
> ---
> net/net.c | 160 +-
> 1 file
On Tue, 20 Apr 2021 23:15:32 +0800
Zhang Chen wrote:
> Since the real user scenario does not need COLO to monitor all traffic.
> Add colo-passthrough-add and colo-passthrough-del to maintain
> a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands.
> Except protocol field is
On Tue, 20 Apr 2021 23:15:36 +0800
Zhang Chen wrote:
> Add passthrough list for each CompareState.
>
> Signed-off-by: Zhang Chen
> ---
> net/colo-compare.c | 28
> net/colo-compare.h | 12
> 2 files changed, 40 insertions(+)
>
> diff --git a/net/colo-
On Tue, 20 Apr 2021 23:15:35 +0800
Zhang Chen wrote:
> Rename structure with COLO index and move it to .h file,
> It make other modules can reuse COLO code.
Hi,
There are some definitions that don't need to be moved into the header,
more comments below.
In general I think the new passthrough fe
ror.c | 8 ++---
> net/filter-rewriter.c | 3 +-
> net/net.c | 4 +++
> softmmu/runstate.c | 1 +
> 12 files changed, 129 insertions(+), 37 deletions(-)
>
I guess Zhang Chen can already take the network-related patches through his
tree.
Regards,
Lukas Straub
--
pgpLi2cUeRqps.pgp
Description: OpenPGP digital signature
> softmmu/runstate.c | 1 +
> 12 files changed, 135 insertions(+), 29 deletions(-)
>
Looks good to me and works well in my tests:
Reviewed-by: Lukas Straub
Tested-by: Lukas Straub
Regards,
Lukas Straub
--
pgpxtM7C7xGdm.pgp
Description: OpenPGP digital signature
On Wed, 31 Mar 2021 15:16:18 -0500
Eric Blake wrote:
> On 3/31/21 3:00 PM, Lukas Straub wrote:
> > Hi,
> > This qmp command that used to work:
> > {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "
tdev": "mirror0",
"vnet_hdr_support": false}}}
now fails with the following error:
{"error": {"class": "GenericError", "desc": "Parameter 'netdev' is missing"}}
I haven't looked closely into it, but I think
9151e59a8b6e854eb733553c6772351049ca6ab6 "qapi/qom: QAPIfy object-add"
is the culprint.
Regards,
Lukas Straub
--
pgpaJyK4c06N0.pgp
Description: OpenPGP digital signature
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 249 +
3 files changed, 252
ter a
yank instance as they are initialized via
chardev_new()
qemu_char_open()
cc->open() (qmp_chardev_open_socket()).
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char-socket.c | 20 +---
chardev/char.c | 35 ++
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.
Regards,
Lukas Straub
Changes:
-v8:
-test: use custom thread to accept() instead of qio_net_listener
-v7:
-test: fix patchew error by
register a yank instance.
This in turn tries to dereference the NULL-pointer.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 48f321b3e1
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 227 +
3 files changed, 230
register a yank instance.
This in turn tries to dereference the NULL-pointer.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 48f321b3e1
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.
Regards,
Lukas Straub
Changes:
-v7:
-test: fix patchew error by not using macros
-v6:
-test: (hopefully) fix test on OSX by using
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c
ter a
yank instance as they are initialized via
chardev_new()
qemu_char_open()
cc->open() (qmp_chardev_open_socket()).
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char-socket.c | 20 +---
chardev/char.c | 35 ++
On Mon, 29 Mar 2021 22:19:17 +0400
Marc-André Lureau wrote:
> Hi Lukas
>
> On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub wrote:
>
> > Hello Everyone,
> > These patches increase test coverage for yank, add tests and fix bugs and
> > crashes in yank in combination w
ter a
yank instance as they are initialized via
chardev_new()
qemu_char_open()
cc->open() (qmp_chardev_open_socket()).
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char-socket.c | 20 +---
chardev/char.c | 35 ++
register a yank instance.
This in turn tries to dereference the NULL-pointer.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 48f321b3e1
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 200 +
3 files changed, 203
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.
Regards,
Lukas Straub
Changes:
-v6:
-test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
server socket so new
-yank - too few tests run (expected 6, got 1)
> >
> >
> Lukas, can you have a look too?
I guess OSX is waiting for a accept() from the other side (I have no OSX here
to test though). I'll fix it.
Regards,
Lukas Straub
--
pgpQJmJ4cAODo.pgp
Description: OpenPGP digital signature
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 200 +
3 files changed, 203
register a yank instance.
This in turn tries to dereference the NULL-pointer.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 48f321b3e1
ter a
yank instance as they are initialized via
chardev_new()
qemu_char_open()
cc->open() (qmp_chardev_open_socket()).
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char-socket.c | 20 +---
chardev/char.c | 35 ++
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.
Regards,
Lukas Straub
Changes:
-v5:
-test: fix memory leak
-v4:
-test: fix CharChangeTestConfig structs on stack going out of scope
On Fri, 26 Mar 2021 17:52:40 +
Peter Maydell wrote:
> On Fri, 26 Mar 2021 at 17:34, Lukas Straub wrote:
> >
> > The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6:
> >
> > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-2021
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 200 +
3 files changed, 203
register a yank instance.
This in turn tries to dereference the NULL-pointer.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 48f321b3e1
Remove dependency on qiochannel by removing yank_generic_iochannel and
letting migration and chardev use their own yank function for
iochannel.
Signed-off-by: Lukas Straub
Reviewed-by: Thomas Huth
Reviewed-by: Marc-André Lureau
---
MAINTAINERS | 1 +
chardev/char-socket.c
ter a
yank instance as they are initialized via
chardev_new()
qemu_char_open()
cc->open() (qmp_chardev_open_socket()).
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char-socket.c | 20 +---
chardev/char.c | 35 ++
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c
Yank now only depends on util and can be always linked in. Also remove
the stubs as they are not needed anymore.
Signed-off-by: Lukas Straub
Reviewed-by: Thomas Huth
Reviewed-by: Marc-André Lureau
---
MAINTAINERS | 1 -
stubs/meson.build | 1 -
stubs/yank.c | 23
core code
-Always link in the yank code to increase test coverage
-Fix yank with chardev-change
-Add tests for yank with chardev-change
--------
Lukas Straub (6):
yank: Remove dependency on qiochannel
yank: Always link full
On Fri, 26 Mar 2021 19:56:26 +0400
Marc-André Lureau wrote:
> Hi
>
> On Fri, Mar 26, 2021 at 11:48 AM Lukas Straub wrote:
>
> > Hello Everyone,
> > These patches increase test coverage for yank, add tests and fix bugs and
> > crashes in yank in combination w
https://lore.kernel.org/qemu-devel/cover.1616744509.git.lukasstra...@web.de/
Regards,
Lukas Straub
--
pgpM_sORoMekL.pgp
Description: OpenPGP digital signature
101 - 200 of 601 matches
Mail list logo
