Migration and yank code assume that qio_channel_shutdown is thread
-safe and can be called from qmp oob handler. Document this after
checking the code.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
include/io/channel.h | 5 -
1 file changed, 4
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8c744a9bdf..81288fd219 100644
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 95e45812d5
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Acked-by: Dr. David Alan Gilbert
---
migration/channel.c | 13 +
migration/migration.c | 25 +
migration/multifd.c | 10
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b
be queried by a 'query-yank' oob command.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
include/qemu/yank.h | 95 +++
qapi/meson.build | 1 +
qapi/qapi-schema.json | 1 +
qapi/yank.json| 115 ++
util/meson.build | 1 +
u
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
block/nbd.c | 154 +++-
1 file changed,
out-of-band qmp command to recover from
these kinds of hangs. The different subsystems register callbacks which get
executed with the yank command. For example the callback can shutdown() a
socket. This is intended for the colo use-case, but it can be used for other
things too of course.
Regar
On Fri, 30 Oct 2020 15:02:09 +0100
Markus Armbruster wrote:
> Lukas Straub writes:
>
> > On Thu, 29 Oct 2020 17:36:14 +0100
> > Markus Armbruster wrote:
> >
> >> Nothing major, looks almost ready to me.
> >>
> >> Lukas Straub writes:
>
On Thu, 29 Oct 2020 17:36:14 +0100
Markus Armbruster wrote:
> Nothing major, looks almost ready to me.
>
> Lukas Straub writes:
>
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can registe
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index ef6f5c7399
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b
Migration and yank code assume that qio_channel_shutdown is thread
-safe and can be called from qmp oob handler. Document this after
checking the code.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
include/io/channel.h | 5 -
1 file changed, 4
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Acked-by: Dr. David Alan Gilbert
---
migration/channel.c | 13 +
migration/migration.c | 25 +
migration/multifd.c | 10
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 95e45812d5
yank_register_instance will abort, because the yank instance is
already/still registered.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
---
tests/test-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index 9196e566e9..aedb5c9eda 100644
--- a/tests
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
block/nbd.c | 154 +++-
1 file changed,
be queried by a 'query-yank' oob command.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
include/qemu/yank.h | 95
qapi/misc.json | 106 ++
util/meson.build| 1 +
util/yank.c | 213
4 fil
ntended for the colo use-case, but it can be used for other
things too of course.
Regards,
Lukas Straub
Lukas Straub (8):
Introduce yank feature
block/nbd.c: Add yank feature
chardev/char-socket.c: Add yank feature
migration: Add yank feature
io/channel-tls.c: make qio_channel_tls_shutd
EMU networking device
> ```
> -device virtio-net-pci,id=e0,netdev=hn0 \
> -netdev
> tap,id=hn0,br=br0,vhost=off,helper=/usr/local/libexec/qemu-bridge-helper \
> ```
>
> Thanks.
>
> Regards,
> Derek
>
> ** Affects: qemu
> Importance: Undecided
>
On Thu, 27 Aug 2020 14:37:00 +0200
Markus Armbruster wrote:
> I apologize for not reviewing this much earlier.
>
> Lukas Straub writes:
>
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can re
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5a22c8be42
yank_register_instance will abort, because the yank instance is
already/still registered.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
---
tests/test-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index d35cc839bc..2ced07de69 100644
--- a/tests
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
block/nbd.c |
Migration and yank code assume that qio_channel_shutdown is thread
-safe and can be called from qmp oob handler. Document this after
checking the code.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
include/io/channel.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
these kinds of hangs. The different subsystems register callbacks which get
executed with the yank command. For example the callback can shutdown() a
socket. This is intended for the colo use-case, but it can be used for other
things too of course.
Regards,
Lukas Straub
Lukas Straub (8):
Introduce
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Acked-by: Dr. David Alan Gilbert
---
migration/channel.c | 12
migration/migration.c | 25 +
migration/multifd.c | 10
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
chardev/char-socket.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char
be queried by a 'query-yank' oob command.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
include/qemu/yank.h | 81 +++
qapi/misc.json | 62 +++
util/meson.build| 1 +
util/yank.c | 187
4 files ch
On Thu, 27 Aug 2020 14:37:00 +0200
Markus Armbruster wrote:
> I apologize for not reviewing this much earlier.
>
> Lukas Straub writes:
>
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can re
On Tue, 18 Aug 2020 14:26:31 +0200
Lukas Straub wrote:
> On Tue, 4 Aug 2020 10:11:22 +0200
> Lukas Straub wrote:
>
> > Hello Everyone,
> > In many cases, if qemu has a network connection (qmp, migration, chardev,
> > etc.)
> > to some other server and that ser
On Tue, 18 Aug 2020 14:27:01 +0200
Lukas Straub wrote:
> On Tue, 4 Aug 2020 12:46:29 +0200
> Lukas Straub wrote:
>
> > Hello Everyone,
> > So here is v3. Patch 1 can already be merged independently of the others.
> > Please review.
> >
> > R
On Tue, 4 Aug 2020 12:46:29 +0200
Lukas Straub wrote:
> Hello Everyone,
> So here is v3. Patch 1 can already be merged independently of the others.
> Please review.
>
> Regards,
> Lukas Straub
>
> Based-on:
> "Introduce 'yank' oob qmp command to recover
On Tue, 4 Aug 2020 10:11:22 +0200
Lukas Straub wrote:
> Hello Everyone,
> In many cases, if qemu has a network connection (qmp, migration, chardev,
> etc.)
> to some other server and that server dies or hangs, qemu hangs too.
> These patches introduce the new 'yank' out-of-b
While I'm not going to have much time for this, I'll still
try to test and review patches.
Signed-off-by: Lukas Straub
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3d2b..02090a728b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Optionally install the resouce-agent so it gets picked up by
pacemaker.
Signed-off-by: Lukas Straub
---
Makefile | 5 +
configure | 10 ++
2 files changed, 15 insertions(+)
diff --git a/Makefile b/Makefile
index c2120d8d48..dccc20b120 100644
--- a/Makefile
+++ b/Makefile
Introduce a resource agent which can be used to manage qemu COLO
in a pacemaker cluster.
Signed-off-by: Lukas Straub
---
scripts/colo-resource-agent/colo | 1501 ++
1 file changed, 1501 insertions(+)
create mode 100755 scripts/colo-resource-agent/colo
diff --git
Replace duplicate code with pick_qemu_util.
Signed-off-by: Lukas Straub
---
tests/acceptance/boot_linux.py | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
index 0055dc7cee..0d3629cabb 100644
This introduces a generic function to pick qemu utility binaries
from the build dir, system or via test parameter.
Signed-off-by: Lukas Straub
---
tests/acceptance/avocado_qemu/__init__.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/acceptance/avocado_qemu
Add high-level test relying on the colo resource-agent to test
all failover cases while checking guest network connectivity.
Signed-off-by: Lukas Straub
---
scripts/colo-resource-agent/crm_master | 44 ++
scripts/colo-resource-agent/crm_resource | 12 +
tests/acceptance/colo.py
If we remove the child with the highest index from the quorum,
decrement s->next_child_index. This way we get stable children
names as long as we only remove the last child.
Signed-off-by: Lukas Straub
Fixes: https://bugs.launchpad.net/bugs/1881231
Reviewed-by: Zhang Chen
Reviewed-by: Albe
Hello Everyone,
So here is v3. Patch 1 can already be merged independently of the others.
Please review.
Regards,
Lukas Straub
Based-on:
"Introduce 'yank' oob qmp command to recover from hanging qemu"
Changes:
v3:
-resource-agent: Don't determine local qemu state by remote ma
yank_register_instance will abort, because the yank instance is
already/still registered.
Signed-off-by: Lukas Straub
---
tests/test-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index d35cc839bc..2ced07de69 100644
--- a/tests/test-char.c
+++ b/tests/test
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3d2b
Migration and yank code assume that qio_channel_shutdown is thread
-safe. Document this after checking the code.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
include/io/channel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/io
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
migration/channel.c | 12
migration/migration.c | 25 -
migration/multifd.c | 10 ++
migration/qemu-file
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
block/nbd.c | 129
1 file changed,
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index ef62dbf3d7
be queried by a 'query-yank' oob command.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
include/qemu/yank.h | 80 +++
qapi/misc.json | 45 +++
util/Makefile.objs | 1 +
util/yank.c | 184
4 files ch
callbacks which get
executed with the yank command. For example the callback can shutdown() a
socket. This is intended for the colo use-case, but it can be used for other
things too of course.
Regards,
Lukas Straub
v7:
-yank_register_instance now returns error via Error **errp instead
On Fri, 31 Jul 2020 10:37:34 +0100
Daniel P. Berrangé wrote:
> On Fri, Jul 31, 2020 at 11:27:04AM +0200, Lukas Straub wrote:
> > yank_register_instance (called when creating the new chardev object)
> > aborts if the instance already exists. So check for duplicate id before
>
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3d2b
Migration and yank code assume that qio_channel_shutdown is thread
-safe. Document this after checking the code.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
include/io/channel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/io
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b
yank_register_instance (called when creating the new chardev object)
aborts if the instance already exists. So check for duplicate id before
creating the new chardev to prevent this.
Signed-off-by: Lukas Straub
---
chardev/char.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 24
1 file changed, 24 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
yank_register_instance will abort, because the yank instance is
already/still registered.
Signed-off-by: Lukas Straub
---
tests/test-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index d35cc839bc..2ced07de69 100644
--- a/tests/test-char.c
+++ b/tests/test
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
migration/channel.c | 12
migration/migration.c | 18 +-
migration/multifd.c | 10
be queried by a 'query-yank' oob command.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
include/qemu/yank.h | 79 +++
qapi/misc.json | 45 +++
util/Makefile.objs | 1 +
util/yank.c
callbacks which get
executed with the yank command. For example the callback can shutdown() a
socket. This is intended for the colo use-case, but it can be used for other
things too of course.
Regards,
Lukas Straub
v6:
-add Reviewed-by and Acked-by tags
-rebase on master
-lots of changes
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
block/nbd.c | 123 +++-
1 file changed,
.zhanghaili...@huawei.com/T/#u
Hailang, are you ok with that?
Regards,
Lukas Straub
pgpWMhtdQOKzT.pgp
Description: OpenPGP digital signature
s->iothread is checked for NULL on object creation in colo_compare_complete,
so it's guaranteed not to be NULL.
This resolves a false alert from Coverity (CID 1429969).
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --
On Sat, 6 Jun 2020 21:17:32 +0200
Lukas Straub wrote:
> Hello Everyone,
> So here is v2. Patch 1 can already be merged independently of the others.
>
> Regards,
> Lukas Straub
>
> Changes:
> v2:
> -use new yank api
> -drop disk_size parameter
> -introduc
On Wed, 24 Jun 2020 21:47:46 +0200
Lukas Straub wrote:
> On Tue, 23 Jun 2020 16:42:30 +0200
> Lukas Straub wrote:
>
> > Hello Everyone,
> > In many cases, if qemu has a network connection (qmp, migration, chardev,
> > etc.)
> > to some other server and that
On Thu, 25 Jun 2020 10:30:24 +0100
Peter Maydell wrote:
> On Thu, 18 Jun 2020 at 14:23, Jason Wang wrote:
> >
> > From: Lukas Straub
> >
> > In colo_compare_complete, insert CompareState into net_compares
> > only after everything has been initialized.
>
On Tue, 23 Jun 2020 16:42:30 +0200
Lukas Straub wrote:
> Hello Everyone,
> In many cases, if qemu has a network connection (qmp, migration, chardev,
> etc.)
> to some other server and that server dies or hangs, qemu hangs too.
> These patches introduce the new 'yank' out-of-b
Migration and yank code assume that qio_channel_shutdown is thread
-safe. Document this after checking the code.
Signed-off-by: Lukas Straub
---
include/io/channel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/io/channel.h b/include/io/channel.h
index d4557f0930..6b8a2b87b8
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
---
MAINTAINERS | 13 +
1 file changed, 13 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 955cc8dd5c..a403d59190 100644
--- a/MAINTAINERS
+++ b
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b/io/channel-tls.c
index 7ec8ceff2f..b350c84640 100644
--- a
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
---
chardev/char-socket.c | 24
1 file changed, 24 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index afebeec5c3..4e7a7e9ae4 100644
--- a/chardev/char
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
---
migration/channel.c | 12
migration/migration.c | 18 +-
migration/multifd.c | 10 ++
migration/qemu-file-channel.c | 6 ++
migration
be queried by a 'query-yank' oob command.
Signed-off-by: Lukas Straub
---
include/qemu/yank.h | 79 +++
qapi/misc.json | 45 +++
util/Makefile.objs | 1 +
util/yank.c | 179
4 files changed, 304 insertions(+)
create m
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
---
block/nbd.c | 101 +---
1 file changed, 64 insertions(+), 37 deleti
register callbacks which get
executed with the yank command. For example the callback can shutdown() a
socket. This is intended for the colo use-case, but it can be used for other
things too of course.
Regards,
Lukas Straub
v5:
-move yank.c to util/
-move yank.h to include/qemu/
-add license to yank.h
On Wed, 17 Jun 2020 16:09:09 +0100
Stefan Hajnoczi wrote:
> On Mon, May 25, 2020 at 05:44:26PM +0200, Lukas Straub wrote:
> > @@ -1395,6 +1407,15 @@ static int nbd_client_reopen_prepare(BDRVReopenState
> > *state,
> > return 0;
> > }
> >
>
++-
> > qemu-options.hx| 33 +
> > 2 files changed, 59 insertions(+), 17 deletions(-)
>
>
> Queued for 5.1.
>
> Thanks
>
>
Hi,
It looks like this hasn't been merged.
Regards,
Lukas Straub
pgprnYzxxtUsU.pgp
Description: OpenPGP digital signature
On Fri, 19 Jun 2020 17:52:40 +0100
Daniel P. Berrangé wrote:
> On Fri, Jun 19, 2020 at 06:29:24PM +0200, Lukas Straub wrote:
> > On Wed, 17 Jun 2020 16:12:40 +0100
> > Stefan Hajnoczi wrote:
> >
> > > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub w
On Wed, 17 Jun 2020 16:12:40 +0100
Stefan Hajnoczi wrote:
> On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > +static struct YankInstance *yank_find_instance(char *name)
>
> There are const char * -> char * casts in later patches. Please use
> const
On Wed, 17 Jun 2020 15:39:36 +0100
Stefan Hajnoczi wrote:
> On Thu, May 21, 2020 at 04:48:06PM +0100, Daniel P. Berrangé wrote:
> > On Thu, May 21, 2020 at 05:42:41PM +0200, Lukas Straub wrote:
> > > On Thu, 21 May 2020 16:03:35 +0100
> > > Stefan Hajnoczi wrote:
&
On Tue, 16 Jun 2020 15:44:06 +0100
Daniel P. Berrangé wrote:
> On Mon, May 25, 2020 at 05:44:26PM +0200, Lukas Straub wrote:
> > Register a yank function which shuts down the socket and sets
> > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
> > error
On Tue, 16 Jun 2020 15:39:57 +0100
Daniel P. Berrangé wrote:
> On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can register themselves and
&g
On Tue, 16 Jun 2020 01:42:45 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Sunday, June 7, 2020 3:00 AM
> > To: Zhang, Chen
> > Cc: qemu-devel ; Alberto Garcia
> > ; Dr. David Alan Gilbert ; Jas
On Mon, 8 Jun 2020 03:46:11 +0800
Zhang Chen wrote:
> From: Zhang Chen
>
> MIGRATION_STATUS_ACTIVE is invalid here, handle it by default case.
>
> Suggested-by: Lukas Straub
> Signed-off-by: Zhang Chen
> ---
Looks good and works well in my tests.
Reviewed-by:
On Mon, 8 Jun 2020 03:46:09 +0800
Zhang Chen wrote:
> From: Zhang Chen
>
> No need to reuse MIGRATION_STATUS_ACTIVE boot COLO.
>
> Signed-off-by: Zhang Chen
> Reviewed-by: zhanghailiang
> ---
Looks good and works well in my tests.
Reviewed-by: Lukas Straub
Te
o matter its old running state.
> * After exited COLO, we will keep running.
> */
> +case MIGRATION_STATUS_ACTIVE:
> +/*
> + * We should really assert here, but since it's during
> + * migration, let's try to reduce the usage of
wed-by: zhanghailiang
> ---
Hi,
Looks good and works well in my tests.
Reviewed-by: Lukas Straub
Tested-by: Lukas Straub
Regards,
Lukas Straub
pgpGIA0kOhJ53.pgp
Description: OpenPGP digital signature
r. David Alan Gilbert"
> Signed-off-by: David Hildenbrand
> ---
Hi,
This works well in my colo tests.
Tested-by: Lukas Straub
Regards,
Lukas Straub
pgplYuRWlINxS.pgp
Description: OpenPGP digital signature
While I'm not going to have much time for this, I'll still
try to test and review patches.
Signed-off-by: Lukas Straub
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fac2b..4c623a96e1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Add high-level test relying on the colo resource-agent to test
all failover cases while checking guest network connectivity.
Signed-off-by: Lukas Straub
---
scripts/colo-resource-agent/crm_master | 44 ++
scripts/colo-resource-agent/crm_resource | 12 +
tests/acceptance/colo.py
On Mon, 25 May 2020 17:44:12 +0200
Lukas Straub wrote:
> Hello Everyone,
> In many cases, if qemu has a network connection (qmp, migration, chardev,
> etc.)
> to some other server and that server dies or hangs, qemu hangs too.
> These patches introduce the new 'yank' out-of-b
Optionally install the resouce-agent so it gets picked up by
pacemaker.
Signed-off-by: Lukas Straub
---
Makefile | 5 +
configure | 10 ++
2 files changed, 15 insertions(+)
diff --git a/Makefile b/Makefile
index 8a9113e666..2ebffc4465 100644
--- a/Makefile
+++ b/Makefile
Introduce a resource agent which can be used to manage qemu COLO
in a pacemaker cluster.
Signed-off-by: Lukas Straub
---
scripts/colo-resource-agent/colo | 1466 ++
1 file changed, 1466 insertions(+)
create mode 100755 scripts/colo-resource-agent/colo
diff --git
Replace duplicate code with pick_qemu_util.
Signed-off-by: Lukas Straub
---
tests/acceptance/boot_linux.py | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
index 075a386300..6b99112cad 100644
This introduces a generic function to pick qemu utility binaries
from the build dir, system or via test parameter.
Signed-off-by: Lukas Straub
---
tests/acceptance/avocado_qemu/__init__.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/acceptance/avocado_qemu
If we remove the child with the highest index from the quorum,
decrement s->next_child_index. This way we get stable children
names as long as we only remove the last child.
Signed-off-by: Lukas Straub
Fixes: https://bugs.launchpad.net/bugs/1881231
Reviewed-by: Zhang Chen
Reviewed-by: Albe
Hello Everyone,
So here is v2. Patch 1 can already be merged independently of the others.
Regards,
Lukas Straub
Changes:
v2:
-use new yank api
-drop disk_size parameter
-introduce pick_qemu_util function and use it
Overview:
Hello Everyone,
These patches introduce a resource agent for fully
On Mon, 18 May 2020 09:38:24 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Monday, May 11, 2020 8:27 PM
> > To: qemu-devel
> > Cc: Alberto Garcia ; Dr. David Alan Gilbert
> > ; Zhang, Chen
> >
301 - 400 of 601 matches
Mail list logo
