Thank you, I see that there is an issue and I'll take care of fixing
it in the future
On Mon, Jan 22, 2024 at 5:53 PM Peter Maydell wrote:
>
> On Thu, 18 Jan 2024 at 16:02, Manolo de Medici
> wrote:
> >
> > Recently, a testsuite for gnumach, the GNU/Hurd micro
On Mon, Jan 22, 2024 at 6:04 PM Peter Maydell wrote:
>
> (Cc'ing the block folks)
>
> On Thu, 18 Jan 2024 at 16:03, Manolo de Medici
> wrote:
> >
> > Compilation fails on systems where copy_file_range is already defined as a
> > stub.
>
> What do you mean
On Mon, Jan 22, 2024 at 6:40 PM Peter Maydell wrote:
>
> On Mon, 22 Jan 2024 at 17:27, Daniel P. Berrangé wrote:
> >
> > On Thu, Jan 18, 2024 at 05:02:23PM +0100, Manolo de Medici wrote:
> > > qemu uses the PATH_MAX and IOV_MAX constants extensively
> > >
Compilation fails on systems where copy_file_range is already defined as a
stub.
The prototype of copy_file_range in glibc returns an ssize_t, not an off_t.
The function currently only exists on linux and freebsd, and in both cases
the return type is ssize_t
Signed-off-by: Manolo de Medici
Signed-off-by: Manolo de Medici
---
configure | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index 21ab9a64e9..fb11ede5b2 100755
--- a/configure
+++ b/configure
@@ -353,6 +353,8 @@ elif check_define __NetBSD__; then
host_os=netbsd
elif check_define __APPLE__
The Hurd currently doesn't have any TPM driver, compilation fails
for missing symbols unless these are left undefined.
Signed-off-by: Manolo de Medici
---
backends/tpm/tpm_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/tpm/tpm_ioctl.h b/backends/tpm
qemu uses the PATH_MAX and IOV_MAX constants extensively
in the code. Define these constants to sensible values ourselves
if the system doesn't define them already.
Signed-off-by: Manolo de Medici
---
include/qemu/osdep.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/qemu
be compiled without any special configure options.
Please review, thanks,
Manolo de Medici (4):
Include new arbitrary limits if not already defined
Avoid conflicting types for 'copy_file_range'
Add the GNU/Hurd as a target host
Exclude TPM ioctls definitions for the GNU/Hurd
backends/tpm
ific
> functions/whatever that it needs.
This is the best solution for this problem, any pointers on how to best do this?
Thanks
On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell wrote:
>
> On Wed, 17 Jan 2024 at 12:59, Manolo de Medici
> wrote:
> >
> > tests/qtest/tpm-* co
Ok Samuel,
in the v2 of this patch series I will fix this bug in qemu.
the capstone library')
On Wed, Jan 17, 2024 at 1:32 PM Manolo de Medici
wrote:
>
> tests/qtest/tpm-* compilation is not disabled by disable-tpm,
> for this reason compilation fails on systems that doesn't
> support the linux/bsd TPM api. Fix this by allowing tests
> to be disabled.
Understood, but I cannot judge if it is a bug in qemu or it fixes
another host os,
since qemu doesn't target only glibc.
In order to avoid breaking other hosts, I consider it more cautious to
ignore the difference.
In the long term the Hurd is going to implement copy_file_range
Hello Samuel,
the presence of the qemu stub causes the following compilation error:
FAILED: libblock.fa.p/block_file-posix.c.o
cc -m32 -Ilibblock.fa.p -I. -I../../.. -Iqapi -Itrace -Iui -Iui/shader
-Iblock -I/usr/include/glib-2.0 -I/usr/lib/i386-gnu/glib-2.0/include
-fdiagnostics-color=auto -Wall
__copy_file_ran
rightfully so I'd say, because copy_file_range is just a stub on the Hurd.
As such, we really need to exclude the code that defines the stub in
qemu on the Hurd.
On Wed, Jan 17, 2024 at 2:56 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Manolo,
>
> On 17/1/24 13:31, Mano
qemu uses the PATH_MAX and IOV_MAX constants extensively
in the code. Define these constants to sensible values ourselves
if the system doesn't define them already.
Signed-off-by: Manolo de Medici
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 9a405bed89..9fb6ac5c64 100644
the minimal effort to make qemu compilable and
running in GNU/Hurd. With this patchset applied, qemu can be compiled with
the '--disable-tpm' and the '--disable-tests' configure options.
Please review, thanks,
Manolo de Medici (4):
Allow tests to be disabled
Add the GNU/Hurd as a target host
tests/qtest/tpm-* compilation is not disabled by disable-tpm,
for this reason compilation fails on systems that doesn't
support the linux/bsd TPM api. Fix this by allowing tests
to be disabled.
Signed-off-by: Manolo de Medici
---
configure | 7 +++
1 file changed, 7 insertions(+)
diff
It's already defined as a stub on the GNU Hurd.
Signed-off-by: Manolo de Medici
diff --git a/block/file-posix.c b/block/file-posix.c
index 35684f7e21..05426abb7d 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1999,7 +1999,7 @@ static int handle_aiocb_write_zeroes_unmap(void
Signed-off-by: Manolo de Medici
---
configure | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index c36ce1f7e2..d4648af96a 100755
--- a/configure
+++ b/configure
@@ -354,6 +354,8 @@ elif check_define __NetBSD__; then
host_os=netbsd
elif check_define __APPLE__
tests/qtest/tpm-* compilation is not disabled by disable-tpm,
for this reason compilation fails on systems that doesn't
support the linux/bsd TPM api. Fix this by allowing tests
to be disabled.
Signed-off-by: Manolo de Medici
---
configure | 7 +++
1 file changed, 7 insertions(+)
diff
20 matches
Mail list logo
