[PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers

2023-05-22 Thread Marco Liebel
them to the correct location makes shuffling of .tmp vector registers work as expected. Signed-off-by: Marco Liebel --- target/hexagon/mmvec/decode_ext_mmvec.c | 8 +++ tests/tcg/hexagon/hvx_misc.c| 31 + 2 files changed, 35 insertions(+), 4 deletions

[PATCH] Hexagon (target/hexagon) Fix assignment to tmp registers

2023-05-22 Thread Marco Liebel
The order in which instructions are generated by gen_insn() influences assignment to tmp registers. During generation, tmp instructions (e.g. generate_V6_vassign_tmp) use vreg_src_off() to determine what kind of register to use as source. If some instruction (e.g. generate_V6_vmpyowh_64_acc) uses

[PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Marco Liebel
test_vshuff checks that the vshuff instruction works correctly when both vector registers are the same. Using vshuff in this way is undefined and will be rejected by the compiler in a future version of the toolchain. Signed-off-by: Marco Liebel --- tests/tcg/hexagon/hvx_misc.c | 45

[PATCH] Use hexagon toolchain version 16.0.0

2023-03-29 Thread Marco Liebel
Signed-off-by: Marco Liebel --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker b/tests/docker/dockerfiles/debian-hexagon-cross.docker index 5308ccb8fe..b99d99f943

RE: [PATCH 2/2] Add test for storing .new vector

2023-03-21 Thread Marco Liebel
> -Original Message- > From: Peter Maydell > Sent: Dienstag, 21. März 2023 18:20 > To: Marco Liebel (QUIC) > Cc: qemu-devel@nongnu.org; Taylor Simpson ; > Matheus Bernardino (QUIC) > Subject: Re: [PATCH 2/2] Add test for storing .new vector > > WARNING:

[PATCH 2/2] Add test for storing .new vector

2023-03-21 Thread Marco Liebel
Hexagon toolchain version 16.0.0 fixes a bug where the ecoding of storing a .new vector was incorrect. This resulted in an incorrect valued being stored. The test checks that the correct value is used. Signed-off-by: Marco Liebel --- tests/tcg/hexagon/hvx_misc.c | 29

[PATCH 0/2] Update hexagon toolchain

2023-03-21 Thread Marco Liebel
Updates the hexagon toolchain and adds a test for a bug that was fixed by the new version. Marco Liebel (2): Use hexagon toolchain version 16.0.0 Add test for storing .new vector .../dockerfiles/debian-hexagon-cross.docker | 2 +- tests/tcg/hexagon/hvx_misc.c | 29

[PATCH 1/2] Use hexagon toolchain version 16.0.0

2023-03-21 Thread Marco Liebel
Signed-off-by: Marco Liebel --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker b/tests/docker/dockerfiles/debian-hexagon-cross.docker index 5308ccb8fe..b99d99f943

[PATCH v3 2/2] Use black code style for python scripts

2023-03-20 Thread Marco Liebel
Signed-off-by: Marco Liebel --- target/hexagon/dectree.py | 396 --- target/hexagon/gen_analyze_funcs.py | 135 +++--- target/hexagon/gen_helper_funcs.py | 338 +++-- target/hexagon/gen_helper_protos.py | 165 --- target/hexagon

[PATCH v3 1/2] Use f-strings in python scripts

2023-03-20 Thread Marco Liebel
Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_analyze_funcs.py | 115 - target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py | 8 +- target

[PATCH v3 0/2] Use f-strings and black code style

2023-03-20 Thread Marco Liebel
Replaces python 2 format strings with f-strings and applies black code style to all python files in target/hexagon. Marco Liebel (2): Use f-strings in python scripts Use black code style for python scripts target/hexagon/dectree.py | 396 +++-- target/hexagon

[PATCH v2] Use f-strings in python scripts

2023-03-14 Thread Marco Liebel
Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_analyze_funcs.py | 115 - target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py | 8 +- target

RE: [PATCH] Use f-strings in python scripts

2023-03-14 Thread Marco Liebel
> -Original Message- > From: Taylor Simpson > Sent: Dienstag, 14. März 2023 18:54 > To: Marco Liebel (QUIC) ; qemu- > de...@nongnu.org > Subject: RE: [PATCH] Use f-strings in python scripts > > > > > -Original Message- > > From: Marco Li

[PATCH] Use f-strings in python scripts

2023-03-13 Thread Marco Liebel
Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py | 8 +- target/hexagon/gen_op_attribs.py| 4 +- target/hexagon

[PATCH v3] Hexagon (target/hexagon) implement mutability mask for GPRs

2023-01-05 Thread Marco Liebel
Some registers are defined to have immutable bits, this commit will implement that behavior. Signed-off-by: Marco Liebel --- target/hexagon/genptr.c | 44 - tests/tcg/hexagon/Makefile.target | 1 + tests/tcg/hexagon/reg_mut.c | 152 ++ 3

RE: [PATCH v2] Hexagon (target/hexagon) implement mutability mask for GPRs

2023-01-04 Thread Marco Liebel
> -Original Message- > From: Taylor Simpson > Sent: Mittwoch, 21. Dezember 2022 21:06 > To: Marco Liebel ; Marco Liebel (QUIC) > ; qemu-devel@nongnu.org > Cc: Brian Cain > Subject: RE: [PATCH v2] Hexagon (target/hexagon) implement mutability > mask for GPRs &g

RE: [PATCH v2] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-12-21 Thread Marco Liebel
> > +#define WRITE_REG_IN_PACKET(reg_name, output, input) \ > > +asm volatile("{ " reg_name " = %1 }\n\t" \ > > This is no different from the WRITE_REG above. Instructions on a line with > no curly braces are a single packet. > Understood. The feedback on Brian's patch said to write tests

[PATCH v2] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-12-16 Thread Marco Liebel
Some registers are defined to have immutable bits, this commit will implement that behavior. Signed-off-by: Marco Liebel --- This incorporates the feedback given on Brian's patch target/hexagon/genptr.c | 43 - tests/tcg/hexagon/Makefile.target | 3 + tests/tcg/hexagon