Hey,
Here's one for the calendar - a 2 day track at FOSDEM devoted to Open
Source Virtualization and Cloud.
Hope to see you there! :)
Cheers,
Mark.
Forwarded Message
From: Thierry Carrez thie...@openstack.org
To: openst...@lists.launchpad.net openst...@lists.launchpad.net
/get_maintainer.pl -f net.c net/
Anthony Liguori aligu...@us.ibm.com (maintainer:Network device
layer,commit_signer:4/16=25%)
Mark McLoughlin mar...@redhat.com (maintainer:Network device layer)
This is clearly out of date - feel free to remove it
Cheers,
Mark.
net: Monitor command set_link finds only VLAN clients, fix
Nice. They all look good to me
Acked-by: Mark McLoughlin mar...@redhat.com
Cheers,
Mark.
On Mon, 2009-12-14 at 15:10 +, Daniel P. Berrange wrote:
The model I had in mind was for the proxy to define a VNC extension that
allows the client to query what 'desktops' are available and request
switching between them at any time. The list of desktop would of course
be authorized per
On Fri, 2009-12-11 at 13:04 -0600, Anthony Liguori wrote:
But to introduce another protocol where a user has to make a choice to
use Spice over VNC, I think we need a really good justification for
that. It's really about complexity. A user shouldn't have to know
about Spice or VNC. They
Hi Dave,
On Fri, 2009-12-11 at 14:59 +1000, Dave Airlie wrote:
Hi guys,
Building 0.11.0, qemu -vga vmware -sdl works fine.
with git I just get a blank screen.
I'm trying to bisect but I keep running into a big chunk of NIC changes
where none of the drivers compile, so I thought maybe
-off-by: Arnd Bergmann a...@arndb.de
Looks fine to me
Acked-by: Mark McLoughlin mar...@redhat.com
Cheers,
Mark.
On Wed, 2009-11-25 at 20:36 +, Blue Swirl wrote:
On Wed, Nov 25, 2009 at 6:49 PM, Mark McLoughlin mar...@redhat.com wrote:
A replacement for qemu_new_vlan_client(), using NetClientInfo to
replace most arguments.
+VLANClientState *qemu_new_net_client(NetClientInfo *info
On Tue, 2009-11-24 at 22:27 +0100, Pierre Riteau wrote:
On 24 nov. 2009, at 12:22, Mark McLoughlin wrote:
On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote:
Isn't there a way to detect whether the kernel supports the
TUNSETOFFLOAD ioctl at all?
The kernel will set errno
On Wed, 2009-11-25 at 11:04 +0100, Pierre Riteau wrote:
This avoids the TUNSETOFFLOAD ioctl() failed: Invalid argument message
on kernels without TUNSETOFFLOAD support.
Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr
Acked-by: Mark McLoughlin mar...@redhat.com
Thanks,
Mark.
---
net
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
Makefile |1 +
net.c| 530 +--
net/socket.c | 561 ++
net/socket.h | 33
4 files changed, 596 insertions
Hi,
Here's a new series of patches mainly to fix qemu_announce_self()
with -netdev as discussed earlier on the list.
I would have liked to have split the series in three, but there
would be conflicts between each, so here goes:
1) Patches 01 to 05 - net.c cleanups
These
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
Makefile |1 +
net.c | 102 +-
net/vde.c | 124 +
net/vde.h | 36 ++
4 files changed, 162 insertions
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
Makefile |1 +
net.c | 127 +--
net/dump.c | 151
net/dump.h | 33 +
4 files changed, 186 insertions(+), 126
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
Makefile|1 +
monitor.c |1 +
net.c | 718 +---
net.h |8 +-
net/slirp.c | 752 +++
net/slirp.h | 51
Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/dp8393x.c | 10 +-
hw/etraxfs_eth.c | 10 +-
hw/mcf_fec.c | 10 +-
hw/mipsnet.c | 10
Common state for all NICs.
The opaque member will replace the opaque member in VLANClientState
since only NICs need it.
The conf member will allow us to iterate over NICs, access the MAC
addr for the NIC and send a packet from each NIC in qemu_announce_self().
Signed-off-by: Mark McLoughlin mar
Nothing qdev specific about this, make it available throughtout.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/qdev.h | 10 --
osdep.h | 10 ++
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/qdev.h b/hw/qdev.h
index 41642ee..8d53754 100644
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap.c | 82 +---
1 files changed, 45 insertions(+), 37 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index b2e5908..d34feec 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -47,7 +47,7
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/mipsnet.c | 45 +++--
1 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/mipsnet.c b/hw/mipsnet.c
index 67160a4..a066f63 100644
--- a/hw/mipsnet.c
+++ b/hw/mipsnet.c
@@ -35,7 +35,8
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
Makefile |2 +-
net.c | 35 ++-
net/util.c | 60
net/util.h | 32
4 files changed, 95 insertions
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/xen_nic.c | 46 +-
1 files changed, 29 insertions(+), 17 deletions(-)
diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index bcf161c..08055b8 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -41,6 +41,7
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap-win32.c | 39 +++
1 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/net/tap-win32.c b/net/tap-win32.c
index ea66471..ef63782 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/ne2000-isa.c | 22 ++
hw/ne2000.c | 35 +--
hw/ne2000.h |2 +-
3 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c
index
Was used by hot-unplug, but not anymore.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net.h b/net.h
index bc8392b..9ffcfe3 100644
--- a/net.h
+++ b/net.h
@@ -124,7 +124,6 @@ struct NICInfo {
char *devaddr
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/slirp.c | 61 +++---
1 files changed, 37 insertions(+), 24 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index d6d5772..3f91c4b 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -64,8
Now that we have a way to iterate NICs.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
savevm.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/savevm.c b/savevm.c
index 4668843..3cfc5aa 100644
--- a/savevm.c
+++ b/savevm.c
@@ -123,24
From: Pierre Riteau pierre.rit...@irisa.fr
vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
the kernel doesn't support IFF_VNET_HDR.
Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap-linux.c |2 ++
1 files
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/vde.c | 45 -
1 files changed, 28 insertions(+), 17 deletions(-)
diff --git a/net/vde.c b/net/vde.c
index 4d09967..42b4633 100644
--- a/net/vde.c
+++ b/net/vde.c
@@ -34,7 +34,7 @@
#include
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/xilinx_ethlite.c | 35 ---
1 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c
index b7129d5..37e33ec 100644
--- a/hw/xilinx_ethlite.c
+++ b/hw
... and VLANClientState::opaque and qemu_find_vlan_client().
All of these are now unused
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 44
net.h | 13 -
2 files changed, 0 insertions(+), 57 deletions(-)
diff --git
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 20
net.h |2 ++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/net.c b/net.c
index a1ec243..c71699d 100644
--- a/net.c
+++ b/net.c
@@ -326,6 +326,26 @@ qemu_find_vlan_client_by_name(Monitor
Reported-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/net.c b/net.c
index c71699d..13bdbb2 100644
--- a/net.c
+++ b/net.c
@@ -1055,12 +1055,18 @@ int
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/usb-net.c | 57 +++--
1 files changed, 31 insertions(+), 26 deletions(-)
diff --git a/hw/usb-net.c b/hw/usb-net.c
index 7b8cc7a..2556e05 100644
--- a/hw/usb-net.c
+++ b/hw/usb-net.c
net_tap_init() always sets vnet_hdr using qemu_opt_get_bool(), but
initialize it in net_init_tap() just to reduce confusion.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/etraxfs_eth.c | 45 +++--
1 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c
index 2cc2332..dedd107 100644
--- a/hw/etraxfs_eth.c
+++ b/hw
From: Pierre Riteau pierre.rit...@irisa.fr
This avoids the TUNSETOFFLOAD ioctl() failed: Invalid argument message
on kernels without TUNSETOFFLOAD support.
Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap-linux.c |5 +
1
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/mcf_fec.c | 58 +-
1 files changed, 33 insertions(+), 25 deletions(-)
diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
index 8242c8a..4e7fbed 100644
--- a/hw/mcf_fec.c
+++ b/hw/mcf_fec.c
Add a NetClientInfo pointer to VLANClientState and use that
for the typecode and function pointers.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/dp8393x.c|4 ++--
hw/virtio-net.c |2 +-
net.c | 45 -
net.h
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/eepro100.c | 43 ---
1 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 8734907..eb16a51 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -195,7
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/smc91c111.c | 35 ---
1 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/hw/smc91c111.c b/hw/smc91c111.c
index b7398c9..c1a88c9 100644
--- a/hw/smc91c111.c
+++ b/hw/smc91c111.c
@@ -18,7 +18,7
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/e1000.c | 47 ++-
1 files changed, 26 insertions(+), 21 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 00f6a57..683fdcc 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -75,7 +75,7 @@ enum
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/rtl8139.c | 43 ---
1 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index c166db0..931cde9 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -459,7 +459,7
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/socket.c | 74 +++--
1 files changed, 45 insertions(+), 29 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 551fc2b..7331d87 100644
--- a/net/socket.c
+++ b/net/socket.c
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/virtio-net.c | 73 +-
1 files changed, 39 insertions(+), 34 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 2f147e5..4f8d89e 100644
--- a/hw/virtio-net.c
+++ b/hw
This structure holds data which is common to all instances of a given
net client type/model.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/net.h b/net.h
index 9ffcfe3..56c5849 100644
--- a/net.h
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/dp8393x.c | 41 +
1 files changed, 25 insertions(+), 16 deletions(-)
diff --git a/hw/dp8393x.c b/hw/dp8393x.c
index 5143cc8..be9714d 100644
--- a/hw/dp8393x.c
+++ b/hw/dp8393x.c
@@ -154,7 +154,8
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/dump.c | 47 +++
1 files changed, 27 insertions(+), 20 deletions(-)
diff --git a/net/dump.c b/net/dump.c
index 05a102b..4ed3f5f 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -28,7 +28,7
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/musicpal.c | 31 ++-
1 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/hw/musicpal.c b/hw/musicpal.c
index 264669f..4a33e28 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -151,7 +151,7
Print an error if the user specifies vnet_hdr=1 on the cmdline.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap-solaris.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/net/tap-solaris.c b/net/tap-solaris.c
index ef4e60c..e14fe36 100644
--- a/net
.
From: Mark McLoughlin mar...@redhat.com
Subject: [PATCH] net: initialize vnet_hdr in net_tap_init()
Don't assume that all tap_open() implementations will set it to
zero if VNET_HDR support isn't found.
Fixes tap networking on host kernels lacking IFF_VNET_HDR support.
Reported-by: Pierre Riteau
On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
the kernel doesn't support IFF_VNET_HDR.
Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr
Thanks Pierre, I see why this is needed now
Acked-by: Mark McLoughlin mar
On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote:
On 24 nov. 2009, at 11:28, Mark McLoughlin wrote:
On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
the kernel doesn't support IFF_VNET_HDR.
Signed-off
Hi Gerd,
Thanks for looking, you're absolutely right that this approach just
isn't right with e.g. -device
On Mon, 2009-11-16 at 10:28 +0100, Gerd Hoffmann wrote:
On 11/12/09 21:29, Mark McLoughlin wrote:
No doubt this is the worst idea ever, but the requirement is simple -
some way
No doubt this is the worst idea ever, but the requirement is simple -
some way to iterate all NICs in the system.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/qdev.c | 20
hw/qdev.h |3 +++
2 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/hw
Probably the second worst idea in the world, ever.
While iterating over all NICs in the system, we need to be
able to query their 'net-client' and 'macaddr' properties.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/qdev-properties.c | 31 ---
hw/qdev.h
Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/dp8393x.c | 10 +-
hw/etraxfs_eth.c | 10 +-
hw/mcf_fec.c | 10 +-
hw/mipsnet.c | 10
Hi,
The recent fix to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the
assignment to NICInfo::vc that used to live in qdev_get_vlan_client().
Now that NICs are qdev-ified, we should just iterate over the
qdev tree
Now that we have a sane way of iterating over NICs.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
savevm.c | 43 ++-
1 files changed, 26 insertions(+), 17 deletions(-)
diff --git a/savevm.c b/savevm.c
index 039740c..3736588 100644
--- a/savevm.c
advantage is that we can easily get the client associated with
a qdev.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/qdev-properties.c | 25 +
hw/qdev.h|5 +
net.h|8 +---
3 files changed, 35 insertions(+), 3 deletions
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/dp8393x.c| 10 +-
hw/e1000.c | 10 +-
hw/eepro100.c | 10 +-
hw/etraxfs_eth.c| 11 +--
hw/mcf_fec.c| 10 +-
hw/mipsnet.c| 15 ++-
hw
No valid users left except the announce_self() code which currently
crashes when used with -netdev.
Note the assertion in the xen code. Need to figure out how to support
the -netdev arg with xen.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/integratorcp.c|3 +-
hw/mcf5208.c
On Thu, 2009-11-12 at 20:29 +, Mark McLoughlin wrote:
...
+printf(qemu_announce_self_iter() mac = %p\n, mac);
+
+len = announce_self_create(buf, mac);
+
+printf(sending packet from %s\n, client-name);
Ooops, some debugging leftovers. removed in my tree.
Cheers,
Mark.
On Thu, 2009-11-12 at 03:31 +, Armin Garcia wrote:
I have the next problem I configure the tun/tap and all great any error,
I have an IP from my dhcp, I can see my virtual machine (winxp) from my
other computers, but In my virtual machine I cant connect to internet,
I mean, when I
On Tue, 2009-11-10 at 15:44 +, Paul Brook wrote:
On Thursday 08 October 2009, Mark McLoughlin wrote:
Hi,
Here's a series of patches which gets the ball rolling on adding
a -netdev option.
...
The idea is to de-emphasise the vlan support, and instead make
a nic
On Tue, 2009-11-10 at 18:03 +0100, Juan Quintela wrote:
Mark McLoughlin mar...@redhat.com wrote:
On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote:
commit b04c4134d6de28c249277de19e523bfbe4aebbd6
broke incoming migration. After talking with Gleb, code was intended
to be the way
Hey,
Just a heads up - on 32 bit hosts where qemu was using preadv and
pwritev, we were seeing data corruption due to file offset being
truncated:
https://bugzilla.redhat.com/533063
https://bugzilla.redhat.com/526549
The glibc headers fix is posted here:
On Fri, 2009-10-30 at 16:15 -0500, Dustin Kirkland wrote:
On Thu, Oct 29, 2009 at 10:34 AM, Dustin Kirkland
kirkl...@canonical.com wrote:
whitelist host virtio networking features
This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb,
fixing crashes when guests with 2.6.25
On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
Okay, let's try re-enabling the drain-entire-queue behaviour, with a
difference - before each subsequent packet, use qemu_can_send_packet()
to check that we can send it. This is similar to how we check before
Hi Dustin,
On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote:
I believe that we have identified a regression in qemu-kvm-0.11.0.
Regression versus which previous version of qemu-kvm?
The kvm process crashes for older guests with virtio networking, when
the guest's incoming network
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote:
Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009:
Assuming this is something like the virtio-net in 2.6.26, there was no
receivable buffers support so (as Scott points out) it must be that
we've read a packet from
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1)
being called and get an mtu of 1500 on virbr0 using his birdge.sh script.
virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1)
being called and get an mtu of 1500 on virbr0 using his
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote:
On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote:
In the mean time, Hardy's kernel is in git here:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary
I'll save you a few clicks...
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote:
On Thu, 2009-10-29 at 14:48 +, Mark McLoughlin wrote:
Ah, it all makes sense now.
I was getting confused between HOST_* and GUEST_*
this should have been:
features |= (1 VIRTIO_NET_F_MAC);
features |= (1
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote:
On Thu, 2009-10-29 at 15:01 +, Mark McLoughlin wrote:
Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct
Brilliant!
Works like a champ. I'll send a patch in a subsequent email. Would you
add a signed-off
On Wed, 2009-10-28 at 11:36 +0800, Scott Tsai wrote:
Scott, Sven, if you could test the tap-drain-queue branch from
my tree, that would be great:
http://repo.or.cz/w/qemu/markmc.git
Thanks,
Mark.
Mark,
I've tested http://repo.or.cz/w/qemu/markmc.git and it indeed works
that virtio_net_get_config() uses.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/virtio-net.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 93294af..4b09a93 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -837,6
Hi Anthony,
Thanks for merging this stuff ...
In the process of merging it all into qemu-kvm, I noticed a couple of
problems:
1) bb6e63644 lacked the change to add the type code to
qemu_new_vlan_client() so that and the subsequent 14 commits are
unbuildable
2)
Now that we disable any receiver whose queue is full, we do not require
senders to handle a zero return by supplying a sent callback.
This is a second step towards allowing can_receive() handlers to return
true even if no buffer space is available.
Signed-off-by: Mark McLoughlin mar
-by: Scott Tsai scottt...@gmail.com
Tested-by: Sven Rudolph sven_rudo...@drewag.de
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap.c | 33 +++--
1 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index 60354e4..f32226b
Hey,
Scott points out that the current behaviour of draining the
entire queue in tap_send() doesn't work with non-virtio NICs because
we drop a packet when the NIC queue fills up.
This series of patches first disables this behaviour, fixes
various aspects of the queueing logic
if no buffer space is available.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 49 ++---
net.h |1 +
2 files changed, 39 insertions(+), 11 deletions(-)
diff --git a/net.c b/net.c
index 661bbc1..9dea615 100644
--- a/net.c
+++ b/net.c
it.
This patch should be a performance improvement since we no longer have
to go through the mainloop for each packet.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net/tap.c | 33 ++---
1 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/net/tap.c b
just allow
receive() to return zero when this condition occurs and have the caller
handle queueing the packet.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/virtio-net.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio
-by: Scott Tsai scottt...@gmail.com
Tested-by: Sven Rudolph sven_rudo...@drewag.de
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/net.c b/net.c
index 3d3829d..7466961 100644
--- a/net.c
+++ b/net.c
On Thu, 2009-10-22 at 15:34 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
Hey,
We've been meaning to split net.c up for quite a while now,
so here goes with a first cut at.
There shouldn't be anything too controversial here, apart
from CONFIG_LINUX maybe
On Thu, 2009-10-22 at 20:53 +0200, Juan Quintela wrote:
Mark McLoughlin mar...@redhat.com wrote:
Hey,
We've been meaning to split net.c up for quite a while now,
so here goes with a first cut at.
If you have to respin this series, please use
git mv foo.c net/foo.c
I did
Hi,
Any ideas on this segfault a Fedora 12 user (Gene, cc-ed) is seeing?
Thread 1 (Thread 2849):
#0 0x7f25fcd10f70 in memset () from /lib64/libc.so.6
No symbol table info available.
#1 0x004babc6 in audio_capture_mix_and_clear (samples=-1099358712,
rpos=value optimized out,
On Fri, 2009-10-23 at 17:41 +0400, malc wrote:
On Fri, 23 Oct 2009, malc wrote:
On Fri, 23 Oct 2009, Mark McLoughlin wrote:
Hi,
Any ideas on this segfault a Fedora 12 user (Gene, cc-ed) is seeing?
[..snip..]
Summary: No idea.
FWIW, there's no information
On Fri, 2009-10-23 at 20:25 +0400, Michael Tokarev wrote:
I've two questions:
o what's the intended usage of all-vlan-equal case, when kvm (or qemu)
reflects packets from one interface to another? It's what bridge
in linux is for, I think.
I don't think it's necessarily an intended
On Fri, 2009-10-23 at 08:44 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
On Thu, 2009-10-22 at 15:34 -0500, Anthony Liguori wrote:
This series doesn't build for me. I get dependency errors even after a
full rebuild. I'm building from a separate directory fwiw
[v2: handle building in a separate dir]
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
Makefile | 10 +++---
configure |2 +-
net.h |2 +-
net-queue.c = net/queue.c |2 +-
net-queue.h = net/queue.h |0
5 files
Looks like these are just artifacts of vl.c being split up.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
qemu-char.c |6 --
savevm.c|6 --
vl.c|6 --
3 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index
This is so as to allow APIs which operate on specific client types
without having to add a function table entry which is only implemented
by a single client type.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
hw/dp8393x.c |3 ++-
hw/etraxfs_eth.c |3 ++-
hw/mcf_fec.c
tap_receive_raw() always prepends a vnet header if IFF_VNET_HDR is
enabled.
tap_receive() only prepends when the a header is required but the NIC
doesn't supply one.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 23 +++
1 files changed, 19 insertions(+), 4
Making features dependent on the availability of newer versions if_tun.h
is going to get seriously clumsy, so let's just import the definitions
we need. It's only a small handful.
If and when we're comfortable depending on 2.6.30 headers, we can remove
this again.
Signed-off-by: Mark McLoughlin
In the case where a NIC and backend agree on a packet header format,
this API allows injecting packets which lack the agreed upon header.
We need this for sending our gratuitous ARP.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net-queue.h |1 +
net.c | 37
These lamely named functions allow virtio-net to query whether
IFF_VNET_HDR is enabled on a tap interface and inform the tap code
that virtio-net will supply packets with a vnet header.
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 39
with such things ending up in writeconfig output?
Signed-off-by: Mark McLoughlin mar...@redhat.com
---
net.c | 97 +++--
1 files changed, 52 insertions(+), 45 deletions(-)
diff --git a/net.c b/net.c
index 356a280..fccabdb 100644
--- a/net.c
1 - 100 of 142 matches
Mail list logo
