Re: [PATCH v3 25/30] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

2021-04-30 Thread Matheus K. Ferst
_addi_tl(cpu_gpr[a->rt], cpu_gpr[a->ra], si); +} else { + tcg_gen_movi_tl(cpu_gpr[a->rt], si); +} +return true; +} I'd also keep this as in the last version, where trans_ADDI is called. Thanks, Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software Júnior Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Re: [PATCH v3 17/30] target/ppc: Remove DisasContext.exception

2021-04-30 Thread Matheus K. Ferst
ave set NORETURN. */ -g_assert_not_reached(); -} -} } static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) You removed the uses, but left the field. Thanks, Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software Júnior Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Re: [PATCH v2 09/15] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

2021-04-28 Thread Matheus K. Ferst
forwarded their arguments to a third method that does the real work. Is this kind of approach desirable? We initially achieved this by using const_elt to set r=0 for addi, which is not particularly nice, but we can look for other solutions. Thanks, Matheus K. Ferst Instituto de Pesquisas ELDOR

Re: [PATCH v2 11/15] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-04-28 Thread Matheus K. Ferst
sad part of this kind of approach is that it would leave us with, eg. arg_LBZX and arg_LBZUX instead of a single arg_X, making it harder to put multiple insns under the same implementation. Thanks, Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software

Re: [PATCH v2 1/2] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-23 Thread Matheus K. Ferst
iner: +powerpc-test-debian-cross-container: <<: *container_job_definition stage: containers-layer2 needs: ['amd64-debian10-container'] Should this be debian11? Yes, I'll send a new version. Thanks, Matheus K. Ferst Instituto de Pesquisas ELDORADO <http:

Re: [PATCH 2/2] tests/tcg/ppc64le: tests for brh/brw/brd

2021-04-20 Thread Matheus K. Ferst
Use "+r" for in/out argument. r~ Fixed, thanks! Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software Júnior Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Re: [PATCH 1/2] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-20 Thread Matheus K. Ferst
uild}.docker debian-ppc64{el-cross,le-crossbuild}.docker debian-s390x-cross{,build}.docker -- Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software Júnior Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Re: [PATCH 2/2] tests/tcg/ppc64le: tests for brh/brw/brd

2021-04-20 Thread Matheus K. Ferst
On 20/04/2021 11:58, Richard Henderson wrote: On 4/19/21 6:33 PM, matheus.fe...@eldorado.org.br wrote: +#include +#include + +int main(void) +{ Oh, also, there's nothing in here that requires stdio.h. r~ Forgot to remove. Will be fixed in the next version. Thanks, Matheus K.

Re: [PATCH 1/2] tests/docker: gcc-10 based images for ppc64{,le} tests

2021-04-20 Thread Matheus K. Ferst
ce. We could do something like: > ppc64*-|ppc64le-*) > container_hosts=x86_64 > container_image=debian-powerpc-test-cross > container_cross_cc=${target%%-*}-linux-gnu-gcc-10 > container_cross_cc=powerpc${container_cross_cc#ppc} But I think it's kind of ugly to repeat container_cross_cc line. If we do that, we can bring ppc-* too, but another line would be needed to handle ppc64abi32-*... -- Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software Júnior Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Re: [RFC PATCH 0/3] tests/tcg/ppc64le: paddi tests

2021-04-16 Thread Matheus K. Ferst
g/ppc64{,le}/Makefile.target. Would it be Mr. Gibson? Uh... sorta? I also don't know much about what's going on here, but I'm probably maintainer by default. So, should I update MAINTAINERS in this series? -- Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldor

<    1   2