Hi,
Patch 1 is the fix, patch 2 adds a test.
I think we must get this into 5.1, rc2 or not.
Max Reitz (2):
block: Fix bdrv_aligned_p*v() for qiov_offset != 0
iotests/028: Add test for cross-base-EOF reads
block/io.c | 10 ++
tests/qemu-iotests/028 | 19
Signed-off-by: Max Reitz
---
tests/qemu-iotests/028 | 19 +++
tests/qemu-iotests/028.out | 11 +++
2 files changed, 30 insertions(+)
diff --git a/tests/qemu-iotests/028 b/tests/qemu-iotests/028
index 5d043cef92..6dd3ae09a3 100755
--- a/tests/qemu-iotests/028
+++ b
On 28.07.20 13:35, Paolo Bonzini wrote:
> On 28/07/20 13:33, Vladimir Sementsov-Ogievskiy wrote:
>>> Thanks for both your investigation. Does the attached patch help?
>>
>> For me, the reproducer is fixed with your patch.
>
> Is it possible to make a quick testcase using qemu-io?
This seems to w
93d25ceea3c0dcbe6d6b425309317fab6b22e (refs/bisect/bad)
> Author: Vladimir Sementsov-Ogievskiy
> Date: Tue Jun 4 19:15:13 2019 +0300
>
> block/qcow2: implement .bdrv_co_preadv_part
>
> Indeed, I am currently able to reliable reproduce the issue with this
> commit a
e already do for the arm- and
tricore-softmmu targets.
Signed-off-by: Thomas Huth
Message-Id: <20200722161908.25383-1-th...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/check | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-
test fails. Just force compat=1.1 for that
particular case to enforce the cluster to get allocated.
Fixes: 61b3043965fe3552ee2684a97e7cc809ca7a71b3
Signed-off-by: Max Reitz
Message-Id: <20200727135237.1096841-1-mre...@redhat.com>
Reviewed-by: Eric Blake
---
tests/qemu-iotests/197 | 4 +
for qcow2 -o compat=0.10
--------
Max Reitz (2):
block/amend: Check whether the node exists
iotests/197: Fix for compat=0.10
Thomas Huth (1):
iotests: Select a default machine for the rx and avr targets
block/amend.c
: ced914d0ab9fb2c900f873f6349a0b8eecd1fdbe
Signed-off-by: Max Reitz
Message-Id: <20200710095037.10885-1-mre...@redhat.com>
Reviewed-by: Maxim Levitsky
---
block/amend.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/amend.c b/block/amend.c
index f4612dcf08..392df9ef83 100644
OK, that’s interesting. To be honest, I have no idea. I’ll keep this in
mind and I’ll try to play around with it, but I can’t promise anything.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1888467
T
test fails. Just force compat=1.1 for that
particular case to enforce the cluster to get allocated.
Fixes: 61b3043965fe3552ee2684a97e7cc809ca7a71b3
Signed-off-by: Max Reitz
---
tests/qemu-iotests/197 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/197 b
On 26.07.20 17:25, Nir Soffer wrote:
> Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case
> is writing compressed disk content to OVA archive.
>
> Signed-off-by: Nir Soffer
> ---
> tests/qemu-iotests/302 | 83 ++
> tests/qemu-iotests/3
On 26.07.20 17:25, Nir Soffer wrote:
> When converting to qcow2 compressed format, the last step is a special
> zero length compressed write, ending in call to bdrv_co_truncate(). This
> call always fail for the nbd driver since it does not implement
> bdrv_co_truncate().
>
> For block devices, wh
On 23.07.20 17:51, Andrey Shinkevich wrote:
> On 25.06.2020 18:22, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> block/backup-top.c | 2 +-
>> block/backup.c | 9 +
>> blockdev.c | 19 +++
>> 3 files
On 22.07.20 20:31, Andrey Shinkevich wrote:
> On 25.06.2020 18:22, Max Reitz wrote:
>> This includes some permission limiting (for example, we only need to
>> take the RESIZE permission for active commits where the base is smaller
>> than the top).
>>
>&g
On 20.07.20 18:08, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> This allows us to differentiate between filters and nodes with COW
>> backing files: Filters cannot be used as overlays at all (for this
>> function).
>>
>> Signed-off-by: Max
On 20.07.20 17:10, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> It is trivial, so we might as well do it.
>>
>> Signed-off-by: Max Reitz
>> ---
>> block/null.c | 7 +++
>> tests/qemu-iotests/153.out | 2
On 22.07.20 18:19, Thomas Huth wrote:
> If you are building only with either the new rx-softmmu or avr-softmmu
> target, "make check-block" fails a couple of tests since there is no
> default machine defined in these new targets. We have to select a machine
> in the "check" script for these, just l
On 10.07.20 11:50, Max Reitz wrote:
> We should check whether the user-specified node-name actually refers to
> a node. The simplest way to do that is to use bdrv_lookup_bs() instead
> of bdrv_find_node() (the former wraps the latter, and produces an error
> message if necessary).
&
On 23.07.20 19:56, Peter Maydell wrote:
> On Fri, 10 Jul 2020 at 10:51, Max Reitz wrote:
>>
>> We should check whether the user-specified node-name actually refers to
>> a node. The simplest way to do that is to use bdrv_lookup_bs() instead
>> of bdrv_find_node() (
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Add script to benchmark new backup architecture.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> scripts/simplebench/bench-backup.py | 132
> 1 file changed, 132 insertions(+)
> create mode 100755 scri
b.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
Looks a bit unrelated. Apart from that:
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
ns(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> This brings async request handling and block-status driven chunk sizes
> to backup out of the box, which improves backup performance.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-copy.h | 9 +--
> block/bac
+++---
> 2 files changed, 154 insertions(+), 153 deletions(-)
It’s a shame that we don’t run this test with the default configuration
then, but I suppose that’s how it is. For now, at least.
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> The further change of moving backup to be a on block-copy call will
-on?
> make copying chunk-size and cluster-size a separate things. So, even
s/a/two/
> with 64k cluster sized qcow2 image, default chunk would be 1M.
> Test 219 depends o
;: 65536 } }" \
> + 'speed': 65536,
> + 'x-max-chunk': 65536 } }" \
Out of curiosity, would it also suffice to disable copy offloading?
But anyway:
Reviewed-by: Max Reitz
> "return"
>
> # If we d
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> After introducing parallel async copy requests instead of plain
> cluster-by-cluster copying loop, backup job may finish earlier than
> final assertion in do_test_stop. Let's require slow backup explicitly
> by specifying speed parameter.
Is
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> After introducing parallel async copy requests instead of plain
> cluster-by-cluster copying loop, we'll have to wait for paused status,
> as we need to wait for several parallel request. So, let's gently wait
> instead of just asserting that
On 22.07.20 14:22, Max Reitz wrote:
> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>> Add new parameters to configure future backup features. The patch
>> doesn't introduce aio backup requests (so we actually have only one
>> worker) neither requests larg
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Add new parameters to configure future backup features. The patch
> doesn't introduce aio backup requests (so we actually have only one
> worker) neither requests larger than one cluster. Still, formally we
> satisfy these maximums anyway, so
ff-by: Vladimir Sementsov-Ogievskiy
> ---
> job.c | 1 +
> 1 file changed, 1 insertion(+)
Sounds reasonable to me, although I’d prefer an opinion from John.
So, a middle-weak:
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
.h | 2 ++
> blockjob.c | 6 ++
> 2 files changed, 8 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Add function to cancel running async block-copy call. It will be used
> in backup.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-copy.h | 7 +++
> block/block-copy.c | 22 +++---
>
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> We are going to directly use one async block-copy operation for backup
> job, so we need rate limitator.
%s/limitator/limiter/g, I think.
> We want to maintain current backup behavior: only background copying is
> limited and copy-before-wr
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> They will be used for backup.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-copy.h | 5 +
> block/block-copy.c | 10 --
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git
Hi,
What exactly do you mean by “file size”? The file length (as reported
by ls -l) or the bytes used on disk (reported as “disk size” by qemu-
img, or by du -B1)?
You say that qcow2 and vmdk are normal – do you mean as input or as
output formats?
One thing that comes to my mind is that from ht
Signed-off-by: Max Reitz
---
tests/qemu-iotests/300 | 515 +
tests/qemu-iotests/300.out | 5 +
tests/qemu-iotests/group | 1 +
3 files changed, 521 insertions(+)
create mode 100755 tests/qemu-iotests/300
create mode 100644 tests/qemu-iotests/300
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 3590ed78a0..20645a6e7d 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -28,6
Test node/bitmap aliases during migration'
Max Reitz (3):
migration: Add block-bitmap-mapping parameter
iotests.py: Add wait_for_runstate()
iotests: Test node/bitmap aliases during migration
qapi/migration.json| 104 ++-
migration/migration.h | 3 +
migrat
(on the source, the destination, or even both with
arbitrary aliases in the migration stream).
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Max Reitz
---
qapi/migration.json| 104 -
migration/migration.h | 3 +
migration/block-dirty-bitmap.c | 373
On 21.07.20 15:55, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/122 | 30 ++
> tests/qemu-iotests/122.out | 17 +
> 2 files changed, 47 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description:
key management")
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1857490
Signed-off-by: Maxim Levitsky
Message-Id: <20200719122059.59843-2-mlevi...@redhat.com>
Signed-off-by: Max Reitz
---
block/crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/crypt
From: Maxim Levitsky
Test that we can't write-share raw luks images by default,
but we still can with share-rw=on
Signed-off-by: Maxim Levitsky
Message-Id: <20200719122059.59843-3-mlevi...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/2
glink: https://bugs.launchpad.net/qemu/+bug/1878255
Originally-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
Message-Id: <20200720100141.129739-1-stefa...@redhat.com>
Signed-off-by: Max Reitz
---
block/block-backend.c | 8
1 file changed, 8 insertions(+)
diff --git a/block
The following changes since commit af3d69058e09bede9900f266a618ed11f76f49f3:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200720'
into staging (2020-07-20 15:58:07 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-202
On 21.07.20 13:20, Kevin Wolf wrote:
> Am 21.07.2020 um 12:19 hat Max Reitz geschrieben:
>> On 20.07.20 15:18, Kevin Wolf wrote:
>>> Signed-off-by: Kevin Wolf
>>> ---
>>> tests/qemu-iotests/122 | 34 ++
On 20.07.20 15:18, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/122 | 34 ++
> tests/qemu-iotests/122.out | 17 +
> 2 files changed, 51 insertions(+)
>
> diff --git a/tests/qemu-iotests/122 b/tests/qemu-iotests/122
>
e source image was empty.
>
> Reported-by: Nir Soffer
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2-cluster.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 20.07.20 12:01, Stefan Hajnoczi wrote:
> bdrv_aio_cancel() calls aio_poll() on the AioContext for the given I/O
> request until it has completed. ENOMEDIUM requests are special because
> there is no BlockDriverState when the drive has no medium!
>
> Define a .get_aio_context() function for BlkA
On 17.07.20 17:24, Vladimir Sementsov-Ogievskiy wrote:
> 17.07.2020 17:00, Max Reitz wrote:
>> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>>> We'll need async block-copy invocation to use in backup directly.
>>>
>>> Signed-off-by: Vladimir S
On 20.07.20 20:02, Vladimir Sementsov-Ogievskiy wrote:
> 16.07.2020 16:53, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> tests/qemu-iotests/300 | 511 +
>> tests/qemu-iotests/300.out | 5 +
>> tests/qemu-iot
On 20.07.20 18:46, Vladimir Sementsov-Ogievskiy wrote:
> 16.07.2020 16:53, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> tests/qemu-iotests/iotests.py | 4
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/iotest
On 20.07.20 18:31, Vladimir Sementsov-Ogievskiy wrote:
> 16.07.2020 16:53, Max Reitz wrote:
>> This migration parameter allows mapping block node names and bitmap
>> names to aliases for the purpose of block dirty bitmap migration.
>>
>> This way, management tools can us
On 19.07.20 14:20, Maxim Levitsky wrote:
> A rebase gone wrong, and I ended up allowing a luks image
> to be opened at the same time by two VMs without any warnings/overrides.
>
> Fix that and also add an iotest to prevent this from happening.
>
> Best regards,
> Maxim Levisky
>
> Maxim Le
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> We'll need async block-copy invocation to use in backup directly.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-copy.h | 13 +
> block/block-copy.c | 40
t; +ret = block_copy_dirty_clusters(call_state);
It’s possible that much of this code will change in a future patch of
this series, but as it is, it might be nice to make
block_copy_dirty_clusters’s argument a const pointer so it’s clear that
the call to block_copy_wait_one() below will use the
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Add parameter to enable/disable copy_range. Keep current default for
> now (enabled).
Why x-, though? I can’t think of a reason why we would have to remove this.
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/block-core.json
ts/qemu-iotests/129 | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 17.07.20 12:54, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> block/file-posix.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
> Signed-off-by: Kevin Wolf
> ---
> block/file-posix.c | 33 +----
> 1 file changed, 21 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
nged, 33 insertions(+), 33 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 17.07.20 13:32, Kevin Wolf wrote:
> Am 17.07.2020 um 13:02 hat Max Reitz geschrieben:
>> On 16.07.20 16:26, Kevin Wolf wrote:
>>> Unaligned requests will automatically be aligned to bl.request_alignment
>>> and we can't extend write requests to access space
s just look at the file system magic and disable
> s->needs_alignment for NFS. This way, O_DIRECT can still be used on NFS
> for images that are not aligned to 4k.
>
> Signed-off-by: Kevin Wolf
> Reviewed-by: Eric Blake
> ---
> block/file-posix.c | 26 +++++
t can have backing files (i.e., qcow2 in practice) because
WRITE_UNCHANGED is only used by COR and block jobs doing something with
a backing chain, so it shouldn’t matter in practice, but, well.
So, either way:
Reviewed-by: Max Reitz
> +!(cumulative_perms & B
On 15.07.20 14:52, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> bdrv_refresh_filename() and the kind of related bdrv_dirname() should
>> look to the primary child when they wish to copy the underlying file's
>> filename.
>>
>> Signed-
On 14.07.20 20:37, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> Instead of looking at just bs->file and bs->backing, we should look at
>> all children that could end up receiving forwarded requests.
>>
>> Signed-off-by: Max R
On 14.07.20 16:52, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> Before HEAD^, we needed this because bdrv_co_flush() by itself would
>> only flush bs->file. With HEAD^, bdrv_co_flush() will flush all
>> children on which a WRITE or WRITE_UNCHANGED p
On 10.07.20 21:42, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> Reopening a node's backing child needs a bit of special handling because
>> the "backing" child has different defaults than all other children
>> (among other things). Addi
On 10.07.20 19:41, Andrey Shinkevich wrote:
> On 10.07.2020 18:24, Max Reitz wrote:
>> On 09.07.20 16:52, Andrey Shinkevich wrote:
>>> On 25.06.2020 18:21, Max Reitz wrote:
>>>> Because of the (not so recent anymore) changes that make the stream job
>>>>
On 13.07.20 12:18, Vladimir Sementsov-Ogievskiy wrote:
> 25.06.2020 18:21, Max Reitz wrote:
>> Add some helper functions for skipping filters in a chain of block
>> nodes.
>>
>> Signed-off-by: Max Reitz
>> ---
>> include/block/block_int.h | 3
On 13.07.20 11:06, Vladimir Sementsov-Ogievskiy wrote:
> 25.06.2020 18:21, Max Reitz wrote:
>> There are BDS children that the general block layer code can access,
>> namely bs->file and bs->backing. Since the introduction of filters and
>> external data files, their
> Reported-by: Peter Maydell
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/030 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
Signed-off-by: Max Reitz
---
tests/qemu-iotests/300 | 511 +
tests/qemu-iotests/300.out | 5 +
tests/qemu-iotests/group | 1 +
3 files changed, 517 insertions(+)
create mode 100755 tests/qemu-iotests/300
create mode 100644 tests/qemu-iotests/300
(on the source, the destination, or even both with
arbitrary aliases in the migration stream).
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Max Reitz
---
Vladimir noted in v1 that it would be better to ignore bitmaps whose
names aren't mapped, or that are on nodes whose names a
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 3590ed78a0..fb240a334c 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -803,6
] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/3:[0117] [FC] 'migration: Add block-bitmap-mapping parameter'
002/3:[] [--] 'iotests.py: Add wait_for_runstate()'
003/3:[0202] [FC] 'iotests: Test node/bitmap
On 15.07.20 13:51, Alberto Garcia wrote:
> On Tue, Jul 14, 2020 at 02:56:57PM +0200, Max Reitz wrote:
>> Thanks, fixed up patch 21 (by initializing expected_type to just
>> anything, I chose QCOW2_SUBCLUSTER_NORMAL, which I preferred over
>> just using 0), resolved some iotes
On 14.07.20 13:08, Kevin Wolf wrote:
> Am 14.07.2020 um 11:56 hat Max Reitz geschrieben:
>> On 13.07.20 16:29, Kevin Wolf wrote:
>>> Am 13.07.2020 um 13:19 hat Max Reitz geschrieben:
>>>> On 10.07.20 16:21, Kevin Wolf wrote:
>>>>> Unalig
On 10.07.20 18:12, Alberto Garcia wrote:
> Hi,
>
> here's the new version of the patches to add subcluster allocation
> support to qcow2.
>
> Please refer to the cover letter of the first version for a full
> description of the patches:
>
>https://lists.gnu.org/archive/html/qemu-block/2019-1
d-by: Eric Blake
> Reviewed-by: Max Reitz
> ---
> qapi/block-core.json | 7 +++
> block/qcow2.h| 8 ++-
> include/block/block_int.h| 1 +
> block/qcow2.c| 66 ++--
> tests/qemu-iotests/031.
On 13.07.20 16:29, Kevin Wolf wrote:
> Am 13.07.2020 um 13:19 hat Max Reitz geschrieben:
>> On 10.07.20 16:21, Kevin Wolf wrote:
>>> Unaligned requests will automatically be aligned to bl.request_alignment
>>> and we don't want to extend requests to access space bey
On 13.07.20 13:19, Max Reitz wrote:
> On 10.07.20 16:21, Kevin Wolf wrote:
>> Unaligned requests will automatically be aligned to bl.request_alignment
>> and we don't want to extend requests to access space beyond the end of
>> the image, so it's required that the im
On 10.07.20 16:21, Kevin Wolf wrote:
> Unaligned requests will automatically be aligned to bl.request_alignment
> and we don't want to extend requests to access space beyond the end of
> the image, so it's required that the image size is aligned.
>
> With write requests, this could cause assertion
On 17.06.20 20:27,
Sorry :/
Connor Kuehl wrote:
> Providing an empty string for the backing file parameter like so:
>
> qemu-img create -f qcow2 -b '' /tmp/foo
>
> allows the flow of control to reach and subsequently fail an assert
> statement because passing an empty string to
>
>
On 06.07.20 22:39, Eric Blake wrote:
> During 'qemu-img create ... 2>&1', if --quiet is not in force, we can
> end up with buffered I/O in stdout that was produced before failure,
> but which appears in output after failure. This is confusing; the fix
> is to flush stdout prior to attempting anyth
On 10.07.20 18:12, Max Reitz wrote:
> On 07.07.20 18:17, Kevin Wolf wrote:
>> Am 07.07.2020 um 16:23 hat Kevin Wolf geschrieben:
>>> Espeically when O_DIRECT is used with image files so that the page cache
>>> indirection can't cause a merge of allocating request
On 11.07.20 10:57, Alex Bennée wrote:
>
> Max Reitz writes:
>
>> Otherwise the result is basically unpredictable.
>>
>> (Note that the precise environment variable to control sorting order is
>> LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
On 10.07.20 19:18, John Snow wrote:
>
>
> On 7/10/20 12:32 PM, Max Reitz wrote:
>> Hi,
>>
>> I’m sorry.
>>
>> John, could I ask you to test whether this series fixes the problems
>> you’re seeing?
>>
>
> This is based on kwolf/block,
Hi,
I’m sorry.
John, could I ask you to test whether this series fixes the problems
you’re seeing?
Max Reitz (2):
iotests: Drop readarray from _do_filter_img_create
iotests: Set LC_ALL=C for sort
tests/qemu-iotests/common.filter | 12 ++--
1 file changed, 6 insertions(+), 6
: Max Reitz
---
tests/qemu-iotests/common.filter | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index 345c3ca03e..4fd5c29b2a 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
Some systems where we run tests on do not have a 4.x bash, so they do
not have readarray. While it looked a bit nicer than messing with
`head` and `tail`, we do not really need it, so we might as well not use
it.
Reported-by: Claudio Fontana
Signed-off-by: Max Reitz
---
tests/qemu-iotests
On 07.07.20 18:17, Kevin Wolf wrote:
> Am 07.07.2020 um 16:23 hat Kevin Wolf geschrieben:
>> Espeically when O_DIRECT is used with image files so that the page cache
>> indirection can't cause a merge of allocating requests, the file will
>> fragment on the file system layer, with a potentially ver
On 10.07.20 17:42, Peter Maydell wrote:
> On Fri, 10 Jul 2020 at 16:31, Max Reitz wrote:
>>
>> On 10.07.20 17:18, Peter Maydell wrote:
>>> readarray only arrived sometime in bash 4, and the OSX system
>>> bash is 3.2.57, so it won't have that builtin.
>
On 10.07.20 17:18, Peter Maydell wrote:
> On Fri, 10 Jul 2020 at 16:13, Max Reitz wrote:
>>
>> On 10.07.20 16:44, Claudio Fontana wrote:
>>> Speaking of MacOS and CI, commit 57ee95ed4ee7b4c039ec5f0705c45734c56706bc
>>>
>>> Author: Max Reitz
On 09.07.20 17:13, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> Because of the (not so recent anymore) changes that make the stream job
>> independent of the base node and instead track the node above it, we
>> have to split that "bottom" node
On 09.07.20 16:52, Andrey Shinkevich wrote:
> On 25.06.2020 18:21, Max Reitz wrote:
>> Because of the (not so recent anymore) changes that make the stream job
>> independent of the base node and instead track the node above it, we
>> have to split that "bottom" node
I see. Yeah, configure by default doesn't enable -Werror for OSX.
>>> My build tree has
>>> '--extra-cflags=-fdiagnostics-color=never -Werror
>>> -Wno-error=deprecated-declarations'
>>
>> TIL this is different on OSX...
>>
>>>
&g
On 09.07.20 17:09, Peter Maydell wrote:
> On Mon, 6 Jul 2020 at 11:05, Max Reitz wrote:
>>
>> From: Maxim Levitsky
>>
>> blockdev-amend will be used similiar to blockdev-create
>> to allow on the fly changes of the structure of the format based block
>>
: ced914d0ab9fb2c900f873f6349a0b8eecd1fdbe
Signed-off-by: Max Reitz
---
block/amend.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/amend.c b/block/amend.c
index f4612dcf08..392df9ef83 100644
--- a/block/amend.c
+++ b/block/amend.c
@@ -69,8 +69,12 @@ void qmp_x_blockdev_amend(const
d-by: Eric Blake
> Reviewed-by: Max Reitz
> ---
After running basically all test combinations I usually run, I noticed
that 191 should also be modified to drop the extended_l2 option from the
qemu-img info output (down under “checking image base” and “checking
image layer”, where there are
1301 - 1400 of 13164 matches
Mail list logo
