On 10.11.20 19:57, Dr. David Alan Gilbert wrote:
* Max Reitz (mre...@redhat.com) wrote:
Contrary to what the check (and warning) in lo_init() claims, we can
announce submounts just fine even without statx() -- the check is based
on comparing both the mount ID and st_dev of parent and child
The following changes since commit 2a190a7256a3e0563b29ffd67e0164097b4a6dac:
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/renesas-fixes-20201109' into staging (2020-11-09
11:20:25 +)
are available in the Git repository at:
https://github.com/XanClic/qemu.git
rcia
Signed-off-by: Max Reitz
---
block.c | 54 --
1 file changed, 24 insertions(+), 30 deletions(-)
diff --git a/block.c b/block.c
index 9a945a058d..f1cedac362 100644
--- a/block.c
+++ b/block.c
@@ -4910,9 +4910,11 @@ int bdrv_drop_
rent kinds of "should not". Let's do it later.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20201106124241.16950-3-vsement...@virtuozzo.com>
Reviewed-by: Alberto Garcia
Signed-off-by: Max Reitz
---
block.c | 25 ++---
1 file changed, 22 insertions(+),
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20201106124241.16950-2-vsement...@virtuozzo.com>
Reviewed-by: Alberto Garcia
Signed-off-by: Max Reitz
---
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.c
index 2fd9
the original error. While we're at it, we can avoid the
confusing ?: by spelling the logic more directly.
Fixes: 4a9c9ea0d3
Reported-by: Guoyi Tu
Signed-off-by: Eric Blake
Message-Id: <20201105155122.60943-1-ebl...@redhat.com>
Reviewed-by: Alberto Garcia
Signed-off-by: Max Reitz
---
block
st_blocks in struct _stat64 yet, we disable the
usage of it
on msys2/mingw, and create a typedef long long blkcnt_t; for further
implementation
Signed-off-by: Yonggang Luo
Message-Id: <20201105123116.674-2-luoyongg...@gmail.com>
Signed-off-by: Max Reitz
---
block/nfs.c | 13 -
From: shiliyang
There have some code style problems be found when read the block driver code.
So I fixes some problems of this error, ERROR: "foo* bar" should be "foo *bar".
Signed-off-by: Liyang Shi
Reported-by: Euler Robot
---
block/qcow2.h| 6 +++---
block/blkdebug.c | 2 +-
On 09.11.20 18:38, Max Reitz wrote:
The following changes since commit 2a190a7256a3e0563b29ffd67e0164097b4a6dac:
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/renesas-fixes-20201109' into staging (2020-11-09
11:20:25 +)
are available in the Git repository at:
https
From: Klaus Jensen
Fix dereference after NULL check.
Reported-by: Coverity (CID 1436128)
Fixes: b20804946bce ("hw/block/nvme: update nsid when registered")
Signed-off-by: Klaus Jensen
Message-Id: <20201104102248.32168-2-...@irrelevant.dk>
Reviewed-by: Philippe Mathieu-Daudé
Si
-by: Christian Borntraeger
Reviewed-by: Paolo Bonzini
Message-Id: <20201104185025.434703-3-mlevi...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/240 | 219 +++--
tests/qemu-iotests/240.out | 76 +++--
2 files changed, 130 insertions(+
From: Yonggang Luo
Initially, libnfs has not been enabled, and now it's fixed, so enable it
on cirrus.
Signed-off-by: Yonggang Luo
Message-Id: <20201105123116.674-3-luoyongg...@gmail.com>
Signed-off-by: Max Reitz
---
.cirrus.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.cirr
The following changes since commit 2a190a7256a3e0563b29ffd67e0164097b4a6dac:
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/renesas-fixes-20201109' into staging (2020-11-09
11:20:25 +)
are available in the Git repository at:
https://github.com/XanClic/qemu.git
: <20201104185025.434703-2-mlevi...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 814804a4c6..bcd4fe5b6f 100644
--- a/tests/qemu-iotests/iotests.py
+++ b
From: AlexChen
The "qemu-common.h" include is not used, remove it.
Reported-by: Euler Robot
Signed-off-by: AlexChen
Message-Id: <5f8ffb94.3030...@huawei.com>
Signed-off-by: Max Reitz
---
block/dmg-lzfse.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/dmg-lzf
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20201007161323.4667-1-be...@igalia.com>
Signed-off-by: Max Reitz
---
block/qcow2.h | 19 +++
block/qcow2-cluster.c | 5 +++--
block/qcow2.c | 19 +++
3 files c
1436131)
Signed-off-by: Klaus Jensen
Message-Id: <20201104102248.32168-4-...@irrelevant.dk>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Max Reitz
---
hw/block/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 2bdc50eb6f..01b657b1c5 10
From: Greg Kurz
This function is really an internal helper for bdrv_close(). Update its
doc comment to make this clear and make the function private.
Signed-off-by: Greg Kurz
Message-Id: <160387245480.131299.13430357162209598411.stgit@bahia>
Reviewed-by: Stefan Hajnoczi
Signed-off-b
irrelevant.dk>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Max Reitz
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 080d782f1c..2bdc50eb6f 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -452,7 +452,7 @@
[Cc-ing Stefan]
On 09.11.20 16:05, Peter Maydell wrote:
In vu_blk_discard_write_zeroes(), we read a 32-bit sector count from
the descriptor and convert it to a 64-bit byte count. Coverity warns
that the left shift is done with 32-bit arithmetic so it might
overflow before the conversion to
On 06.11.20 13:42, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
These series supersedes "Fix nested permission update" and includes one
more fix (patch 01) and more improvements.
I think patch 01 is good to have in 5.2, 02 is probably OK for 5.2 and
the others are OK for next release. Still all
+++--
1 file changed, 17 insertions(+), 71 deletions(-)
Reviewed-by: Max Reitz
-by: Max Reitz
(because AFAIR *_set_perm is
used quite often).)
Reviewed-by: Max Reitz
On 30.10.20 04:35, shiliyang wrote:
There have some code style problems be found when read the block driver code.
So I fixes some problems of this error, ERROR: "foo* bar" should be "foo *bar".
Signed-off-by: Liyang Shi
Reported-by: Euler Robot
---
block/blkdebug.c | 2 +-
block/dmg.c
On 05.11.20 16:51, Eric Blake wrote:
Back in 2015, we attempted to fix error reporting for images that
claimed to have more than INT64_MAX/512 sectors, but due to the type
promotions caused by BDRV_SECTOR_SIZE being unsigned, this
inadvertently forces all negative ret values to be slammed into
On 05.11.20 13:31, Yonggang Luo wrote:
V3-V4
Use uint64_t instead of blkcnt_t
V2-V3
Revise the commit message of
* block: enable libnfs on msys2/mingw in cirrus.yml
V1-V2
Apply suggestion from Peter Lieven
Yonggang Luo (2):
block: Fixes nfs compiling error on msys2/mingw
block: enable
On 05.11.20 13:32, 罗勇刚(Yonggang Luo) wrote:
On Thu, Nov 5, 2020 at 7:43 PM Max Reitz <mailto:mre...@redhat.com>> wrote:
>
> On 13.10.20 02:15, Yonggang Luo wrote:
> > At the begging libnfs are not enabled because of compiling error,
> > now it's fixed so ena
the assignments, no?
(And, as you write, in the future potentially drop the parameters.)
Anyway:
Reviewed-by: Max Reitz
On 05.11.20 14:14, Eric Blake wrote:
On 11/5/20 2:31 AM, Max Reitz wrote:
On 05.11.20 06:40, Tuguoyi wrote:
As BDRV_SECTOR_SIZE is of type uint64_t, the expression will
automatically convert the @ret to uint64_t. When an error code
returned from bdrv_nb_sectors(), the promoted @ret
On 05.11.20 14:22, Max Reitz wrote:
On 31.10.20 13:35, Vladimir Sementsov-Ogievskiy wrote:
First, permission update loop tries to do iterations transactionally,
but the whole update is not transactional: nobody roll-back successful
loop iterations when some iteration fails
by: Vladimir Sementsov-Ogievskiy
---
block.c | 36 +++-
1 file changed, 15 insertions(+), 21 deletions(-)
And it’s also much simpler and clearer now.
Reviewed-by: Max Reitz
On 05.11.20 12:46, 罗勇刚(Yonggang Luo) wrote:
On Thu, Nov 5, 2020 at 7:44 PM Max Reitz <mailto:mre...@redhat.com>> wrote:
>
> On 05.11.20 12:32, 罗勇刚(Yonggang Luo) wrote:
> >
> >
> > On Thu, Nov 5, 2020 at 7:29 PM Max Reitz <mailto:mre...@redhat.
On 05.11.20 12:32, 罗勇刚(Yonggang Luo) wrote:
On Thu, Nov 5, 2020 at 7:29 PM Max Reitz <mailto:mre...@redhat.com>> wrote:
>
> On 13.10.20 02:15, Yonggang Luo wrote:
> > These compiling errors are fixed:
> > ../block/nfs.c:27:10: fatal error: poll.h: No such fi
On 13.10.20 02:15, Yonggang Luo wrote:
At the begging libnfs are not enabled because of compiling error,
now it's fixed so enable it
Signed-off-by: Yonggang Luo
---
.cirrus.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.cirrus.yml b/.cirrus.yml
index f42ccb956a..2c6bf45e6d 100644
On 13.10.20 02:15, Yonggang Luo wrote:
These compiling errors are fixed:
../block/nfs.c:27:10: fatal error: poll.h: No such file or directory
27 | #include
| ^~~~
compilation terminated.
../block/nfs.c:63:5: error: unknown type name 'blkcnt_t'
63 | blkcnt_t
On 04.11.20 19:50, Maxim Levitsky wrote:
While most of the patches in V1 of this series are already merged upstream,
the patch that fixes iotest 240 was broken on s390 and was not accepted.
This is an updated version of this patch, based on Paulo's suggestion,
that hopefully makes this iotest
On 05.11.20 06:40, Tuguoyi wrote:
As BDRV_SECTOR_SIZE is of type uint64_t, the expression will
automatically convert the @ret to uint64_t. When an error code
returned from bdrv_nb_sectors(), the promoted @ret will be a very
large number, as a result the -EFBIG will be returned which is not the
On 26.10.20 16:18, Vladimir Sementsov-Ogievskiy wrote:
> 23.07.2020 12:47, Max Reitz wrote:
>>> +static void coroutine_fn backup_set_speed(BlockJob *job, int64_t speed)
>>> +{
>>> + BackupBlockJob *s = container_of(job, BackupBlockJob, comm
On 22.10.20 23:10, Vladimir Sementsov-Ogievskiy wrote:
> 23.07.2020 11:03, Max Reitz wrote:
>> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>>> After introducing parallel async copy requests instead of plain
>>> cluster-by-cluster copying loop, backup
On 22.10.20 22:50, Vladimir Sementsov-Ogievskiy wrote:
> 22.07.2020 14:28, Max Reitz wrote:
>> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>>> Add function to cancel running async block-copy call. It will be used
>>> in backup.
>>>
>>>
kDeviceMapEntry hasn't bothered
> anyone enough to complain in almost four years. Get rid of it.
>
> Cc: Paolo Bonzini
> Cc: Eric Blake
> Reviewed-by: Eric Blake
> Signed-off-by: Markus Armbruster
> ---
> I found an old patch I neglected to merge.
>
&g
On 22.10.20 22:35, Vladimir Sementsov-Ogievskiy wrote:
> 22.07.2020 15:22, Max Reitz wrote:
>> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>>> Add new parameters to configure future backup features. The patch
>>> doesn't introduce aio backup requests (s
From: Markus Armbruster
BlockDeviceMapEntry has never been used. It was added in commit
facd6e2 "so that it is published through the introspection mechanism."
What exactly introspecting types that aren't used for anything could
accomplish isn't clear. What "introspection mechanism" to use is
BlockDeviceMapEntry
Max Reitz (1):
qapi/block-core: Improve MapEntry documentation
qapi/block-core.json | 47
1 file changed, 13 insertions(+), 34 deletions(-)
--
2.28.0
we can make
them even clearer.)
Signed-off-by: Max Reitz
---
qapi/block-core.json | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 1b8b4156b4..3f86675357 100644
--- a/qapi/block-core.json
+++ b/qapi/block
On 04.11.20 11:22, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Fix three issues reported by coverity (CIDs 1436128, 1436129 and
> 1436131).
>
> Klaus Jensen (3):
> hw/block/nvme: fix null ns in register namespace
> hw/block/nvme: fix uint16_t use of uint32_t sgls member
> hw/block/nvme:
On 04.11.20 12:04, Klaus Jensen wrote:
> On Nov 4 11:59, Max Reitz wrote:
>> On 04.11.20 11:22, Klaus Jensen wrote:
>>> From: Klaus Jensen
>>>
>>> Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the
>>> namespaces
)
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz
quot;hw/block/nvme: support multiple namespaces")
> Reported-by: Coverity (CID 1436131)
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks! :)
Reviewed-by: Max Reitz
k/nvme.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Max Reitz
On 27.10.20 11:49, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This adds support for multiple namespaces by introducing a new 'nvme-ns'
> device model. The nvme device creates a bus named from the device name
> ('id'). The nvme-ns devices then connect to this and registers
> themselves with the
On 27.10.20 11:49, Klaus Jensen wrote:
> From: Klaus Jensen
>
> For now, support the Data Block, Segment and Last Segment descriptor
> types.
>
> See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)").
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Keith Busch
> ---
>
On 27.10.20 11:49, Klaus Jensen wrote:
> From: Klaus Jensen
>
> If the user does not specify an nsid parameter on the nvme-ns device,
> nvme_register_namespace will find the first free namespace id and assign
> that.
>
> This fix makes sure the assigned id is saved.
>
> Signed-off-by: Klaus
() mount IDs, is utterly broken anyway.
Thus, drop said check in lo_init().
Reported-by: Miklos Szeredi
Signed-off-by: Max Reitz
---
tools/virtiofsd/passthrough_ll.c | 8
1 file changed, 8 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index
On 07.10.20 18:13, Alberto Garcia wrote:
> The QCowL2Meta structure is used to store information about a part of
> a write request that touches clusters that need changes in their L2
> entries. This happens with newly-allocated clusters or subclusters.
>
> This structure has changed a bit since
On 28.10.20 09:07, Greg Kurz wrote:
> This function is really an internal helper for bdrv_close(). Update its
> doc comment to make this clear and make the function private.
>
> Signed-off-by: Greg Kurz
> ---
>
> As suggested by Stefan here:
>
>
On 21.10.20 11:12, AlexChen wrote:
> The "qemu-common.h" include is not used, remove it.
>
> Reported-by: Euler Robot
> Signed-off-by: AlexChen
> ---
> block/dmg-lzfse.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, I’ve applied this patch to my block branch:
On 01.11.20 17:15, Maxim Levitsky wrote:
> The recent changes that brought RCU delayed device deletion,
> broke few tests and this test breakage went unnoticed.
>
> Fix this test by rewriting it in python
> (which allows to wait for DEVICE_DELETED events before continuing).
>
> Signed-off-by:
On 02.11.20 20:56, Dr. David Alan Gilbert (git) wrote:
> From: Max Reitz
>
> Whenever we encounter a directory with an st_dev or mount ID that
> differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so
> the guest can create a submount for it.
>
>
On 03.11.20 09:10, Miklos Szeredi wrote:
> On Mon, Nov 2, 2020 at 5:19 PM Max Reitz wrote:
>>
>> Whenever we encounter a directory with an st_dev or mount ID that
>> differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so
>> the guest can create a sub
, virtiofsd requires them. (If you have a
timestamp_timeout period for sudoers (e.g. the default of 5 min), you
can provide this by executing something like "sudo true" before invoking
Avocado.)
Signed-off-by: Max Reitz
---
tests/acceptance/virtiofs_submounts.py
.
If that is available, add it to the lo_inode key.
Most of this patch is taken from Miklos's mail here:
https://marc.info/?l=fuse-devel=160062521827983
(virtiofsd-use-mount-id.patch attachment)
Suggested-by: Miklos Szeredi
Signed-off-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/passthrough_ll.c
Let download_cloudinit() take an optional pubkey, which subclasses of
BootLinux can pass through setUp().
Signed-off-by: Max Reitz
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Willian Rampazzo
Reviewed-by: Stefan Hajnoczi
---
tests/acceptance/boot_linux.py | 13 +++--
1 file
Check whether the glibc provides statx() and if so, define CONFIG_STATX.
Signed-off-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
---
meson.build | 16
1 file changed, 16 insertions(+)
diff --git a/meson.build b/meson.build
index 47e32e1fcb..39ac5cf6d8 100644
--- a/meson.build
fuse_entry_param is converted to fuse_attr on the line (by
fill_entry()), so it should have a member that mirrors fuse_attr.flags.
fill_entry() should then copy this fuse_entry_param.attr_flags to
fuse_attr.flags.
Signed-off-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd
'
007/7:[0042] [FC] 'tests/acceptance: Add virtiofs_submounts.py'
Max Reitz (7):
virtiofsd: Check FUSE_SUBMOUNTS
virtiofsd: Add attr_flags to fuse_entry_param
meson.build: Check for statx()
virtiofsd: Add mount ID to the lo_inode key
virtiofsd: Announce sub-mount points
tests/acceptance
there is no statx().)
Signed-off-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/helper.c | 1 +
tools/virtiofsd/passthrough_ll.c | 22 ++
2 files changed, 23 insertions(+)
diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
index 2e181a49b5
FUSE_SUBMOUNTS is a pure indicator by the kernel to signal that it
supports submounts. It does not check its state in the init reply, so
there is nothing for fuse_lowlevel.c to do but to check its existence
and copy it into fuse_conn_info.capable.
Signed-off-by: Max Reitz
Reviewed-by: Stefan
On 29.10.20 21:46, Eduardo Habkost wrote:
> On Thu, Oct 29, 2020 at 06:17:44PM +0100, Max Reitz wrote:
>> This test invokes several shell scripts to create a random directory
>> tree full of submounts, and then check in the VM whether every submount
>> has its own ID an
Let download_cloudinit() take an optional pubkey, which subclasses of
BootLinux can pass through setUp().
Signed-off-by: Max Reitz
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Willian Rampazzo
Reviewed-by: Stefan Hajnoczi
---
tests/acceptance/boot_linux.py | 13 +++--
1 file
there is no statx().)
Signed-off-by: Max Reitz
---
tools/virtiofsd/helper.c | 1 +
tools/virtiofsd/passthrough_ll.c | 22 ++
2 files changed, 23 insertions(+)
diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
index 2e181a49b5..4433724d3a 100644
--- a/tools
, virtiofsd requires them. (If you have a
timestamp_timeout period for sudoers (e.g. the default of 5 min), you
can provide this by executing something like "sudo true" before invoking
Avocado.)
Signed-off-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
---
tests/acceptance/virtiofs_su
fuse_entry_param is converted to fuse_attr on the line (by
fill_entry()), so it should have a member that mirrors fuse_attr.flags.
fill_entry() should then copy this fuse_entry_param.attr_flags to
fuse_attr.flags.
Signed-off-by: Max Reitz
---
tools/virtiofsd/fuse_lowlevel.h | 5 +
tools
m'
003/7:[down] 'meson.build: Check for statx()'
004/7:[down] 'virtiofsd: Add mount ID to the lo_inode key'
005/7:[0077] [FC] 'virtiofsd: Announce sub-mount points'
006/7:[] [--] 'tests/acceptance/boot_linux: Accept SSH pubkey'
007/7:[] [--] 'tests/acceptance: Add virtiofs_submounts.py'
Check whether the glibc provides statx() and if so, define CONFIG_STATX.
Signed-off-by: Max Reitz
---
meson.build | 16
1 file changed, 16 insertions(+)
diff --git a/meson.build b/meson.build
index 47e32e1fcb..39ac5cf6d8 100644
--- a/meson.build
+++ b/meson.build
@@ -736,6
FUSE_SUBMOUNTS is a pure indicator by the kernel to signal that it
supports submounts. It does not check its state in the init reply, so
there is nothing for fuse_lowlevel.c to do but to check its existence
and copy it into fuse_conn_info.capable.
Signed-off-by: Max Reitz
---
tools/virtiofsd
.
If that is available, add it to the lo_inode key.
Most of this patch is taken from Miklos's mail here:
https://marc.info/?l=fuse-devel=160062521827983
(virtiofsd-use-mount-id.patch attachment)
Suggested-by: Miklos Szeredi
Signed-off-by: Max Reitz
---
I’m not sure how to better mark Miklos as the original author
am")
> 2f10415abfc5 ("virtiofsd: Announce FUSE_ATTR_FLAGS")
> 97d741cc96dd ("linux/fuse.h: Pull in from Linux")
>
> Cc: Max Reitz
> Cc: Stefan Hajnoczi
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Alex Williamson
Reviewed-by: Max Reitz
Thanks again, and sorry.
Max
signature.asc
Description: OpenPGP digital signature
> changing the flag in question. As Adam wrote, I noted that I would thus
*Alex, sorry :/
On 28.10.20 08:55, Stefan Hajnoczi wrote:
> On Tue, Oct 27, 2020 at 08:13:28PM -0600, Alex Williamson wrote:
>> This reverts the following commits due to their basis on a bogus
>> linux kernel header update:
>
> What was the issue? Did the sub-mounts series include kernel header
> changes that
On 28.10.20 09:11, Cornelia Huck wrote:
> On Tue, 27 Oct 2020 23:42:57 +
> Peter Maydell wrote:
>
>> On Mon, 26 Oct 2020 at 19:39, Alex Williamson
>> wrote:
>>>
>>> VFIO update 2020-10-26
>>>
>>> * Migration support (Kirti
On 28.10.20 03:00, Alex Williamson wrote:
> On Tue, 27 Oct 2020 23:42:57 +
> Peter Maydell wrote:
>
>> On Mon, 26 Oct 2020 at 19:39, Alex Williamson
>> wrote:
>>>
>>> VFIO update 2020-10-26
>>>
>>> * Migration support (Kirti
This pretends FUSE exports are a kind of protocol. As such, they are
always tested under the format node. This is probably the best way to
test them, actually, because this will generate more I/O load and more
varied patterns.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/check
Signed-off-by: Max Reitz
---
tests/qemu-iotests/check | 11 +++
tests/qemu-iotests/common.rc | 17 +
2 files changed, 28 insertions(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 678b6e4910..3c1fa4435a 100755
--- a/tests/qemu-iotests/check
Otherwise, exports and block devices are not properly shut down and
closed, unless the users explicitly issues blockdev-del and
block-export-del commands for each of them.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
storage-daemon/qemu-storage-daemon.c | 3 +++
1 file changed, 3
We have good coverage of the normal I/O paths now, but what remains is a
test that tests some more special cases: Exporting an image on itself
(thus turning a formatted image into a raw one), some error cases, and
non-writable and non-growable exports.
Signed-off-by: Max Reitz
Reviewed-by: Kevin
If the test environment has some other child processes running (like a
storage daemon that provides a FUSE export), then "wait" will never
finish. Use wait=yes _cleanup_qemu instead.
(We need to discard the output so there is no change to the reference
output.)
Signed-off-by:
alue and thus work around what technically is the caller
misbehaving.
This second solution is less clean, but it is robust against people
keeping their old habit of adjusting TEST_IMG only, and requires much
less changes. So this patch implements it.
Signed-off-by: Max Reitz
Reviewed-by: Kevin
the rather low-hanging fruits.
Note that 221 and 250 only pass when .lseek is correctly implemented,
which is only possible with a libfuse that is 3.8 or newer.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/025 | 2 +-
tests/qemu-iotests/026 | 2 +-
tests/qemu-iotests
output.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/028 | 14 --
tests/qemu-iotests/028.out | 3 +++
tests/qemu-iotests/089 | 3 ++-
tests/qemu-iotests/089.out | 1 +
4 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/tests/qemu
Avoid creating images with custom filenames in $TEST_DIR, because
non-file protocols may want to keep $TEST_IMG (and all other test
images) in some other directory.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/200 | 3 +--
tests/qemu-iotests/200.out | 4
is important, so
clean up the image before the state is lost.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/287 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287
index f98a4cadc1..036cc09e82 100755
This is a relatively new feature in libfuse (available since 3.8.0,
which was released in November 2019), so we have to add a dedicated
check whether it is available before making use of it.
Signed-off-by: Max Reitz
---
configure | 8 -
meson.build | 20
This allows allocating areas after the (old) EOF as part of a growing
resize, writing zeroes, and discarding.
Signed-off-by: Max Reitz
---
block/export/fuse.c | 84 +
1 file changed, 84 insertions(+)
diff --git a/block/export/fuse.c b/block/export
Most Python tests are restricted to the file protocol (without
explicitly saying so), but these are the ones that would break
./check -fuse -qcow2.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/206 | 3 ++-
tests/qemu-iotests/242 | 3 ++-
2 files changed, 4 insertions
, because at that point the
BlockBackend is destroyed altogether anyway.)
Signed-off-by: Max Reitz
---
qapi/block-export.json | 6 +-
block/export/fuse.c| 44 ++
2 files changed, 41 insertions(+), 9 deletions(-)
diff --git a/qapi/block-export.json
it'
017/20:[0018] [FC] 'iotests: Give access to the qemu-storage-daemon'
018/20:[0004] [FC] 'iotests: Allow testing FUSE exports'
019/20:[] [--] 'iotests: Enable fuse for many tests'
020/20:[] [--] 'iotests/308: Add test for FUSE exports'
Max Reitz (20):
meson: Detect libfuse
f
This makes the export actually useful instead of only producing errors
whenever it is accessed.
Signed-off-by: Max Reitz
---
block/export/fuse.c | 242
1 file changed, 242 insertions(+)
diff --git a/block/export/fuse.c b/block/export/fuse.c
index
In most cases, _make_test_img does not need a _filter_imgfmt on top. It
does that by itself.
(The exception is when IMGFMT has been overwritten but TEST_IMG has not.
In such cases, we do need a _filter_imgfmt on top to filter the test's
original IMGFMT from TEST_IMG.)
Signed-off-by: Max Reitz
801 - 900 of 13087 matches
Mail list logo
