This generally does not work on non-file protocols. It is better to
create the image with the final name from the start, and most tests do
this already. Let 046 follow suit.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/046 | 5 +++--
tests/qemu-iotests/046.out
).
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
tests/qemu-iotests/071 | 19 +++
tests/qemu-iotests/174 | 10 +-
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
index 88faebcc1d..18fe9054b0 100755
--- a/tests
Signed-off-by: Max Reitz
---
configure | 7 +++
meson.build | 6 ++
meson_options.txt | 2 ++
3 files changed, 15 insertions(+)
diff --git a/configure b/configure
index 83610b0db8..fc315deebe 100755
--- a/configure
+++ b/configure
@@ -448,6 +448,7 @@ meson="&qu
for it to settle. Therefore, keep track of mount point
paths to at least catch the most obvious instances of that problem.
Signed-off-by: Max Reitz
---
qapi/block-export.json | 23 ++-
include/block/fuse.h | 30
block.c | 1 +
block/export/export.c| 4 +
block/export
into
two patches.)
Max Reitz (2):
iotests/291: Filter irrelevant parts of img-info
iotests/291: Stop NBD server
tests/qemu-iotests/291 | 16 +---
tests/qemu-iotests/291.out | 20
2 files changed, 13 insertions(+), 23 deletions(-)
--
2.26.2
("qemu-img: Support bitmap --merge into backing image")
Signed-off-by: Max Reitz
---
tests/qemu-iotests/291 | 14 +++---
tests/qemu-iotests/291.out | 20
2 files changed, 11 insertions(+), 23 deletions(-)
diff --git a/tests/qemu-iotests/291 b/tests/qe
on FUSE
exports, because then the export (which is the image used by qemu-nbd)
will go away before qemu-nbd exits, which will lead to qemu-nbd
complaining that it cannot flush the bitmaps in the image.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/291 | 2 ++
1 file changed, 2 insertions(+)
diff
On 15.10.20 14:01, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> Based-on: <20200907182011.521007-1-kw...@redhat.com>
>> (“block/export: Add infrastructure and QAPI for block exports”)
>>
>> (Though its patch 16 needs a s/= \
On 15.10.20 17:58, Kevin Wolf wrote:
> Am 15.10.2020 um 17:18 hat Max Reitz geschrieben:
>> On 15.10.20 11:46, Kevin Wolf wrote:
>>> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>>>> This makes the export actually useful instead of only producing error
On 15.10.20 17:41, Kevin Wolf wrote:
> Am 15.10.2020 um 16:46 hat Max Reitz geschrieben:
>> On 15.10.20 10:57, Kevin Wolf wrote:
>>> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
[...]
>>>> +static void fuse_export_shutdown(BlockExport *blk_exp)
>
On 14.10.20 20:57, Andrey Shinkevich wrote:
> On 14.10.2020 15:01, Max Reitz wrote:
>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>> Limit COR operations by the base node in the backing chain when the
>>> overlay base node name is given. It will be useful for a block
On 14.10.20 18:39, Vladimir Sementsov-Ogievskiy wrote:
> 14.10.2020 19:30, Max Reitz wrote:
>> On 14.10.20 17:22, Vladimir Sementsov-Ogievskiy wrote:
>>> 14.10.2020 15:51, Max Reitz wrote:
>>>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>>>> If the fl
On 15.10.20 13:43, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> This pretends FUSE exports are a kind of protocol. As such, they are
>> always tested under the format node. This is probably the best way to
>> test them, actually, because this w
On 15.10.20 13:27, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> Signed-off-by: Max Reitz
>> ---
>> tests/qemu-iotests/check | 11 +++
>> tests/qemu-iotests/common.rc | 17 +
>> 2 files changed, 28 insertions
On 15.10.20 12:41, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> These will behave more like normal files in that writes beyond the EOF
>> will automatically grow the export size.
>>
>> Signed-off-by: Max Reitz
>> ---
>> qapi/
On 15.10.20 11:46, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> This makes the export actually useful instead of only producing errors
>> whenever it is accessed.
>>
>> Signed-off-by: Max Reitz
>>
On 15.10.20 10:57, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> block-export-add type=fuse allows mounting block graph nodes via FUSE on
>> some existing regular file. That file should then appears like a raw
>> disk image, and accesses to
On 14.10.20 18:08, Andrey Shinkevich wrote:
> On 14.10.2020 14:09, Max Reitz wrote:
>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>> We are going to use the COR-filter for a block-stream job.
>>> To limit COR operations by the base node in the backing chain during
&g
On 14.10.20 17:22, Vladimir Sementsov-Ogievskiy wrote:
> 14.10.2020 15:51, Max Reitz wrote:
>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>> If the flag BDRV_REQ_PREFETCH was set, pass it further to the
>>> COR-driver to skip unneeded reading. It can be taken i
On 14.10.20 16:56, Vladimir Sementsov-Ogievskiy wrote:
> 14.10.2020 14:57, Max Reitz wrote:
>> On 14.10.20 13:09, Max Reitz wrote:
>>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>>> We are going to use the COR-filter for a block-stream job.
>>>>
On 14.10.20 16:28, Andrey Shinkevich wrote:
> On 14.10.2020 13:44, Max Reitz wrote:
>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>> Provide API for the COR-filter insertion/removal.
>>> Also, drop the filter child permissions for an inactive state when the
>&
On 12.10.20 19:43, Andrey Shinkevich wrote:
> This patch completes the series with the COR-filter insertion for
> block-stream operations. Adding the filter makes it possible for copied
> regions to be discarded in backing files during the block-stream job,
> what will reduce the disk overuse.
>
On 12.10.20 19:43, Andrey Shinkevich wrote:
> Avoid writing a filter JSON-name to QCOW2 image when the backing file
> is changed after the block stream job.
>
> Signed-off-by: Andrey Shinkevich
> ---
> block/stream.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff
On 12.10.20 19:43, Andrey Shinkevich wrote:
> Whereas the block-stream job starts using a backing file name of the
> base node overlay after the block-stream job completes, mark the QMP
> 'backing-file' argument as deprecated.
>
> Signed-off-by: Andrey Shinkevich
> ---
>
On 12.10.20 19:43, Andrey Shinkevich wrote:
> The 'backing-file' argument is not used by the block-stream job. It
> designates a backing file name to set in QCOW2 image header after the
> block-stream job finished. A backing file name of the node above base
> is used instead.
>
> Signed-off-by:
On 12.10.20 19:43, Andrey Shinkevich wrote:
> If the flag BDRV_REQ_PREFETCH was set, pass it further to the
> COR-driver to skip unneeded reading. It can be taken into account for
> the COR-algorithms optimization. That check is being made during the
> block stream job by the moment.
>
>
On 12.10.20 19:43, Andrey Shinkevich wrote:
> Add support for the BDRV_REQ_PREFETCH flag to the supported_write_flags
s/write/read/
> of the COR-filter.
>
> Signed-off-by: Andrey Shinkevich
> ---
> block/copy-on-read.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
+++
> 1 file changed, 4 insertions(+)
Not sure what the problem with passing BDRV_REQ_PREFETCH to drivers that
aren’t the COR filter are would be, but:
Reviewed-by: Max Reitz
(I mean, outside of the context of COR the flag is undefined, so it can
be anything, but intuitively I’d assume i
On 12.10.20 19:43, Andrey Shinkevich wrote:
> Modify the comment for the flag BDRV_REQ_PREFETCH as we are going to
> use it alone and pass it to the COR-filter driver for further
> processing.
>
> Signed-off-by: Andrey Shinkevich
> ---
> include/block/block.h | 7 ---
> 1 file changed, 4
On 14.10.20 13:09, Max Reitz wrote:
> On 12.10.20 19:43, Andrey Shinkevich wrote:
>> We are going to use the COR-filter for a block-stream job.
>> To limit COR operations by the base node in the backing chain during
>> stream job, pass the name of overlay base node to the c
On 12.10.20 19:43, Andrey Shinkevich wrote:
> Limit COR operations by the base node in the backing chain when the
> overlay base node name is given. It will be useful for a block stream
> job when the COR-filter is applied. The overlay base node is passed as
> the base itself may change due to
On 12.10.20 19:43, Andrey Shinkevich wrote:
> Limit COR operations by the base node in the backing chain when the
> overlay base node name is given. It will be useful for a block stream
> job when the COR-filter is applied. The overlay base node is passed as
> the base itself may change due to
On 12.10.20 19:43, Andrey Shinkevich wrote:
> We are going to use the COR-filter for a block-stream job.
> To limit COR operations by the base node in the backing chain during
> stream job, pass the name of overlay base node to the copy-on-read
> driver as base node itself may change due to
ockDriverState *bs,
> + QDict *node_options,
> + int flags, Error **errp)
I had hoped you could make this a generic block layer function. :(
(Because it really is rather generic)
*shrug*
Reviewed-by: Max R
On 14.10.20 03:03, Chenqun (kuhn) wrote:
>
>
>> -Original Message-----
>> From: Max Reitz [mailto:mre...@redhat.com]
>> Sent: Tuesday, October 13, 2020 10:47 PM
>> To: Chenqun (kuhn) ; qemu-devel@nongnu.org;
>> qemu-triv...@nongnu.org
>> Cc: vsemen
On 13.10.20 14:33, Chen Qun wrote:
> A default value is provided for the variable 'bitmap_name' to avoid compiler
> warning.
>
> The compiler show warning:
> migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>
On 02.10.20 10:23, Fabian Grünbichler wrote:
> On October 1, 2020 7:31 pm, Max Reitz wrote:
>> On 22.09.20 11:14, Fabian Grünbichler wrote:
>>> heavily based on/practically forked off iotest 257 for bitmap backups,
>>> but:
>>>
>>> - no writes t
| 37 +---
> monitor/hmp-cmds.c | 7 +---
> replay/replay-debugging.c | 4 +-
> tests/qemu-iotests/267.out | 10 ++---
> 7 files changed, 67 insertions(+), 89 deletions(-)
Reviewed-by: Max Reitz
On 09.10.20 14:55, Jakob Bohm wrote:
> On 2020-10-09 10:48, Max Reitz wrote:
>> On 08.10.20 18:49, Jakob Bohm wrote:
>>> (Top posting because previous reply did so):
>>>
>>> If the bug was closed as "can't reproduce", why was a very similar bug
>&
On 12.10.20 12:16, Philippe Mathieu-Daudé wrote:
> On 10/12/20 12:07 PM, Max Reitz wrote:
>> On 08.10.20 19:48, Philippe Mathieu-Daudé wrote:
>>> From: Daniel P. Berrangé
>>>
>>> The bdrv_all_*_snapshot functions return a BlockDriverState pointer
>>&g
On 08.10.20 19:48, Philippe Mathieu-Daudé wrote:
> From: Daniel P. Berrangé
>
> The bdrv_all_*_snapshot functions return a BlockDriverState pointer
> for the invalid backend, which the callers then use to report an
> error message. In some cases multiple callers are reporting the
> same error
On 10.10.20 00:54, Jakob Bohm wrote:
[...]
> Theoretically, locking on a raw file needs to be protocol-compatible
> with loop-mounting the same raw file, so if the loop driver doesn't
> probe those magic byte offsets to prevent out-of-order block writes,
> then there is little point for the qemu
On 09.10.20 14:55, Jakob Bohm wrote:
> On 2020-10-09 10:48, Max Reitz wrote:
[...]
> The error I got was specifically "Failed to lock byte 100" and VM not
> starting. The ISO file was on a R/W NFS3 share, but was itself R/O for
> the user that root was mapped to by lin
On 08.10.20 18:49, Jakob Bohm wrote:
> (Top posting because previous reply did so):
>
> If the bug was closed as "can't reproduce", why was a very similar bug
> listed as fixed in RHSA-2019:2553-01 ?
Hi,
Which very similar bug do you mean? I can only guess that perhaps you
mean 1603104 or
On 22.09.20 11:14, Fabian Grünbichler wrote:
> heavily based on/practically forked off iotest 257 for bitmap backups,
> but:
>
> - no writes to filter node 'mirror-top' between completion and
> finalization, as those seem to deadlock?
> - no inclusion of not-yet-available full/top sync modes in
block/mirror.c | 28 +---
> blockdev.c | 29 +
> 2 files changed, 34 insertions(+), 23 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 22.09.20 11:14, Fabian Grünbichler wrote:
> From: John Snow
>
> Teach mirror two new tricks for using bitmaps:
>
> Always: no matter what, we synchronize the copy_bitmap back to the
> sync_bitmap. In effect, this allows us resume a failed mirror at a later
> date, since the target bdrv
power of 2 between 512 and 64M
> +# power of 2 between 512 and 64M . Must not be specified if
s/ \./\./
(What a cheerful-looking regex.)
With that fixed:
Reviewed-by: Max Reitz
> +# @bitmap is present.
> #
> # @buf-size: maximum amount of data in flight from source to
> #target
signature.asc
Description: OpenPGP digital signature
On 25.09.20 19:13, Vladimir Sementsov-Ogievskiy wrote:
> 25.09.2020 13:24, Max Reitz wrote:
>> On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
>>> Performance improvements / degradations are usually discussed in
>>> percentage. Let's make the script calculate it
On 25.09.20 17:32, Vladimir Sementsov-Ogievskiy wrote:
> 25.09.2020 18:11, Vladimir Sementsov-Ogievskiy wrote:
>> 25.09.2020 12:11, Max Reitz wrote:
>>> On 25.09.20 10:49, Vladimir Sementsov-Ogievskiy wrote:
>>>> 25.09.2020 11:26, Max Reitz wrote:
>>>&
ed, 257 insertions(+)
> create mode 100755 tests/qemu-iotests/307
> create mode 100644 tests/qemu-iotests/307.out
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
> ---
> tests/qemu-iotests/iotests.py | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 24.09.20 17:27, Kevin Wolf wrote:
> Add a function to list the NBD exports offered by an NBD server.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/iotests.py | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz
signatu
tests/iotests.py | 49 ---
> 1 file changed, 23 insertions(+), 26 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 24.09.20 17:27, Kevin Wolf wrote:
> These QMP commands are replaced by block-export-add/del.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-export.json | 11 +--
> docs/system/deprecated.rst | 6 ++
> 2 files changed, 15 insertions(+), 2 deletions
On 24.09.20 17:27, Kevin Wolf wrote:
> There is no real reason any more why nbd_export_new() and
> nbd_export_create() should be separate functions. The latter only
> performs a few checks before it calls the former.
>
> What makes the current state stand out is that it's the only function in
>
tered the event, not
the return):
https://git.xanclic.moe/XanClic/qemu/commit/e6f7510149a4a26c868013639ec89d28f16857d8#diff-3
and considered it kind of a hack.
Oh well. :)
Reviewed-by: Max Reitz
> $QEMU_IO_PROG -f raw -r -c close \
> "nbd+unix:///drv?socket=$SOCK_DIR/nbd" 2>&1 \
signature.asc
Description: OpenPGP digital signature
> create mode 100755 scripts/simplebench/bench_prealloc.py
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Performance improvements / degradations are usually discussed in
> percentage. Let's make the script calculate it for us.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> scripts/simplebench/simplebench.py | 46
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Introduce dynamic float precision and use percentage to show delta.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> scripts/simplebench/simplebench.py | 26 +-
> 1 file changed, 25 insertions(+), 1
On 25.09.20 10:49, Vladimir Sementsov-Ogievskiy wrote:
> 25.09.2020 11:26, Max Reitz wrote:
>> On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>>> ---
>>> tests/qemu-iotests/298 | 186 +
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Support benchmarks returning not seconds but iops. We'll use it for
> further new test.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> scripts/simplebench/simplebench.py | 35 +++---
> 1 file changed, 27
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/298 | 186 +
> tests/qemu-iotests/298.out | 5 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 192 insertions(+)
>
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/iotests.py | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
> +.argmin = 1,
> +.argmax = 3,
> +.args = "[-m prealloc_mode] off",
> +.oneline= "truncates the current file at the given offset",
> +};
> +
Forward-declaring truncate_cmd instead of truncate_f would mean a
smaller diffstat.
But that isn’t what other commands do, so.
*shrug*
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> It's intended to be inserted between format and protocol nodes to
> preallocate additional space (expanding protocol file) on writes
> crossing EOF. It improves performance for file-systems with slow
> allocation.
>
> Signed-off-by:
On 24.09.20 16:51, Vladimir Sementsov-Ogievskiy wrote:
> 24.09.2020 16:25, Max Reitz wrote:
>> On 23.09.20 16:38, Vladimir Sementsov-Ogievskiy wrote:
>>> 17.09.2020 19:09, Andrey Shinkevich wrote:
>>>> On 04.09.2020 14:22, Max Reitz wrote:
>>>>&g
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Do generic processing even for drivers which define .bdrv_check_perm
> handler. It's needed for further preallocate filter: it will need to do
> additional action on bdrv_check_perm, but don't want to reimplement
> generic logic.
>
> The
On 23.09.20 16:38, Vladimir Sementsov-Ogievskiy wrote:
> 17.09.2020 19:09, Andrey Shinkevich wrote:
>> On 04.09.2020 14:22, Max Reitz wrote:
>>> On 28.08.20 18:52, Andrey Shinkevich wrote:
>>>> Provide API for the COR-filter insertion/removal.
>> ...
>>
On 07.09.20 14:17, Vladimir Sementsov-Ogievskiy wrote:
> 07.09.2020 14:44, Max Reitz wrote:
>> On 04.09.20 15:48, Vladimir Sementsov-Ogievskiy wrote:
>>> 04.09.2020 16:21, Max Reitz wrote:
>>>> On 28.08.20 18:52, Andrey Shinkevich wrote:
>>>>> To
On 22.09.20 15:13, Andrey Shinkevich wrote:
> On 04.09.2020 16:59, Vladimir Sementsov-Ogievskiy wrote:
>> 04.09.2020 15:50, Max Reitz wrote:
>>> On 28.08.20 18:52, Andrey Shinkevich wrote:
>>>> Limit the guest's COR operations by the base node in the backing
On 22.09.20 17:58, Daniel P. Berrangé wrote:
> On Tue, Sep 22, 2020 at 12:49:12PM +0200, Max Reitz wrote:
>> Based-on: <20200907182011.521007-1-kw...@redhat.com>
>> (“block/export: Add infrastructure and QAPI for block exports”)
>>
>> (Though its pat
On 22.09.20 13:14, Thomas Huth wrote:
[...]
> Could you turn this immediately into a meson test instead? See e.g.
> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07112.html as
> an example for how to do this.
Done (I think). Until I send v3, the updated version lives here:
On 22.09.20 13:14, Thomas Huth wrote:
[...]
> Could you turn this immediately into a meson test instead? See e.g.
> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07112.html as
> an example for how to do this.
Sure!
Max
signature.asc
Description: OpenPGP digital signature
We have good coverage of the normal I/O paths now, but what remains is a
test that tests some more special cases: Exporting an image on itself
(thus turning a formatted image into a raw one), some error cases, and
non-writable and non-growable exports.
Signed-off-by: Max Reitz
---
tests/qemu
Signed-off-by: Max Reitz
---
tests/qemu-iotests/check | 11 +++
tests/qemu-iotests/common.rc | 17 +
2 files changed, 28 insertions(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index e14a1f354d..467a7cf1b7 100755
--- a/tests/qemu-iotests/check
alue and thus work around what technically is the caller
misbehaving.
This second solution is less clean, but it is robust against people
keeping their old habit of adjusting TEST_IMG only, and requires much
less changes. So this patch implements it.
Signed-off-by: Max Reitz
---
tes
Otherwise, exports and block devices are not properly shut down and
closed, unless the users explicitly issues blockdev-del and
block-export-del commands for each of them.
Signed-off-by: Max Reitz
---
storage-daemon/qemu-storage-daemon.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Most Python tests are restricted to the file protocol (without
explicitly saying so), but these are the ones that would break
./check -fuse -qcow2.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/206 | 3 ++-
tests/qemu-iotests/242 | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff
Avoid creating images with custom filenames in $TEST_DIR, because
non-file protocols may want to keep $TEST_IMG (and all other test
images) in some other directory.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/200 | 3 +--
tests/qemu-iotests/200.out | 4 ++--
tests/qemu-iotests/229
the rather low-hanging fruits.
Note that 221 and 250 only pass when .lseek is correctly implemented,
which is only possible with a libfuse that is 3.8 or newer.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/025 | 2 +-
tests/qemu-iotests/026 | 2 +-
tests/qemu-iotests/028 | 2 +-
tests/qemu
This generally does not work on non-file protocols. It is better to
create the image with the final name from the start, and most tests do
this already. Let 046 follow suit.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/046 | 5 +++--
tests/qemu-iotests/046.out | 2 +-
2 files changed
This pretends FUSE exports are a kind of protocol. As such, they are
always tested under the format node. This is probably the best way to
test them, actually, because this will generate more I/O load and more
varied patterns.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/check
is important, so
clean up the image before the state is lost.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/287 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287
index f98a4cadc1..036cc09e82 100755
--- a/tests/qemu-iotests/287
In most cases, _make_test_img does not need a _filter_imgfmt on top. It
does that by itself.
(The exception is when IMGFMT has been overwritten but TEST_IMG has not.
In such cases, we do need a _filter_imgfmt on top to filter the test's
original IMGFMT from TEST_IMG.)
Signed-off-by: Max Reitz
).
Signed-off-by: Max Reitz
---
tests/qemu-iotests/071 | 19 +++
tests/qemu-iotests/174 | 10 +-
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
index 88faebcc1d..18fe9054b0 100755
--- a/tests/qemu-iotests/071
+++ b
This is a relatively new feature in libfuse (available since 3.8.0,
which was released in November 2019), so we have to let configure check
whether it is available before making use of it.
Signed-off-by: Max Reitz
---
configure | 32 +++
block/export/fuse.c | 77
If the test environment has some other child processes running (like a
storage daemon that provides a FUSE export), then "wait" will never
finish. Use wait=yes _cleanup_qemu instead.
(We need to discard the output so there is no change to the reference
output.)
Signed-off-by:
This allows allocating areas after the (old) EOF as part of a growing
resize, writing zeroes, and discarding.
Signed-off-by: Max Reitz
---
block/export/fuse.c | 79 +
1 file changed, 79 insertions(+)
diff --git a/block/export/fuse.c b/block/export
ge'
016/20:[down] 'storage-daemon: Call bdrv_close_all() on exit'
017/20:[down] 'iotests: Give access to the qemu-storage-daemon'
018/20:[0042] [FC] 'iotests: Allow testing FUSE exports'
019/20:[0026] [FC] 'iotests: Enable fuse for many tests'
020/20:[0104] [FC] 'iotests/281: Add test for FUSE exports'
output.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/028 | 14 --
tests/qemu-iotests/028.out | 3 +++
tests/qemu-iotests/089 | 3 ++-
tests/qemu-iotests/089.out | 1 +
4 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/tests/qemu-iotests/028 b/tests/qemu
for it to settle. Therefore, keep track of mount point
paths to at least catch the most obvious instances of that problem.
Signed-off-by: Max Reitz
---
qapi/block-export.json | 24 +++-
include/block/fuse.h | 30 +
block.c | 1 +
block/export/export.c| 4 +
block/export
These will behave more like normal files in that writes beyond the EOF
will automatically grow the export size.
Signed-off-by: Max Reitz
---
qapi/block-export.json | 6 +-
block/export/fuse.c| 12 +++-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/qapi/block
This makes the export actually useful instead of only producing errors
whenever it is accessed.
Signed-off-by: Max Reitz
---
block/export/fuse.c | 226
1 file changed, 226 insertions(+)
diff --git a/block/export/fuse.c b/block/export/fuse.c
index
Signed-off-by: Max Reitz
---
configure | 34 ++
meson.build | 6 ++
2 files changed, 40 insertions(+)
diff --git a/configure b/configure
index ce27eafb0a..21c31e4694 100755
--- a/configure
+++ b/configure
@@ -538,6 +538,7 @@ meson=""
ninja=&quo
On 18.09.20 22:11, Vladimir Sementsov-Ogievskiy wrote:
> 17.07.2020 16:45, Max Reitz wrote:
>> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>>> Refactor common path to use BlockCopyCallState pointer as parameter, to
>>> prepare it for use in asynchronous block
request), the test fails (for no good reason).
Filter the length, too.
Signed-off-by: Max Reitz
---
This has annoyed me for quite some time now, but when rebasing (and
testing) my FUSE export series, it became apparent that on a FUSE export
qcow2 images with -o compat=0.10 always fail this test
On 10.08.20 12:14, Denis V. Lunev wrote:
> Latency threshold is set to 10 seconds following guest request timeout
> on legacy storage controller.
>
> Signed-off-by: Denis V. Lunev
> CC: Vladimir Sementsov-Ogievskiy
> CC: Stefan Hajnoczi
> CC: Kevin Wolf
> CC: Max Re
Vladimir Sementsov-Ogievskiy
> CC: Stefan Hajnoczi
> CC: Kevin Wolf
> CC: Max Reitz
> ---
> block/block-backend.c | 5 +
> include/sysemu/block-backend.h | 1 +
> 2 files changed, 6 insertions(+)
(Note: I’m just writing this mail because I already responded to pat
gt; Signed-off-by: Denis V. Lunev
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> CC: Stefan Hajnoczi
> CC: Kevin Wolf
> CC: Max Reitz
> ---
> block/accounting.c | 59 +-
> blockdev.c | 7 -
> include/block
901 - 1000 of 13087 matches
Mail list logo
