[Stable-8.2.2 13/60] linux-user/aarch64: Add padding before __kernel_rt_sigreturn

ves: https://linaro.atlassian.net/browse/GNU-974 Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-Id: <20240202034427.504686-1-richard.hender...@linaro.org> (cherry picked from commit 6400be014f80e4c2c246eb8be709ea3a96428233) Signed-off-by: Michael Tokarev diff --git a/li

[Stable-8.2.2 11/60] pci-host: designware: Limit value range of iATU viewport register

d from commit 8a73152020337a7fbf34daf0a006d4d89ec1494e) Signed-off-by: Michael Tokarev diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index f477f97847..f016f02109 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -340,6 +340,8 @@ static void designware_pcie_root

[Stable-8.2.2 16/60] iotests: give tempdir an identifying name

vieved-by: Michael Tokarev Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 7d2faf0ce2ccc896ac56bc5ed2cdf4a55056a8bb) Signed-off-by: Michael Tokarev diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py index 3ff38f2661..588f30a4f1 100644 --- a/test

[Stable-8.2.2 01/60] migration: Plug memory leak on HMP migrate error path

/20240117140722.3979657-1-arm...@redhat.com [peterx: fix CID number as reported by Peter Maydell] Signed-off-by: Peter Xu (cherry picked from commit 918f620d30a9b0095b7824b8d77a2d6059a439d9) Signed-off-by: Michael Tokarev diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c

[Stable-8.2.2 v0 00/60] Patch Round-up for stable 8.2.2, freeze on 2024-03-02

The following patches are queued for QEMU stable v8.2.2: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: https://wiki.qemu.org/Planning/8.2 Please respond here or CC qemu-sta...@nongnu.org on any additional

Re: [PATCH v2] hw/hppa/Kconfig: Fix building with "configure --without-default-devices"

16.02.2024 12:16, Thomas Huth : When running "configure" with "--without-default-devices", building of qemu-system-hppa currently fails with: .. Applied to trivial-patches, thanks! /mjt

Re: [PATCH v1 00/21] Trivial tree wide typo fixes

20.02.2024 11:52, Manos Pitsidianakis wrote: .. So I picked up this series, to reduce the list SPAM. With the following details: docs: correct typos fixed "the historical behaviour" (why my spell checker continues marking "behaviour"? tests: correct typos Xen headers: correct

Re: [PATCH 23/23] qemu-img: inline list of supported commands, remove qemu-img-cmds.h include

20.02.2024 21:48, Daniel P. Berrangé: ... $ ./build/qemu-img check --help Check basic image integrity. Usage: qemu-img check [-f FMT | --image-opts] [-T CACHE_MODE] [-r] [-u] [--output human|json] [--object OBJDEF] FILENAME Arguments: $ ./build/qemu-img check --help Check basic

Re: [PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand

20.02.2024 20:45, Daniel P. Berrangé wrote: On Sat, Feb 10, 2024 at 12:22:33AM +0300, Michael Tokarev wrote: also remove bdrv_oflags handling (only list can use RO mode) --- qemu-img.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) I'd suggest docs/tools/qemu-img.rst

Re: [PATCH v1 03/21] Xen headers: correct typos

20.02.2024 11:52, Manos Pitsidianakis пишет: Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +- include/hw/xen/interface/arch-x86/xen.h| 2 +-

Re: [PATCH v1 01/21] docs: correct typos

20.02.2024 13:42, Manos Pitsidianakis wrote: ..  Set this variable to 2 to create the pipelines and run all -the jobs immediately, as was historicaly behaviour +the jobs immediately, as was historically behaviour as long as we do this let's fix grammar too? as was historically the behaviour

Re: [PATCH] configure: do not require gcc runtime library for firmwares

16.02.2024 21:12, Marek Marczykowski-Górecki : probe_target_compiler() when checking for multilib support checks if -nostdlib works together with -lgcc. It isn't necessary for building various components in pc-bios/optionrom, as evidenced by looking at actually used link flags there. Alpine

Re: [PATCH] scripts/qemu-binfmt-conf.sh: refresh

09.09.2023 16:23, Michael Tokarev : A friendly ping? A friendly ping #2? Thanks, /mjt 21.07.2023 14:50, Michael Tokarev wrote: Currently qemu-binfmt-conf.sh does a number of strange things. 1. --systemd requires an argument - the CPU type to register,     while --debian (which

Re: Ping 2: [PATCH v2] Allowing setting and overriding parameters in smb.conf

18.02.2024 01:28, Henrik Carlqvist : Still wondering if there are any plans to apply my patch or if you would like to change anything in the patch? Being able to set parameters in smb.conf would be really useful these days for people running old versions of Windows like Windows XP in a qemu

Re: [PATCH] target/i386: Eip error in x86_64-softmmu

15.01.2024 05:08, guoguangyao wrote: When closing PCREL, qemu-system-x86_64 run into error. Eip modification here leads to the result. Using s->pc in func gen_update_eip_next() solves the problem. Fixes: b5e0d5d22fbf("target/i386: Fix 32-bit wrapping of pc/eip computation") It looks like the

Re: [PATCH] vdpa: set old virtio status at cvq isolation probing end

26.07.2023 05:07, Jason Wang wrote: On Wed, Jul 26, 2023 at 2:21 AM Eugenio Pérez wrote: The device already has a virtio status set by vhost_vdpa_init by the time vhost_vdpa_probe_cvq_isolation is called. vhost_vdpa_init set S_ACKNOWLEDGE and S_DRIVER, so it is invalid to just reset it. It

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

17.05.2023 22:48, Stefano Stabellini : On Wed, 17 May 2023, Michael Tokarev wrote: 17.05.2023 12:47, Chuck Zmudzinski wrote: On 5/17/2023 2:39 AM, Michael Tokarev wrote: 08.02.2023 05:03, Chuck Zmudzinski wrote:... Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge spe

Re: [PATCH] scsi: megasas: Internal cdbs have 16-byte length

28.02.2023 20:11, Guenter Roeck wrote: Host drivers do not necessarily set cdb_len in megasas io commands. With commits 6d1511cea0 ("scsi: Reject commands if the CDB length exceeds buf_len") and fe9d8927e2 ("scsi: Add buf_len parameter to scsi_req_new()"), this results in failures to boot Linux

Re: [PATCH v3 3/6] target/arm: Adjust and validate mtedesc sizem1

07.02.2024 05:52, Richard Henderson : When we added SVE_MTEDESC_SHIFT, we effectively limited the maximum size of MTEDESC. Adjust SIZEM1 to consume the remaining bits (32 - 10 - 5 - 12 == 5). Assert that the data to be stored fits within the field (expecting 8 * 4 - 1 == 31, exact fit). Cc:

Re: [PATCH] .gitlab-ci/windows.yml: Don't install libusb or spice packages on 32-bit

this with a simple mechanism for the msys2-64bit and msys2-32bit jobs to specify a list of extra packages to install on top of the common ones we install for both jobs. Reviewed-by: Michael Tokarev Yes, this also hit me on -stable. Thanks, /mjt Cc: qemu-sta...@nongnu.org Resolves: https

Re: [PULL 00/60] virtio,pc,pci: features, cleanups, fixes

15.02.2024 16:39, Michael S. Tsirkin : Maybe add Akihiko Odaki (2): hw/smbios: Fix OEM strings table option validation hw/smbios: Fix port connector option validation this Dmitry Osipenko (1): virtio-gpu: Correct virgl_renderer_resource_get_info() error check and

Re: [PATCH] system/physmem: remove redundant arg reassignment

15.02.2024 12:15, Manos Pitsidianakis : Arguments `ram_block` are reassigned to local declarations `block` without further use. Remove re-assignment to reduce noise. Reviewed-by: Michael Tokarev And applied to trivial-patches, thanks! /mjt

Re: [PATCH] hw/i386/sgx: Use QDev API

13.02.2024 10:16, Philippe Mathieu-Daudé : Prefer the QDev API over the low level QOM one. No logical change intended. ... /* set the numa node property for sgx epc object */ -object_property_set_uint(obj, SGX_EPC_NUMA_NODE_PROP, list->value->node, -

Re: [PATCH] hw/i386/sgx: Use QDev API

13.02.2024 10:16, Philippe Mathieu-Daudé: Prefer the QDev API over the low level QOM one. No logical change intended. Reviewed-by: Michael Tokarev Picked up for trivial-patches. /mjt

Re: [PULL 00/60] virtio,pc,pci: features, cleanups, fixes

14.02.2024 14:13, Michael S. Tsirkin: virtio,pc,pci: features, cleanups, fixes vhost-user-snd support x2APIC mode with TCG support CXL update to r3.1 fixes, cleanups all over the place. Signed-off-by: Michael S. Tsirkin

Re: [PATCH v4 5/9] pcie_sriov: Validate NumVFs

14.02.2024 17:54, Akihiko Odaki wrote: On 2024/02/14 17:58, Michael Tokarev wrote: 14.02.2024 08:13, Akihiko Odaki wrote: The guest may write NumVFs greater than TotalVFs and that can lead to buffer overflow in VF implementations. This seems to be stable-worthy (Cc'd), and maybe even CVE

Re: [PULL 26/34] migration/multifd: Join the TLS thread

14.02.2024 16:27, Fabiano Rosas : Michael Tokarev writes: ..>>> This change, which is suggested for -stable, while simple by its own, seems to depend on the previous changes in this series, which are not for -stable. In particular, whole "Finally recycle all the

Re: [PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h'

ons(+), 12 deletions(-) For the series: Reviewed-by: Michael Tokarev and picked up for trivial-patches. Thanks, /mjt

Re: [PATCH] hw/i386/kvm/ioapic: Replace magic '24' value by proper definition

09.02.2024 22:01, Philippe Mathieu-Daudé: Replace '24' -> KVM_IOAPIC_NUM_PINS. Picked up for trivial-patches. Not exactly a trivial thing but heck :) Thanks, /mjt Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/kvm/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PULL 00/12] Hppa64 patches

13.02.2024 22:16, Helge Deller: On 2/13/24 19:09, Michael Tokarev wrote: 13.02.2024 02:47, del...@kernel.org: Helge Deller (11):    disas/hppa: Add disassembly for qemu specific instructions    target/hppa: Add "diag 0x101" for console output support    hw/pci-host/astro: Avoi

Re: [PATCH v4 5/9] pcie_sriov: Validate NumVFs

14.02.2024 08:13, Akihiko Odaki wrote: The guest may write NumVFs greater than TotalVFs and that can lead to buffer overflow in VF implementations. This seems to be stable-worthy (Cc'd), and maybe even CVE-worthy? Thanks, /mjt Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O

Re: [PATCH 0/3] hw/usb: Rename NB_PORTS -> UHCI_PORTS / EHCI_PORTS

13.02.2024 07:38, Philippe Mathieu-Daudé wrote: Rename variables to avoid clashing when including both "hw/usb/hcd-ehci.h" and "hw/usb/hcd-uhci.h" in the same file. Philippe Mathieu-Daudé (3): hw/usb: Style cleanup hw/usb/uhci: Rename NB_PORTS -> UHCI_PORTS hw/usb/ehci: Rename NB_PORTS

Re: [PULL 00/12] Hppa64 patches

13.02.2024 02:47, del...@kernel.org пишет: From: Helge Deller The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440: Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +) are available in the Git repository at:

[PULL 10/15] iothread: Simplify expression in qemu_in_iothread()

From: Kevin Wolf 'a == b ? false : true' is a rather convoluted way of writing 'a != b'. Use the more obvious way to write it. Signed-off-by: Kevin Wolf Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- iothread.c | 3 +-- 1 file changed, 1

[PULL 14/15] cpu-target: Include missing 'exec/memory.h' header

^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- cpu-target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpu-target.c b/cpu-target.c index 958d63e882..86444cc2c6 100644 --- a/cpu-target.c +++ b/cpu-tar

[PULL 06/15] hw/smbios: Fix port connector option validation

Signed-off-by: Akihiko Odaki Reviewed-by: Michael Tokarev Reviewed-by: Ani Sinha Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- hw/smbios/smbios.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index a9048c1342..a3c4e52ce9 10064

[PULL 13/15] system: Move memory_ldst.c.inc to system

From: BALATON Zoltan This file is only used by system/physmem.c so move them together. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell Reviewed-by: Michael Tokarev Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- memory_ldst.c.inc => system/memory_ldst.c.inc

[PULL 11/15] qemu-options.hx: document that tftp=dir is readonly

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286 Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- qemu-options.hx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index f7c83362d1..aec2328736 100644 --- a/qemu-options.hx +++ b/qemu

[PULL 15/15] monitor/target: Include missing 'exec/memory.h' header

eclaration] if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) { ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- monitor/hmp-cmds-target.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PULL 04/15] hw/arm/smmuv3: Consolidate the use of device_class_set_parent_realize()

From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/arm/smmuv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3

[PULL 08/15] MAINTAINERS: Cover qapi/stats.json

From: Markus Armbruster Commit aa09b3d5f8e (stats: Move QMP commands from monitor/ to stats/) created section Stats, but neglected to add qapi/stats.json to it. Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- MAINTAINERS | 1

[PULL 12/15] qemu-options.hx: Add zoom-to-fit to option summary for gtk

From: BALATON Zoltan The detailed help lists zoom-to-fit as valid option but it is missing from the short option summary. Add it there too. Signed-off-by: BALATON Zoltan Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1

[PULL 05/15] hw/smbios: Fix OEM strings table option validation

y: Akihiko Odaki Reviewed-by: Michael Tokarev Reviewed-by: Ani Sinha Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- hw/smbios/smbios.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index c0c5a81e66..a9048c1342 100644 --- a

[PULL 02/15] hw/isa/pc87312: Consolidate the use of device_class_set_parent_realize()

From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/isa/pc87312.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/pc87312.c b/hw/isa

[PULL 09/15] qemu-nbd: mention --tls-hostname option in qemu-nbd --help

This option was not documented. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1240 Reviewed-by: Daniel P. Berrangé Signed-off-by: Michael Tokarev --- qemu-nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-nbd.c b/qemu-nbd.c index bac0b5e3ec..d7b3ccab21 100644 --- a/qemu

[PULL 07/15] MAINTAINERS: Cover qapi/cxl.json

Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f80db6a96a..87f03ebccd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2894,6 +2894,7 @@ S: Supported F: hw/cxl/ F: hw/mem/cxl_type3.c F: include/hw/cxl/ +F: qapi

[PULL 00/15] Trivial patches for 2024-02-13

Kevin Wolf (1): iothread: Simplify expression in qemu_in_iothread() Markus Armbruster (2): MAINTAINERS: Cover qapi/cxl.json MAINTAINERS: Cover qapi/stats.json Michael Tokarev (2): qemu-nbd: mention --tls-hostname option in qemu-nbd --help qemu-options.hx: document

[PULL 03/15] hw/intc/s390_flic: Consolidate the use of device_class_set_parent_realize()

From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/intc/s390_flic_kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c

[PULL 01/15] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/isa/vt82c686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa

Re: [PATCH] tcg/arm: Fix goto_tb for large translation blocks

emu-stable@ Reviewed-by: Michael Tokarev --- tcg/arm/tcg-target.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index ffd23ef789..6a04c73c76 100644 --- a/tcg/arm/tcg-target.c.inc +++ b/tcg/arm/tcg-target.c.inc

Re: [PATCH] tcg: Increase width of temp_subindex

13.02.2024 08:44, Michael Tokarev wrote: 13.02.2024 05:21, Richard Henderson: We need values 0-3 for TCG_TYPE_I128 on 32-bit hosts. Cc: qemu-sta...@nongnu.org Fixes: 43eef72f4109 ("tcg: Add temp allocation for TCGv_i128") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2159

Re: [PATCH] tcg: Increase width of temp_subindex

alid value in temp_subindex lead to a crash. Somehow it feels deja vue too, maybe we increased some other width like this already, in stable series too, but I can't find it now. "This" in "this value" should be omitted. With this fixed, Reviewed-by: Michael Tokarev Thank you fo

Re: [PULL 11/12] target/hppa: Update SeaBIOS-hppa to version 16

11.02.2024 15:29, del...@kernel.org From: Helge Deller SeaBIOS-hppa version 16 news & enhancements: pc-bios/hppa-firmware.img | Bin 163324 -> 167820 bytes pc-bios/hppa-firmware64.img | Bin 0 -> 206024 bytes roms/seabios-hppa | 2 +- 3 files changed, 1 insertion(+), 1

Re: [PULL 11/12] target/hppa: Update SeaBIOS-hppa to version 16

11.02.2024 15:29, del...@kernel.org пишет: From: Helge Deller SeaBIOS-hppa version 16 news & enhancements: - Initial 64-bit firmware release - Added fault handler to catch and report firmware bugs - Use Qemu's builtin_console_out() via diag 0x101 - parisc-qemu-install Makefile target to

Re: [PULL 26/34] migration/multifd: Join the TLS thread

10.02.2024 12:18, Michael Tokarev: 08.02.2024 06:05, pet...@redhat.com : From: Fabiano Rosas We're currently leaking the resources of the TLS thread by not joining it and also overwriting the p->thread pointer altogether. Fixes: a1af605bd5 ("migration/multifd: fix hangup with TLS-Mul

Re: [PULL 26/34] migration/multifd: Join the TLS thread

08.02.2024 06:05, pet...@redhat.com : From: Fabiano Rosas We're currently leaking the resources of the TLS thread by not joining it and also overwriting the p->thread pointer altogether. Fixes: a1af605bd5 ("migration/multifd: fix hangup with TLS-Multifd due to blocking handshake") Cc:

Re: [PATCH] hw/i386/kvm/ioapic: Replace magic '24' value by proper definition

09.02.2024 22:01, Philippe Mathieu-Daudé: Replace '24' -> KVM_IOAPIC_NUM_PINS. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/kvm/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 409d0c8c76..b96fe84eed 100644

Re: [PATCH 0/2] block: Allow concurrent BB context changes

09.02.2024 19:51, Hanna Czenczek : On 09.02.24 15:08, Michael Tokarev wrote: 02.02.2024 17:47, Hanna Czenczek : Hi, Without the AioContext lock, a BB's context may kind of change at any time (unless it has a root node, and I/O requests are pending). That also means that its own context

Re: [PATCH v2 3/3] virtio-blk: Use ioeventfd_attach in start_ioeventfd

09.02.2024 20:11, Hanna Czenczek : The mentioned comit is v8.2.0-812-gd3f6f294ae, - ie, past 8.2. Is this new change still relevant for stable? Sorry again. :/ There's nothing to be sorry about here - it's regular work, and is quite good at it, - I just asked to be sure, maybe I

Re: [PATCH trivial] qemu-img: factor out parse_output_format() and use it in the code

07.02.2024 20:52, Michael Tokarev : Use common code and simplify error message I've sent this as part of qemu-img --help/options refactoring series, done in that context so this path does not make sense anymore. /mjt

Re: [PATCH 00/23] qemu-img: refersh options and --help handling

10.02.2024 00:22, Michael Tokarev wrote: Quite big patchset implementing normal, readable qemu-img --help (and qemu-img COMMAND --help) output with readable descriptions, and adding many long options in the process. ... I forgot to run checkpatch.pl - minor edits, the result is at https

Re: [PATCH 11/23] qemu-img: allow specifying -f fmt for snapshot subcommand

10.02.2024 00:22, Michael Tokarev wrote: For consistency with other commands, and since it already accepts --image-opts, allow specifying -f fmt too. ... -c = getopt_long(argc, argv, ":la:c:d:hqU", +c = getopt_long(argc, argv, &qu

Re: [PATCH 0/3] system/memory: Trivial fixes

09.02.2024 18:00, Philippe Mathieu-Daudé : - Include missing "exec/memory.h" - Set machine as parent of io/mem regions Philippe Mathieu-Daudé (3): cpu-target: Include missing 'exec/memory.h' header monitor/target: Include missing 'exec/memory.h' header system/physmem: Assign global

[PATCH 08/23] qemu-img: refresh options/--help for "convert" command

Add missing long options and --help output. convert uses -B for --backing, - why not -b? Signed-off-by: Michael Tokarev --- qemu-img.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index

[PATCH 20/23] qemu-img: refresh options/--help for "dd" command

Add missing long options and --help output. --- qemu-img.c | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 9a0cd05d42..db1f80e15d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -5417,6 +5417,8 @@ static int img_dd(const

[PATCH 06/23] qemu-img: refresh options/--help for "commit" command

Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index ad7fa033b1..eabf45c423 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1029,8

[PATCH 21/23] qemu-img: refresh options/--help for "measure" command

Add missing long options and --help output. Also add -s short option for --size (and remove OPTION_SIZE). --- qemu-img.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index db1f80e15d..e2c8855ff5 100644

[PATCH 13/23] qemu-img: refresh options/--help for "snapshot" command

Add missing long options and --help output. --- qemu-img.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d9dfff2f07..67e6a7797d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3553,9 +3553,15 @@ static int

[PATCH 14/23] qemu-img: refresh options/--help for "rebase" command

Add missing long options and --help output. Options added: --format, --cache - for the image in question --backing, --backing-format, --backing-cache, --backing-unsafe - for the new backing file (was eg CACHE vs SRC_CACHE, which is unclear). Probably should rename local variables. ---

[PATCH 04/23] qemu-img: refresh options/--help for "check" command

Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 4e962843da..3ae07bfae0 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -792,7 +792,9

[PATCH 18/23] qemu-img: refresh options/--help for "bench" command

Add missing long options and --help output. --- qemu-img.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index f598eba3a8..3be365cd07 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4781,9 +4781,19 @@ static int

[PATCH 01/23] qemu-img: pass current cmd info into command handlers

cmd info will be useful in --help output as well. Signed-off-by: Michael Tokarev --- qemu-img.c | 150 ++--- 1 file changed, 75 insertions(+), 75 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7668f86769..05f80b6e5b 100644 --- a/qemu

[PATCH 22/23] qemu-img: implement short --help, remove global help() function

now once all individual subcommands has --help support, remove the large unreadable help() thing and replace it with small global --help, which refers to individual command --help for more info. While at it, also line-wrap list of formats after 74 chars. Signed-off-by: Michael Tokarev --- qemu

[PATCH 15/23] qemu-img: resize: do not always eat last argument

. Signed-off-by: Michael Tokarev --- qemu-img.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 69d41e0a92..929a25a021 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4271,13 +4271,13 @@ static int img_resize(const img_cmd_t *ccmd, int argc

[PATCH 03/23] qemu-img: factor out parse_output_format() and use it in the code

Use common code and simplify error message Signed-off-by: Michael Tokarev --- qemu-img.c | 63 -- 1 file changed, 18 insertions(+), 45 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7edfc56572..4e962843da 100644 --- a/qemu-img.c

[PATCH 19/23] qemu-img: refresh options/--help for "bitmap" command

Add missing long options and --help output. --- qemu-img.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 3be365cd07..9a0cd05d42 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -5103,7 +5103,24 @@ static int img_bitmap(const

[PATCH 17/23] qemu-img: refresh options/--help for "amend" command

Add missing long options and --help output. --- qemu-img.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index e552401074..f598eba3a8 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4493,7 +4493,12 @@ static int img_amend(const

[PATCH 23/23] qemu-img: inline list of supported commands, remove qemu-img-cmds.h include

also add short description to each command and use it in --help Signed-off-by: Michael Tokarev --- qemu-img.c | 42 +++--- 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d9c5c6078b..e57076738e 100644 --- a/qemu

[PATCH 05/23] qemu-img: simplify --repair error message

Signed-off-by: Michael Tokarev --- qemu-img.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 3ae07bfae0..ad7fa033b1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -843,8 +843,8 @@ static int img_check(const img_cmd_t *ccmd, int argc, char

[PATCH 11/23] qemu-img: allow specifying -f fmt for snapshot subcommand

For consistency with other commands, and since it already accepts --image-opts, allow specifying -f fmt too. Signed-off-by: Michael Tokarev --- docs/tools/qemu-img.rst | 2 +- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 9 ++--- 3 files changed, 9 insertions(+), 6 deletions

[PATCH 07/23] qemu-img: refresh options/--help for "compare" command

Signed-off-by: Michael Tokarev --- qemu-img.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index eabf45c423..8f16ee9deb 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1464,9 +1464,17 @@ static int img_compare(const img_cmd_t

[PATCH 16/23] qemu-img: refresh options/--help for "resize" command

Add missing long options and --help output. --- qemu-img.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 929a25a021..e552401074 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4283,7 +4283,9 @@ static int img_resize(const

[PATCH 10/23] qemu-img: refresh options/--help for "map" command

Add missing long options and --help output. --- qemu-img.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index a1a0ba99f0..5af0b8ec18 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3425,7 +3425,20 @@ static int img_map(const img_cmd_t

[PATCH 00/23] qemu-img: refersh options and --help handling

). For bitmap, things are scary, I'm not sure what -b SRC_FILENAME really means, - for now I gave it --source option, but this does not make it more clear, suggestions welcome. There are many other inconsistencies, I can't fix them all in one go.. :) Michael Tokarev (23): qemu-img: pass current cmd info

[PATCH 09/23] qemu-img: refresh options/--help for "info" command

Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d4dafebff9..a1a0ba99f0 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -65,7 +65,6

[PATCH 02/23] qemu-img: refresh options/--help for "create" subcommand

Add missing long options (eg --format). Create helper function cmd_help() to display command-specific help text, and use it to print --help for 'create' subcommand. Signed-off-by: Michael Tokarev --- qemu-img.c | 45 - 1 file changed, 44 insertions

[PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand

also remove bdrv_oflags handling (only list can use RO mode) --- qemu-img.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 1e09b78d00..d9dfff2f07 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3541,7 +3541,7 @@ static int

Re: [PATCH v2 3/3] virtio-blk: Use ioeventfd_attach in start_ioeventfd

02.02.2024 18:31, Hanna Czenczek : Commit d3f6f294aeadd5f88caf0155e4360808c95b3146 ("virtio-blk: always set ioeventfd during startup") has made virtio_blk_start_ioeventfd() always kick the virtqueue (set the ioeventfd), regardless of whether the BB is drained. That is no longer necessary,

Re: [PATCH 0/2] block: Allow concurrent BB context changes

02.02.2024 17:47, Hanna Czenczek : Hi, Without the AioContext lock, a BB's context may kind of change at any time (unless it has a root node, and I/O requests are pending). That also means that its own context (BlockBackend.ctx) and that of its root node can differ sometimes (while the context

Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

09.02.2024 00:21, Stefan Hajnoczi wrote: On Thu, 1 Feb 2024 at 06:37, Michael Tokarev wrote: for (;;) { -bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS); +bytes = MIN(size - offset, BDRV_REQUEST_MAX_BYTES); Hmm. This smells like a -stable material, but you know

[PATCH trivial v2] qemu-options.hx: document that tftp=dir is readonly

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286 Signed-off-by: Michael Tokarev --- v2: include suggestion by Peter. Not keeping Reviewed-by tags. qemu-options.hx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5adbed1101

Re: pc-bios/optionrom can't be built anymore since 33ab4787422b04

08.02.2024 16:38, Michael Tokarev: Commit v7.0.0-1454-g33ab478742 "configure: enable cross-compilation of optionrom" effectively broke building of optionroms on anything but real i386 or using newly supported cross/docker image.  Before that, it was trivial to do that using native x8

pc-bios/optionrom can't be built anymore since 33ab4787422b04

Commit v7.0.0-1454-g33ab478742 "configure: enable cross-compilation of optionrom" effectively broke building of optionroms on anything but real i386 or using newly supported cross/docker image. Before that, it was trivial to do that using native x86_64 tools. # Mac OS X ships with a broken

Re: [PULL 1/1] virtio-blk: avoid using ioeventfd state in irqfd conditional

08.02.2024 11:42, Kevin Wolf wrote: The patch email itself was CCed to qemu-stable and even contained a note for backporting to stable: https://lists.gnu.org/archive/html/qemu-block/2024-01/msg00278.html Ahh. Yes. I'm having a large(ish) queue in stable and missed the fact I already has

[PATCH trivial] qemu-options.hx: document that tftp=dir is readonly

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286 Signed-off-by: Michael Tokarev --- qemu-options.hx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5adbed1101..05f70231c9 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3100,6

Re: [PULL 1/1] virtio-blk: avoid using ioeventfd state in irqfd conditional

06.02.2024 18:31, Stefan Hajnoczi : Requests that complete in an IOThread use irqfd to notify the guest while requests that complete in the main loop thread use the traditional qdev irq code path. The reason for this conditional is that the irq code path requires the BQL: if

Re: [RFC/INCOMPLETE PATCH 0/8] Attempt to make qemu-img options consistent and --help working

07.02.2024 22:01, Manos Pitsidianakis: Hello Michael, Such changes are long overdue. However given the complexity of commands and arguments, maybe it'd be a good idea to write a code generator for the command line interface, This way you could also generate --help outputs, manpages, shell

Re: [PATCH] ui/console: Fix console resize with placeholder surface

07.02.2024 20:20, Tianlan Zhou : In `qemu_console_resize()`, the old surface of the console is keeped if the new console size is the same as the old one. If the old surface is a placeholder, and the new size of console is the same as the placeholder surface (640*480), the surface won't be

[PATCH 8/8] qemu-img: refresh options/--help for "convert" command

Signed-off-by: Michael Tokarev --- qemu-img.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index ea3fe95169..c8fba27e35 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2351,14 +2351,28 @@ static int

[PATCH 7/8] qemu-img: refresh options/--help for "compare" command

Signed-off-by: Michael Tokarev --- qemu-img.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 7ff63aeea2..ea3fe95169 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1447,9 +1447,15 @@ static int img_compare(const char *cmdname

<    5   6   7   8   9   10   11   12   13   14   >